Skip to contentSkip to conversation

s390/kvm: avoid hypfs error message

PATCH Applied Juergen Gross 4 participants 6 messages Jun 20, 2022 – Aug 11, 2022 s390

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 s390/kvm: avoid hypfs error message

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

Demote the severity of first message from "error" to "info" and issue the second message only in other error cases.

---
V2:
- don't bail out if KVM, but avoid error messages instead (Christian Borntraeger)

---
 arch/s390/hypfs/hypfs_diag.c | 2 +-
 arch/s390/hypfs/inode.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/s390/hypfs/hypfs_diag.c +1 -1
index f0bc4dc3e9bf..6511d15ace45 100644
@@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
 	int rc;
 
 	if (diag204_probe()) {
-		pr_err("The hardware system does not support hypfs\n");
+		pr_info("The hardware system does not support hypfs\n");
 		return -ENODATA;
 	}
 
arch/s390/hypfs/inode.c +1 -1
index 5c97f48cea91..ee919bfc8186 100644
@@ -496,9 +496,9 @@ static int __init hypfs_init(void)
 	hypfs_vm_exit();
 fail_hypfs_diag_exit:
 	hypfs_diag_exit();
+	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
 fail_dbfs_exit:
 	hypfs_dbfs_exit();
-	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
 	return rc;
 }
 device_initcall(hypfs_init)
Signature · 1 line
2.35.3
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

Demote the severity of first message from "error" to "info" and issue the second message only in other error cases.

Quoted 8 lines

---
V2:
- don't bail out if KVM, but avoid error messages instead (Christian Borntraeger)

---
 arch/s390/hypfs/hypfs_diag.c | 2 +-
 arch/s390/hypfs/inode.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
reviewer Acked-by on v2 1/1
#2 lore raw
In reply to Juergen Gross

Am 20.06.22 um 11:45 schrieb Juergen Gross:

Quoted 9 lines

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

Demote the severity of first message from "error" to "info" and issue the second message only in other error cases.

Quoted 37 lines

---
V2:
- don't bail out if KVM, but avoid error messages instead (Christian Borntraeger)

---
  arch/s390/hypfs/hypfs_diag.c | 2 +-
  arch/s390/hypfs/inode.c      | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
arch/s390/hypfs/hypfs_diag.c +1 -1
index f0bc4dc3e9bf..6511d15ace45 100644
@@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
  	int rc;
 
  	if (diag204_probe()) {
-		pr_err("The hardware system does not support hypfs\n");
+		pr_info("The hardware system does not support hypfs\n");
  		return -ENODATA;
  	}
 
arch/s390/hypfs/inode.c +1 -1
index 5c97f48cea91..ee919bfc8186 100644
@@ -496,9 +496,9 @@ static int __init hypfs_init(void)
  	hypfs_vm_exit();
  fail_hypfs_diag_exit:
  	hypfs_diag_exit();
+	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
  fail_dbfs_exit:
  	hypfs_dbfs_exit();
-	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
  	return rc;
  }
  device_initcall(hypfs_init)
maintainer Applied
#3 lore raw
In reply to Juergen Gross
Quoted 9 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

Demote the severity of first message from "error" to "info" and issue the second message only in other error cases.

Applied, thanks!

Quoted 40 lines

---
V2:
- don't bail out if KVM, but avoid error messages instead (Christian Borntraeger)

---
 arch/s390/hypfs/hypfs_diag.c | 2 +-
 arch/s390/hypfs/inode.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/s390/hypfs/hypfs_diag.c +1 -1
index f0bc4dc3e9bf..6511d15ace45 100644
@@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
 	int rc;
 
 	if (diag204_probe()) {
-		pr_err("The hardware system does not support hypfs\n");
+		pr_info("The hardware system does not support hypfs\n");
 		return -ENODATA;
 	}
 
arch/s390/hypfs/inode.c +1 -1
index 5c97f48cea91..ee919bfc8186 100644
@@ -496,9 +496,9 @@ static int __init hypfs_init(void)
 	hypfs_vm_exit();
 fail_hypfs_diag_exit:
 	hypfs_diag_exit();
+	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
 fail_dbfs_exit:
 	hypfs_dbfs_exit();
-	pr_err("Initialization of hypfs failed with rc=%i\n", rc);
 	return rc;
 }
 device_initcall(hypfs_init)
Signature · 1 line
2.35.3
#4 lore raw
Quoted 6 lines · Alexander Gordeev
Quoted 5 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

Quoted 6 lines
Quoted 4 lines

Demote the severity of first message from "error" to "info" and issue the second message only in other error cases.

Applied, thanks!

Hmm, applied to which tree and branch?

I would have thought this patch should have reached upstream by now...

Juergen

#5 lore raw
Quoted 6 lines · Juergen Gross
Quoted 1 line · Alexander Gordeev

Applied, thanks!

Hmm, applied to which tree and branch?

I would have thought this patch should have reached upstream by now...

Hi Juergen,

This one is going to land in -rc2 or -rc3 most likely.

Thanks!

Quoted 1 line

Juergen