Skip to contentSkip to conversation

ARM: dts: am33xx: Fix MMCHS0 dma properties

PATCH Superseded YuTong Chang 2 participants 2 messages Jun 20, 2022 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

YuTong Chang

author
#0 lore raw

PATCH 1/1 ARM: dts: am33xx: Fix MMCHS0 dma properties

According to technical manual(table 11-24), the DMA of MMCHS0 should be direct mapped.

Signed-off-by YuTong Chang <[email protected]>

---
v1: Cleaned up coding style and addressed review comments

 arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/am33xx-l4.dtsi +1 -2
index 7da42a5b959c..7e50fe633d8a 100644
@@ -1502,8 +1502,7 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0>, <&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;
Signature · 1 line
2.36.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · YuTong Chang

According to technical manual(table 11-24), the DMA of MMCHS0 should be direct mapped.

Signed-off-by YuTong Chang <[email protected]>

This should be v2, not v1. You already sent a v1.

Acked-by Krzysztof Kozlowski <[email protected]>
Quoted 11 lines

---
v1: Cleaned up coding style and addressed review comments

 arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/am33xx-l4.dtsi +0 -0
index 7da42a5b959c..7e50fe633d8a 100644

arch/arm/boot/dts/am33xx-l4.dtsi SYSC_OMAP2_SOFTRESET | · line 1508

Quoted 9 lines
arch/arm/boot/dts/am33xx-l4.dtsi +1 -2
@@ -1502,8 +1502,7 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0>, <&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;

Best regards,
Krzysztof