src: proto: support DF, LE, VA for DSCP
PATCH 1/1 src: proto: support DF, LE, VA for DSCP
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with 0x00 value.
As per RFC 5865, add "va" for VOICE-ADMIT with 0x2c value.
As per RFC 8622, add "le" for Lower-Effort with 0x01 value.
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
--- src/proto.c | 3 +++ 1 file changed, 3 insertions(+)
src/proto.c +3 -0
@@ -684,7 +684,9 @@ static const struct symbol_table dscp_type_tbl = {SYMBOL ("cs5" ,0x28 ),SYMBOL ("cs6" ,0x30 ),SYMBOL ("cs7" ,0x38 ), +SYMBOL ("df" ,0x00 ),SYMBOL ("be" ,0x00 ), +SYMBOL ("le" ,0x01 ),SYMBOL ("af11" ,0x0a ),SYMBOL ("af12" ,0x0c ), SYMBOL("af13", 0x0e),
@@ -697,6 +699,7 @@ static const struct symbol_table dscp_type_tbl = {SYMBOL ("af41" ,0x22 ),SYMBOL ("af42" ,0x24 ),SYMBOL ("af43" ,0x26 ), +SYMBOL ("va" ,0x2c ),SYMBOL ("ef" ,0x2e ),SYMBOL_LIST_END },
Signature · 1 line
2.36.1
Pablo Neira Ayuso
maintainerHi,
Quoted 5 lines · Oleksandr Natalenko
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with
0x00value.As per RFC 5865, add "va" for VOICE-ADMIT with
0x2cvalue.
Quickly browsing, I don't find "va" nor 0x2c in this RFC above? Could you refer to page?
Quoted 1 line
As per RFC 8622, add "le" for Lower-Effort with
0x01value.
This RFC refers to replacing CS1 by LE
o This update to RFC 4594 removes the following entry from its Figure 4:
|---------------+------+-------------------+---------+--------+----| | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| | Data | | | | | |
------------------------------------------------------------------
and replaces it with the following entry:
|---------------+------+-------------------+----------+--------+----|
| Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes|
| Data | | | | | |
-------------------------------------------------------------------static const struct symbol_table dscp_type_tbl = {
.base = BASE_HEXADECIMAL,
.symbols = {
[...]
SYMBOL("cs1", 0x08),
[...]
SYMBOL("le", 0x01),Quoted 2 lines
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
Aliasing is fine, let's just clarify this first.
Thanks.
Hello.
Thank you for your response. Please find my comments inline.
Quoted 9 lines · On pondělí 27. června 2022 19:31:27 CEST Pablo Neira Ayuso wrote:
Quoted 5 lines · Oleksandr Natalenko
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with
0x00value.As per RFC 5865, add "va" for VOICE-ADMIT with
0x2cvalue.Quickly browsing, I don't find "va" nor
0x2cin this RFC above? Could you refer to page?
As per my understanding it's page 11 ("2.3. Recommendations on implementation of an Admitted Telephony Service Class") here:
Name Space Reference
--------- ------- ---------
VOICE-ADMIT 101100 [RFC5865]Am I wrong?
Quoted 20 lines
Quoted 1 line
As per RFC 8622, add "le" for Lower-Effort with
0x01value.This RFC refers to replacing CS1 by LE
o This update to RFC 4594 removes the following entry from its Figure 4:
|---------------+------+-------------------+---------+--------+----| | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| | Data | | | | | |------------------------------------------------------------------
and replaces it with the following entry:
|---------------+------+-------------------+----------+--------+----| | Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes| | Data | | | | | | -------------------------------------------------------------------
Quoted 7 lines
static const struct symbol_table dscp_type_tbl = {
.base = BASE_HEXADECIMAL,
.symbols = {
[...]
SYMBOL("cs1", 0x08),
[...]
SYMBOL("le", 0x01),I think we shouldn't remove existing symbol, should we? Please let me know if I missed any suggested action item for myself here.
Quoted 4 lines
Quoted 2 lines
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
Aliasing is fine, let's just clarify this first.
I mean, "le" would be an alias to "0x01", not to "cs1".
BTW, the reason I included Loganaden Velvindron in Cc is that "le" was already added in the past, but got quickly reverted as it broke some tests. Shall "le" interfere with "less-equal", or what could be the issue with it? If the name is not acceptable, "lephb" or similar can be used instead.
Thanks.
Thanks.
Signature · 1 line
Oleksandr Natalenko (post-factum)
Pablo Neira Ayuso
maintainerQuoted 15 lines · Oleksandr Natalenko
Hello.
Thank you for your response. Please find my comments inline.
Quoted 9 lines · On pondělí 27. června 2022 19:31:27 CEST Pablo Neira Ayuso wrote:
Quoted 5 lines · Oleksandr Natalenko
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with
0x00value.As per RFC 5865, add "va" for VOICE-ADMIT with
0x2cvalue.Quickly browsing, I don't find "va" nor
0x2cin this RFC above? Could you refer to page?
Quoted 7 lines
As per my understanding it's page 11 ("2.3. Recommendations on implementation of an Admitted Telephony Service Class") here:
Name Space Reference --------- ------- --------- VOICE-ADMIT 101100 [RFC5865]Am I wrong?
Ok, hence the 'va'.
Quoted 28 lines
Quoted 20 lines
Quoted 1 line
As per RFC 8622, add "le" for Lower-Effort with
0x01value.This RFC refers to replacing CS1 by LE
o This update to RFC 4594 removes the following entry from its Figure 4:
|---------------+------+-------------------+---------+--------+----| | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| | Data | | | | | |------------------------------------------------------------------
and replaces it with the following entry:
|---------------+------+-------------------+----------+--------+----| | Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes| | Data | | | | | | -------------------------------------------------------------------Quoted 7 lines
static const struct symbol_table dscp_type_tbl = { .base = BASE_HEXADECIMAL, .symbols = { [...] SYMBOL("cs1", 0x08), [...] SYMBOL("le", 0x01),
Quoted 2 lines
I think we shouldn't remove existing symbol, should we? Please let me know if I missed any suggested action item for myself here.
Not removing. I mean, if I understood correctly, the RFC says LE == cs1 ? But the values are different.
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
Aliasing is fine, let's just clarify this first.
Quoted 7 lines
I mean, "le" would be an alias to "
0x01", not to "cs1".BTW, the reason I included Loganaden Velvindron in Cc is that "le" was already added in the past, but got quickly reverted as it broke some tests. Shall "le" interfere with "less-equal", or what could be the issue with it? If the name is not acceptable, "lephb" or similar can be used instead.
Oh right, this is an issue for the parser, the 'le' keyword is an alias of '<='.
What does 'lephb' stands for BTW?
Note that these aliases will be lost when listing back the ruleset from the kernel, so it is only working as an input.
Hello.
Quoted 14 lines · On středa 29. června 2022 19:24:28 CEST Pablo Neira Ayuso wrote:
Quoted 13 lines · Oleksandr Natalenko
Quoted 9 lines · On pondělí 27. června 2022 19:31:27 CEST Pablo Neira Ayuso wrote:
Quoted 5 lines · Oleksandr Natalenko
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with
0x00value.As per RFC 5865, add "va" for VOICE-ADMIT with
0x2cvalue.Quickly browsing, I don't find "va" nor
0x2cin this RFC above? Could you refer to page?As per my understanding it's page 11 ("2.3. Recommendations on implementation of an Admitted Telephony Service Class") here:
Quoted 7 lines
Quoted 5 lines
Name Space Reference --------- ------- --------- VOICE-ADMIT 101100 [RFC5865]Am I wrong?
Ok, hence the 'va'.
Yes.
Quoted 28 lines
Quoted 28 lines
Quoted 27 lines
Quoted 1 line
As per RFC 8622, add "le" for Lower-Effort with
0x01value.This RFC refers to replacing CS1 by LE
o This update to RFC 4594 removes the following entry from its Figure 4:
|---------------+------+-------------------+---------+--------+----| | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| | Data | | | | | |------------------------------------------------------------------
and replaces it with the following entry:
|---------------+------+-------------------+----------+--------+----| | Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes| | Data | | | | | | -------------------------------------------------------------------static const struct symbol_table dscp_type_tbl = { .base = BASE_HEXADECIMAL, .symbols = { [...] SYMBOL("cs1", 0x08), [...] SYMBOL("le", 0x01),
Quoted 4 lines
Quoted 2 lines
I think we shouldn't remove existing symbol, should we? Please let me know if I missed any suggested action item for myself here.
Not removing. I mean, if I understood correctly, the RFC says LE == cs1 ?
To my understanding, no. The RFC talks about obsoleting:
"This specification obsoletes RFC 3662 and updates the DSCP recommended in RFCs 4594 and 8325 to use the DSCP assigned in this specification."
Quoted 1 line
But the values are different.
Yes, as a consequence of obsoleting, not replacing.
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
Aliasing is fine, let's just clarify this first.
I mean, "le" would be an alias to "
0x01", not to "cs1".
Quoted 8 lines
Quoted 5 lines
BTW, the reason I included Loganaden Velvindron in Cc is that "le" was already added in the past, but got quickly reverted as it broke some tests. Shall "le" interfere with "less-equal", or what could be the issue with it? If the name is not acceptable, "lephb" or similar can be used instead.
Oh right, this is an issue for the parser, the 'le' keyword is an alias of '<='.
OK, then another name should be found.
Quoted 1 line
What does 'lephb' stands for BTW?
"LE PHB" originally, as described in the RFC, it's Lower-Effort Per-Hop Behavior.
Quoted 2 lines
Note that these aliases will be lost when listing back the ruleset from the kernel, so it is only working as an input.
Sure thing.
Thanks.
Signature · 1 line
Oleksandr Natalenko (post-factum)
Pablo Neira Ayuso
maintainerQuoted 21 lines · Oleksandr Natalenko
Hello.
Quoted 18 lines · On středa 29. června 2022 19:24:28 CEST Pablo Neira Ayuso wrote:
Quoted 17 lines · Oleksandr Natalenko
Quoted 9 lines · On pondělí 27. června 2022 19:31:27 CEST Pablo Neira Ayuso wrote:
Quoted 5 lines · Oleksandr Natalenko
Add a couple of aliases for well-known DSCP values.
As per RFC 4594, add "df" as an alias of "cs0" with
0x00value.As per RFC 5865, add "va" for VOICE-ADMIT with
0x2cvalue.Quickly browsing, I don't find "va" nor
0x2cin this RFC above? Could you refer to page?As per my understanding it's page 11 ("2.3. Recommendations on implementation of an Admitted Telephony Service Class") here:
Name Space Reference --------- ------- --------- VOICE-ADMIT 101100 [RFC5865]
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Am I wrong?
Ok, hence the 'va'.
Yes.
OK.
Quoted 33 lines
Quoted 28 lines
Quoted 28 lines
Quoted 27 lines
Quoted 1 line
As per RFC 8622, add "le" for Lower-Effort with
0x01value.This RFC refers to replacing CS1 by LE
o This update to RFC 4594 removes the following entry from its Figure 4:
|---------------+------+-------------------+---------+--------+----| | Low-Priority | CS1 | Not applicable | RFC3662 | Rate | Yes| | Data | | | | | |------------------------------------------------------------------
and replaces it with the following entry:
|---------------+------+-------------------+----------+--------+----| | Low-Priority | LE | Not applicable | RFC 8622 | Rate | Yes| | Data | | | | | | -------------------------------------------------------------------static const struct symbol_table dscp_type_tbl = { .base = BASE_HEXADECIMAL, .symbols = { [...] SYMBOL("cs1", 0x08), [...] SYMBOL("le", 0x01),Quoted 4 lines
Quoted 2 lines
I think we shouldn't remove existing symbol, should we? Please let me know if I missed any suggested action item for myself here.
Not removing. I mean, if I understood correctly, the RFC says LE == cs1 ?
Quoted 7 lines
To my understanding, no. The RFC talks about obsoleting:
"This specification obsoletes RFC 3662 and updates the DSCP recommended in RFCs 4594 and 8325 to use the DSCP assigned in this specification."
Quoted 1 line
But the values are different.
Yes, as a consequence of obsoleting, not replacing.
OK.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 4 lines
Quoted 2 lines
tc-cake(8) in diffserv8 mode would benefit from having "le" alias since it corresponds to "Tin 0".
Aliasing is fine, let's just clarify this first.
I mean, "le" would be an alias to "
0x01", not to "cs1".BTW, the reason I included Loganaden Velvindron in Cc is that "le" was already added in the past, but got quickly reverted as it broke some tests. Shall "le" interfere with "less-equal", or what could be the issue with it? If the name is not acceptable, "lephb" or similar can be used instead.
Quoted 8 lines
Quoted 2 lines
Oh right, this is an issue for the parser, the 'le' keyword is an alias of '<='.
OK, then another name should be found.
Quoted 1 line
What does 'lephb' stands for BTW?
"LE PHB" originally, as described in the RFC, it's Lower-Effort Per-Hop Behavior.
Fine with me.