Revert "drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 Revert "drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"
This reverts commit 8fc74d18639a2402ca52b177e990428e26ea881f.
BAR0 is the main (only?) register bank for this device. We most obviously can't unmap it before the netdev is unregistered. This was pointed out in review but the patch got reposted and merged, anyway.
The author of the patch was only testing it with a QEMU model, which I presume does not emulate enough for the netdev to be brought up (author's replies are not visible in lore because they kept sending their emails in HTML).
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/neterion/vxge/vxge-main.c +1 -1
@@ -4736,10 +4736,10 @@ static void vxge_remove(struct pci_dev *pdev)for (i =0 ; i < vdev->no_of_vpath; i++)vxge_free_mac_add_list (&vdev->vpaths[i]); -iounmap (vdev->bar0);vxge_device_unregister (hldev);/* Do not call pci_disable_sriov here, as it will break child devices */ vxge_hw_device_terminate (hldev); +iounmap (vdev->bar0);pci_release_region (pdev,0 );pci_disable_device (pdev); driver_config->config_dev_cnt--;
Signature · 1 line
2.36.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Mon, 20 Jun 2022 12:12:37 -0700 you wrote:
This reverts commit
8fc74d18639a2402ca52b177e990428e26ea881f.BAR0 is the main (only?) register bank for this device. We most obviously can't unmap it before the netdev is unregistered. This was pointed out in review but the patch got reposted and merged, anyway.
[...]
Here is the summary with links:
- [net] Revert "drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"
https://git.kernel.org/netdev/net/c/877fe9d49b74
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html