Skip to contentSkip to conversation

printk/console: Enable console kthreads only when there is no boot console left

PATCH In review Petr Mladek 6 participants 9 messages Jun 21, 2022 – Jun 23, 2022 Printk

lore
Share & tools
lore

Petr Mladek

author maintainer
#0 lore raw

PATCH v2 1/1 printk/console: Enable console kthreads only when there is no boot console left

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

---
Changes against v1:

+ Updated comment and commit message [Linus,John]
+ Added Tested-by [Marek]

 kernel/printk/printk.c | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)
kernel/printk/printk.c +26 -13
index b095fb5f5f61..157a3e8c01bb 100644
@@ -3551,6 +3551,19 @@ void __init console_init(void)
 	}
 }
 
+static int __init printk_activate_kthreads(void)
+{
+	struct console *con;
+
+	console_lock();
+	printk_kthreads_available = true;
+	for_each_console(con)
+		printk_start_kthread(con);
+	console_unlock();
+
+	return 0;
+}
+
 /*
  * Some boot consoles access data that is in the init section and which will
  * be discarded after the initcalls have been run. To make sure that no code
@@ -3567,6 +3580,7 @@ void __init console_init(void)
  */
 static int __init printk_late_init(void)
 {
+	bool no_bootcon = true;
 	struct console *con;
 	int ret;
 
@@ -3588,7 +3602,10 @@ static int __init printk_late_init(void)
 			pr_warn("bootconsole [%s%d] uses init memory and must be disabled even before the real one is ready\n",
 				con->name, con->index);
 			unregister_console(con);
+			continue;
 		}
+
+		no_bootcon = false;
 	}
 	ret = cpuhp_setup_state_nocalls(CPUHP_PRINTK_DEAD, "printk:dead", NULL,
 					console_cpu_notify);
@@ -3597,23 +3614,19 @@ static int __init printk_late_init(void)
 					console_cpu_notify, NULL);
 	WARN_ON(ret < 0);
 	printk_sysctl_init();
-	return 0;
-}
-late_initcall(printk_late_init);
-
-static int __init printk_activate_kthreads(void)
-{
-	struct console *con;
 
-	console_lock();
-	printk_kthreads_available = true;
-	for_each_console(con)
-		printk_start_kthread(con);
-	console_unlock();
+	/*
+	 * Boot consoles may be accessing the same hardware as normal
+	 * consoles and thus must not be called in parallel. Therefore
+	 * only activate threaded console printing if it is known that
+	 * there are no boot consoles registered.
+	 */
+	if (no_bootcon)
+		printk_activate_kthreads();
 
 	return 0;
 }
-early_initcall(printk_activate_kthreads);
+late_initcall(printk_late_init);
 
 #if defined CONFIG_PRINTK
 /* If @con is specified, only wait for that console. Otherwise wait for all. */
Signature · 1 line
2.35.3
reviewer Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Petr Mladek

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

Quoted 7 lines

[..]

Quoted 50 lines
kernel/printk/printk.c +17 -10
+static int __init printk_activate_kthreads(void)
+{
+	struct console *con;
+
+	console_lock();
+	printk_kthreads_available = true;
+	for_each_console(con)
+		printk_start_kthread(con);
+	console_unlock();
+
+	return 0;
+}
+
 /*
  * Some boot consoles access data that is in the init section and which will
  * be discarded after the initcalls have been run. To make sure that no code
@@ -3567,6 +3580,7 @@ void __init console_init(void)
  */
 static int __init printk_late_init(void)
 {
+	bool no_bootcon = true;
 	struct console *con;
 	int ret;
 
@@ -3588,7 +3602,10 @@ static int __init printk_late_init(void)
 			pr_warn("bootconsole [%s%d] uses init memory and must be disabled even before the real one is ready\n",
 				con->name, con->index);
 			unregister_console(con);
+			continue;
 		}
+
+		no_bootcon = false;
 	}
 	ret = cpuhp_setup_state_nocalls(CPUHP_PRINTK_DEAD, "printk:dead", NULL,
 					console_cpu_notify);
@@ -3597,23 +3614,19 @@ static int __init printk_late_init(void)
 					console_cpu_notify, NULL);
 	WARN_ON(ret < 0);
 	printk_sysctl_init();
-	return 0;
-}
-late_initcall(printk_late_init);
-
-static int __init printk_activate_kthreads(void)
-{
-	struct console *con;
 
-	console_lock();
-	printk_kthreads_available = true;
-	for_each_console(con)

kernel/printk/printk.c static int __init printk_late_init(void) · line 3625

Quoted 10 lines
kernel/printk/printk.c +8 -2
-		printk_start_kthread(con);
-	console_unlock();
+	/*
+	 * Boot consoles may be accessing the same hardware as normal
+	 * consoles and thus must not be called in parallel. Therefore
+	 * only activate threaded console printing if it is known that
+	 * there are no boot consoles registered.
+	 */
+	if (no_bootcon)
+		printk_activate_kthreads();

A quick question. Here we still can have bootcon which can unregistered later, right? Do you think it'll make sense to check if printing kthreads can be safely started and start them if so (if no CON_BOOT found and kthreads are not already created) at the end of unregister_console()?

author maintainer
#2 lore raw
Quoted 17 lines · Sergey Senozhatsky
Quoted 8 lines · Petr Mladek

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

Quoted 7 lines
Quoted 1 line

Thanks.

Quoted 14 lines
Quoted 14 lines
kernel/printk/printk.c +5 -8
-static int __init printk_activate_kthreads(void)
-{
-	struct console *con;
 
-	console_lock();
-	printk_kthreads_available = true;
-	for_each_console(con)
-		printk_start_kthread(con);
-	console_unlock();
+	/*
+	 * Boot consoles may be accessing the same hardware as normal
+	 * consoles and thus must not be called in parallel. Therefore
+	 * only activate threaded console printing if it is known that
+	 * there are no boot consoles registered.
Quoted 8 lines

kernel/printk/printk.c static int __init printk_late_init(void) · line 3625

Quoted 3 lines
kernel/printk/printk.c +3 -0
+	 */
+	if (no_bootcon)
+		printk_activate_kthreads();

A quick question. Here we still can have bootcon which can unregistered later, right? Do you think it'll make sense to check if printing kthreads can be safely started and start them if so (if no CON_BOOT found and kthreads are not already created) at the end of unregister_console()?

Yeah, that's my plan how to optimize it in the future. I just wanted to do something simple and be on the safe side for 5.19.

Best Regards,
Petr

#3 lore raw
Quoted 23 lines · Petr Mladek
Quoted 14 lines
Quoted 14 lines
kernel/printk/printk.c +5 -8
-static int __init printk_activate_kthreads(void)
-{
-	struct console *con;
 
-	console_lock();
-	printk_kthreads_available = true;
-	for_each_console(con)
-		printk_start_kthread(con);
-	console_unlock();
+	/*
+	 * Boot consoles may be accessing the same hardware as normal
+	 * consoles and thus must not be called in parallel. Therefore
+	 * only activate threaded console printing if it is known that
+	 * there are no boot consoles registered.
Quoted 8 lines

kernel/printk/printk.c static int __init printk_late_init(void) · line 3625

Quoted 3 lines
kernel/printk/printk.c +3 -0
+	 */
+	if (no_bootcon)
+		printk_activate_kthreads();

A quick question. Here we still can have bootcon which can unregistered later, right? Do you think it'll make sense to check if printing kthreads can be safely started and start them if so (if no CON_BOOT found and kthreads are not already created) at the end of unregister_console()?

Quoted 2 lines

Yeah, that's my plan how to optimize it in the future. I just wanted to do something simple and be on the safe side for 5.19.

Sounds good.

maintainer Reviewed-by on v2 1/1
#4 lore raw
In reply to Petr Mladek
Quoted 8 lines · Petr Mladek

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

Quoted 7 lines
Tested-by on v2 1/1
#5 lore raw
In reply to Petr Mladek

Hi Petr,

Quoted 16 lines · Petr Mladek

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

Quoted 2 lines

---
Changes against v1:

The lockups on boot seem to be gone on my boards with this patch. So FWIW:

#6 lore raw
Quoted 2 lines · Daniel Palmer

The lockups on boot seem to be gone on my boards with this patch.

Good.

Petr, was this all the reports sorted out? Sounds like we can keep the kernel thread model.

Linus

author maintainer
#7 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 2 lines · Daniel Palmer

The lockups on boot seem to be gone on my boards with this patch.

Good.

Petr, was this all the reports sorted out? Sounds like we can keep the kernel thread model.

Yes, it seems that we fixed all the reports when boot failed or the console was messed or silent.

There is one more issue, see
https://lore.kernel.org/r/[email protected]
It is about synchronization between messages printed by userspace and kernel consoles.

The synchronization was never guaranteed. I think that it is not an argument to remove the kthreads. They are really needed, especially for huge systems, noisy debugging, or RT where softlockups really hurts.

My opinion is that we might easily support 3 printk modes, switched on the command line:

1. Use printk console kthreads when the system is normally running. It makes printk() predictable and safe. We do our best to switch to the direct mode when the kthreads are not reliable, for example, panic, suspend, reboot.

IMHO, it should be default, especially for production systems.

2. Use an atomic console in fully synchronous mode. It is inspired by a patch from Peter Zijlstra. It calls the (serial) console directly from printk() and uses CPU-reentrant lock to serialize the messages between CPUs.

AFAIK, Peter and some others use this approach to debug some nasty bugs in the scheduler, NMI, early boot when even the legacy code using console_lock() is not reliable enough.

John Ogness is working on the atomic serial console. It would allow to integrate this mode a clean way.

It is not usable for production because printk() might slow down the entire system.

3. Use the legacy code that tries to call consoles from printk() via console_trylock(). We need this code anyway for the early boot, suspend, reboot, panic.

It would be used for debugging nasty bugs like the 2nd mode for system without serial console. It will be pretty hard to create lockless variant for more complicate consoles.

I am not happy that we need more modes. But I think that they all have a good justification.

Best Regards,
Petr

Tested-by on v2 1/1
#8 lore raw
In reply to Petr Mladek

Hi Petr,

Quoted 8 lines · Petr Mladek

Threaded console printing does not take into consideration that boot consoles may be accessing the same hardware as normal consoles and thus must not be called in parallel.

Since it is currently not possible to identify which consoles are accessing the same hardware, delay threaded console printing activation until it is known that there are no boot consoles registered.

Quoted 7 lines

Thanks, this restores the lost printing of "38000000.serial: ttySIF0 at MMIO ..." on SiPEED MAiXBiT, so

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds