tests/kms_flip: Skip test only for invalid combination

PATCH Superseded Jeevan B 1 participant 1 message Jun 22, 2022

Share & tools

Jeevan B

author

2022-06-22 07:50 UTC #0 lore raw

PATCH v3 1/1 tests/kms_flip: Skip test only for invalid combination

currently the entire test is skipping. adding this fix to skip test only for invalid cases and run on other valid display combination.

v2: add RUN_PAIR check to avoid crash on single display.
v3: add flag to check for valid display combination.(Karthik)

Signed-off-by Jeevan B <[email protected]>

---
 tests/kms_flip.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

tests/kms_flip.c +4 -5

index c5b5741a..12641a93 100755
@@ -932,7 +932,7 @@ static bool mode_compatible(const drmModeModeInfo *a, const drmModeModeInfo *b)
 	return true;
 }
 
-static void get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
+static bool get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
 				 drmModeConnector *c1, drmModeConnector *c2)
 {
 	int n, m;

@@ -946,14 +946,13 @@ static void get_compatible_modes(drmModeModeInfo *a, drmModeModeInfo *b,
 			for (m = 0; m < c2->count_modes; m++) {
 				*b = c2->modes[m];
 				if (mode_compatible(a, b))
-					return;
+					return true;
 			}
 		}
-
-		igt_skip("Compatible mode not found.\n");
+		return false;
 	}
 
-	return;
+	return false;
 }
 
 static void connector_find_compatible_mode(int crtc_idx0, int crtc_idx1,

Signature · 1 line

2.36.0