Skip to contentSkip to conversation

btrfs: lower some mount messages level to debug

PATCH In review David Sterba 2 participants 3 messages Jun 22, 2022 – Jun 23, 2022 Btrfs file system

lore
Share & tools
lore

David Sterba

author maintainer
#0 lore raw

PATCH 1/1 btrfs: lower some mount messages level to debug

Change message level from info to debug for the following messages, there's no reason to print them for all users as that won't help debugging if nearly all filesystems use that.

- flagging fs with big metadata feature

Added in commit 727011e07cbd ("Btrfs: allow metadata blocks larger than the page size") in 2010 and it's been default for mkfs since 3.12 (2013).

- has skinny extents

Added in 3173a18f7055 ("Btrfs: add a incompatible format change for smaller metadata extent refs") in 2013 and default for mkfs since 3.18 (2014).

---
 fs/btrfs/disk-io.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/disk-io.c +2 -3
index 8592eaf6de53..3d435560980c 100644
@@ -3472,8 +3472,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	 */
 	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE) {
 		if (!(features & BTRFS_FEATURE_INCOMPAT_BIG_METADATA))
-			btrfs_info(fs_info,
-				"flagging fs with big metadata feature");
+			btrfs_debug(fs_info, "flagging fs with big metadata feature");
 		features |= BTRFS_FEATURE_INCOMPAT_BIG_METADATA;
 	}
 
@@ -3514,7 +3513,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 		features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_ZSTD;
 
 	if (features & BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA)
-		btrfs_info(fs_info, "has skinny extents");
+		btrfs_debug(fs_info, "has skinny extents");
 
 	/*
 	 * mixed block groups end up with duplicate but slightly offset
Signature · 1 line
2.36.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · David Sterba

Change message level from info to debug for the following messages, there's no reason to print them for all users as that won't help debugging if nearly all filesystems use that.

- flagging fs with big metadata feature

Added in commit 727011e07cbd ("Btrfs: allow metadata blocks larger than the page size") in 2010 and it's been default for mkfs since 3.12 (2013).

Quoted 7 lines

- has skinny extents

Added in 3173a18f7055 ("Btrfs: add a incompatible format change for smaller metadata extent refs") in 2013 and default for mkfs since 3.18 (2014).

Quoted 27 lines
---
  fs/btrfs/disk-io.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/disk-io.c +2 -3
index 8592eaf6de53..3d435560980c 100644
@@ -3472,8 +3472,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
  	 */
  	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE) {
  		if (!(features & BTRFS_FEATURE_INCOMPAT_BIG_METADATA))
-			btrfs_info(fs_info,
-				"flagging fs with big metadata feature");
+			btrfs_debug(fs_info, "flagging fs with big metadata feature");
  		features |= BTRFS_FEATURE_INCOMPAT_BIG_METADATA;
  	}
 
@@ -3514,7 +3513,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
  		features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_ZSTD;
 
  	if (features & BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA)
-		btrfs_info(fs_info, "has skinny extents");
+		btrfs_debug(fs_info, "has skinny extents");
 
  	/*
  	 * mixed block groups end up with duplicate but slightly offset
#2 lore raw
In reply to David Sterba
Quoted 10 lines · David Sterba

Change message level from info to debug for the following messages, there's no reason to print them for all users as that won't help debugging if nearly all filesystems use that.

- flagging fs with big metadata feature

Added in commit 727011e07cbd ("Btrfs: allow metadata blocks larger than the page size") in 2010 and it's been default for mkfs since 3.12 (2013).

Quoted 7 lines

- has skinny extents

Added in 3173a18f7055 ("Btrfs: add a incompatible format change for smaller metadata extent refs") in 2013 and default for mkfs since 3.18 (2014).

One more nit, the following hunk should also be added (as per Qu's suggestion):

fs/btrfs/disk-io.c +0 -0
index 0af4c03279df..7ae24acd899b 100644
@@ -3795,7 +3795,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
        if (fs_info->uuid_root &&
            (btrfs_test_opt(fs_info, RESCAN_UUID_TREE) ||
             fs_info->generation != 

btrfs_super_uuid_tree_generation(disk_super))) {
- btrfs_info(fs_info, "checking UUID tree");

+               btrfs_debug(fs_info, "checking UUID tree");
                ret = btrfs_check_uuid_tree(fs_info);
                if (ret) {
                        btrfs_warn(fs_info,
Quoted 27 lines
---
  fs/btrfs/disk-io.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/disk-io.c +2 -3
index 8592eaf6de53..3d435560980c 100644
@@ -3472,8 +3472,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
  	 */
  	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE) {
  		if (!(features & BTRFS_FEATURE_INCOMPAT_BIG_METADATA))
-			btrfs_info(fs_info,
-				"flagging fs with big metadata feature");
+			btrfs_debug(fs_info, "flagging fs with big metadata feature");
  		features |= BTRFS_FEATURE_INCOMPAT_BIG_METADATA;
  	}
 
@@ -3514,7 +3513,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
  		features |= BTRFS_FEATURE_INCOMPAT_COMPRESS_ZSTD;
 
  	if (features & BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA)
-		btrfs_info(fs_info, "has skinny extents");
+		btrfs_debug(fs_info, "has skinny extents");
 
  	/*
  	 * mixed block groups end up with duplicate but slightly offset