Skip to contentSkip to conversation

test-runner: fix result/monitor options

PATCH Applied James Prestwood 2 participants 2 messages Jun 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test-runner: fix result/monitor options

An earlier commit fixed several options but ended up breaking others. The result_parent/monitor_parent options are hidden from the user and only meant to be passed to the kernel but they relied on the fact that the underscore was present, not a dash. This updates the argument to use a dash:

--result-parent
--monitor-parent

Fixes 00e41eb0ff ("test-runner: Fix parsing for some arguments")
---
 tools/runner.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/runner.py +2 -2
index b018a0ad..d39b560f 100644
@@ -117,8 +117,8 @@ class RunnerCoreArgParse(ArgumentParser):
 				type=str,
 				help='Use physical adapters for tests (passthrough)')
 		self.add_argument('--testhome', help=SUPPRESS)
-		self.add_argument('--monitor_parent', help=SUPPRESS)
-		self.add_argument('--result_parent', help=SUPPRESS)
+		self.add_argument('--monitor-parent', help=SUPPRESS)
+		self.add_argument('--result-parent', help=SUPPRESS)
 
 		# Prevent --autotest/--unittest from being used together
 		auto_unit_group = self.add_mutually_exclusive_group()
Signature · 1 line
2.34.1
#1 lore raw

Hi James,

Quoted 5 lines · James Prestwood

An earlier commit fixed several options but ended up breaking others. The result_parent/monitor_parent options are hidden from the user and only meant to be passed to the kernel but they relied on the fact that the underscore was present, not a dash. This updates the argument to use a dash:

Quoted 8 lines

--result-parent
--monitor-parent

Fixes 00e41eb0ff ("test-runner: Fix parsing for some arguments")
---
  tools/runner.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Regards,
-Denis