Add Mediatek MT6370 PMIC support
Subsystems (12)
v3 cover Add Mediatek MT6370 PMIC support
From: ChiaEn Wu <[email protected]>
This patch series add Mediatek MT6370 PMIC support. The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.
Among with this we took some changes and refined the device tree files to comply with DT specifications.
Thank you,
ChiaEn Wu
---
Changes in v3:
- Remove ADC ABI file, which is added in v2 Patch 7
- In patch 02/14:
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"
- In patch 03/14:
- Use leds-class-multicolor.yaml instead of common.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".
- In patch 04/14:
- Remove the description of enum.
- In patch 05/14:
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values
- In patch 06/14:
- Use " in entire patchset
- Refine ADC description
- Rename "enable-gpio" to "enable-gpios" in "regualtor"
- Change "/schemas/" to "../" in every reference of all MT6370 modules
- In patch 07/14:
- Refine Kconfig help text
- Refine error message of unknown vendor ID in mt6370_check_vendor_info()
- Refine return value handling of mt6370_regmap_read()
- Refine all probe error by using dev_err_probe()
- Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and mt6370_regmap_write()
- Add "#define VENID*" and drop the comments in mt6370_check_vendor_info()
- Drop "MFD" in MODULE_DESCRIPTION()
- In patch 09/14:
- Refine Kconfig help text
- In patch 10/14:
- Refine Kconfig help text
- Refine all channel value in read_scale()
a. current: uA --> mA
b. voltage: uV --> mV
c. temperature: degrees Celsius --> milli degrees Celsius
- Add "default:" condition of switch statement in read_scale() and read_raw()
- Add error message for reading ADC register failed
- Add the comment for adc_lock
- Add <linux/mod_devicetable.h> header file for struct of_device_id
- Replace "adc" text with "ADC" in all of the error messages
- In patch 12/14:
- Refine the grammer of the Kconfig.
- Change reg mode to the const current mode.
- In patch 14/14:
- Refine bool properties parsing (pwm-enable, ovp-shutdown, ocp-shutdown) in DT parsing function
- Refine u32 and u8 properties parsing (pwm-hys-input-th-steps, ovp-microvolt, ocp-microamp), from using register value to using actual value
- Refine error string of "channle-use" parsing failed
- Refine Kconfig help text
Changes in v2:
- In patch 01/15:
- Add "unevaluatedProperties: false".
- Delete "DT bindings".
- Refine the description to fit in 80 columns.
- Skip the connector description.
- In patch 02/15:
- Refine items description of interrupt-name
- Rename "usb-otg-vbus" to "usb-otg-vbus-regulator"
- Add constraint properties for ADC
- In patch 03/15:
- Skip not useful description of "^(multi-)?led@[0-3]$" and reg.
- Due to the dependency, remove the mention of mfd document directory.
- Delete Soft-start property. In design aspect, we think soft-restart should always be enabled, our new chip has deleted the related setting register , also, we don’t allow user adjust this parameter in this chip.
- Refine the commit message.
- In patch 04/15:
- Skip not useful description of "^led@[0-1]$" and reg.
- Add apace after '#'.
- Refine the commit message.
- In patch 05/15:
- Remove "binding documentation" in subject title
- Refine description of mt6370 backlight binding document
- Refine properties name(bled-pwm-hys-input-bit, bled-ovp-microvolt, bled-ocp-microamp) and their description
- In patch 06/15:
- Refine ADC and Regulator descriptions
- Refine include header usage in example
- Refine node name to generic node name("pmic@34")
- Refine led example indentation
- Refine license of mediatek,mt6370_adc.h
- Rename the dts example from IRQ define to number.
- Remove mediatek,mt6370.h
- In patch 07/15:
- Add ABI documentation for mt6370 non-standard ADC sysfs interfaces.
- In patch 08/15:
- Add all IRQ define into mt6370.c.
- Refine include header usage
- In patch 09/15:
- No changes.
- In patch 10/15:
- Use 'gpiod_get_from_of_node' to replace 'fwnode_gpiod_get_index'.
- In patch 11/15:
- Refine Kconfig mt6370 help text
- Refine mask&shift to FIELD_PREP()
- Refine mutex lock name ("lock" -> "adc_lock")
- Refine mt6370_adc_read_scale()
- Refine mt6370_adc_read_offset()
- Refine mt6370_channel_labels[] by using enum to index chan spec
- Refine MT6370_ADC_CHAN()
- Refine indio_dev->name
- Remove useless include header files
- In patch 12/15:
- Refine mt6370_chg_otg_rdesc.of_match
("mt6370,otg-vbus" -> "usb-otg-vbus-regulator") to match
DT binding- In patch 13/15:
- Refine Kconfig description.
- Remove include "linux/of.h" and use "linux/mod_devicetable.h".
- Place a comma for the last element of the const unsigned int array.
- Add a comment line for the mutex 'lock'.
- In probe function, use 'dev_err_probe' in some judgement to reduce the LOC.
- Refine include header usage.
BIT/GENMASK -> linux/bits.h
FIELD_GET -> linux/bitfield.h
- In patch 14/15:
- Add blank line.
- Replace container_of() with to_mt6370_led() .
- Refine description of ramping.
- Refine the mt6370_init_common_properties function.
- Refine the probe return.
- In patch 15/15:
- Refine MT6370 help text in Kconfig
- Refine DT Parse function
- Remove useless enum
- Add comment for 6372 backward compatible in bl_update_status() and
check_vendor_info()
- Using dev_err_probe(); insteads dev_err()&return; in the probe()
Alice Chen (2):
dt-bindings: leds: Add Mediatek MT6370 flashlight
leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support
ChiYuan Huang (8):
dt-bindings: usb: Add Mediatek MT6370 TCPC
dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED
indicator
dt-bindings: backlight: Add Mediatek MT6370 backlight
dt-bindings: mfd: Add Mediatek MT6370
mfd: mt6370: Add Mediatek MT6370 support
usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator
support
ChiaEn Wu (4):
dt-bindings: power: supply: Add Mediatek MT6370 Charger
iio: adc: mt6370: Add Mediatek MT6370 support
power: supply: mt6370: Add Mediatek MT6370 charger driver
video: backlight: mt6370: Add Mediatek MT6370 support
.../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++ .../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 + .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++ .../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +++++ .../power/supply/mediatek,mt6370-charger.yaml | 87 ++ .../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 + drivers/iio/adc/Kconfig | 9 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/mt6370-adc.c | 275 +++++ drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/flash/Kconfig | 9 + drivers/leds/flash/Makefile | 1 + drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ drivers/leds/leds-mt6370.c | 989 +++++++++++++++++ drivers/mfd/Kconfig | 13 + drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++ drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + drivers/power/supply/mt6370-charger.c | 1132 ++++++++++++++++++++ drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6370-regulator.c | 388 +++++++ drivers/usb/typec/tcpm/Kconfig | 8 + drivers/usb/typec/tcpm/Makefile | 1 + drivers/usb/typec/tcpm/tcpci_mt6370.c | 212 ++++ drivers/video/backlight/Kconfig | 9 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/mt6370-backlight.c | 346 ++++++ include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 + 31 files changed, 5074 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml create mode 100644 drivers/iio/adc/mt6370-adc.c create mode 100644 drivers/leds/flash/leds-mt6370-flash.c create mode 100644 drivers/leds/leds-mt6370.c create mode 100644 drivers/mfd/mt6370.c create mode 100644 drivers/power/supply/mt6370-charger.c create mode 100644 drivers/regulator/mt6370-regulator.c create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c create mode 100644 drivers/video/backlight/mt6370-backlight.c create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Signature · 1 line
2.7.4
PATCH v3 1/14 dt-bindings: usb: Add Mediatek MT6370 TCPC
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 TCPC binding documentation.
--- .../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml new file +36 -0
@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/usb/mediatek,mt6370-tcpc.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Mediatek MT6370 Type-C Port Switch and Power Delivery controller + +maintainers: + - ChiYuan Huang <[email protected]> + +description: | + Mediatek MT6370 is a multi-functional device. + It integrates charger, ADC, flash, RGB indicators, + regulators (DSV/VIBLDO), and TypeC Port Switch with Power Delivery controller. + This document only describes MT6370 Type-C Port Switch and + Power Delivery controller. + +properties: + compatible: + enum: + - mediatek,mt6370-tcpc + + interrupts: + maxItems: 1 + + connector: + type: object + $ref: /schemas/connector/usb-connector.yaml# + unevaluatedProperties: false + +additionalProperties: false + +required: + - compatible + - interrupts
Signature · 1 line
2.7.4
PATCH v3 2/14 dt-bindings: power: supply: Add Mediatek MT6370 Charger
In reply to ChiaEn WuFrom: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 Charger binding documentation.
---
v3
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"
--- .../power/supply/mediatek,mt6370-charger.yaml | 87 ++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +87 -0
@@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Battery Charger + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Provides Battery Charger, Boost for OTG devices and BC1.2 detection. + +properties: + compatible: + const: mediatek,mt6370-charger + + interrupts: + description: | + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D" + are required. + items: + - description: BC1.2 done irq + - description: usb plug in irq + - description: mivr irq + + interrupt-names: + items: + - const: attach_i + - const: uvp_d_evt + - const: mivr + + io-channels: + description: | + Use ADC channel to read VBUS, IBUS, IBAT, etc., info. + minItems: 1 + items: + - description: | + VBUS voltage with lower accuracy (+-75mV) but higher measure + range (1~22V) + - description: | + VBUS voltage with higher accuracy (+-30mV) but lower measure + range (1~9.76V) + - description: the main system input voltage + - description: battery voltage + - description: battery temperature-sense input voltage + - description: IBUS current (required) + - description: battery current + - description: | + regulated output voltage to supply for the PWM low-side gate driver + and the bootstrap capacitor + - description: IC junction temperature + + io-channel-names: + items: + - const: vbusdiv5 + - const: vbusdiv2 + - const: vsys + - const: vbat + - const: ts_bat + - const: ibus + - const: ibat + - const: chg_vddp + - const: temp_jc + + usb-otg-vbus-regulator: + type: object + description: OTG boost regulator. + unevaluatedProperties: false + $ref: /schemas/regulator/regulator.yaml# + + properties: + enable-gpios: + maxItems: 1 + +required: + - compatible + - interrupts + - interrupt-names + - io-channels + +additionalProperties: false + +...
Signature · 1 line
2.7.4
PATCH v3 3/14 dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add Mediatek mt6370 current sink type LED indicator binding documentation.
---
v3
- Use leds-class-multicolor.yaml instead of common.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".
--- .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +77 -0
@@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6370 PMIC from MediaTek Integrated. + +maintainers: + - Alice Chen <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode + +allOf: + - $ref: leds-class-multicolor.yaml# + +properties: + compatible: + const: mediatek,mt6370-indicator + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: object + + properties: + reg: + enum: [0, 1, 2, 3] + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "^led@[0-2]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + required: + - reg + - color + + required: + - reg + - color + - "#address-cells" + - "#size-cells" + + "^led@[0-3]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + enum: [0, 1, 2, 3] + + required: + - reg + - color + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false
Signature · 1 line
2.7.4
PATCH v3 4/14 dt-bindings: leds: Add Mediatek MT6370 flashlight
In reply to ChiaEn WuFrom: Alice Chen <[email protected]>
Add Mediatek MT6370 flashlight binding documentation.
---
v3
- Remove the description of enum.
--- .../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml new file +41 -0
@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-flashlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Flash LED driver for MT6370 PMIC from MediaTek Integrated. + +maintainers: + - Alice Chen <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode. + +properties: + compatible: + const: mediatek,mt6370-flashlight + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-1]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + enum: [0, 1] + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false
Signature · 1 line
2.7.4
PATCH v3 5/14 dt-bindings: backlight: Add Mediatek MT6370 backlight
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add mt6370 backlight binding documentation.
---
v3
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values
--- .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +92 -0
@@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Backlight + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + The MT6370 Backlight WLED driver supports up to a 29V output voltage for + 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current + capability with 2048 current steps (11 bits) in exponential or linear + mapping curves. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + const: mediatek,mt6370-backlight + + default-brightness: + minimum: 0 + maximum: 2048 + + max-brightness: + minimum: 0 + maximum: 2048 + + enable-gpios: + description: External backlight 'enable' pin + maxItems: 1 + + mediatek,bled-pwm-enable: + description: | + Enable external PWM input for backlight dimming + type: boolean + + mediatek,bled-pwm-hys-enable: + description: | + Enable the backlight input-hysteresis for PWM mode + type: boolean + + mediatek,bled-pwm-hys-input-th-steps: + $ref: /schemas/types.yaml#/definitions/uint8 + enum: [1, 4, 16, 64] + description: | + The selection of the upper and lower bounds threshold of backlight + PWM resolution. If we choose selection 64, the variation of PWM + resolution needs over than 64 steps. + + mediatek,bled-ovp-shutdown: + description: | + Enable the backlight shutdown when OVP level triggered + type: boolean + + mediatek,bled-ovp-microvolt: + enum: [17000000, 21000000, 25000000, 29000000] + description: | + Backlight OVP level selection. + + mediatek,bled-ocp-shutdown: + description: | + Enable the backlight shutdown when OCP level triggerred. + type: boolean + + mediatek,bled-ocp-microamp: + enum: [900000, 1200000, 1500000, 1800000] + description: | + Backlight OC level selection. + + mediatek,bled-channel-use: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + Backlight LED channel to be used. + Each bit mapping to: + - 0: CH4 + - 1: CH3 + - 2: CH2 + - 3: CH1 + minimum: 1 + maximum: 15 + +required: + - compatible + - mediatek,bled-channel-use + +additionalProperties: false
Signature · 1 line
2.7.4
PATCH v3 6/14 dt-bindings: mfd: Add Mediatek MT6370
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 binding documentation.
---
v3
- Use " in entire patchset
- Refine ADC description
- Rename "enable-gpio" to "enable-gpios" in "regualtor"
- Change "/schemas/" to "../" in every reference of all MT6370 modules
--- .../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +++++++++++++++++++++ include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++ 2 files changed, 298 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml new file +280 -0
@@ -0,0 +1,280 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 SubPMIC + +maintainers: + - ChiYuan Huang <[email protected]> + +description: | + MT6370 is a highly-integrated smart power management IC, which includes a + single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & + Power Delivery (PD) controller, dual flash LED current sources, a RGB LED + driver, a backlight WLED driver, a display bias driver and a general LDO for + portable devices. + +properties: + compatible: + const: mediatek,mt6370 + + reg: + maxItems: 1 + + wakeup-source: true + + interrupts: + maxItems: 1 + + interrupt-controller: true + + "#interrupt-cells": + const: 1 + + adc: + type: object + description: | + Provides 9 channels for system monitoring, including VBUSDIV5 (lower + accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower + measure range), VBAT, VSYS, CHG_VDDP, TS_BAT, IBUS, IBAT, and TEMP_JC. + + properties: + compatible: + const: mediatek,mt6370-adc + + "#io-channel-cells": + const: 1 + + required: + - compatible + - "#io-channel-cells" + + backlight: + type: object + $ref: ../leds/backlight/mediatek,mt6370-backlight.yaml# + + charger: + type: object + $ref: ../power/supply/mediatek,mt6370-charger.yaml# + + tcpc: + type: object + $ref: ../usb/mediatek,mt6370-tcpc.yaml# + + indicator: + type: object + $ref: ../leds/mediatek,mt6370-indicator.yaml# + + flashlight: + type: object + $ref: ../leds/mediatek,mt6370-flashlight.yaml# + + regulators: + type: object + description: | + List all supported regulators, which support the control for DisplayBias + voltages and one general purpose LDO which commonly used to drive the + vibrator. + + patternProperties: + "^(dsvbst|vibldo)$": + $ref: /schemas/regulator/regulator.yaml# + type: object + unevaluatedProperties: false + + "^(dsvpos|dsvneg)$": + $ref: /schemas/regulator/regulator.yaml# + type: object + unevaluatedProperties: false + + properties: + enable-gpios: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-controller + - "#interrupt-cells" + - regulators + - adc + - backlight + - indicator + - tcpc + - charger + - flashlight + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/leds/common.h> + #include <dt-bindings/iio/adc/mediatek,mt6370_adc.h> + #include <dt-bindings/usb/pd.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@34 { + compatible = "mediatek,mt6370"; + reg = <0x34>; + wakeup-source; + interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>; + interrupt-controller; + #interrupt-cells = <1>; + + mt6370_adc: adc { + compatible = "mediatek,mt6370-adc"; + #io-channel-cells = <1>; + }; + + backlight { + compatible = "mediatek,mt6370-backlight"; + mediatek,bled-channel-use = /bits/ 8 <15>; + }; + + charger { + compatible = "mediatek,mt6370-charger"; + interrupts = <48>, <68>, <6>; + interrupt-names = "attach_i", "uvp_d_evt", "mivr"; + io-channels = <&mt6370_adc MT6370_CHAN_IBUS>; + + mt6370_otg_vbus: usb-otg-vbus-regulator { + regulator-name = "mt6370-usb-otg-vbus"; + regulator-min-microvolt = <4350000>; + regulator-max-microvolt = <5800000>; + regulator-min-microamp = <500000>; + regulator-max-microamp = <3000000>; + }; + }; + + indicator { + compatible = "mediatek,mt6370-indicator"; + #address-cells = <1>; + #size-cells = <0>; + + multi-led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RGB>; + led-max-microamp = <24000>; + #address-cells = <1>; + #size-cells = <0>; + led@0 { + reg = <0>; + color = <LED_COLOR_ID_RED>; + }; + led@1 { + reg = <1>; + color = <LED_COLOR_ID_GREEN>; + }; + led@2 { + reg = <2>; + color = <LED_COLOR_ID_BLUE>; + }; + }; + led@3 { + reg = <3>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <6000>; + }; + }; + + flashlight { + compatible = "mediatek,mt6370-flashlight"; + #address-cells = <1>; + #size-cells = <0>; + led@0 { + reg = <0>; + led-sources = <0>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1248000>; + }; + led@1 { + reg = <1>; + led-sources = <1>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1248000>; + }; + }; + + tcpc { + compatible = "mediatek,mt6370-tcpc"; + interrupts-extended = <&gpio26 4 IRQ_TYPE_LEVEL_LOW>; + + connector { + compatible = "usb-c-connector"; + label = "USB-C"; + vbus-supply = <&mt6370_otg_vbus>; + data-role = "dual"; + power-role = "dual"; + try-power-role = "sink"; + source-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>; + sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>; + op-sink-microwatt = <10000000>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + endpoint { + remote-endpoint = <&usb_hs>; + }; + }; + port@1 { + reg = <1>; + endpoint { + remote-endpoint = <&usb_ss>; + }; + }; + port@2 { + reg = <2>; + endpoint { + remote-endpoint = <&dp_aux>; + }; + }; + }; + }; + }; + + regulators { + dsvbst { + regulator-name = "mt6370-dsv-vbst"; + regulator-min-microvolt = <4000000>; + regulator-max-microvolt = <6200000>; + }; + dsvpos { + regulator-name = "mt6370-dsv-vpos"; + regulator-min-microvolt = <4000000>; + regulator-max-microvolt = <6000000>; + regulator-boot-on; + }; + dsvneg { + regulator-name = "mt6370-dsv-vneg"; + regulator-min-microvolt = <4000000>; + regulator-max-microvolt = <6000000>; + regulator-boot-on; + }; + vibldo { + regulator-name = "mt6370-vib-ldo"; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <4000000>; + }; + }; + }; + };
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h new file +18 -0
@@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ + +#ifndef __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__ +#define __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__ + +/* ADC Channel Index */ +#define MT6370_CHAN_VBUSDIV5 0 +#define MT6370_CHAN_VBUSDIV2 1 +#define MT6370_CHAN_VSYS 2 +#define MT6370_CHAN_VBAT 3 +#define MT6370_CHAN_TS_BAT 4 +#define MT6370_CHAN_IBUS 5 +#define MT6370_CHAN_IBAT 6 +#define MT6370_CHAN_CHG_VDDP 7 +#define MT6370_CHAN_TEMP_JC 8 +#define MT6370_CHAN_MAX 9 + +#endif
Signature · 1 line
2.7.4
PATCH v3 7/14 mfd: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
---
v3
- Refine Kconfig help text
- Refine error message of unknown vendor ID in mt6370_check_vendor_info()
- Refine return value handling of mt6370_regmap_read()
- Refine all probe error by using dev_err_probe()
- Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and mt6370_regmap_write()
- Add "#define VENID*" and drop the comments in mt6370_check_vendor_info()
- Drop "MFD" in MODULE_DESCRIPTION()
--- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/mfd/mt6370.c
drivers/mfd/Kconfig +13 -0
@@ -937,6 +937,19 @@ config MFD_MT6360 PMIC part includes 2-channel BUCKs and 2-channel LDOs LDO part includes 4-channel LDOs +config MFD_MT6370 + tristate "Mediatek MT6370 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6370 SubPMIC functional support. + It consists of a single cell battery charger with ADC monitoring, RGB + LEDs, dual channel flashlight, WLED backlight driver, display bias + voltage supply, one general purpose LDO, and the USB Type-C & PD + controller complies with the latest USB Type-C and PD standards. + config MFD_MT6397 tristate "MediaTek MT6397 PMIC Support" select MFD_CORE
drivers/mfd/Makefile +1 -0
@@ -242,6 +242,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o obj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.o obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
drivers/mfd/mt6370.c new file +358 -0
358 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 8/14 usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add chip level mt6370 tcpci driver.
--- drivers/usb/typec/tcpm/Kconfig | 8 ++ drivers/usb/typec/tcpm/Makefile | 1 + drivers/usb/typec/tcpm/tcpci_mt6370.c | 212 ++++++++++++++++++++++++++++++++++ 3 files changed, 221 insertions(+) create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
drivers/usb/typec/tcpm/Kconfig +8 -0
@@ -35,6 +35,14 @@ config TYPEC_MT6360 USB Type-C. It works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. +config TYPEC_TCPCI_MT6370 + tristate "Mediatek MT6370 Type-C driver" + depends on MFD_MT6370 + help + Mediatek MT6370 is a multi-functional IC that includes + USB Type-C. It works with Type-C Port Controller Manager + to provide USB PD and USB Type-C functionalities. + config TYPEC_TCPCI_MAXIM tristate "Maxim TCPCI based Type-C chip driver" help
drivers/usb/typec/tcpm/Makefile +1 -0
@@ -6,4 +6,5 @@ typec_wcove-y := wcove.o obj-$(CONFIG_TYPEC_TCPCI) += tcpci.o obj-$(CONFIG_TYPEC_RT1711H) += tcpci_rt1711h.o obj-$(CONFIG_TYPEC_MT6360) += tcpci_mt6360.o +obj-$(CONFIG_TYPEC_TCPCI_MT6370) += tcpci_mt6370.o obj-$(CONFIG_TYPEC_TCPCI_MAXIM) += tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +212 -0
212 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 9/14 regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add mt6370 DisplayBias and VibLDO support.
---
v3
- Refine Kconfig help text
--- drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6370-regulator.c | 388 +++++++++++++++++++++++++++++++++++ 3 files changed, 397 insertions(+) create mode 100644 drivers/regulator/mt6370-regulator.c
drivers/regulator/Kconfig +8 -0
@@ -804,6 +804,14 @@ config REGULATOR_MT6360 2-channel buck with Thermal Shutdown and Overload Protection 6-channel High PSRR and Low Dropout LDO. +config REGULATOR_MT6370 + tristate "MT6370 SubPMIC Regulator" + depends on MFD_MT6370 + help + Say Y here to enable MT6370 regulator support. + This driver supports the control for DisplayBias voltages and one + general purpose LDO which is commonly used to drive the vibrator. + config REGULATOR_MT6380 tristate "MediaTek MT6380 PMIC" depends on MTK_PMIC_WRAP
drivers/regulator/Makefile +1 -0
@@ -97,6 +97,7 @@ obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o obj-$(CONFIG_REGULATOR_MT6358) += mt6358-regulator.o obj-$(CONFIG_REGULATOR_MT6359) += mt6359-regulator.o obj-$(CONFIG_REGULATOR_MT6360) += mt6360-regulator.o +obj-$(CONFIG_REGULATOR_MT6370) += mt6370-regulator.o obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o obj-$(CONFIG_REGULATOR_MTK_DVFSRC) += mtk-dvfsrc-regulator.o
drivers/regulator/mt6370-regulator.c new file +388 -0
388 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 10/14 iio: adc: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuFrom: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 ADC support.
---
v3
- Refine Kconfig help text
- Refine all channel value in read_scale()
a. current: uA --> mA b. voltage: uV --> mV c. temperature: degrees Celsius --> milli degrees Celsius
- Add "default:" condition of switch statement in read_scale() and read_raw()
- Add error message for reading ADC register failed
- Add the comment for adc_lock
- Add <linux/mod_devicetable.h> header file for struct of_device_id
- Replace "adc" text with "ADC" in all of the error messages
--- drivers/iio/adc/Kconfig | 9 ++ drivers/iio/adc/Makefile | 1 + drivers/iio/adc/mt6370-adc.c | 275 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 285 insertions(+) create mode 100644 drivers/iio/adc/mt6370-adc.c
drivers/iio/adc/Kconfig +9 -0
@@ -737,6 +737,15 @@ config MEDIATEK_MT6360_ADC is used in smartphones and tablets and supports a 11 channel general purpose ADC. +config MEDIATEK_MT6370_ADC + tristate "Mediatek MT6370 ADC driver" + depends on MFD_MT6370 + help + Say yes here to enable Mediatek MT6370 ADC support. + + This ADC driver provides 9 channels for system monitoring (charger + current, voltage, and temperature). + config MEDIATEK_MT6577_AUXADC tristate "MediaTek AUXADC driver" depends on ARCH_MEDIATEK || COMPILE_TEST
drivers/iio/adc/Makefile +1 -0
@@ -68,6 +68,7 @@ obj-$(CONFIG_MCP320X) += mcp320x.o obj-$(CONFIG_MCP3422) += mcp3422.o obj-$(CONFIG_MCP3911) += mcp3911.o obj-$(CONFIG_MEDIATEK_MT6360_ADC) += mt6360-adc.o +obj-$(CONFIG_MEDIATEK_MT6370_ADC) += mt6370-adc.o obj-$(CONFIG_MEDIATEK_MT6577_AUXADC) += mt6577_auxadc.o obj-$(CONFIG_MEN_Z188_ADC) += men_z188_adc.o obj-$(CONFIG_MESON_SARADC) += meson_saradc.o
drivers/iio/adc/mt6370-adc.c new file +275 -0
275 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 11/14 power: supply: mt6370: Add Mediatek MT6370 charger driver
In reply to ChiaEn WuFrom: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 charger driver.
--- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + drivers/power/supply/mt6370-charger.c | 1132 +++++++++++++++++++++++++++++++++ 3 files changed, 1144 insertions(+) create mode 100644 drivers/power/supply/mt6370-charger.c
drivers/power/supply/Kconfig +11 -0
@@ -619,6 +619,17 @@ config CHARGER_MT6360 Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2. +config CHARGER_MT6370 + tristate "Mediatek MT6370 Charger Driver" + depends on MFD_MT6370 + depends on REGULATOR + select LINEAR_RANGES + help + Say Y here to enable MT6370 Charger Part. + The device supports High-Accuracy Voltage/Current Regulation, + Average Input Current Regulation, Battery Temperature Sensing, + Over-Temperature Protection, DPDM Detection for BC1.2. + config CHARGER_QCOM_SMBB tristate "Qualcomm Switch-Mode Battery Charger and Boost" depends on MFD_SPMI_PMIC || COMPILE_TEST
drivers/power/supply/Makefile +1 -0
@@ -82,6 +82,7 @@ obj-$(CONFIG_CHARGER_MAX8997) += max8997_charger.o obj-$(CONFIG_CHARGER_MAX8998) += max8998_charger.o obj-$(CONFIG_CHARGER_MP2629) += mp2629_charger.o obj-$(CONFIG_CHARGER_MT6360) += mt6360_charger.o +obj-$(CONFIG_CHARGER_MT6370) += mt6370-charger.o obj-$(CONFIG_CHARGER_QCOM_SMBB) += qcom_smbb.o obj-$(CONFIG_CHARGER_BQ2415X) += bq2415x_charger.o obj-$(CONFIG_CHARGER_BQ24190) += bq24190_charger.o
drivers/power/supply/mt6370-charger.c new file +1132 -0
1,132 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 12/14 leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
In reply to ChiaEn WuFrom: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 current sink type LED Indicator driver.
---
v3
- Refine the grammer of the Kconfig.
- Change reg mode to the const current mode.
--- drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 1001 insertions(+) create mode 100644 drivers/leds/leds-mt6370.c
drivers/leds/Kconfig +11 -0
@@ -244,6 +244,17 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC. +config LEDS_MT6370_RGB + tristate "LED Support for Mediatek MT6370 PMIC" + depends on LEDS_CLASS + depends on MFD_MT6370 + select LINEAR_RANGE + help + Say Y here to enable support for MT6370_RGB LED device. + In MT6370, there are four channel current-sink LED drivers that + support hardware pattern for const current, PWM, and breath mode. + Isink4 channel can also be used as a CHG_VIN power good indicator. + config LEDS_S3C24XX tristate "LED Support for Samsung S3C24XX GPIO LEDs" depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
@@ -62,6 +62,7 @@ obj-$(CONFIG_LEDS_MIKROTIK_RB532) += leds-rb532.o obj-$(CONFIG_LEDS_MLXCPLD) += leds-mlxcpld.o obj-$(CONFIG_LEDS_MLXREG) += leds-mlxreg.o obj-$(CONFIG_LEDS_MT6323) += leds-mt6323.o +obj-$(CONFIG_LEDS_MT6370_RGB) += leds-mt6370.o obj-$(CONFIG_LEDS_NET48XX) += leds-net48xx.o obj-$(CONFIG_LEDS_NETXBIG) += leds-netxbig.o obj-$(CONFIG_LEDS_NIC78BX) += leds-nic78bx.o
drivers/leds/leds-mt6370.c new file +989 -0
989 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 13/14 leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support
In reply to ChiaEn WuFrom: Alice Chen <[email protected]>
Add Mediatek MT6370 flashlight support.
--- drivers/leds/flash/Kconfig | 9 + drivers/leds/flash/Makefile | 1 + drivers/leds/flash/leds-mt6370-flash.c | 657 +++++++++++++++++++++++++++++++++ 3 files changed, 667 insertions(+) create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
drivers/leds/flash/Kconfig +9 -0
@@ -90,4 +90,13 @@ config LEDS_SGM3140 This option enables support for the SGM3140 500mA Buck/Boost Charge Pump LED Driver. +config LEDS_MT6370_FLASHLIGHT + tristate "Flash LED Support for Mediatek MT6370 PMIC" + depends on LEDS_CLASS + depends on MFD_MT6370 + help + Support 2 channels and torch/strobe mode. + Say Y here to enable support for + MT6370_FLASH_LED device. + endif # LEDS_CLASS_FLASH
drivers/leds/flash/Makefile +1 -0
@@ -9,3 +9,4 @@ obj-$(CONFIG_LEDS_MAX77693) += leds-max77693.o obj-$(CONFIG_LEDS_RT4505) += leds-rt4505.o obj-$(CONFIG_LEDS_RT8515) += leds-rt8515.o obj-$(CONFIG_LEDS_SGM3140) += leds-sgm3140.o +obj-$(CONFIG_LEDS_MT6370_FLASHLIGHT) += leds-mt6370-flash.o
drivers/leds/flash/leds-mt6370-flash.c new file +657 -0
657 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 14/14 video: backlight: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuFrom: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 Backlight support.
---
v3
- Refine bool properties parsing (pwm-enable, ovp-shutdown, ocp-shutdown) in DT parsing function
- Refine u32 and u8 properties parsing (pwm-hys-input-th-steps, ovp-microvolt, ocp-microamp), from using register value to using actual value
- Refine error string of "channle-use" parsing failed
- Refine Kconfig help text
--- drivers/video/backlight/Kconfig | 9 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/mt6370-backlight.c | 346 +++++++++++++++++++++++++++++ 3 files changed, 356 insertions(+) create mode 100644 drivers/video/backlight/mt6370-backlight.c
drivers/video/backlight/Kconfig +9 -0
@@ -268,6 +268,15 @@ config BACKLIGHT_MAX8925 If you have a LCD backlight connected to the WLED output of MAX8925 WLED output, say Y here to enable this driver. +config BACKLIGHT_MT6370 + tristate "Mediatek MT6370 Backlight Driver" + depends on MFD_MT6370 + help + This enables support for Mediatek MT6370 Backlight driver. + It's commonly used to drive the display WLED. There are 4 channels + inside, and each channel supports up to 30mA of current capability + with 2048 current steps in exponential or linear mapping curves. + config BACKLIGHT_APPLE tristate "Apple Backlight Driver" depends on X86 && ACPI
drivers/video/backlight/Makefile +1 -0
@@ -44,6 +44,7 @@ obj-$(CONFIG_BACKLIGHT_LP855X) += lp855x_bl.o obj-$(CONFIG_BACKLIGHT_LP8788) += lp8788_bl.o obj-$(CONFIG_BACKLIGHT_LV5207LP) += lv5207lp.o obj-$(CONFIG_BACKLIGHT_MAX8925) += max8925_bl.o +obj-$(CONFIG_BACKLIGHT_MT6370) += mt6370-backlight.o obj-$(CONFIG_BACKLIGHT_OMAP1) += omap1_bl.o obj-$(CONFIG_BACKLIGHT_PANDORA) += pandora_bl.o obj-$(CONFIG_BACKLIGHT_PCF50633) += pcf50633-backlight.o
drivers/video/backlight/mt6370-backlight.c new file +346 -0
346 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight
In reply to ChiaEn WuQuoted 67 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add mt6370 backlight binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values--- .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yamlDocumentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +44
-0@@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Backlight + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + The MT6370 Backlight WLED driver supports up to a 29V output voltage for + 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current + capability with 2048 current steps (11 bits) in exponential or linear + mapping curves. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + const: mediatek,mt6370-backlight + + default-brightness: + minimum: 0 + maximum: 2048 + + max-brightness: + minimum: 0 + maximum: 2048 + + enable-gpios: + description: External backlight 'enable' pin + maxItems: 1 + + mediatek,bled-pwm-enable: + description: | + Enable external PWM input for backlight dimming + type: boolean + + mediatek,bled-pwm-hys-enable: + description: |
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml line 54
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +10
-0+ Enable the backlight input-hysteresis for PWM mode + type: boolean + + mediatek,bled-pwm-hys-input-th-steps: + $ref: /schemas/types.yaml#/definitions/uint8 + enum: [1, 4, 16, 64] + description: | + The selection of the upper and lower bounds threshold of backlight + PWM resolution. If we choose selection 64, the variation of PWM + resolution needs over than 64 steps.
more than?
Thanks,
Joe
Quoted 41 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +38
-0+ + mediatek,bled-ovp-shutdown: + description: | + Enable the backlight shutdown when OVP level triggered + type: boolean + + mediatek,bled-ovp-microvolt: + enum: [17000000, 21000000, 25000000, 29000000] + description: | + Backlight OVP level selection. + + mediatek,bled-ocp-shutdown: + description: | + Enable the backlight shutdown when OCP level triggerred. + type: boolean + + mediatek,bled-ocp-microamp: + enum: [900000, 1200000, 1500000, 1800000] + description: | + Backlight OC level selection. + + mediatek,bled-channel-use: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + Backlight LED channel to be used. + Each bit mapping to: + - 0: CH4 + - 1: CH3 + - 2: CH2 + - 3: CH1 + minimum: 1 + maximum: 15 + +required: + - compatible + - mediatek,bled-channel-use + +additionalProperties: falseSignature · 1 line
2.7.4
Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuQuoted 28 lines · ChiaEn Wu
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 Backlight support.
Signed-off-by ChiaEn Wu <[email protected]>drivers/video/backlight/Kconfig +19
-0+static int mt6370_init_backlight_properties(struct mt6370_priv *priv, + struct backlight_properties *props) +{ + struct device *dev = priv->dev; + u8 prop_val; + u32 brightness, ovp_uV, ocp_uA; + unsigned int mask, val; + int ret; + + /* Vendor optional properties */ + val = 0; + if (device_property_read_bool(dev, "mediatek,bled-pwm-enable")) + val |= MT6370_BL_PWM_EN_MASK; + + if (device_property_read_bool(dev, "mediatek,bled-pwm-hys-enable")) + val |= MT6370_BL_PWM_HYS_EN_MASK; + + ret = device_property_read_u8(dev, + "mediatek,bled-pwm-hys-input-th-steps",
drivers/video/backlight/Kconfig
Quoted 10 lines
drivers/video/backlight/Kconfig +10
-0+ &prop_val); + if (!ret) { + prop_val = clamp_val(prop_val, + MT6370_BL_PWM_HYS_TH_MIN_STEP, + MT6370_BL_PWM_HYS_TH_MAX_STEP); + /* + * prop_val = 1 --> 1 steps --> 0x00 + * prop_val = 2 ~ 4 --> 4 steps --> 0x01 + * prop_val = 5 ~ 16 --> 16 steps --> 0x10 + * prop_val = 17 ~ 64 --> 64 steps --> 0x11
^^^^^
These numbers are binary, not hex, right? If so, the comments should be 0b00 to 0b03 .
drivers/video/backlight/Kconfig
Quoted 9 lines
drivers/video/backlight/Kconfig +9
-0+ */ + prop_val = (ilog2(roundup_pow_of_two(prop_val)) + 1) >> 1; + val |= prop_val << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1); + } + + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, + val, val); + if (ret) + return ret;
Overall, I like this approach! Easy to read and understand.
drivers/video/backlight/Kconfig
Quoted 7 lines
<snip>
drivers/video/backlight/Kconfig +6
-0+static int mt6370_bl_probe(struct platform_device *pdev) +{ + struct mt6370_priv *priv; + struct backlight_properties props = { + .type = BACKLIGHT_RAW, + .scale = BACKLIGHT_SCALE_LINEAR,
Sorry, I missed this before but the KConfig comment says that the backlight can support both linear and exponential curves.
Is there a good reason to default to linear?
Daniel.
Quoted 1 line
Mark Brown
maintainerRe: (subset) [PATCH v3 00/14] Add Mediatek MT6370 PMIC support
In reply to ChiaEn WuQuoted 10 lines · ChiaEn Wu
From: ChiaEn Wu <[email protected]>
This patch series add Mediatek MT6370 PMIC support. The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
commit: 8171c93bac1bf9e98269b2efb19ef4e6c4e55ed7
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuQuoted 4 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
...
drivers/mfd/Kconfig config MFD_MT6360 · line 951
Quoted 12 lines
drivers/mfd/Kconfig +12
-0+config MFD_MT6370 + tristate "Mediatek MT6370 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6370 SubPMIC functional support. + It consists of a single cell battery charger with ADC monitoring, RGB + LEDs, dual channel flashlight, WLED backlight driver, display bias + voltage supply, one general purpose LDO, and the USB Type-C & PD + controller complies with the latest USB Type-C and PD standards.
What will be the module name in case it's chosen to be built as a module?
...
Quoted 8 lines
obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.oobj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.oobj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
This whole bunch of drivers is in the wrong place in Makefile.
https://lore.kernel.org/all/[email protected]/
...
Quoted 1 line
+#define
MT6370_REG_MAXADDR0x1FF
Wondering if (BIT(10) - 1) gives a better hint on how hardware limits this (so it will be clear it's 10-bit address).
...
Quoted 6 lines
drivers/mfd/mt6370.c new file +6
-0+static int mt6370_check_vendor_info (struct mt6370_info *info) +{ +unsigned int devinfo; +int ret; + + ret =regmap_read (info->regmap,MT6370_REG_DEV_INFO , &devinfo);
drivers/mfd/mt6370.c line 240
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+if (ret) +return ret; + +switch (FIELD_GET (MT6370_VENID_MASK , devinfo)) { +case MT6370_VENID_RT5081 : +case MT6370_VENID_RT5081A : +case MT6370_VENID_MT6370 : +case MT6370_VENID_MT6371 : +case MT6370_VENID_MT6372P : +case MT6370_VENID_MT6372CP :
return 0;
drivers/mfd/mt6370.c line 247
Quoted 7 lines
drivers/mfd/mt6370.c new file +7
-0+break ; +default : +dev_err (info->dev,"Unknown Vendor ID 0x%02x\n" , devinfo); +return -ENODEV ; + } + +return 0 ;
...and drop these two lines?
Quoted 1 line
+}
...
drivers/mfd/mt6370.c line 258
Quoted 2 lines
drivers/mfd/mt6370.c new file +2
-0+ bank_idx = *(u8 *)reg_buf; + bank_addr = *(u8 *)(reg_buf +1 );
Why not
const u8 *u8_buf = reg_buf; bank_idx = u8_buf[0]; bank_addr = u8_buf[1];
?
...
drivers/mfd/mt6370.c line 264
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+if (ret <0 ) +return ret; +else if (ret != val_size)
Redundant 'else'.
Quoted 1 line
+ return
-EIO;
...
drivers/mfd/mt6370.c line 277
Quoted 2 lines
drivers/mfd/mt6370.c new file +2
-0+ bank_idx = *(u8 *)data; + bank_addr = *(u8 *)(data +1 );
As per above.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
In reply to ChiaEn WuQuoted 4 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add chip level mt6370 tcpci driver.
...
drivers/usb/typec/tcpm/Kconfig config TYPEC_MT6360 · line 44
Quoted 7 lines
drivers/usb/typec/tcpm/Kconfig +7
-0+config TYPEC_TCPCI_MT6370 + tristate "Mediatek MT6370 Type-C driver" + depends on MFD_MT6370 + help + Mediatek MT6370 is a multi-functional IC that includes + USB Type-C. It works with Type-C Port Controller Manager + to provide USB PD and USB Type-C functionalities.
What will be the module name?
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 7
Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +5
-0+#include <linux/bits.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h>
No user of this header is found in this file.
Quoted 7 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +7
-0+#include <linux/platform_device.h> +#include <linux/pm_wakeup.h> +#include <linux/pm_wakeirq.h> +#include <linux/regmap.h> +#include <linux/regulator/consumer.h> +#include <linux/usb/tcpm.h> +#include "tcpci.h"
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 64
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4
-0+if (did ==MT6370_TCPC_DID_A ) { + ret =regmap_write (data->regmap,TCPC_FAULT_CTRL ,0x80 ); +if (ret) +return ret;
return regmap_write(...);
Quoted 3 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +3
-0+ } + +return 0 ;
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 96
Quoted 8 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +8
-0+if (ret && !source) + ret =regulator_disable (priv->vbus); +else if (!ret && source) + ret =regulator_enable (priv->vbus); +else + ret =0 ; + +return ret;
Can it be
if (ret && ...)
return regulator_disable(...);
if (!ret && ...)
return regulator_enable(...);return 0;
?
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 140
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4
-0+if (!priv->tcpci_data.regmap) { +dev_err (&pdev->dev,"Failed to init regmap\n" ); +return -ENODEV ; + }
return dev_err_probe(...); ?
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 146
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4
-0+if (ret) { +dev_err (&pdev->dev,"Failed to check vendor info (%d)\n" , ret); +return ret; + }
Ditto.
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 150
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +3
-0+ priv->irq =platform_get_irq (pdev,0 ); +if (priv->irq <0 ) { +dev_err (&pdev->dev,"Failed to get TCPC irq (%d)\n" , priv->irq);
The message like this is printed in case of error inside platform_get_irq(), no need to duplicate.
Quoted 2 lines
(quoted diff) +2
-0+ return priv->irq; + }
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 166
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4
-0+ priv->tcpci =tcpci_register_port (&pdev->dev, &priv->tcpci_data); +if (IS_ERR (priv->tcpci)) { +dev_err (&pdev->dev,"Failed to register tcpci port\n" ); +return PTR_ERR (priv->tcpci);
return dev_err_probe(); ?
Quoted 1 line
+ }
...
drivers/usb/typec/tcpm/tcpci_mt6370.c line 175
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4
-0+if (ret) { +dev_err (&pdev->dev,"Failed to allocate irq (%d)\n" , ret); +tcpci_unregister_port (priv->tcpci); +return ret;
Ditto.
Quoted 1 line
+ }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
In reply to ChiaEn WuQuoted 4 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add mt6370 DisplayBias and VibLDO support.
...
drivers/regulator/mt6370-regulator.c line 8
Quoted 7 lines
drivers/regulator/mt6370-regulator.c new file +6
-0+#include <linux/bits.h> +#include <linux/gpio/consumer.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h>
Any users of this? (See below)
Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/regulator/driver.h> +#include <linux/regulator/machine.h>
...
drivers/regulator/mt6370-regulator.c line 59
Quoted 9 lines
drivers/regulator/mt6370-regulator.c new file +9
-0+#define MT6370_LDO_MINUV 1600000 +#define MT6370_LDO_STPUV 200000 +#define MT6370_LDO_N_VOLT 13 +#define MT6370_DBVBOOST_MINUV 4000000 +#define MT6370_DBVBOOST_STPUV 50000 +#define MT6370_DBVBOOST_N_VOLT 45 +#define MT6370_DBVOUT_MINUV 4000000 +#define MT6370_DBVOUT_STPUV 50000 +#define MT6370_DBVOUT_N_VOLT 41
If UV is a unit suffix, make it _UV.
...
Quoted 1 line
+ .of_match =
of_match_ptr("dsvbst"),
Would it even be called / used if CONFIG_OF=n?
...
Quoted 1 line
+ .regulators_node =
of_match_ptr("regulators"),
Ditto.
...
drivers/regulator/mt6370-regulator.c line 314
Quoted 13 lines
drivers/regulator/mt6370-regulator.c new file +12
-0+for (i =0 ; i <ARRAY_SIZE (mt6370_irqs); i++) { + irq =platform_get_irq_byname (pdev, mt6370_irqs[i].name); + + rdev = priv->rdev[mt6370_irqs[i].rid]; + + ret =devm_request_threaded_irq (priv->dev, irq,NULL , + mt6370_irqs[i].handler,0 , + mt6370_irqs[i].name, rdev); +if (ret) { +dev_err (priv->dev, +"Failed to register (%d) interrupt\n" , i); +return ret;
return dev_err_probe(...); ?
Quoted 2 lines
(quoted diff) +2
-0+ } + }
...
drivers/regulator/mt6370-regulator.c line 338
Quoted 9 lines
drivers/regulator/mt6370-regulator.c new file +8
-0+for (i =0 ; i <MT6370_MAX_IDX ; i++) { + rdev =devm_regulator_register (priv->dev, + mt6370_regulator_descs + i, + &cfg); +if (IS_ERR (rdev)) { +dev_err (priv->dev, +"Failed to register (%d) regulator\n" , i); +return PTR_ERR (rdev);
return dev_err_probe(...); ?
Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+ } + + priv->rdev[i] = rdev; + }
...
drivers/regulator/mt6370-regulator.c line 362
Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+if (!priv->regmap) { +dev_err (&pdev->dev,"Failed to init regmap\n" ); +return -ENODEV ; + }
return dev_err_probe(...);
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuQuoted 4 lines · ChiaEn Wu
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 ADC support.
...
drivers/iio/adc/Kconfig config MEDIATEK_MT6360_ADC · line 747
Quoted 8 lines
drivers/iio/adc/Kconfig +8
-0+config MEDIATEK_MT6370_ADC + tristate "Mediatek MT6370 ADC driver" + depends on MFD_MT6370 + help + Say yes here to enable Mediatek MT6370 ADC support. + + This ADC driver provides 9 channels for system monitoring (charger + current, voltage, and temperature).
What will be the module name?
...
Quoted 1 line
+#include <
dt-bindings/iio/adc/mediatek,mt6370_adc.h>
Usually this goes after linux/* asm/* as it's not so generic.
drivers/iio/adc/mt6370-adc.c line 9
Quoted 7 lines
drivers/iio/adc/mt6370-adc.c new file +6
-0+#include <linux/bits.h> +#include <linux/bitfield.h> +#include <linux/iio/iio.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/mod_devicetable.h>
I believe the order should be otherwise, this is first followed by module.h.
Quoted 3 lines
drivers/iio/adc/mt6370-adc.c new file +3
-0+#include <linux/mutex.h> +#include <linux/platform_device.h> +#include <linux/regmap.h>
...
Quoted 1 line
+#define
ADC_CONV_POLLING_TIME1000
If it's time, add a unit suffix, if it's a counter, make it clear.
...
Quoted 1 line
+
msleep(ADC_CONV_TIME_US / 1000);
Why define microseconds if milliseconds are in use?
...
drivers/iio/adc/mt6370-adc.c line 64
Quoted 8 lines
drivers/iio/adc/mt6370-adc.c new file +8
-0+ ret =regmap_read_poll_timeout (priv->regmap, +MT6370_REG_CHG_ADC , reg_val, + !(reg_val &MT6370_ADC_START_MASK ), +ADC_CONV_POLLING_TIME , +ADC_CONV_TIME_US *3 ); +if (ret) { +if (ret == -ETIMEDOUT ) +dev_err (priv->dev,"Failed to wait ADC conversion\n" );
wait for
drivers/iio/adc/mt6370-adc.c line 67
Quoted 3 lines
drivers/iio/adc/mt6370-adc.c new file +3
-0+else +dev_err (priv->dev, +"Failed to read ADC register (%d)\n" , ret);
Do you really need to differentiate the errors here? I believe the latter one covers all cases.
Quoted 2 lines
(quoted diff) +2
-0+ goto adc_unlock; + }
...
drivers/iio/adc/mt6370-adc.c line 206
Quoted 9 lines
drivers/iio/adc/mt6370-adc.c new file +9
-0+#define MT6370_ADC_CHAN (_idx, _type, _addr, _extra_info) { \ + .type = _type, \ + .channel = MT6370_CHAN_##_idx, \ + .address = _addr, \ + .scan_index = MT6370_CHAN_##_idx, \ + .indexed = 1, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ + BIT(IIO_CHAN_INFO_SCALE) | \ + _extra_info \
Leave a comma after the last member as well.
Quoted 1 line
+}
...
drivers/iio/adc/mt6370-adc.c line 231
Quoted 5 lines
drivers/iio/adc/mt6370-adc.c new file +4
-0+ regmap =dev_get_regmap (pdev->dev.parent,NULL ); +if (!regmap) { +dev_err (&pdev->dev,"Failed to get regmap\n" ); +return -ENODEV ;
return dev_err_probe(...);
Quoted 1 line
+ }
...
drivers/iio/adc/mt6370-adc.c line 247
Quoted 5 lines
drivers/iio/adc/mt6370-adc.c new file +5
-0+ ret =regmap_write (priv->regmap,MT6370_REG_CHG_ADC ,0 ); +if (ret) { +dev_err (&pdev->dev,"Failed to reset ADC\n" ); +return ret; + }
Ditto.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver
In reply to ChiaEn WuQuoted 4 lines · ChiaEn Wu
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 charger driver.
...
drivers/power/supply/Kconfig config CHARGER_MT6360 · line 631
Quoted 10 lines
drivers/power/supply/Kconfig +10
-0+config CHARGER_MT6370 + tristate "Mediatek MT6370 Charger Driver" + depends on MFD_MT6370 + depends on REGULATOR + select LINEAR_RANGES + help + Say Y here to enable MT6370 Charger Part. + The device supports High-Accuracy Voltage/Current Regulation, + Average Input Current Regulation, Battery Temperature Sensing, + Over-Temperature Protection, DPDM Detection for BC1.2.
Module name?
...
Quoted 1 line
+#include <
dt-bindings/iio/adc/mediatek,mt6370_adc.h>
This usually goes after linux/*
Quoted 18 lines
drivers/power/supply/mt6370-charger.c new file +15
-0+#include <linux/atomic.h> +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/gpio/consumer.h> +#include <linux/iio/consumer.h> +#include <linux/init.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/power_supply.h> +#include <linux/regmap.h> +#include <linux/regulator/driver.h> +#include <linux/workqueue.h>
...
Quoted 1 line
+#define
MT6370_MIVR_IBUS_TH100000 /* 100 mA */
Instead of comment, add proper units.
...
drivers/power/supply/mt6370-charger.c line 100
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+MT6370_USB_STAT_DCP , +MT6370_USB_STAT_CDP , + MT6370_USB_STAT_MAX,
No comma for a terminator line.
...
drivers/power/supply/mt6370-charger.c line 220
Quoted 4 lines
drivers/power/supply/mt6370-charger.c new file +4
-0+static inline u32 mt6370_chg_val_to_reg(const struct mt6370_chg_range *range, + u32 val) +static inline u32 mt6370_chg_reg_to_val(const struct mt6370_chg_range *range, + u8 reg)
I'm wondering if you can use the
https://elixir.bootlin.com/linux/v5.19-rc3/source/include/linux/linear_range.h
APIs.
...
Quoted 1 line
+ int ret = 0;
This seems a redundant assignment, see below.
drivers/power/supply/mt6370-charger.c line 276
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ rcfg->ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(of), + "enable", 0,
For index == 0 don't use _index API.
drivers/power/supply/mt6370-charger.c line 281
Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+GPIOD_OUT_LOW | +GPIOD_FLAGS_BIT_NONEXCLUSIVE , + rdesc->name); +if (IS_ERR (rcfg->ena_gpiod)) { +dev_err (priv->dev,"Failed to requeset OTG EN Pin\n" );
request
Quoted 1 line
+
rcfg->ena_gpiod= NULL;
So, use _optional and return any errors you got.
Quoted 7 lines
drivers/power/supply/mt6370-charger.c new file +7
-0+ }else { + val =MT6370_OPA_MODE_MASK |MT6370_OTG_PIN_EN_MASK ; + ret =regmap_update_bits (priv->regmap,MT6370_REG_CHG_CTRL1 , + val, val); +if (ret) +dev_err (priv->dev,"Failed to set otg bits\n" ); + }
...
drivers/power/supply/mt6370-charger.c line 367
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ irq_num =platform_get_irq_byname (pdev, irq_name); +
Unwanted blank line.
drivers/power/supply/mt6370-charger.c line 369
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+if (irq_num <0 ) { +dev_err (priv->dev,"Failed to get platform resource\n" );
Isn't it printed by the call?
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+ }else { +if (en) +enable_irq (irq_num); +else +disable_irq_nosync (irq_num); + }
...
Quoted 1 line
+toggle_cfo_exit:
The useless label.
Quoted 2 lines
(quoted diff) +2
-0+ return ret; +}
...
drivers/power/supply/mt6370-charger.c line 509
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ ret =mt6370_chg_get_online (priv, val); +if (!val->intval) {
No error check?
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+ val->intval =POWER_SUPPLY_STATUS_DISCHARGING ; +return 0 ; + }
...
Quoted 13 lines
drivers/power/supply/mt6370-charger.c new file +13
-0+static int mt6370_chg_set_online (struct mt6370_priv *priv, +const union power_supply_propval *val) +{ +int attach; +u32 pwr_rdy = !!val->intval; + +mutex_lock (&priv->attach_lock); + attach =atomic_read (&priv->attach); +if (pwr_rdy == !!attach) { +dev_err (priv->dev,"pwr_rdy is same(%d)\n" , pwr_rdy); +mutex_unlock (&priv->attach_lock); +return 0 ; + }
drivers/power/supply/mt6370-charger.c line 640
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +9
-0+ +atomic_set (&priv->attach, pwr_rdy); +mutex_unlock (&priv->attach_lock); + +if (!queue_work (priv->wq, &priv->bc12_work)) +dev_err (priv->dev,"bc12 work has already queued\n" ); + +return 0 ; +
Unwanted blank line.
Quoted 45 lines
drivers/power/supply/mt6370-charger.c new file +44
-0+} +static int mt6370_chg_get_property (struct power_supply *psy, +enum power_supply_property psp, +union power_supply_propval *val) +{ +struct mt6370_priv *priv =power_supply_get_drvdata (psy); +int ret =0 ; + +switch (psp) { +case POWER_SUPPLY_PROP_ONLINE : + ret =mt6370_chg_get_online (priv, val); +break ; +case POWER_SUPPLY_PROP_STATUS : + ret =mt6370_chg_get_status (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TYPE : + ret =mt6370_chg_get_charge_type (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT : + ret =mt6370_chg_get_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX : + ret =mt6370_chg_get_max_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE : + ret =mt6370_chg_get_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX : + ret =mt6370_chg_get_max_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT : + ret =mt6370_chg_get_aicr (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT : + ret =mt6370_chg_get_mivr (priv, val); +break ; +case POWER_SUPPLY_PROP_PRECHARGE_CURRENT : + ret =mt6370_chg_get_iprechg (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT : + ret =mt6370_chg_get_ieoc (priv, val); +break ; +case POWER_SUPPLY_PROP_TYPE : + val->intval = priv->psy_desc->type;
drivers/power/supply/mt6370-charger.c line 731
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10
-0+break ; +case POWER_SUPPLY_PROP_USB_TYPE : + val->intval = priv->psy_usb_type; +break ; +default : + ret = -EINVAL ; +break ; + } + +return ret;
In all cases, return directly.
Quoted 1 line
+}
...
Quoted 16 lines
drivers/power/supply/mt6370-charger.c new file +16
-0+switch (psp) { +case POWER_SUPPLY_PROP_ONLINE : + ret =mt6370_chg_set_online (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT : + ret =mt6370_chg_set_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE : + ret =mt6370_chg_set_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT : + ret =mt6370_chg_set_aicr (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT : + ret =mt6370_chg_set_mivr (priv, val); +break ;
drivers/power/supply/mt6370-charger.c line 766
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10
-0+case POWER_SUPPLY_PROP_PRECHARGE_CURRENT : + ret =mt6370_chg_set_iprechg (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT : + ret =mt6370_chg_set_ieoc (priv, val); +break ; +default : + ret = -EINVAL ; + } +return ret;
As per above.
...
drivers/power/supply/mt6370-charger.c line 864
Quoted 9 lines
drivers/power/supply/mt6370-charger.c new file +9
-0+for (i =0 ; i <F_MAX ; i++) { + priv->rmap_fields[i] =devm_regmap_field_alloc (priv->dev, + priv->regmap, + fds[i].field); +if (IS_ERR (priv->rmap_fields[i])) { +dev_err (priv->dev, +"Failed to allocate regmap field [%s]\n" , + fds[i].name); +return PTR_ERR (priv->rmap_fields[i]);
return dev_err_probe();
Quoted 2 lines
(quoted diff) +2
-0+ } + }
...
drivers/power/supply/mt6370-charger.c line 884
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+mutex_init (&priv->attach_lock); +atomic_set (&priv->attach,0 );
Why not atomic_init() ?
But yeah, usage of it and other locking mechanisms in this driver are questionable.
...
Quoted 1 line
+ /* ICHG/IEOC Workaroud, ICHG can not be set less than 900mA */
Workaround
...
Quoted 1 line
+ return
IS_ERR(priv->rdev)?PTR_ERR(priv->rdev): 0;
PTR_ERR_OR_ZERO()
...
Quoted 1 line
+ .of_node =
priv->dev->of_node,
dev_of_node() ?
drivers/power/supply/mt6370-charger.c line 942
Quoted 7 lines
drivers/power/supply/mt6370-charger.c new file +7
-0+ }; + + priv->psy_desc = &mt6370_chg_psy_desc; + priv->psy_desc->name =dev_name (priv->dev); + priv->psy =devm_power_supply_register (priv->dev, priv->psy_desc, &cfg); + +return IS_ERR (priv->psy) ?PTR_ERR (priv->psy) :0 ;
PTR_ERR_OR_ZERO()
Quoted 1 line
+}
...
drivers/power/supply/mt6370-charger.c line 955
Quoted 11 lines
drivers/power/supply/mt6370-charger.c new file +11
-0+static irqreturn_t mt6370_attach_i_handler (int irq,void *data) +{ +struct mt6370_priv *priv = data; +u32 otg_en; +int ret; + +/* Check in otg mode or not */ + ret =mt6370_chg_field_get (priv,F_BOOST_STAT , &otg_en); +if (ret <0 ) { +dev_err (priv->dev,"failed to get otg state\n" ); +return IRQ_HANDLED ;
Handled error?
drivers/power/supply/mt6370-charger.c line 963
Quoted 8 lines
drivers/power/supply/mt6370-charger.c new file +7
-0+ } + +if (otg_en) +return IRQ_HANDLED ; +mutex_lock (&priv->attach_lock); +atomic_set (&priv->attach,MT6370_ATTACH_STAT_ATTACH_BC12_DONE ); +mutex_unlock (&priv->attach_lock);
Mutex around atomic?! It's interesting...
Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+if (!queue_work (priv->wq, &priv->bc12_work)) +dev_err (priv->dev,"bc12 work has already queued\n" ); + +return IRQ_HANDLED ; +}
...
drivers/power/supply/mt6370-charger.c line 1014
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+for (i =0 ; i <ARRAY_SIZE (mt6370_chg_irqs); i++) { + ret =platform_get_irq_byname (to_platform_device (priv->dev), + mt6370_chg_irqs[i].name); +if (ret <0 ) { +dev_err (priv->dev,"Failed to get irq %s\n" , + mt6370_chg_irqs[i].name);
Isn't the same printed by the above call?
drivers/power/supply/mt6370-charger.c line 1027
Quoted 13 lines
drivers/power/supply/mt6370-charger.c new file +13
-0+return ret; + } + + ret =devm_request_threaded_irq (priv->dev, ret,NULL , + mt6370_chg_irqs[i].handler, +IRQF_TRIGGER_FALLING , +dev_name (priv->dev), + priv); + +if (ret <0 ) { +dev_err (priv->dev,"Failed to request irq %s\n" , + mt6370_chg_irqs[i].name); +return ret;
return dev_err_probe();
Quoted 2 lines
(quoted diff) +2
-0+ } + }
...
drivers/power/supply/mt6370-charger.c line 1035
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+static int mt6370_chg_probe (struct platform_device *pdev) +{
Use return dev_err_probe(...); pattern.
drivers/power/supply/mt6370-charger.c line 1095
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+probe_out: +destroy_workqueue (priv->wq); +mutex_destroy (&priv->attach_lock);
I don't see clearly the initialization of these in the ->probe(). Besides that, does destroy_workque() synchronize the actual queue(s)?
Mixing devm_ and non-devm_ may lead to a wrong release order that's why it is better to see allocating and destroying resources in one function (they may be wrapped, but should be both of them, seems like you have done it only for the first parts).
Quoted 2 lines
(quoted diff) +2
-0+ return ret; +}
...
drivers/power/supply/mt6370-charger.c line 1104
Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+static int mt6370_chg_remove (struct platform_device *pdev) +{ +struct mt6370_priv *priv =platform_get_drvdata (pdev); + +if (priv) {
Can you describe when this condition can be false?
Quoted 8 lines
drivers/power/supply/mt6370-charger.c new file +8
-0+mt6370_chg_enable_irq (priv,"mivr" , false); +cancel_delayed_work_sync (&priv->mivr_dwork); +destroy_workqueue (priv->wq); +mutex_destroy (&priv->attach_lock); + } + +return 0 ; +}
...
drivers/power/supply/mt6370-charger.c line 1125
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+static struct platform_driver mt6370_chg_driver = { + .probe = mt6370_chg_probe, + .remove = mt6370_chg_remove, + .driver = { + .name ="mt6370-charger" , + .of_match_table =of_match_ptr (mt6370_chg_of_match),
No good use of of_match_ptr(), please drop it.
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ }, +};
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
In reply to ChiaEn WuQuoted 7 lines · ChiaEn Wu
drivers/leds/Kconfig +0
-0@@ -244,6 +244,17 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC.
drivers/leds/Kconfig config LEDS_MT6323 · line 255
Quoted 10 lines
drivers/leds/Kconfig +9
-0+config LEDS_MT6370_RGB + tristate "LED Support for Mediatek MT6370 PMIC" + depends on LEDS_CLASS + depends on MFD_MT6370 + select LINEAR_RANGE + help + Say Y here to enable support for MT6370_RGB LED device. + In MT6370, there are four channel current-sink LED drivers that + support hardware pattern for const current, PWM, and breath mode.
Spell out "constant" (if that is what "const" means here). ?
Quoted 1 line
drivers/leds/Kconfig +1
-0+ Isink4 channel can also be used as a CHG_VIN power good indicator.
Signature · 1 line
~Randy
Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
In reply to ChiaEn WuHi ChiaEn!
Thanks for your patch!
Quoted 5 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 current sink type LED Indicator driver.
Signed-off-by ChiYuan Huang <[email protected]>
(...)
Quoted 3 lines
drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++
There is a drivers/leds/flash subdirectory these days, put the driver in that directory instead.
Yours,
Linus Walleij
Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
Quoted 8 lines · Linus Walleij
Thanks for your patch!
Quoted 4 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 current sink type LED Indicator driver.
Quoted 8 lines
Quoted 1 line
Signed-off-by ChiYuan Huang <[email protected]>(...)
Quoted 3 lines
drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++There is a
drivers/leds/flashsubdirectory these days, put the driver in that directory instead.
Sorry I'm commenting on the wrong patch.
I meant this one. Move that into drivers/leds/flash
drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++
Yours,
Linus Walleij
Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
Hi Linus,
Thank you for the comment.
Linus Walleij <[email protected]> 於 2022年6月24日 週五 下午2:25寫道:
Quoted 16 lines · Linus Walleij
Quoted 14 lines
Thanks for your patch!
Quoted 5 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 current sink type LED Indicator driver.
Signed-off-by ChiYuan Huang <[email protected]>(...)
Quoted 3 lines
drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++
Quoted 7 lines
Quoted 2 lines
There is a
drivers/leds/flashsubdirectory these days, put the driver in that directory instead.Sorry I'm commenting on the wrong patch.
I meant this one. Move that into
drivers/leds/flashdrivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++
In next version, I'll use "leds: flash: ......" instead of "leds:
flashlight: ......" in subject.
May I confirm that the driver has already in the drivers/leds/flash, so I don’t have to move it in next version?
Sincerely,
Alice Chen
Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight
In reply to Joe Simmons-TalbottHi Joe,
Joe Simmons-Talbott <[email protected]> 於 2022年6月23日 週四 晚上9:17寫道:
Quoted 82 lines · ChiaEn Wu
Quoted 67 lines
From: ChiYuan Huang <[email protected]>
Add mt6370 backlight binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values--- .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yamlDocumentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +44
-0@@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Backlight + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + The MT6370 Backlight WLED driver supports up to a 29V output voltage for + 4 channels of 8 series WLEDs. Each channel supports up to 30mA of current + capability with 2048 current steps (11 bits) in exponential or linear + mapping curves. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + const: mediatek,mt6370-backlight + + default-brightness: + minimum: 0 + maximum: 2048 + + max-brightness: + minimum: 0 + maximum: 2048 + + enable-gpios: + description: External backlight 'enable' pin + maxItems: 1 + + mediatek,bled-pwm-enable: + description: | + Enable external PWM input for backlight dimming + type: boolean + + mediatek,bled-pwm-hys-enable: + description: |Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml line 54
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +10
-0+ Enable the backlight input-hysteresis for PWM mode + type: boolean + + mediatek,bled-pwm-hys-input-th-steps: + $ref: /schemas/types.yaml#/definitions/uint8 + enum: [1, 4, 16, 64] + description: | + The selection of the upper and lower bounds threshold of backlight + PWM resolution. If we choose selection 64, the variation of PWM + resolution needs over than 64 steps.more than?
Quoted 3 lines
Thanks,
Joe
Thanks for your helpful comments!
I will revise this in the next patch. Thanks!
Quoted 33 lines
Quoted 33 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +33
-0+ + mediatek,bled-ovp-shutdown: + description: | + Enable the backlight shutdown when OVP level triggered + type: boolean + + mediatek,bled-ovp-microvolt: + enum: [17000000, 21000000, 25000000, 29000000] + description: | + Backlight OVP level selection. + + mediatek,bled-ocp-shutdown: + description: | + Enable the backlight shutdown when OCP level triggerred. + type: boolean + + mediatek,bled-ocp-microamp: + enum: [900000, 1200000, 1500000, 1800000] + description: | + Backlight OC level selection. + + mediatek,bled-channel-use: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + Backlight LED channel to be used. + Each bit mapping to: + - 0: CH4 + - 1: CH3 + - 2: CH2 + - 3: CH1 + minimum: 1 + maximum: 15 +
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +5
-1+required: + - compatible + - mediatek,bled-channel-use + +additionalProperties: false --2.7.4
Best regards,
ChiaEn Wu
Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support
In reply to Daniel ThompsonHi Daniel,
Thanks for your comments!
Daniel Thompson <[email protected]> 於 2022年6月23日 週四 晚上9:43寫道:
Quoted 42 lines · ChiaEn Wu
Quoted 28 lines
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 Backlight support.
Signed-off-by ChiaEn Wu <[email protected]>drivers/video/backlight/Kconfig +19
-0+static int mt6370_init_backlight_properties(struct mt6370_priv *priv, + struct backlight_properties *props) +{ + struct device *dev = priv->dev; + u8 prop_val; + u32 brightness, ovp_uV, ocp_uA; + unsigned int mask, val; + int ret; + + /* Vendor optional properties */ + val = 0; + if (device_property_read_bool(dev, "mediatek,bled-pwm-enable")) + val |= MT6370_BL_PWM_EN_MASK; + + if (device_property_read_bool(dev, "mediatek,bled-pwm-hys-enable")) + val |= MT6370_BL_PWM_HYS_EN_MASK; + + ret = device_property_read_u8(dev, + "mediatek,bled-pwm-hys-input-th-steps",drivers/video/backlight/Kconfig
Quoted 10 lines
drivers/video/backlight/Kconfig +10
-0+ &prop_val); + if (!ret) { + prop_val = clamp_val(prop_val, + MT6370_BL_PWM_HYS_TH_MIN_STEP, + MT6370_BL_PWM_HYS_TH_MAX_STEP); + /* + * prop_val = 1 --> 1 steps --> 0x00 + * prop_val = 2 ~ 4 --> 4 steps --> 0x01 + * prop_val = 5 ~ 16 --> 16 steps --> 0x10 + * prop_val = 17 ~ 64 --> 64 steps --> 0x11^^^^^
Quoted 2 lines
These numbers are binary, not hex, right? If so, the comments should be 0b00 to 0b03 .
Ohh! Yes! These numbers are binary!
I so apologize for making this mistake...
I will revise the comments in the next patch!
Thank you so much!
Quoted 26 lines
drivers/video/backlight/Kconfig
Quoted 11 lines
drivers/video/backlight/Kconfig +9
-0+ */ + prop_val = (ilog2(roundup_pow_of_two(prop_val)) + 1) >> 1; + val |= prop_val << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1); + } + + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, + val, val); + if (ret) + return ret;Overall, I like this approach! Easy to read and understand.
drivers/video/backlight/Kconfig
Quoted 7 lines
<snip>
drivers/video/backlight/Kconfig +6
-0+static int mt6370_bl_probe(struct platform_device *pdev) +{ + struct mt6370_priv *priv; + struct backlight_properties props = { + .type = BACKLIGHT_RAW, + .scale = BACKLIGHT_SCALE_LINEAR,Sorry, I missed this before but the KConfig comment says that the backlight can support both linear and exponential curves.
Quoted 1 line
Is there a good reason to default to linear?
Well...
The customers who used this PMIC have very few or even no use exponential curve, so I set the default to linear.
If you think this is inappropriate, I will add a DT property to control this feature in the next patch!
By the way,
I found some mistakes in my probe() function... I didn't use "return" when I use dev_err_probe()...
I will refine it in the next patch!
Quoted 4 lines
Daniel.
Quoted 1 line
Best regards,
ChiaEn Wu
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
In reply to Andy ShevchenkoHi Andy,
Thanks for your helpful comments! We have some questions below.
Andy Shevchenko <[email protected]> 於 2022年6月24日 週五 凌晨2:01寫道:
Quoted 22 lines · ChiaEn Wu
Quoted 4 lines
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
...
drivers/mfd/Kconfig config MFD_MT6360 · line 951
Quoted 12 lines
drivers/mfd/Kconfig +12
-0+config MFD_MT6370 + tristate "Mediatek MT6370 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6370 SubPMIC functional support. + It consists of a single cell battery charger with ADC monitoring, RGB + LEDs, dual channel flashlight, WLED backlight driver, display bias + voltage supply, one general purpose LDO, and the USB Type-C & PD + controller complies with the latest USB Type-C and PD standards.
Quoted 1 line
What will be the module name in case it's chosen to be built as a module?
OK, we will add related text in the next patch! Thanks!
Quoted 12 lines
...
Quoted 8 lines
obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.oobj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.oobj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
Quoted 4 lines
This whole bunch of drivers is in the wrong place in
Makefile.
hmm... So shall we need to cherry-pick your this patch first, then modify the Makefile before the next submission??
Quoted 6 lines
...
Quoted 1 line
+#define
MT6370_REG_MAXADDR0x1FFWondering if (BIT(10) - 1) gives a better hint on how hardware limits this (so it will be clear it's 10-bit address).
well... This "0x1FF" is just a virtual mapping value to map the max address of the PMU bank(0x1XX).
So, I feel its means is different from using (BIT(10) - 1) here.
Quoted 30 lines
...
Quoted 6 lines
drivers/mfd/mt6370.c new file +6
-0+static int mt6370_check_vendor_info (struct mt6370_info *info) +{ +unsigned int devinfo; +int ret; + + ret =regmap_read (info->regmap,MT6370_REG_DEV_INFO , &devinfo);drivers/mfd/mt6370.c line 240
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+if (ret) +return ret; + +switch (FIELD_GET (MT6370_VENID_MASK , devinfo)) { +case MT6370_VENID_RT5081 : +case MT6370_VENID_RT5081A : +case MT6370_VENID_MT6370 : +case MT6370_VENID_MT6371 : +case MT6370_VENID_MT6372P : +case MT6370_VENID_MT6372CP :return 0;
drivers/mfd/mt6370.c line 247
Quoted 7 lines
drivers/mfd/mt6370.c new file +7
-0+break ; +default : +dev_err (info->dev,"Unknown Vendor ID 0x%02x\n" , devinfo); +return -ENODEV ; + } + +return 0 ;
Quoted 1 line
...and drop these two lines?
OK! We will refine it in the next patch!
Quoted 8 lines
Quoted 2 lines
+}
...
drivers/mfd/mt6370.c line 258
Quoted 2 lines
drivers/mfd/mt6370.c new file +2
-0+ bank_idx = *(u8 *)reg_buf; + bank_addr = *(u8 *)(reg_buf +1 );
Quoted 8 lines
Why not
const u8 *u8_buf = reg_buf; bank_idx = u8_buf[0]; bank_addr = u8_buf[1];?
We will refine it in the next patch! Thanks!
Quoted 8 lines
...
drivers/mfd/mt6370.c line 264
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+if (ret <0 ) +return ret; +else if (ret != val_size)Redundant 'else'.
I'm not quite sure what you mean, so I made the following changes first.
------------------------------------
if (ret < 0)
return ret;
if (ret != val_size)
return -EIO;------------------------------------
I don't know if it meets your expectations??
Quoted 5 lines
Quoted 2 lines
+ return
-EIO;...
Quoted 8 lines
drivers/mfd/mt6370.c line 277
Quoted 2 lines
drivers/mfd/mt6370.c new file +2
-0+ bank_idx = *(u8 *)data; + bank_addr = *(u8 *)(data +1 );As per above.
--
With Best Regards,
Andy Shevchenko
Best regards,
ChiaEn Wu
Re: [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger
In reply to ChiaEn WuQuoted 70 lines · ChiaEn Wu
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 Charger binding documentation.
Signed-off-by ChiaEn Wu <[email protected]>---
v3
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"--- .../power/supply/mediatek,mt6370-charger.yaml | 87 ++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yamlDocumentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +47
-0@@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Battery Charger + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Provides Battery Charger, Boost for OTG devices and BC1.2 detection. + +properties: + compatible: + const: mediatek,mt6370-charger + + interrupts: + description: | + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D" + are required. + items: + - description: BC1.2 done irq + - description: usb plug in irq + - description: mivr irq + + interrupt-names: + items: + - const: attach_i + - const: uvp_d_evt + - const: mivr + + io-channels: + description: | + Use ADC channel to read VBUS, IBUS, IBAT, etc., info. + minItems: 1 + items: + - description: | + VBUS voltage with lower accuracy (+-75mV) but higher measure + range (1~22V) + - description: | + VBUS voltage with higher accuracy (+-30mV) but lower measure + range (1~9.76V) + - description: the main system input voltage
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml line 57
Quoted 10 lines
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +10
-0+ - description: battery voltage + - description: battery temperature-sense input voltage + - description: IBUS current (required) + - description: battery current + - description: | + regulated output voltage to supply for the PWM low-side gate driver + and the bootstrap capacitor + - description: IC junction temperature + + io-channel-names:
It does not match io-channels, you need minItems here as well.
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml line 68
Quoted 11 lines
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +11
-0+ items: + - const: vbusdiv5 + - const: vbusdiv2 + - const: vsys + - const: vbat + - const: ts_bat + - const: ibus + - const: ibat + - const: chg_vddp + - const: temp_jc +
Best regards,
Krzysztof
Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
In reply to Andy ShevchenkoHi Andy,
Thanks for your helpful comments!
Andy Shevchenko <[email protected]> 於 2022年6月24日 週五 凌晨2:19寫道:
Quoted 38 lines · ChiaEn Wu
Quoted 4 lines
From: ChiYuan Huang <[email protected]>
Add mt6370 DisplayBias and VibLDO support.
...
drivers/regulator/mt6370-regulator.c line 8
Quoted 7 lines
drivers/regulator/mt6370-regulator.c new file +6
-0+#include <linux/bits.h> +#include <linux/gpio/consumer.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> Any users of this? (See below)
Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/regulator/driver.h> +#include <linux/regulator/machine.h> ...
drivers/regulator/mt6370-regulator.c line 59
Quoted 9 lines
drivers/regulator/mt6370-regulator.c new file +9
-0+#define MT6370_LDO_MINUV 1600000 +#define MT6370_LDO_STPUV 200000 +#define MT6370_LDO_N_VOLT 13 +#define MT6370_DBVBOOST_MINUV 4000000 +#define MT6370_DBVBOOST_STPUV 50000 +#define MT6370_DBVBOOST_N_VOLT 45 +#define MT6370_DBVOUT_MINUV 4000000 +#define MT6370_DBVOUT_STPUV 50000 +#define MT6370_DBVOUT_N_VOLT 41If UV is a unit suffix, make it
_UV.
Quoted 5 lines
...
Quoted 1 line
+ .of_match =
of_match_ptr("dsvbst"),Would it even be called / used if
CONFIG_OF=n?
We got a notification from Mark telling us that this patch has been
applied to git.
( https://lore.kernel.org/linux-arm-kernel/[email protected]/
)
So, should we need to make any other changes in the next submission?
Quoted 54 lines
...
Quoted 1 line
+ .regulators_node =
of_match_ptr("regulators"),Ditto.
...
drivers/regulator/mt6370-regulator.c line 314
Quoted 13 lines
drivers/regulator/mt6370-regulator.c new file +12
-0+for (i =0 ; i <ARRAY_SIZE (mt6370_irqs); i++) { + irq =platform_get_irq_byname (pdev, mt6370_irqs[i].name); + + rdev = priv->rdev[mt6370_irqs[i].rid]; + + ret =devm_request_threaded_irq (priv->dev, irq,NULL , + mt6370_irqs[i].handler,0 , + mt6370_irqs[i].name, rdev); +if (ret) { +dev_err (priv->dev, +"Failed to register (%d) interrupt\n" , i); +return ret;return
dev_err_probe(...); ?Quoted 2 lines
(quoted diff) +2
-0+ } + }...
drivers/regulator/mt6370-regulator.c line 338
Quoted 9 lines
drivers/regulator/mt6370-regulator.c new file +8
-0+for (i =0 ; i <MT6370_MAX_IDX ; i++) { + rdev =devm_regulator_register (priv->dev, + mt6370_regulator_descs + i, + &cfg); +if (IS_ERR (rdev)) { +dev_err (priv->dev, +"Failed to register (%d) regulator\n" , i); +return PTR_ERR (rdev);return
dev_err_probe(...); ?Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+ } + + priv->rdev[i] = rdev; + }...
drivers/regulator/mt6370-regulator.c line 362
Quoted 4 lines
drivers/regulator/mt6370-regulator.c new file +4
-0+if (!priv->regmap) { +dev_err (&pdev->dev,"Failed to init regmap\n" ); +return -ENODEV ; + }
Quoted 5 lines
return
dev_err_probe(...);--
With Best Regards,
Andy Shevchenko
Best regards,
ChiaEn Wu
Re: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator
In reply to ChiaEn WuQuoted 43 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek mt6370 current sink type LED indicator binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Useleds-class-multicolor.yamlinstead ofcommon.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".--- .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yamlDocumentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +21
-0@@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6370 PMIC from MediaTek Integrated. + +maintainers: + - Alice Chen <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode + +allOf: + - $ref: leds-class-multicolor.yaml# + +properties: + compatible: + const: mediatek,mt6370-indicator
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml line 31
Quoted 10 lines
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +10
-0+ + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: object
Here as well unevaluatedProperties:false (on the type level)
Quoted 36 lines
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +36
-0+ + properties: + reg: + enum: [0, 1, 2, 3] + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "^led@[0-2]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + required: + - reg + - color + + required: + - reg + - color + - "#address-cells" + - "#size-cells" + + "^led@[0-3]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + enum: [0, 1, 2, 3] +
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml line 77
Quoted 10 lines
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +10
-0+ required: + - reg + - color + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false
Best regards,
Krzysztof
Krzysztof Kozlowski
Reviewed-byRe: [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator
Quoted 48 lines · Krzysztof Kozlowski
Quoted 47 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek mt6370 current sink type LED indicator binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Useleds-class-multicolor.yamlinstead ofcommon.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".--- .../bindings/leds/mediatek,mt6370-indicator.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yamlDocumentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +25
-0@@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6370 PMIC from MediaTek Integrated. + +maintainers: + - Alice Chen <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode + +allOf: + - $ref: leds-class-multicolor.yaml# + +properties: + compatible: + const: mediatek,mt6370-indicator + + "#address-cells": + const: 1 +
Quoted 8 lines
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml line 31
Quoted 6 lines
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +6
-0+ "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-3]$": + type: objectHere as well unevaluatedProperties:false (on the type level)
Ah, no, it does not work currently. Your code looks good.
Best regards,
Krzysztof
Re: [PATCH v3 04/14] dt-bindings: leds: Add Mediatek MT6370 flashlight
In reply to ChiaEn WuQuoted 6 lines · ChiaEn Wu
From: Alice Chen <[email protected]>
Add Mediatek MT6370 flashlight binding documentation.
Signed-off-by Alice Chen <[email protected]>---
Best regards,
Krzysztof
Re: [PATCH v3 06/14] dt-bindings: mfd: Add Mediatek MT6370
In reply to ChiaEn WuQuoted 71 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Use " in entire patchset
- Refine ADC description
- Rename "enable-gpio" to "enable-gpios" in "regualtor"
- Change "/schemas/" to "../" in every reference of all MT6370 modules--- .../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 +++++++++++++++++++++ include/dt-bindings/iio/adc/mediatek,mt6370_adc.h | 18 ++ 2 files changed, 298 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.hDocumentation/devicetree/bindings/mfd/mediatek,mt6370.yaml new file +46
-0@@ -0,0 +1,280 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 SubPMIC + +maintainers: + - ChiYuan Huang <[email protected]> + +description: | + MT6370 is a highly-integrated smart power management IC, which includes a + single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & + Power Delivery (PD) controller, dual flash LED current sources, a RGB LED + driver, a backlight WLED driver, a display bias driver and a general LDO for + portable devices. + +properties: + compatible: + const: mediatek,mt6370 + + reg: + maxItems: 1 + + wakeup-source: true + + interrupts: + maxItems: 1 + + interrupt-controller: true + + "#interrupt-cells": + const: 1 + + adc: + type: object + description: | + Provides 9 channels for system monitoring, including VBUSDIV5 (lower + accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower + measure range), VBAT, VSYS, CHG_VDDP, TS_BAT, IBUS, IBAT, and TEMP_JC. + + properties: + compatible: + const: mediatek,mt6370-adc +
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml line 56
Quoted 10 lines
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml new file +10
-0+ "#io-channel-cells": + const: 1 + + required: + - compatible + - "#io-channel-cells" + + backlight: + type: object + $ref: ../leds/backlight/mediatek,mt6370-backlight.yaml#
This was correct before: /schemas/leds/ ....
Same in other places.
Best regards,
Krzysztof
Greg KH
maintainerRe: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
In reply to ChiaEn Wudrivers/usb/typec/tcpm/tcpci_mt6370.c line 1
Quoted 4 lines · ChiaEn Wu
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +1
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0+
Are you sure you mean "+" here?
I have to ask, sorry.
And no copyright line? Your company is ok with that, nice! :)
thanks,
greg k-h
Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support
In reply to szuni chenQuoted 7 lines · szuni chen
Quoted 2 lines
I meant this one. Move that into
drivers/leds/flashdrivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++In next version, I'll use "leds: flash: ......" instead of "leds:
flashlight: ......" in subject.
May I confirm that the driver has already in thedrivers/leds/flash, so I don’t have to move it in next version?
Yeah you're right, I am just writing wrong comments today, it is already correct. Sorry!
Yours,
Linus Walleij
Re: [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger
In reply to ChiaEn WuHi ChiaEn,
Quoted 1 line
Add Mediatek MT6370 Charger binding documentation.
s/Mediatek/MediaTek/
Would you mind fix that for the series?
cheers,
Miles
Quoted 111 lines
Signed-off-by ChiaEn Wu <[email protected]>---
v3
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"--- .../power/supply/mediatek,mt6370-charger.yaml | 87 ++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yamlDocumentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +87
-0@@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6370 Battery Charger + +maintainers: + - ChiaEn Wu <[email protected]> + +description: | + This module is part of the MT6370 MFD device. + Provides Battery Charger, Boost for OTG devices and BC1.2 detection. + +properties: + compatible: + const: mediatek,mt6370-charger + + interrupts: + description: | + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D" + are required. + items: + - description: BC1.2 done irq + - description: usb plug in irq + - description: mivr irq + + interrupt-names: + items: + - const: attach_i + - const: uvp_d_evt + - const: mivr + + io-channels: + description: | + Use ADC channel to read VBUS, IBUS, IBAT, etc., info. + minItems: 1 + items: + - description: | + VBUS voltage with lower accuracy (+-75mV) but higher measure + range (1~22V) + - description: | + VBUS voltage with higher accuracy (+-30mV) but lower measure + range (1~9.76V) + - description: the main system input voltage + - description: battery voltage + - description: battery temperature-sense input voltage + - description: IBUS current (required) + - description: battery current + - description: | + regulated output voltage to supply for the PWM low-side gate driver + and the bootstrap capacitor + - description: IC junction temperature + + io-channel-names: + items: + - const: vbusdiv5 + - const: vbusdiv2 + - const: vsys + - const: vbat + - const: ts_bat + - const: ibus + - const: ibat + - const: chg_vddp + - const: temp_jc + + usb-otg-vbus-regulator: + type: object + description: OTG boost regulator. + unevaluatedProperties: false + $ref: /schemas/regulator/regulator.yaml# + + properties: + enable-gpios: + maxItems: 1 + +required: + - compatible + - interrupts + - interrupt-names + - io-channels + +additionalProperties: false + +...Signature · 1 line
2.7.4
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuQuoted 2 lines · ChiaEn Wu
Andy Shevchenko <[email protected]> 於 2022年6月24日 週五 凌晨2:01寫道:
Quoted 1 line · ChiaEn Wu
...
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o
obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.oobj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.oobj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
Quoted 6 lines
Quoted 3 lines
This whole bunch of drivers is in the wrong place in
Makefile.hmm... So shall we need to cherry-pick your this patch first, then modify the
Makefilebefore the next submission??
I don't know what Lee's preferences are, but at least I have these options in mind:
1) wait until Lee applies my series;
2) take that single patch to your tree as a precursor.
In the second case you will need to send the series with that patch as well.
...
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
+#define
MT6370_REG_MAXADDR0x1FFWondering if (BIT(10) - 1) gives a better hint on how hardware limits this (so it will be clear it's 10-bit address).
well... This "
0x1FF" is just a virtual mapping value to map the max address of the PMU bank(0x1XX).
So, I feel its means is different from using (BIT(10) - 1) here.
Perhaps a comment then?
...
Quoted 6 lines
Quoted 5 lines
drivers/mfd/mt6370.c line 264
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+if (ret <0 ) +return ret; +else if (ret != val_size)Redundant 'else'.
Quoted 8 lines
I'm not quite sure what you mean, so I made the following changes first.
------------------------------------if (ret < 0) return ret; if (ret != val_size) return -EIO;------------------------------------
I don't know if it meets your expectations??
Yes.
Quoted 1 line
Quoted 1 line
Quoted 1 line
+ return
-EIO;
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support
In reply to ChiaEn WuQuoted 2 lines · ChiaEn Wu
Andy Shevchenko <[email protected]> 於 2022年6月24日 週五 凌晨2:19寫道:
Quoted 1 line · ChiaEn Wu
...
Quoted 5 lines
We got a notification from Mark telling us that this patch has been
applied to git.
( https://lore.kernel.org/linux-arm-kernel/[email protected]/
)
So, should we need to make any other changes in the next submission?
You may do the followup(s) to address all or some of the comments depending on the case (e.g. good to clean up code with dev_err_probe() use).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver
In reply to Andy ShevchenkoHi Andy,
Sorry for the late reply, I have some questions to ask you below. Thanks!
Andy Shevchenko <[email protected]> 於 2022年6月24日 週五 凌晨2:56寫道:
Quoted 63 lines · ChiaEn Wu
Quoted 4 lines
From: ChiaEn Wu <[email protected]>
Add Mediatek MT6370 charger driver.
...
drivers/power/supply/Kconfig config CHARGER_MT6360 · line 631
Quoted 10 lines
drivers/power/supply/Kconfig +10
-0+config CHARGER_MT6370 + tristate "Mediatek MT6370 Charger Driver" + depends on MFD_MT6370 + depends on REGULATOR + select LINEAR_RANGES + help + Say Y here to enable MT6370 Charger Part. + The device supports High-Accuracy Voltage/Current Regulation, + Average Input Current Regulation, Battery Temperature Sensing, + Over-Temperature Protection, DPDM Detection for BC1.2.Module name?
...
Quoted 1 line
+#include <
dt-bindings/iio/adc/mediatek,mt6370_adc.h>This usually goes after linux/*
Quoted 18 lines
drivers/power/supply/mt6370-charger.c new file +15
-0+#include <linux/atomic.h> +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/gpio/consumer.h> +#include <linux/iio/consumer.h> +#include <linux/init.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/power_supply.h> +#include <linux/regmap.h> +#include <linux/regulator/driver.h> +#include <linux/workqueue.h> ...
Quoted 1 line
+#define
MT6370_MIVR_IBUS_TH100000 /* 100 mA */Instead of comment, add proper units.
...
drivers/power/supply/mt6370-charger.c line 100
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+MT6370_USB_STAT_DCP , +MT6370_USB_STAT_CDP , + MT6370_USB_STAT_MAX,No comma for a terminator line.
...
Quoted 8 lines
drivers/power/supply/mt6370-charger.c line 220
Quoted 4 lines
drivers/power/supply/mt6370-charger.c new file +4
-0+static inline u32 mt6370_chg_val_to_reg(const struct mt6370_chg_range *range, + u32 val) +static inline u32 mt6370_chg_reg_to_val(const struct mt6370_chg_range *range, + u8 reg)I'm wondering if you can use the
https://elixir.bootlin.com/linux/v5.19-rc3/source/include/linux/linear_range.h
APIs.
Thanks for your helpful comments!
I will refine it in the next patch!
Quoted 18 lines
...
Quoted 1 line
+ int ret = 0;
This seems a redundant assignment, see below.
drivers/power/supply/mt6370-charger.c line 276
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ rcfg->ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(of), + "enable", 0,For index == 0 don't use
_indexAPI.drivers/power/supply/mt6370-charger.c line 281
Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+GPIOD_OUT_LOW | +GPIOD_FLAGS_BIT_NONEXCLUSIVE , + rdesc->name); +if (IS_ERR (rcfg->ena_gpiod)) { +dev_err (priv->dev,"Failed to requeset OTG EN Pin\n" );
Quoted 5 lines
request
Quoted 1 line
+
rcfg->ena_gpiod= NULL;So, use
_optionaland return any errors you got.
These days, I tried to use various APIs in <gpio/consumer.h>, and also try to use _optional APIs.
But my OTG regulator node is a child node of the charger node, like below.
----------------------------------------------------------------------------
// copy-paste from our mfd dt-binding example
charger {
compatible = "mediatek,mt6370-charger";
interrupts = <48>, <68>, <6>;
interrupt-names = "attach_i", "uvp_d_evt", "mivr";
io-channels = <&mt6370_adc MT6370_CHAN_IBUS>;
mt6370_otg_vbus: usb-otg-vbus-regulator {
regulator-name = "mt6370-usb-otg-vbus";
regulator-min-microvolt = <4350000>;
regulator-max-microvolt = <5800000>;
regulator-min-microamp = <500000>;
regulator-max-microamp = <3000000>;
};
};----------------------------------------------------------------------------
Hence, if I use _optional APIs, it will always get NULL. And, If I use 'gpiod_get_from_of_node' here, this API will only parse the 'enable' property, not 'enable-gpio' or 'enable-gpios', we need to add the '-gpio' suffix before we use this API.
Only 'fwnode_gpiod_get_index' can match this case. Although fwnode parsing is not preferred, 'of_parse_cb' already can guarantee the callback will only be used by the regulator of_node parsing.
Quoted 39 lines
Quoted 8 lines
drivers/power/supply/mt6370-charger.c new file +7
-0+ }else { + val =MT6370_OPA_MODE_MASK |MT6370_OTG_PIN_EN_MASK ; + ret =regmap_update_bits (priv->regmap,MT6370_REG_CHG_CTRL1 , + val, val); +if (ret) +dev_err (priv->dev,"Failed to set otg bits\n" ); + }...
drivers/power/supply/mt6370-charger.c line 367
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ irq_num =platform_get_irq_byname (pdev, irq_name); +Unwanted blank line.
drivers/power/supply/mt6370-charger.c line 369
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+if (irq_num <0 ) { +dev_err (priv->dev,"Failed to get platform resource\n" );Isn't it printed by the call?
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+ }else { +if (en) +enable_irq (irq_num); +else +disable_irq_nosync (irq_num); + }...
Quoted 1 line
+toggle_cfo_exit:
The useless label.
Review
Quoted 2 lines
(quoted diff) +2
-0+ return ret; +}
Quoted 6 lines
...
drivers/power/supply/mt6370-charger.c line 509
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ ret =mt6370_chg_get_online (priv, val); +if (!val->intval) {No error check?
I replace "mt6370_chg_get_online()" with "power_supply_get_property()" and add some error check.
Could it meet your expectations??
Quoted 141 lines
Quoted 4 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+ val->intval =POWER_SUPPLY_STATUS_DISCHARGING ; +return 0 ; + }...
Quoted 13 lines
drivers/power/supply/mt6370-charger.c new file +13
-0+static int mt6370_chg_set_online (struct mt6370_priv *priv, +const union power_supply_propval *val) +{ +int attach; +u32 pwr_rdy = !!val->intval; + +mutex_lock (&priv->attach_lock); + attach =atomic_read (&priv->attach); +if (pwr_rdy == !!attach) { +dev_err (priv->dev,"pwr_rdy is same(%d)\n" , pwr_rdy); +mutex_unlock (&priv->attach_lock); +return 0 ; + }drivers/power/supply/mt6370-charger.c line 640
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +9
-0+ +atomic_set (&priv->attach, pwr_rdy); +mutex_unlock (&priv->attach_lock); + +if (!queue_work (priv->wq, &priv->bc12_work)) +dev_err (priv->dev,"bc12 work has already queued\n" ); + +return 0 ; +Unwanted blank line.
Quoted 45 lines
drivers/power/supply/mt6370-charger.c new file +44
-0+} +static int mt6370_chg_get_property (struct power_supply *psy, +enum power_supply_property psp, +union power_supply_propval *val) +{ +struct mt6370_priv *priv =power_supply_get_drvdata (psy); +int ret =0 ; + +switch (psp) { +case POWER_SUPPLY_PROP_ONLINE : + ret =mt6370_chg_get_online (priv, val); +break ; +case POWER_SUPPLY_PROP_STATUS : + ret =mt6370_chg_get_status (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TYPE : + ret =mt6370_chg_get_charge_type (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT : + ret =mt6370_chg_get_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX : + ret =mt6370_chg_get_max_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE : + ret =mt6370_chg_get_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX : + ret =mt6370_chg_get_max_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT : + ret =mt6370_chg_get_aicr (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT : + ret =mt6370_chg_get_mivr (priv, val); +break ; +case POWER_SUPPLY_PROP_PRECHARGE_CURRENT : + ret =mt6370_chg_get_iprechg (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT : + ret =mt6370_chg_get_ieoc (priv, val); +break ; +case POWER_SUPPLY_PROP_TYPE : + val->intval = priv->psy_desc->type;drivers/power/supply/mt6370-charger.c line 731
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10
-0+break ; +case POWER_SUPPLY_PROP_USB_TYPE : + val->intval = priv->psy_usb_type; +break ; +default : + ret = -EINVAL ; +break ; + } + +return ret;In all cases, return directly.
Quoted 1 line
+}
...
Quoted 16 lines
drivers/power/supply/mt6370-charger.c new file +16
-0+switch (psp) { +case POWER_SUPPLY_PROP_ONLINE : + ret =mt6370_chg_set_online (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT : + ret =mt6370_chg_set_ichg (priv, val); +break ; +case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE : + ret =mt6370_chg_set_cv (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT : + ret =mt6370_chg_set_aicr (priv, val); +break ; +case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT : + ret =mt6370_chg_set_mivr (priv, val); +break ;drivers/power/supply/mt6370-charger.c line 766
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10
-0+case POWER_SUPPLY_PROP_PRECHARGE_CURRENT : + ret =mt6370_chg_set_iprechg (priv, val); +break ; +case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT : + ret =mt6370_chg_set_ieoc (priv, val); +break ; +default : + ret = -EINVAL ; + } +return ret;As per above.
...
drivers/power/supply/mt6370-charger.c line 864
Quoted 9 lines
drivers/power/supply/mt6370-charger.c new file +9
-0+for (i =0 ; i <F_MAX ; i++) { + priv->rmap_fields[i] =devm_regmap_field_alloc (priv->dev, + priv->regmap, + fds[i].field); +if (IS_ERR (priv->rmap_fields[i])) { +dev_err (priv->dev, +"Failed to allocate regmap field [%s]\n" , + fds[i].name); +return PTR_ERR (priv->rmap_fields[i]);return
dev_err_probe();Review
Quoted 2 lines
(quoted diff) +2
-0+ } + }
Quoted 8 lines
...
drivers/power/supply/mt6370-charger.c line 884
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+mutex_init (&priv->attach_lock); +atomic_set (&priv->attach,0 );Why not
atomic_init()?
But yeah, usage of it and other locking mechanisms in this driver are questionable.
I will refine it in the next patch!
Quoted 52 lines
...
Quoted 1 line
+ /* ICHG/IEOC Workaroud, ICHG can not be set less than 900mA */
Workaround
...
Quoted 1 line
+ return
IS_ERR(priv->rdev)?PTR_ERR(priv->rdev): 0;
PTR_ERR_OR_ZERO()...
Quoted 1 line
+ .of_node =
priv->dev->of_node,
dev_of_node()?drivers/power/supply/mt6370-charger.c line 942
Quoted 7 lines
drivers/power/supply/mt6370-charger.c new file +7
-0+ }; + + priv->psy_desc = &mt6370_chg_psy_desc; + priv->psy_desc->name =dev_name (priv->dev); + priv->psy =devm_power_supply_register (priv->dev, priv->psy_desc, &cfg); + +return IS_ERR (priv->psy) ?PTR_ERR (priv->psy) :0 ;
PTR_ERR_OR_ZERO()Quoted 1 line
+}
...
drivers/power/supply/mt6370-charger.c line 955
Quoted 11 lines
drivers/power/supply/mt6370-charger.c new file +11
-0+static irqreturn_t mt6370_attach_i_handler (int irq,void *data) +{ +struct mt6370_priv *priv = data; +u32 otg_en; +int ret; + +/* Check in otg mode or not */ + ret =mt6370_chg_field_get (priv,F_BOOST_STAT , &otg_en); +if (ret <0 ) { +dev_err (priv->dev,"failed to get otg state\n" ); +return IRQ_HANDLED ;Handled error?
Quoted 4 lines
drivers/power/supply/mt6370-charger.c new file +4
-0+ } + +if (otg_en) +return IRQ_HANDLED ;
Quoted 5 lines
drivers/power/supply/mt6370-charger.c line 963
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+mutex_lock (&priv->attach_lock); +atomic_set (&priv->attach,MT6370_ATTACH_STAT_ATTACH_BC12_DONE ); +mutex_unlock (&priv->attach_lock);Mutex around atomic?! It's interesting...
I will revise it in the next patch.
Quoted 9 lines
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+if (!queue_work (priv->wq, &priv->bc12_work)) +dev_err (priv->dev,"bc12 work has already queued\n" ); + +return IRQ_HANDLED ; +}...
Quoted 8 lines
drivers/power/supply/mt6370-charger.c line 1014
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+for (i =0 ; i <ARRAY_SIZE (mt6370_chg_irqs); i++) { + ret =platform_get_irq_byname (to_platform_device (priv->dev), + mt6370_chg_irqs[i].name); +if (ret <0 ) { +dev_err (priv->dev,"Failed to get irq %s\n" , + mt6370_chg_irqs[i].name);Isn't the same printed by the above call?
well... yes they are similar, I will remove one of them in the next patch.
Quoted 32 lines
Quoted 4 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+return ret; + } +drivers/power/supply/mt6370-charger.c line 1027
Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10
-0+ ret =devm_request_threaded_irq (priv->dev, ret,NULL , + mt6370_chg_irqs[i].handler, +IRQF_TRIGGER_FALLING , +dev_name (priv->dev), + priv); + +if (ret <0 ) { +dev_err (priv->dev,"Failed to request irq %s\n" , + mt6370_chg_irqs[i].name); +return ret;return
dev_err_probe();Quoted 2 lines
(quoted diff) +2
-0+ } + }...
drivers/power/supply/mt6370-charger.c line 1035
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+static int mt6370_chg_probe (struct platform_device *pdev) +{Use return
dev_err_probe(...); pattern.drivers/power/supply/mt6370-charger.c line 1095
Quoted 3 lines
drivers/power/supply/mt6370-charger.c new file +3
-0+probe_out: +destroy_workqueue (priv->wq); +mutex_destroy (&priv->attach_lock);
Quoted 7 lines
I don't see clearly the initialization of these in the ->probe(). Besides that, does
destroy_workque()synchronize the actual queue(s)?Mixing
devm_and non-devm_ may lead to a wrong release order that's why it is better to see allocating and destroying resources in one function (they may be wrapped, but should be both of them, seems like you have done it only for the first parts).
OK, I will try to revise these in the next patch!
Quoted 6 lines
Quoted 3 lines
(quoted diff) +2
-0+ return ret; +}...
Quoted 7 lines
drivers/power/supply/mt6370-charger.c line 1104
Quoted 5 lines
drivers/power/supply/mt6370-charger.c new file +5
-0+static int mt6370_chg_remove (struct platform_device *pdev) +{ +struct mt6370_priv *priv =platform_get_drvdata (pdev); + +if (priv) {Can you describe when this condition can be false?
well... I will remove it in the next patch, sorry for making this stupid mistake...
Quoted 19 lines
Quoted 9 lines
drivers/power/supply/mt6370-charger.c new file +8
-0+mt6370_chg_enable_irq (priv,"mivr" , false); +cancel_delayed_work_sync (&priv->mivr_dwork); +destroy_workqueue (priv->wq); +mutex_destroy (&priv->attach_lock); + } + +return 0 ; +}...
drivers/power/supply/mt6370-charger.c line 1125
Quoted 6 lines
drivers/power/supply/mt6370-charger.c new file +6
-0+static struct platform_driver mt6370_chg_driver = { + .probe = mt6370_chg_probe, + .remove = mt6370_chg_remove, + .driver = { + .name ="mt6370-charger" , + .of_match_table =of_match_ptr (mt6370_chg_of_match),
Quoted 8 lines
No good use of
of_match_ptr(), please drop it.drivers/power/supply/mt6370-charger.c line 1127
Quoted 2 lines
drivers/power/supply/mt6370-charger.c new file +2
-0+ }, +};--
With Best Regards,
Andy Shevchenko
Thanks for your review!
Best regards,
ChiaEn Wu
Re: [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight
In reply to ChiaEn WuQuoted 12 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add mt6370 backlight binding documentation.
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values
Quoted 5 lines
--- .../leds/backlight/mediatek,mt6370-backlight.yaml | 92 ++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
In reply to ChiaEn WuQuoted 3 lines · ChiaEn Wu
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
No such thing as "MFD support".
And you're not getting away with submitting a 370 line patch with a 5 word change log either. :)
Please at least tell us what the device is and what it's used for.
Quoted 63 lines
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- RefineKconfighelp text
- Refine error message of unknown vendor ID inmt6370_check_vendor_info()
- Refine return value handling ofmt6370_regmap_read()
- Refine all probe error by usingdev_err_probe()
- Refine "bank_idx" and "bank_addr" inmt6370_regmap_read()andmt6370_regmap_write()
- Add "#define VENID*" and drop the comments inmt6370_check_vendor_info()
- Drop "MFD" inMODULE_DESCRIPTION()--- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/mfd/mt6370.cdrivers/mfd/Kconfig +13
-0@@ -937,6 +937,19 @@ config MFD_MT6360 PMIC part includes 2-channel BUCKs and 2-channel LDOs LDO part includes 4-channel LDOs +config MFD_MT6370 + tristate "Mediatek MT6370 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6370 SubPMIC functional support. + It consists of a single cell battery charger with ADC monitoring, RGB + LEDs, dual channel flashlight, WLED backlight driver, display bias + voltage supply, one general purpose LDO, and the USB Type-C & PD + controller complies with the latest USB Type-C and PD standards. + config MFD_MT6397 tristate "MediaTek MT6397 PMIC Support" select MFD_COREdrivers/mfd/Makefile +1
-0@@ -242,6 +242,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o obj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.o obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.odrivers/mfd/mt6370.c new file +0
-0
drivers/mfd/mt6370.c line 1
Quoted 1 line
drivers/mfd/mt6370.c new file +1
-0@@ -0,0 +1,358 @@ +// SPDX-License-Identifier: GPL-2.0
No Copyright?
Quoted 98 lines
drivers/mfd/mt6370.c new file +98
-0+#include <linux/bits.h> +#include <linux/i2c.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/mfd/core.h> +#include <linux/module.h> +#include <linux/regmap.h> + +enum { +MT6370_USBC_I2C =0 , +MT6370_PMU_I2C , +MT6370_MAX_I2C +}; + +#define MT6370_REG_DEV_INFO 0x100 +#define MT6370_REG_CHG_IRQ1 0x1C0 +#define MT6370_REG_CHG_MASK1 0x1E0 + +#define MT6370_VENID_MASK GENMASK(7, 4) + +#define MT6370_NUM_IRQREGS 16 +#define MT6370_USBC_I2CADDR 0x4E +#define MT6370_REG_ADDRLEN 2 +#define MT6370_REG_MAXADDR 0x1FF + +#define MT6370_VENID_RT5081 0x8 +#define MT6370_VENID_RT5081A 0xA +#define MT6370_VENID_MT6370 0xE +#define MT6370_VENID_MT6371 0xF +#define MT6370_VENID_MT6372P 0x9 +#define MT6370_VENID_MT6372CP 0xB + +/* IRQ definitions */ +#define MT6370_IRQ_DIRCHGON 0 +#define MT6370_IRQ_CHG_TREG 4 +#define MT6370_IRQ_CHG_AICR 5 +#define MT6370_IRQ_CHG_MIVR 6 +#define MT6370_IRQ_PWR_RDY 7 +#define MT6370_IRQ_FL_CHG_VINOVP 11 +#define MT6370_IRQ_CHG_VSYSUV 12 +#define MT6370_IRQ_CHG_VSYSOV 13 +#define MT6370_IRQ_CHG_VBATOV 14 +#define MT6370_IRQ_CHG_VINOVPCHG 15 +#define MT6370_IRQ_TS_BAT_COLD 20 +#define MT6370_IRQ_TS_BAT_COOL 21 +#define MT6370_IRQ_TS_BAT_WARM 22 +#define MT6370_IRQ_TS_BAT_HOT 23 +#define MT6370_IRQ_TS_STATC 24 +#define MT6370_IRQ_CHG_FAULT 25 +#define MT6370_IRQ_CHG_STATC 26 +#define MT6370_IRQ_CHG_TMR 27 +#define MT6370_IRQ_CHG_BATABS 28 +#define MT6370_IRQ_CHG_ADPBAD 29 +#define MT6370_IRQ_CHG_RVP 30 +#define MT6370_IRQ_TSHUTDOWN 31 +#define MT6370_IRQ_CHG_IINMEAS 32 +#define MT6370_IRQ_CHG_ICCMEAS 33 +#define MT6370_IRQ_CHGDET_DONE 34 +#define MT6370_IRQ_WDTMR 35 +#define MT6370_IRQ_SSFINISH 36 +#define MT6370_IRQ_CHG_RECHG 37 +#define MT6370_IRQ_CHG_TERM 38 +#define MT6370_IRQ_CHG_IEOC 39 +#define MT6370_IRQ_ADC_DONE 40 +#define MT6370_IRQ_PUMPX_DONE 41 +#define MT6370_IRQ_BST_BATUV 45 +#define MT6370_IRQ_BST_MIDOV 46 +#define MT6370_IRQ_BST_OLP 47 +#define MT6370_IRQ_ATTACH 48 +#define MT6370_IRQ_DETACH 49 +#define MT6370_IRQ_HVDCP_STPDONE 51 +#define MT6370_IRQ_HVDCP_VBUSDET_DONE 52 +#define MT6370_IRQ_HVDCP_DET 53 +#define MT6370_IRQ_CHGDET 54 +#define MT6370_IRQ_DCDT 55 +#define MT6370_IRQ_DIRCHG_VGOK 59 +#define MT6370_IRQ_DIRCHG_WDTMR 60 +#define MT6370_IRQ_DIRCHG_UC 61 +#define MT6370_IRQ_DIRCHG_OC 62 +#define MT6370_IRQ_DIRCHG_OV 63 +#define MT6370_IRQ_OVPCTRL_SWON 67 +#define MT6370_IRQ_OVPCTRL_UVP_D 68 +#define MT6370_IRQ_OVPCTRL_UVP 69 +#define MT6370_IRQ_OVPCTRL_OVP_D 70 +#define MT6370_IRQ_OVPCTRL_OVP 71 +#define MT6370_IRQ_FLED_STRBPIN 72 +#define MT6370_IRQ_FLED_TORPIN 73 +#define MT6370_IRQ_FLED_TX 74 +#define MT6370_IRQ_FLED_LVF 75 +#define MT6370_IRQ_FLED2_SHORT 78 +#define MT6370_IRQ_FLED1_SHORT 79 +#define MT6370_IRQ_FLED2_STRB 80 +#define MT6370_IRQ_FLED1_STRB 81 +#define mT6370_IRQ_FLED2_STRB_TO 82 +#define MT6370_IRQ_FLED1_STRB_TO 83 +#define MT6370_IRQ_FLED2_TOR 84 +#define MT6370_IRQ_FLED1_TOR 85 +#define MT6370_IRQ_OTP 93
drivers/mfd/mt6370.c line 110
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+#define MT6370_IRQ_VDDA_OVP 94 +#define MT6370_IRQ_VDDA_UV 95 +#define MT6370_IRQ_LDO_OC 103 +#define MT6370_IRQ_BLED_OCP 118 +#define MT6370_IRQ_BLED_OVP 119 +#define MT6370_IRQ_DSV_VNEG_OCP 123 +#define MT6370_IRQ_DSV_VPOS_OCP 124 +#define MT6370_IRQ_DSV_BST_OCP 125 +#define MT6370_IRQ_DSV_VNEG_SCP 126 +#define MT6370_IRQ_DSV_VPOS_SCP 127
Can you pop these into a header file please?
drivers/mfd/mt6370.c line 114
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+struct mt6370_info { +struct i2c_client *i2c[MT6370_MAX_I2C ]; +struct device *dev;
You don't need both 'i2c' and 'dev'.
You can derive one from the other.
drivers/mfd/mt6370.c line 117
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+struct regmap *regmap; +struct regmap_irq_chip_data *irq_data; +};
This can do into the header file too.
Quoted 94 lines
drivers/mfd/mt6370.c new file +94
-0+static const struct regmap_irq mt6370_irqs[] = { +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHGON ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TREG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_AICR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_MIVR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_PWR_RDY ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FL_CHG_VINOVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VSYSUV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VSYSOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VBATOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VINOVPCHG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_COLD ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_COOL ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_WARM ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_HOT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_STATC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_FAULT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_STATC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_BATABS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_ADPBAD ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_RVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TSHUTDOWN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_IINMEAS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_ICCMEAS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHGDET_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_WDTMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_SSFINISH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_RECHG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TERM ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_IEOC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_ADC_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_PUMPX_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_BATUV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_MIDOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_OLP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_ATTACH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DETACH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_STPDONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_VBUSDET_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_DET ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHGDET ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DCDT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_VGOK ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_WDTMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_UC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_OC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_OV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_SWON ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_UVP_D ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_UVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_OVP_D ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_STRBPIN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_TORPIN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_TX ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_LVF ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_SHORT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_SHORT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_STRB ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_STRB ,8 ), +REGMAP_IRQ_REG_LINE (mT6370_IRQ_FLED2_STRB_TO,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_STRB_TO ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_TOR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_TOR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OTP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_VDDA_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_VDDA_UV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_LDO_OC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BLED_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BLED_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VNEG_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VPOS_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_BST_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VNEG_SCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VPOS_SCP ,8 ) +}; + +static const struct regmap_irq_chip mt6370_irq_chip = { + .name ="mt6370-irqs" , + .status_base =MT6370_REG_CHG_IRQ1 , + .mask_base =MT6370_REG_CHG_MASK1 , + .num_regs =MT6370_NUM_IRQREGS , + .irqs = mt6370_irqs, + .num_irqs =ARRAY_SIZE (mt6370_irqs), +}; + +static const struct resource mt6370_regulator_irqs[] = { +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VPOS_SCP ,"db_vpos_scp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VNEG_SCP ,"db_vneg_scp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_BST_OCP ,"db_vbst_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VPOS_OCP ,"db_vpos_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VNEG_OCP ,"db_vneg_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_LDO_OC ,"ldo_oc" )
drivers/mfd/mt6370.c line 222
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+}; + +static const struct mfd_cell mt6370_devices[] = { +MFD_CELL_OF ("adc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-adc" ), +MFD_CELL_OF ("charger" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-charger" ), +MFD_CELL_OF ("backlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-backlight" ), +MFD_CELL_OF ("flashlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-flashlight" ), +MFD_CELL_OF ("indicator" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-indicator" ), +MFD_CELL_OF ("tcpc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-tcpc" ), +MFD_CELL_RES ("regulator" , mt6370_regulator_irqs)
The first parameters here should be prepended with something, perhaps "mt6370_"?
Quoted 86 lines
drivers/mfd/mt6370.c new file +86
-0+}; + +static int mt6370_check_vendor_info (struct mt6370_info *info) +{ +unsigned int devinfo; +int ret; + + ret =regmap_read (info->regmap,MT6370_REG_DEV_INFO , &devinfo); +if (ret) +return ret; + +switch (FIELD_GET (MT6370_VENID_MASK , devinfo)) { +case MT6370_VENID_RT5081 : +case MT6370_VENID_RT5081A : +case MT6370_VENID_MT6370 : +case MT6370_VENID_MT6371 : +case MT6370_VENID_MT6372P : +case MT6370_VENID_MT6372CP : +break ; +default : +dev_err (info->dev,"Unknown Vendor ID 0x%02x\n" , devinfo); +return -ENODEV ; + } + +return 0 ; +} + +static int mt6370_regmap_read (void *context,const void *reg_buf, +size_t reg_size,void *val_buf,size_t val_size) +{ +struct mt6370_info *info = context; +u8 bank_idx, bank_addr; +int ret; + + bank_idx = *(u8 *)reg_buf; + bank_addr = *(u8 *)(reg_buf +1 ); + + ret =i2c_smbus_read_i2c_block_data (info->i2c[bank_idx], bank_addr, + val_size, val_buf); +if (ret <0 ) +return ret; +else if (ret != val_size) +return -EIO ; + +return 0 ; +} + +static int mt6370_regmap_write (void *context,const void *data,size_t count) +{ +struct mt6370_info *info = context; +u8 bank_idx, bank_addr; +int len = count -MT6370_REG_ADDRLEN ; + + bank_idx = *(u8 *)data; + bank_addr = *(u8 *)(data +1 ); + +return i2c_smbus_write_i2c_block_data (info->i2c[bank_idx], bank_addr, + len, data +MT6370_REG_ADDRLEN ); +} + +static const struct regmap_bus mt6370_regmap_bus = { + .read = mt6370_regmap_read, + .write = mt6370_regmap_write, +}; + +static const struct regmap_config mt6370_regmap_config = { + .reg_bits =16 , + .val_bits =8 , + .reg_format_endian =REGMAP_ENDIAN_BIG , + .max_register =MT6370_REG_MAXADDR , +}; + +static int mt6370_probe (struct i2c_client *i2c) +{ +struct mt6370_info *info; +struct i2c_client *usbc_i2c; +int ret; + + info =devm_kzalloc (&i2c->dev,sizeof (*info),GFP_KERNEL ); +if (!info) +return -ENOMEM ; + + info->dev = &i2c->dev; + + usbc_i2c =devm_i2c_new_dummy_device (&i2c->dev, i2c->adapter, +MT6370_USBC_I2CADDR );
drivers/mfd/mt6370.c line 318
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+if (IS_ERR (usbc_i2c)) +return dev_err_probe (&i2c->dev,PTR_ERR (usbc_i2c), +"Failed to register USBC I2C client\n" ); + +/* Assign I2C client for PMU and TypeC */ + info->i2c[MT6370_PMU_I2C ] = i2c; + info->i2c[MT6370_USBC_I2C ] = usbc_i2c; + + info->regmap =devm_regmap_init (&i2c->dev, &mt6370_regmap_bus, info, + &mt6370_regmap_config);
Apart from in mt6370_check_vendor_info() where is this actually used?
Quoted 29 lines
drivers/mfd/mt6370.c new file +29
-0+if (IS_ERR (info->regmap)) +return dev_err_probe (&i2c->dev,PTR_ERR (info->regmap), +"Failed to register regmap\n" ); + + ret =mt6370_check_vendor_info (info); +if (ret) +return dev_err_probe (&i2c->dev, ret, +"Failed to check vendor info\n" ); + + ret =devm_regmap_add_irq_chip (&i2c->dev, info->regmap, i2c->irq, +IRQF_ONESHOT ,-1 , &mt6370_irq_chip, + &info->irq_data); +if (ret) +return dev_err_probe (&i2c->dev, ret, +"Failed to add irq chip\n" ); + +return devm_mfd_add_devices (&i2c->dev,PLATFORM_DEVID_AUTO , + mt6370_devices,ARRAY_SIZE (mt6370_devices), +NULL ,0 , +regmap_irq_get_domain (info->irq_data)); +} + +static const struct of_device_id mt6370_match_table[] = { + { .compatible ="mediatek,mt6370" , }, + {} +}; +MODULE_DEVICE_TABLE (of, mt6370_match_table); + +static struct i2c_driver mt6370_driver = {
drivers/mfd/mt6370.c line 357
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+ .driver = { + .name = "mt6370", + .of_match_table = mt6370_match_table, + }, + .probe_new = mt6370_probe, +}; +module_i2c_driver (mt6370_driver); + +MODULE_AUTHOR ("ChiYuan Huang <[email protected]>" ); +MODULE_DESCRIPTION ("MT6370 I2C Driver" );
This is not an I2C driver.
Quoted 1 line
drivers/mfd/mt6370.c new file +1
-0+MODULE_LICENSE ("GPL v2" );
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
Hi Lee,
Thanks for your reply.
Lee Jones <[email protected]> 於 2022年7月12日 週二 晚上11:29寫道:
Quoted 13 lines · ChiaEn Wu
Quoted 4 lines
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
No such thing as "MFD support".
And you're not getting away with submitting a 370 line patch with a 5 word change log either. :)
Please at least tell us what the device is and what it's used for.
I sincerely apologize.
We will add more descriptions of the MT6370 feature in the v5 patch.
Quoted 59 lines
Quoted 59 lines
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- RefineKconfighelp text
- Refine error message of unknown vendor ID inmt6370_check_vendor_info()
- Refine return value handling ofmt6370_regmap_read()
- Refine all probe error by usingdev_err_probe()
- Refine "bank_idx" and "bank_addr" inmt6370_regmap_read()andmt6370_regmap_write()
- Add "#define VENID*" and drop the comments inmt6370_check_vendor_info()
- Drop "MFD" inMODULE_DESCRIPTION()--- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/mfd/mt6370.cdrivers/mfd/Kconfig +13
-0@@ -937,6 +937,19 @@ config MFD_MT6360 PMIC part includes 2-channel BUCKs and 2-channel LDOs LDO part includes 4-channel LDOs +config MFD_MT6370 + tristate "Mediatek MT6370 SubPMIC" + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + depends on I2C + help + Say Y here to enable MT6370 SubPMIC functional support. + It consists of a single cell battery charger with ADC monitoring, RGB + LEDs, dual channel flashlight, WLED backlight driver, display bias + voltage supply, one general purpose LDO, and the USB Type-C & PD + controller complies with the latest USB Type-C and PD standards. + config MFD_MT6397 tristate "MediaTek MT6397 PMIC Support" select MFD_COREdrivers/mfd/Makefile +1
-0@@ -242,6 +242,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o obj-$(CONFIG_MFD_MT6360) += mt6360-core.o +obj-$(CONFIG_MFD_MT6370) += mt6370.o mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o obj-$(CONFIG_MFD_MT6397) += mt6397.o obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.odrivers/mfd/mt6370.c +0
-0
Quoted 8 lines
drivers/mfd/mt6370.c line 1
Quoted 6 lines
new file mode 100644
index 0000000..49f02b1drivers/mfd/mt6370.c new file +1
-0@@ -0,0 +1,358 @@ +// SPDX-License-Identifier: GPL-2.0 No Copyright?
We have already added Copyright in the v4 patch.
Quoted 103 lines
Quoted 103 lines
drivers/mfd/mt6370.c new file +102
-0+#include <linux/bits.h> +#include <linux/i2c.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/mfd/core.h> +#include <linux/module.h> +#include <linux/regmap.h> + +enum { +MT6370_USBC_I2C =0 , +MT6370_PMU_I2C , +MT6370_MAX_I2C +}; + +#define MT6370_REG_DEV_INFO 0x100 +#define MT6370_REG_CHG_IRQ1 0x1C0 +#define MT6370_REG_CHG_MASK1 0x1E0 + +#define MT6370_VENID_MASK GENMASK(7, 4) + +#define MT6370_NUM_IRQREGS 16 +#define MT6370_USBC_I2CADDR 0x4E +#define MT6370_REG_ADDRLEN 2 +#define MT6370_REG_MAXADDR 0x1FF + +#define MT6370_VENID_RT5081 0x8 +#define MT6370_VENID_RT5081A 0xA +#define MT6370_VENID_MT6370 0xE +#define MT6370_VENID_MT6371 0xF +#define MT6370_VENID_MT6372P 0x9 +#define MT6370_VENID_MT6372CP 0xB + +/* IRQ definitions */ +#define MT6370_IRQ_DIRCHGON 0 +#define MT6370_IRQ_CHG_TREG 4 +#define MT6370_IRQ_CHG_AICR 5 +#define MT6370_IRQ_CHG_MIVR 6 +#define MT6370_IRQ_PWR_RDY 7 +#define MT6370_IRQ_FL_CHG_VINOVP 11 +#define MT6370_IRQ_CHG_VSYSUV 12 +#define MT6370_IRQ_CHG_VSYSOV 13 +#define MT6370_IRQ_CHG_VBATOV 14 +#define MT6370_IRQ_CHG_VINOVPCHG 15 +#define MT6370_IRQ_TS_BAT_COLD 20 +#define MT6370_IRQ_TS_BAT_COOL 21 +#define MT6370_IRQ_TS_BAT_WARM 22 +#define MT6370_IRQ_TS_BAT_HOT 23 +#define MT6370_IRQ_TS_STATC 24 +#define MT6370_IRQ_CHG_FAULT 25 +#define MT6370_IRQ_CHG_STATC 26 +#define MT6370_IRQ_CHG_TMR 27 +#define MT6370_IRQ_CHG_BATABS 28 +#define MT6370_IRQ_CHG_ADPBAD 29 +#define MT6370_IRQ_CHG_RVP 30 +#define MT6370_IRQ_TSHUTDOWN 31 +#define MT6370_IRQ_CHG_IINMEAS 32 +#define MT6370_IRQ_CHG_ICCMEAS 33 +#define MT6370_IRQ_CHGDET_DONE 34 +#define MT6370_IRQ_WDTMR 35 +#define MT6370_IRQ_SSFINISH 36 +#define MT6370_IRQ_CHG_RECHG 37 +#define MT6370_IRQ_CHG_TERM 38 +#define MT6370_IRQ_CHG_IEOC 39 +#define MT6370_IRQ_ADC_DONE 40 +#define MT6370_IRQ_PUMPX_DONE 41 +#define MT6370_IRQ_BST_BATUV 45 +#define MT6370_IRQ_BST_MIDOV 46 +#define MT6370_IRQ_BST_OLP 47 +#define MT6370_IRQ_ATTACH 48 +#define MT6370_IRQ_DETACH 49 +#define MT6370_IRQ_HVDCP_STPDONE 51 +#define MT6370_IRQ_HVDCP_VBUSDET_DONE 52 +#define MT6370_IRQ_HVDCP_DET 53 +#define MT6370_IRQ_CHGDET 54 +#define MT6370_IRQ_DCDT 55 +#define MT6370_IRQ_DIRCHG_VGOK 59 +#define MT6370_IRQ_DIRCHG_WDTMR 60 +#define MT6370_IRQ_DIRCHG_UC 61 +#define MT6370_IRQ_DIRCHG_OC 62 +#define MT6370_IRQ_DIRCHG_OV 63 +#define MT6370_IRQ_OVPCTRL_SWON 67 +#define MT6370_IRQ_OVPCTRL_UVP_D 68 +#define MT6370_IRQ_OVPCTRL_UVP 69 +#define MT6370_IRQ_OVPCTRL_OVP_D 70 +#define MT6370_IRQ_OVPCTRL_OVP 71 +#define MT6370_IRQ_FLED_STRBPIN 72 +#define MT6370_IRQ_FLED_TORPIN 73 +#define MT6370_IRQ_FLED_TX 74 +#define MT6370_IRQ_FLED_LVF 75 +#define MT6370_IRQ_FLED2_SHORT 78 +#define MT6370_IRQ_FLED1_SHORT 79 +#define MT6370_IRQ_FLED2_STRB 80 +#define MT6370_IRQ_FLED1_STRB 81 +#define mT6370_IRQ_FLED2_STRB_TO 82 +#define MT6370_IRQ_FLED1_STRB_TO 83 +#define MT6370_IRQ_FLED2_TOR 84 +#define MT6370_IRQ_FLED1_TOR 85 +#define MT6370_IRQ_OTP 93 +#define MT6370_IRQ_VDDA_OVP 94 +#define MT6370_IRQ_VDDA_UV 95 +#define MT6370_IRQ_LDO_OC 103 +#define MT6370_IRQ_BLED_OCP 118
Quoted 8 lines
drivers/mfd/mt6370.c line 110
Quoted 6 lines
drivers/mfd/mt6370.c new file +6
-0+#define MT6370_IRQ_BLED_OVP 119 +#define MT6370_IRQ_DSV_VNEG_OCP 123 +#define MT6370_IRQ_DSV_VPOS_OCP 124 +#define MT6370_IRQ_DSV_BST_OCP 125 +#define MT6370_IRQ_DSV_VNEG_SCP 126 +#define MT6370_IRQ_DSV_VPOS_SCP 127Can you pop these into a header file please?
We have already popped them into "mt6370.h" in the v4 patch.
Quoted 114 lines
drivers/mfd/mt6370.c line 114
Quoted 4 lines
drivers/mfd/mt6370.c new file +3
-0+struct mt6370_info { +struct i2c_client *i2c[MT6370_MAX_I2C ]; +struct device *dev;You don't need both 'i2c' and 'dev'.
You can derive one from the other.
drivers/mfd/mt6370.c line 117
Quoted 3 lines
drivers/mfd/mt6370.c new file +3
-0+struct regmap *regmap; +struct regmap_irq_chip_data *irq_data; +};This can do into the header file too.
Quoted 99 lines
drivers/mfd/mt6370.c new file +99
-0+static const struct regmap_irq mt6370_irqs[] = { +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHGON ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TREG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_AICR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_MIVR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_PWR_RDY ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FL_CHG_VINOVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VSYSUV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VSYSOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VBATOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_VINOVPCHG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_COLD ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_COOL ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_WARM ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_BAT_HOT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TS_STATC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_FAULT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_STATC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_BATABS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_ADPBAD ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_RVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_TSHUTDOWN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_IINMEAS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_ICCMEAS ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHGDET_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_WDTMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_SSFINISH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_RECHG ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_TERM ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHG_IEOC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_ADC_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_PUMPX_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_BATUV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_MIDOV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BST_OLP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_ATTACH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DETACH ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_STPDONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_VBUSDET_DONE ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_HVDCP_DET ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_CHGDET ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DCDT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_VGOK ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_WDTMR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_UC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_OC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DIRCHG_OV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_SWON ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_UVP_D ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_UVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_OVP_D ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OVPCTRL_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_STRBPIN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_TORPIN ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_TX ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED_LVF ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_SHORT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_SHORT ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_STRB ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_STRB ,8 ), +REGMAP_IRQ_REG_LINE (mT6370_IRQ_FLED2_STRB_TO,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_STRB_TO ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED2_TOR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_FLED1_TOR ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_OTP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_VDDA_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_VDDA_UV ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_LDO_OC ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BLED_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_BLED_OVP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VNEG_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VPOS_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_BST_OCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VNEG_SCP ,8 ), +REGMAP_IRQ_REG_LINE (MT6370_IRQ_DSV_VPOS_SCP ,8 ) +}; + +static const struct regmap_irq_chip mt6370_irq_chip = { + .name ="mt6370-irqs" , + .status_base =MT6370_REG_CHG_IRQ1 , + .mask_base =MT6370_REG_CHG_MASK1 , + .num_regs =MT6370_NUM_IRQREGS , + .irqs = mt6370_irqs, + .num_irqs =ARRAY_SIZE (mt6370_irqs), +}; + +static const struct resource mt6370_regulator_irqs[] = { +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VPOS_SCP ,"db_vpos_scp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VNEG_SCP ,"db_vneg_scp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_BST_OCP ,"db_vbst_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VPOS_OCP ,"db_vpos_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_DSV_VNEG_OCP ,"db_vneg_ocp" ), +DEFINE_RES_IRQ_NAMED (MT6370_IRQ_LDO_OC ,"ldo_oc" ) +}; + +static const struct mfd_cell mt6370_devices[] = { +MFD_CELL_OF ("adc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-adc" ), +MFD_CELL_OF ("charger" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-charger" ),
Quoted 8 lines
drivers/mfd/mt6370.c line 222
Quoted 5 lines
drivers/mfd/mt6370.c new file +5
-0+MFD_CELL_OF ("backlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-backlight" ), +MFD_CELL_OF ("flashlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-flashlight" ), +MFD_CELL_OF ("indicator" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-indicator" ), +MFD_CELL_OF ("tcpc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-tcpc" ), +MFD_CELL_RES ("regulator" , mt6370_regulator_irqs)The first parameters here should be prepended with something, perhaps "
mt6370_"?
OK, we will add the prefix in the next patch.
Quoted 91 lines
Quoted 91 lines
drivers/mfd/mt6370.c new file +90
-0+}; + +static int mt6370_check_vendor_info (struct mt6370_info *info) +{ +unsigned int devinfo; +int ret; + + ret =regmap_read (info->regmap,MT6370_REG_DEV_INFO , &devinfo); +if (ret) +return ret; + +switch (FIELD_GET (MT6370_VENID_MASK , devinfo)) { +case MT6370_VENID_RT5081 : +case MT6370_VENID_RT5081A : +case MT6370_VENID_MT6370 : +case MT6370_VENID_MT6371 : +case MT6370_VENID_MT6372P : +case MT6370_VENID_MT6372CP : +break ; +default : +dev_err (info->dev,"Unknown Vendor ID 0x%02x\n" , devinfo); +return -ENODEV ; + } + +return 0 ; +} + +static int mt6370_regmap_read (void *context,const void *reg_buf, +size_t reg_size,void *val_buf,size_t val_size) +{ +struct mt6370_info *info = context; +u8 bank_idx, bank_addr; +int ret; + + bank_idx = *(u8 *)reg_buf; + bank_addr = *(u8 *)(reg_buf +1 ); + + ret =i2c_smbus_read_i2c_block_data (info->i2c[bank_idx], bank_addr, + val_size, val_buf); +if (ret <0 ) +return ret; +else if (ret != val_size) +return -EIO ; + +return 0 ; +} + +static int mt6370_regmap_write (void *context,const void *data,size_t count) +{ +struct mt6370_info *info = context; +u8 bank_idx, bank_addr; +int len = count -MT6370_REG_ADDRLEN ; + + bank_idx = *(u8 *)data; + bank_addr = *(u8 *)(data +1 ); + +return i2c_smbus_write_i2c_block_data (info->i2c[bank_idx], bank_addr, + len, data +MT6370_REG_ADDRLEN ); +} + +static const struct regmap_bus mt6370_regmap_bus = { + .read = mt6370_regmap_read, + .write = mt6370_regmap_write, +}; + +static const struct regmap_config mt6370_regmap_config = { + .reg_bits =16 , + .val_bits =8 , + .reg_format_endian =REGMAP_ENDIAN_BIG , + .max_register =MT6370_REG_MAXADDR , +}; + +static int mt6370_probe (struct i2c_client *i2c) +{ +struct mt6370_info *info; +struct i2c_client *usbc_i2c; +int ret; + + info =devm_kzalloc (&i2c->dev,sizeof (*info),GFP_KERNEL ); +if (!info) +return -ENOMEM ; + + info->dev = &i2c->dev; + + usbc_i2c =devm_i2c_new_dummy_device (&i2c->dev, i2c->adapter, +MT6370_USBC_I2CADDR ); +if (IS_ERR (usbc_i2c)) +return dev_err_probe (&i2c->dev,PTR_ERR (usbc_i2c), +"Failed to register USBC I2C client\n" ); +
Quoted 8 lines
drivers/mfd/mt6370.c line 318
Quoted 6 lines
drivers/mfd/mt6370.c new file +6
-0+/* Assign I2C client for PMU and TypeC */ + info->i2c[MT6370_PMU_I2C ] = i2c; + info->i2c[MT6370_USBC_I2C ] = usbc_i2c; + + info->regmap =devm_regmap_init (&i2c->dev, &mt6370_regmap_bus, info, + &mt6370_regmap_config);Apart from in
mt6370_check_vendor_info()where is this actually used?
Well... from my understanding, we use this MFD driver to make other drivers of MT6370 (e.g. charger, ADC, led...) use the same regmap settings.
Thus, this regmap is not only used in mt6370_check_vendor_info().
Quoted 43 lines
Quoted 30 lines
drivers/mfd/mt6370.c new file +29
-0+if (IS_ERR (info->regmap)) +return dev_err_probe (&i2c->dev,PTR_ERR (info->regmap), +"Failed to register regmap\n" ); + + ret =mt6370_check_vendor_info (info); +if (ret) +return dev_err_probe (&i2c->dev, ret, +"Failed to check vendor info\n" ); + + ret =devm_regmap_add_irq_chip (&i2c->dev, info->regmap, i2c->irq, +IRQF_ONESHOT ,-1 , &mt6370_irq_chip, + &info->irq_data); +if (ret) +return dev_err_probe (&i2c->dev, ret, +"Failed to add irq chip\n" ); + +return devm_mfd_add_devices (&i2c->dev,PLATFORM_DEVID_AUTO , + mt6370_devices,ARRAY_SIZE (mt6370_devices), +NULL ,0 , +regmap_irq_get_domain (info->irq_data)); +} + +static const struct of_device_id mt6370_match_table[] = { + { .compatible ="mediatek,mt6370" , }, + {} +}; +MODULE_DEVICE_TABLE (of, mt6370_match_table); + +static struct i2c_driver mt6370_driver = {drivers/mfd/mt6370.c line 357
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+ .driver = { + .name = "mt6370", + .of_match_table = mt6370_match_table, + }, + .probe_new = mt6370_probe, +}; +module_i2c_driver (mt6370_driver); + +MODULE_AUTHOR ("ChiYuan Huang <[email protected]>" ); +MODULE_DESCRIPTION ("MT6370 I2C Driver" );This is not an I2C driver.
Quoted 7 lines
drivers/mfd/mt6370.c line 358
Quoted 1 line
drivers/mfd/mt6370.c new file +1
-0+MODULE_LICENSE ("GPL v2" );--
Lee Jones [李琼斯]
Principal Technical Lead - Developer ServicesLinaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Best regards,
ChiaEn Wu
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
Quoted 43 lines · ChiaEn Wu
Hi Lee,
Thanks for your reply.
Lee Jones <[email protected]> 於 2022年7月12日 週二 晚上11:29寫道:
Quoted 13 lines · ChiaEn Wu
Quoted 4 lines
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
No such thing as "MFD support".
And you're not getting away with submitting a 370 line patch with a 5 word change log either. :)
Please at least tell us what the device is and what it's used for.
I sincerely apologize.
We will add more descriptions of the MT6370 feature in the v5 patch.Quoted 21 lines
Quoted 21 lines
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- RefineKconfighelp text
- Refine error message of unknown vendor ID inmt6370_check_vendor_info()
- Refine return value handling ofmt6370_regmap_read()
- Refine all probe error by usingdev_err_probe()
- Refine "bank_idx" and "bank_addr" inmt6370_regmap_read()andmt6370_regmap_write()
- Add "#define VENID*" and drop the comments inmt6370_check_vendor_info()
- Drop "MFD" inMODULE_DESCRIPTION()--- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/mfd/mt6370.c
[...]
Quoted 27 lines
Quoted 18 lines
Quoted 18 lines
drivers/mfd/mt6370.c new file +18
-0+static int mt6370_probe (struct i2c_client *i2c) +{ +struct mt6370_info *info; +struct i2c_client *usbc_i2c; +int ret; + + info =devm_kzalloc (&i2c->dev,sizeof (*info),GFP_KERNEL ); +if (!info) +return -ENOMEM ; + + info->dev = &i2c->dev; + + usbc_i2c =devm_i2c_new_dummy_device (&i2c->dev, i2c->adapter, +MT6370_USBC_I2CADDR ); +if (IS_ERR (usbc_i2c)) +return dev_err_probe (&i2c->dev,PTR_ERR (usbc_i2c), +"Failed to register USBC I2C client\n" ); +Quoted 8 lines
drivers/mfd/mt6370.c line 318
Quoted 6 lines
drivers/mfd/mt6370.c new file +6
-0+/* Assign I2C client for PMU and TypeC */ + info->i2c[MT6370_PMU_I2C ] = i2c; + info->i2c[MT6370_USBC_I2C ] = usbc_i2c; + + info->regmap =devm_regmap_init (&i2c->dev, &mt6370_regmap_bus, info, + &mt6370_regmap_config);Apart from in
mt6370_check_vendor_info()where is this actually used?
Quoted 4 lines
Well... from my understanding, we use this MFD driver to make other drivers of MT6370 (e.g. charger, ADC, led...) use the same regmap settings.
Thus, this regmap is not only used inmt6370_check_vendor_info().
Well for that to happen you need to store the data somewhere for the child devices to fetch from. I don't see that happening in this patch? What did I miss?
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support
Hi Lee,
Lee Jones <[email protected]> 於 2022年7月13日 週三 下午4:04寫道:
Quoted 58 lines · ChiaEn Wu
Quoted 44 lines
Hi Lee,
Thanks for your reply.
Lee Jones <[email protected]> 於 2022年7月12日 週二 晚上11:29寫道:
Quoted 13 lines · ChiaEn Wu
Quoted 4 lines
From: ChiYuan Huang <[email protected]>
Add Mediatek MT6370 MFD support.
No such thing as "MFD support".
And you're not getting away with submitting a 370 line patch with a 5 word change log either. :)
Please at least tell us what the device is and what it's used for.
I sincerely apologize.
We will add more descriptions of the MT6370 feature in the v5 patch.Quoted 21 lines
Quoted 21 lines
Signed-off-by ChiYuan Huang <[email protected]>---
v3
- RefineKconfighelp text
- Refine error message of unknown vendor ID inmt6370_check_vendor_info()
- Refine return value handling ofmt6370_regmap_read()
- Refine all probe error by usingdev_err_probe()
- Refine "bank_idx" and "bank_addr" inmt6370_regmap_read()andmt6370_regmap_write()
- Add "#define VENID*" and drop the comments inmt6370_check_vendor_info()
- Drop "MFD" inMODULE_DESCRIPTION()--- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile | 1 + drivers/mfd/mt6370.c | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 372 insertions(+) create mode 100644 drivers/mfd/mt6370.c[...]
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
drivers/mfd/mt6370.c new file +8
-0+static const struct mfd_cell mt6370_devices[] = { +MFD_CELL_OF ("adc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-adc" ), +MFD_CELL_OF ("charger" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-charger" ), +MFD_CELL_OF ("backlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-backlight" ), +MFD_CELL_OF ("flashlight" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-flashlight" ), +MFD_CELL_OF ("indicator" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-indicator" ), +MFD_CELL_OF ("tcpc" ,NULL ,NULL ,0 ,0 ,"mediatek,mt6370-tcpc" ), +MFD_CELL_RES ("regulator" , mt6370_regulator_irqs)
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
The first parameters here should be prepended with something, perhaps "
mt6370_"?OK, we will add the prefix in the next patch.
Sorry, I forgot to ask a question in the last mail.
I wonder if using "mt6370-xxx" (dash) is better than using "mt6370_" (underline) ??
Thanks.
Quoted 29 lines
[...]
Quoted 27 lines
Quoted 26 lines
Quoted 14 lines
drivers/mfd/mt6370.c new file +14
-0+static int mt6370_probe (struct i2c_client *i2c) +{ +struct mt6370_info *info; +struct i2c_client *usbc_i2c; +int ret; + + info =devm_kzalloc (&i2c->dev,sizeof (*info),GFP_KERNEL ); +if (!info) +return -ENOMEM ; + + info->dev = &i2c->dev; + + usbc_i2c =devm_i2c_new_dummy_device (&i2c->dev, i2c->adapter, +MT6370_USBC_I2CADDR );drivers/mfd/mt6370.c line 318
Quoted 10 lines
drivers/mfd/mt6370.c new file +10
-0+if (IS_ERR (usbc_i2c)) +return dev_err_probe (&i2c->dev,PTR_ERR (usbc_i2c), +"Failed to register USBC I2C client\n" ); + +/* Assign I2C client for PMU and TypeC */ + info->i2c[MT6370_PMU_I2C ] = i2c; + info->i2c[MT6370_USBC_I2C ] = usbc_i2c; + + info->regmap =devm_regmap_init (&i2c->dev, &mt6370_regmap_bus, info, + &mt6370_regmap_config);Apart from in
mt6370_check_vendor_info()where is this actually used?
Quoted 8 lines
Quoted 4 lines
Well... from my understanding, we use this MFD driver to make other drivers of MT6370 (e.g. charger, ADC, led...) use the same regmap settings.
Thus, this regmap is not only used inmt6370_check_vendor_info().Well for that to happen you need to store the data somewhere for the child devices to fetch from. I don't see that happening in this patch? What did I miss?
hmmm... I got your point... I will let regmap be a local var in probe() in the next patch.
Thank you so much!
Quoted 6 lines
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer ServicesLinaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Best regards,
ChiaEn Wu