drm/amdgpu/display: drop set but unused variable
Subsystems (3)
Alex Deucher
maintainerPATCH 1/2 drm/amdgpu/display: drop set but unused variable
No longer used so drop it.
--- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +0 -2
@@ -1022,7 +1022,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,struct dc_sink *prev_sink =NULL ;struct dpcd_caps prev_dpcd_caps;enum dc_connection_type new_connection_type = dc_connection_none; -enum dc_connection_type pre_connection_type = dc_connection_none;const uint32_t post_oui_delay =30 ;// 30ms DC_LOGGER_INIT (link->ctx->logger);
@@ -1059,7 +1058,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,link_disconnect_sink (link);if (new_connection_type != dc_connection_none) { - pre_connection_type = link->type; link->type = new_connection_type; link->link_state_valid = false;
Signature · 1 line
2.35.3
Alex Deucher
maintainerPATCH 2/2 drm/amdgpu: fix documentation warning
Fixes this issue:drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype for amdgpu_device_gpu_recover_imp(). Prototype was for amdgpu_device_gpu_recover() instead
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev/** -* amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler +* amdgpu_device_gpu_recover - reset the asic and recover scheduler * * @adev: amdgpu_device pointer * @job: which job trigger hang
Signature · 1 line
2.35.3
Re: [PATCH 2/2] drm/amdgpu: fix documentation warning
Ping?
Quoted 27 lines · Alex Deucher
Fixes this issue:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expecting prototype foramdgpu_device_gpu_recover_imp(). Prototype was foramdgpu_device_gpu_recover()insteadFixes cf727044144d ("drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-2@@ -5079,7 +5079,7 @@ static inline void amdggpu_device_stop_pedning_resets(struct amdgpu_device *adev/** -* amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler +* amdgpu_device_gpu_recover - reset the asic and recover scheduler * * @adev: amdgpu_device pointer * @job: which job trigger hang -- 2.35.3
Russell, Kent
Reviewed-byRE: [PATCH 2/2] drm/amdgpu: fix documentation warning
[AMD Official Use Only - General]
Not sure why no one responded, but this is something even I can RB.
Quoted 45 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Monday, June 27, 2022 5:41 PM
To: Deucher, Alexander <[email protected]>
Cc: Stephen Rothwell <[email protected]>; amd-gfx list <amd- [email protected]>
Subject: Re: [PATCH 2/2] drm/amdgpu: fix documentation warningPing?
Quoted 3 lines · Alex Deucher
Fixes this issue:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5094: warning: expectingprototype for
amdgpu_device_gpu_recover_imp(). Prototype was foramdgpu_device_gpu_recover()insteadQuoted 2 lines
Fixes cf727044144d ("drm/amdgpu: Rename
amdgpu_device_gpu_recover_impback toamdgpu_device_gpu_recover")Review
Quoted 7 lines
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.cdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c static inline void
Quoted 4 lines
index
f2a4c268ac72..6c0fbc662b3a100644drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0@@ -5079,7 +5079,7 @@ static inline voidamdggpu_device_stop_pedning_resets(struct
amdgpu_device*adevQuoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-2/** -* amdgpu_device_gpu_recover_imp - reset the asic and recover scheduler +* amdgpu_device_gpu_recover - reset the asic and recover scheduler * * @adev: amdgpu_device pointer * @job: which job trigger hang -- 2.35.3
Quoted 5 lines · Alex Deucher
No longer used so drop it.
Fixes ec457f837890 ("drm/amd/display: Drop unnecessary detect link code")Reported-by kernel test robot <[email protected]>Signed-off-by Alex Deucher <[email protected]>
Harry
Quoted 24 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/amd/display/dc/core/dc_link.c +0
-2@@ -1022,7 +1022,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,struct dc_sink *prev_sink =NULL ;struct dpcd_caps prev_dpcd_caps;enum dc_connection_type new_connection_type = dc_connection_none; -enum dc_connection_type pre_connection_type = dc_connection_none;const uint32_t post_oui_delay =30 ;// 30ms DC_LOGGER_INIT (link->ctx->logger);@@ -1059,7 +1058,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,link_disconnect_sink (link);if (new_connection_type != dc_connection_none) { - pre_connection_type = link->type; link->type = new_connection_type; link->link_state_valid = false;