Skip to contentSkip to conversation

iio: Don't use bare "unsigned"

PATCH In review Joe Simmons-Talbott 2 participants 2 messages Jun 24, 2022 – Jun 25, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: Don't use bare "unsigned"

Use "unsigned int" rather than bare "unsigned". Reported by checkpatch.pl.

---
 drivers/iio/industrialio-buffer.c     | 10 +++++-----
 drivers/iio/industrialio-core.c       |  4 ++--
 drivers/iio/industrialio-sw-device.c  |  2 +-
 drivers/iio/industrialio-sw-trigger.c |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)
drivers/iio/industrialio-buffer.c +5 -5
index b078eb2f3c9d..513a34a0b593 100644
@@ -705,7 +705,7 @@ static unsigned int iio_storage_bytes_for_timestamp(struct iio_dev *indio_dev)
 static int iio_compute_scan_bytes(struct iio_dev *indio_dev,
 				const unsigned long *mask, bool timestamp)
 {
-	unsigned bytes = 0;
+	unsigned int bytes = 0;
 	int length, i, largest = 0;
 
 	/* How much space will the demuxed element take? */
@@ -934,9 +934,9 @@ static int iio_verify_update(struct iio_dev *indio_dev,
  * @l:		list head used for management
  */
 struct iio_demux_table {
-	unsigned from;
-	unsigned to;
-	unsigned length;
+	unsigned int from;
+	unsigned int to;
+	unsigned int length;
 	struct list_head l;
 };
 
@@ -974,7 +974,7 @@ static int iio_buffer_update_demux(struct iio_dev *indio_dev,
 				   struct iio_buffer *buffer)
 {
 	int ret, in_ind = -1, out_ind, length;
-	unsigned in_loc = 0, out_loc = 0;
+	unsigned int in_loc = 0, out_loc = 0;
 	struct iio_demux_table *p = NULL;
 
 	/* Clear out any old demux */
drivers/iio/industrialio-core.c +2 -2
index e1ed44dec2ab..ca28f76b8f40 100644
@@ -384,7 +384,7 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
 {
 	struct iio_dev *indio_dev = file->private_data;
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	unsigned val = 0;
+	unsigned int val = 0;
 	int ret;
 
 	if (*ppos > 0)
@@ -414,7 +414,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file,
 {
 	struct iio_dev *indio_dev = file->private_data;
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	unsigned reg, val;
+	unsigned int reg, val;
 	char buf[80];
 	int ret;
 
drivers/iio/industrialio-sw-device.c +1 -1
index 49f775f16ad5..cdaf30a3f233 100644
@@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_device_types_lock);
 
 static
 struct iio_sw_device_type *__iio_find_sw_device_type(const char *name,
-						     unsigned len)
+						     unsigned int len)
 {
 	struct iio_sw_device_type *d = NULL, *iter;
 
drivers/iio/industrialio-sw-trigger.c +1 -1
index 9ae793a70b8b..994f03a71520 100644
@@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_trigger_types_lock);
 
 static
 struct iio_sw_trigger_type *__iio_find_sw_trigger_type(const char *name,
-						       unsigned len)
+						       unsigned int len)
 {
 	struct iio_sw_trigger_type *t = NULL, *iter;
 
Signature · 1 line
2.35.3
maintainer
#1 lore raw
Quoted 3 lines · On Thu, 23 Jun 2022 22:18:06 -0400 Joe Simmons-Talbott <[email protected]>…

Use "unsigned int" rather than bare "unsigned". Reported by checkpatch.pl.

I've always wondered when someone would get around to tidying this up. Never seemed worth the effort to do it myself :)

Anyhow, thanks. Applied to the togreg branch of iio.git.

Thanks,

Jonathan

Quoted 90 lines
---
 drivers/iio/industrialio-buffer.c     | 10 +++++-----
 drivers/iio/industrialio-core.c       |  4 ++--
 drivers/iio/industrialio-sw-device.c  |  2 +-
 drivers/iio/industrialio-sw-trigger.c |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)
drivers/iio/industrialio-buffer.c +5 -5
index b078eb2f3c9d..513a34a0b593 100644
@@ -705,7 +705,7 @@ static unsigned int iio_storage_bytes_for_timestamp(struct iio_dev *indio_dev)
 static int iio_compute_scan_bytes(struct iio_dev *indio_dev,
 				const unsigned long *mask, bool timestamp)
 {
-	unsigned bytes = 0;
+	unsigned int bytes = 0;
 	int length, i, largest = 0;
 
 	/* How much space will the demuxed element take? */
@@ -934,9 +934,9 @@ static int iio_verify_update(struct iio_dev *indio_dev,
  * @l:		list head used for management
  */
 struct iio_demux_table {
-	unsigned from;
-	unsigned to;
-	unsigned length;
+	unsigned int from;
+	unsigned int to;
+	unsigned int length;
 	struct list_head l;
 };
 
@@ -974,7 +974,7 @@ static int iio_buffer_update_demux(struct iio_dev *indio_dev,
 				   struct iio_buffer *buffer)
 {
 	int ret, in_ind = -1, out_ind, length;
-	unsigned in_loc = 0, out_loc = 0;
+	unsigned int in_loc = 0, out_loc = 0;
 	struct iio_demux_table *p = NULL;
 
 	/* Clear out any old demux */
drivers/iio/industrialio-core.c +2 -2
index e1ed44dec2ab..ca28f76b8f40 100644
@@ -384,7 +384,7 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
 {
 	struct iio_dev *indio_dev = file->private_data;
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	unsigned val = 0;
+	unsigned int val = 0;
 	int ret;
 
 	if (*ppos > 0)
@@ -414,7 +414,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file,
 {
 	struct iio_dev *indio_dev = file->private_data;
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	unsigned reg, val;
+	unsigned int reg, val;
 	char buf[80];
 	int ret;
 
drivers/iio/industrialio-sw-device.c +1 -1
index 49f775f16ad5..cdaf30a3f233 100644
@@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_device_types_lock);
 
 static
 struct iio_sw_device_type *__iio_find_sw_device_type(const char *name,
-						     unsigned len)
+						     unsigned int len)
 {
 	struct iio_sw_device_type *d = NULL, *iter;
 
drivers/iio/industrialio-sw-trigger.c +1 -1
index 9ae793a70b8b..994f03a71520 100644
@@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_trigger_types_lock);
 
 static
 struct iio_sw_trigger_type *__iio_find_sw_trigger_type(const char *name,
-						       unsigned len)
+						       unsigned int len)
 {
 	struct iio_sw_trigger_type *t = NULL, *iter;