Skip to contentSkip to conversation

ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling

PATCH In review Charles Keepax 2 participants 2 messages Jun 27, 2022 – Jun 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling

The conversion of the set_fmt callback to direct clock specification included a small typo, correct the affected code.

Fixes 0b491c7c1b25 ("ASoC: samsung: Update to use set_fmt_new callback")

---

Changes since v1:
- Correct fixes tag.

 sound/soc/samsung/s3c24xx-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/samsung/s3c24xx-i2s.c +1 -1
index 4082ad7cbcc11..c1a314b86b155 100644
@@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
 	pr_debug("hw_params r: IISMOD: %x \n", iismod);
 
 	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
-	case SND_SOC_DAIFMT_BC_CFC:
+	case SND_SOC_DAIFMT_BC_FC:
 		iismod |= S3C2410_IISMOD_SLAVE;
 		break;
 	case SND_SOC_DAIFMT_BP_FP:
Signature · 1 line
2.30.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 3 lines · Charles Keepax

The conversion of the set_fmt callback to direct clock specification included a small typo, correct the affected code.

sound/soc/samsung/s3c24xx-i2s.c: In function 's3c24xx_i2s_set_fmt':

Quoted 1 line
Quoted 1 line

sound/soc/samsung/s3c24xx-i2s.c:173:14: error: 'SND_SOC_DAIFMT_BC_CFC' undeclared (first use in this function); did you mean 'SND_SOC_DAIFMT_BC_FC'?

     173 |         case SND_SOC_DAIFMT_BC_CFC:
         |              ^~~~~~~~~~~~~~~~~~~~~
         |              SND_SOC_DAIFMT_BC_FC

Adding this actual error msg from the kernel test robot will be helpful.

Quoted 29 lines
Fixes 0b491c7c1b25 ("ASoC: samsung: Update to use set_fmt_new callback")

---

Changes since v1:
- Correct fixes tag.

 sound/soc/samsung/s3c24xx-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/samsung/s3c24xx-i2s.c +1 -2
index 4082ad7cbcc11..c1a314b86b155 100644
@@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
        pr_debug("hw_params r: IISMOD: %x \n", iismod);
 
        switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
-       case SND_SOC_DAIFMT_BC_CFC:
+       case SND_SOC_DAIFMT_BC_FC:
                iismod |= S3C2410_IISMOD_SLAVE;
                break;
        case SND_SOC_DAIFMT_BP_FP:
--

2.30.2