platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms
PATCH v2 1/1 platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms
PSC platform profile mode is only supported on Linux for AMD platforms.
Some older Intel platforms (e.g T490) are advertising it's capability as Windows uses it - but on Linux we should only be using MMC profile for Intel systems.
Add a check to prevent it being enabled incorrectly.
---
Changes in v2: rebased on for-next stream
drivers/platform/x86/thinkpad_acpi.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/platform/x86/thinkpad_acpi.c +5 -0
@@ -10565,6 +10565,11 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) dytc_mmc_get_available = true; } }else if (dytc_capabilities &BIT (DYTC_FC_PSC )) {/* PSC MODE */ +/* Support for this only works on AMD platforms */ +if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD ) { +dbg_printk (TPACPI_DBG_INIT ,"PSC not support on Intel platforms\n" ); +return -ENODEV ; + }pr_debug ("PSC is supported\n" ); }else {dbg_printk (TPACPI_DBG_INIT ,"No DYTC support available\n" );
Signature · 1 line
2.36.1
Hi,
Quoted 10 lines · Mark Pearson
PSC platform profile mode is only supported on Linux for AMD platforms.
Some older Intel platforms (e.g T490) are advertising it's capability as Windows uses it - but on Linux we should only be using MMC profile for Intel systems.
Add a check to prevent it being enabled incorrectly.
Signed-off-by Mark Pearson <[email protected]>> ---Changes in v2: rebased on for-next stream
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 20 lines
drivers/platform/x86/thinkpad_acpi.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/platform/x86/thinkpad_acpi.c +5
-0@@ -10565,6 +10565,11 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) dytc_mmc_get_available = true; } }else if (dytc_capabilities &BIT (DYTC_FC_PSC )) {/* PSC MODE */ +/* Support for this only works on AMD platforms */ +if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD ) { +dbg_printk (TPACPI_DBG_INIT ,"PSC not support on Intel platforms\n" ); +return -ENODEV ; + }pr_debug ("PSC is supported\n" ); }else {dbg_printk (TPACPI_DBG_INIT ,"No DYTC support available\n" );