Skip to contentSkip to conversation

drm/amdgpu/display: add missing FP_START/END checks dcn32_clk_mgr.c

PATCH In review Alex Deucher 2 participants 2 messages Jun 27, 2022 – Jun 30, 2022

Subsystems (3)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/display: add missing FP_START/END checks dcn32_clk_mgr.c

Properly handle FP code in dcn32_clk_mgr.c.

Fixes 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
---
 drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c +4 -0
index 4e8059f20007..72bbe7f18f5d 100644
@@ -288,8 +288,10 @@ void dcn32_init_clocks(struct clk_mgr *clk_mgr_base)
 	/* Get UCLK, update bounding box */
 	clk_mgr_base->funcs->get_memclk_states_from_smu(clk_mgr_base);
 
+	DC_FP_START();
 	/* WM range table */
 	dcn32_build_wm_range_table(clk_mgr);
+	DC_FP_END();
 }
 
 static void dcn32_update_clocks_update_dtb_dto(struct clk_mgr_internal *clk_mgr,
@@ -724,9 +726,11 @@ static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
 			&num_levels);
 	clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
 
+	DC_FP_START();
 	/* Refresh bounding box */
 	clk_mgr_base->ctx->dc->res_pool->funcs->update_bw_bounding_box(
 			clk_mgr->base.ctx->dc, clk_mgr_base->bw_params);
+	DC_FP_END();
 }
 
 static bool dcn32_are_clock_states_equal(struct dc_clocks *a,
Signature · 1 line
2.35.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Alex Deucher

Properly handle FP code in dcn32_clk_mgr.c.

Fixes 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
---
  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c +2 -0
index 4e8059f20007..72bbe7f18f5d 100644
@@ -288,8 +288,10 @@ void dcn32_init_clocks(struct clk_mgr *clk_mgr_base)
  	/* Get UCLK, update bounding box */
  	clk_mgr_base->funcs->get_memclk_states_from_smu(clk_mgr_base);
 
+	DC_FP_START();
  	/* WM range table */
  	dcn32_build_wm_range_table(clk_mgr);
+	DC_FP_END();
  }
 
  static void dcn32_update_clocks_update_dtb_dto(struct clk_mgr_internal *clk_mgr,
@@ -724,9 +726,11 @@ static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base)
  			&num_levels);

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c static void dcn32_get_memclk_states_from_smu(struct clk_mgr *clk_mgr_base) · line 736

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c +2 -0
  	clk_mgr_base->bw_params->clk_table.num_entries = num_levels ? num_levels : 1;
 
+	DC_FP_START();
  	/* Refresh bounding box */
  	clk_mgr_base->ctx->dc->res_pool->funcs->update_bw_bounding_box(
  			clk_mgr->base.ctx->dc, clk_mgr_base->bw_params);
+	DC_FP_END();
  }
 
  static bool dcn32_are_clock_states_equal(struct dc_clocks *a,

Hi Alex,

Btw, I already start to work on the FPU isolation for DCN32/321.

Thanks
Siqueira