Skip to contentSkip to conversation

cifs: remove redundant initialization to variable mnt_sign_enabled

PATCH Applied Colin Ian King 2 participants 2 messages Jun 28, 2022 – Jul 3, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: remove redundant initialization to variable mnt_sign_enabled

Variable mnt_sign_enabled is being initialized with a value that is never read, it is being reassigned later on with a different value. The initialization is redundant and can be removed.

Cleans up clang scan-build warning:
fs/cifs/cifssmb.c:465:7: warning: Value stored to 'mnt_sign_enabled
during its initialization is never read

---
 fs/cifs/cifssmb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/cifssmb.c +1 -1
index 6371b9eebdad..9ed21752f2df 100644
@@ -462,7 +462,7 @@ cifs_enable_signing(struct TCP_Server_Info *server, bool mnt_sign_required)
 {
 	bool srv_sign_required = server->sec_mode & server->vals->signing_required;
 	bool srv_sign_enabled = server->sec_mode & server->vals->signing_enabled;
-	bool mnt_sign_enabled = global_secflags & CIFSSEC_MAY_SIGN;
+	bool mnt_sign_enabled;
 
 	/*
 	 * Is signing required by mnt options? If not then check
Signature · 1 line
2.35.3
Applied
#1 lore raw

merged into cifs-2.6.git for-next

Quoted 30 lines · Colin Ian King

Variable mnt_sign_enabled is being initialized with a value that is never read, it is being reassigned later on with a different value. The initialization is redundant and can be removed.

Cleans up clang scan-build warning:
fs/cifs/cifssmb.c:465:7: warning: Value stored to 'mnt_sign_enabled
during its initialization is never read

---
 fs/cifs/cifssmb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/cifssmb.c +1 -2
index 6371b9eebdad..9ed21752f2df 100644
@@ -462,7 +462,7 @@ cifs_enable_signing(struct TCP_Server_Info *server, bool mnt_sign_required)
 {
        bool srv_sign_required = server->sec_mode & server->vals->signing_required;
        bool srv_sign_enabled = server->sec_mode & server->vals->signing_enabled;
-       bool mnt_sign_enabled = global_secflags & CIFSSEC_MAY_SIGN;
+       bool mnt_sign_enabled;
 
        /*
         * Is signing required by mnt options? If not then check
--

2.35.3

Signature · 3 lines
Thanks,

Steve