ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables
Subsystems (3)
PATCH 1/1 ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables
sparse reportssound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static? sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?
Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c, so their storage class specifiers should be static.
--- sound/soc/samsung/rx1950_uda1380.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/samsung/rx1950_uda1380.c +2 -2
@@ -128,7 +128,7 @@ static int rx1950_startup(struct snd_pcm_substream *substream) &hw_rates); } -struct gpio_desc *gpiod_speaker_power; +static struct gpio_desc *gpiod_speaker_power;static int rx1950_spk_power (struct snd_soc_dapm_widget *w,struct snd_kcontrol *kcontrol,int event)
@@ -228,7 +228,7 @@ static int rx1950_probe(struct platform_device *pdev)return devm_snd_soc_register_card (dev, &rx1950_asoc); } -struct platform_driver rx1950_audio = { +static struct platform_driver rx1950_audio = { .driver = { .name ="rx1950-audio" , .pm = &snd_soc_pm_ops,
Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
sparse reports
sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static?sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?Both
gpiod_speaker_powerandrx1950_audioare only used inrx1950_uda1380.c, so their storage class specifiers should be static.Fixes 83d74e354200 ("ASoC: samsung: rx1950: turn into platform driver")Signed-off-by Tom Rix <[email protected]>---
Best regards,
Krzysztof
Mark Brown
maintainerQuoted 8 lines · Tom Rix
sparse reports
sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static?sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?Both
gpiod_speaker_powerandrx1950_audioare only used inrx1950_uda1380.c, so their storage class specifiers should be static.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables
commit: d2294461b90e0c5b3bbfaaf2c8baff4fd3e2bb13
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark