Skip to contentSkip to conversation

Revert "scripts/mod/modpost.c: permit '.cranges' secton for sh64 architecture."

PATCH Superseded Masahiro Yamada 2 participants 2 messages Jun 30, 2022 Kbuild

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "scripts/mod/modpost.c: permit '.cranges' secton for sh64 architecture."

This reverts commit 4d10c223baab8be8f717df3625cfece5be26dead.

Commit 37744feebc08 ("sh: remove sh5 support") removed the sh64 support entirely.

If ".cranges" section is used for other architectures, it is easy to get it back.

---

 scripts/mod/modpost.c | 1 -
 1 file changed, 1 deletion(-)
scripts/mod/modpost.c +0 -1
index 620dc8c4c814..e15227ee58fc 100644
@@ -742,7 +742,6 @@ static const char *const section_white_list[] =
 {
 	".comment*",
 	".debug*",
-	".cranges",		/* sh64 */
 	".zdebug*",		/* Compressed debug sections. */
 	".GCC.command.line",	/* record-gcc-switches */
 	".mdebug*",        /* alpha, score, mips etc. */
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Masahiro Yamada

This reverts commit 4d10c223baab8be8f717df3625cfece5be26dead.

Commit 37744feebc08 ("sh: remove sh5 support") removed the sh64 support entirely.

If ".cranges" section is used for other architectures, it is easy to get it back.

I don't think that will be an issue. BFD has a comment about this being a sh64-only section. I couldn't find any other reference to such a section.

Quoted 22 lines

---

 scripts/mod/modpost.c | 1 -
 1 file changed, 1 deletion(-)
scripts/mod/modpost.c +0 -2
index 620dc8c4c814..e15227ee58fc 100644
@@ -742,7 +742,6 @@ static const char *const section_white_list[] =
 {
        ".comment*",
        ".debug*",
-       ".cranges",             /* sh64 */
        ".zdebug*",             /* Compressed debug sections. */
        ".GCC.command.line",    /* record-gcc-switches */
        ".mdebug*",        /* alpha, score, mips etc. */
--

2.32.0

Signature · 2 lines
Thanks,
~Nick Desaulniers