eth: remove neterion/vxge
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 eth: remove neterion/vxge
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
Because of the size of this driver there is a nontrivial maintenance cost to keeping this code around, in the last 2 years we're averaging more than 1 change a month. Some of which require nontrivial review effort, see commit 877fe9d49b74 ("Revert "drivers/net/ethernet/neterion/vxge:
Fix a use-after-free bug in vxge-main.c"") for example.
Let's try to remove this driver. In general, IMHO, we need to establish a clear path for shedding dead code. It will be hard to unless we have some experience trying to delete stuff.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- .../device_drivers/ethernet/index.rst | 1 - .../device_drivers/ethernet/neterion/vxge.rst | 115 - MAINTAINERS | 3 +- drivers/net/ethernet/neterion/Kconfig | 24 - drivers/net/ethernet/neterion/Makefile | 1 - drivers/net/ethernet/neterion/vxge/Makefile | 8 - .../net/ethernet/neterion/vxge/vxge-config.c | 5099 ----------------- .../net/ethernet/neterion/vxge/vxge-config.h | 2086 ------- .../net/ethernet/neterion/vxge/vxge-ethtool.c | 1154 ---- .../net/ethernet/neterion/vxge/vxge-ethtool.h | 48 - .../net/ethernet/neterion/vxge/vxge-main.c | 4808 ---------------- .../net/ethernet/neterion/vxge/vxge-main.h | 516 -- drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4636 --------------- .../net/ethernet/neterion/vxge/vxge-traffic.c | 2428 -------- .../net/ethernet/neterion/vxge/vxge-traffic.h | 2290 -------- .../net/ethernet/neterion/vxge/vxge-version.h | 49 - 16 files changed, 1 insertion(+), 23265 deletions(-) delete mode 100644 Documentation/networking/device_drivers/ethernet/neterion/vxge.rst delete mode 100644 drivers/net/ethernet/neterion/vxge/Makefile delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-config.c delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-config.h delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-ethtool.c delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-ethtool.h delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-main.c delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-main.h delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-reg.h delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-traffic.c delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-traffic.h delete mode 100644 drivers/net/ethernet/neterion/vxge/vxge-version.h
Documentation/networking/device_drivers/ethernet/index.rst +0 -1
@@ -42,7 +42,6 @@ Device drivers for Ethernet and Ethernet-based virtual function devices. mellanox/mlx5 microsoft/netvsc neterion/s2io - neterion/vxge netronome/nfp pensando/ionic smsc/smc9
Documentation/networking/device_drivers/ethernet/neterion/vxge.rst deleted +0 -115
115 lines not on this page · raw message
MAINTAINERS +1 -2
@@ -13720,12 +13720,11 @@ L: [email protected] S: Maintained F: net/sched/sch_netem.c -NETERION 10GbE DRIVERS (s2io/vxge) +NETERION 10GbE DRIVERS (s2io) M: Jon Mason <[email protected]> L: [email protected] S: Supported F: Documentation/networking/device_drivers/ethernet/neterion/s2io.rst -F: Documentation/networking/device_drivers/ethernet/neterion/vxge.rst F: drivers/net/ethernet/neterion/ NETFILTER
drivers/net/ethernet/neterion/Kconfig +0 -24
@@ -32,28 +32,4 @@ config S2IO To compile this driver as a module, choose M here. The module will be called s2io. -config VXGE - tristate "Neterion (Exar) X3100 Series 10GbE PCIe Server Adapter" - depends on PCI - help - This driver supports Exar Corp's X3100 Series 10 GbE PCIe - I/O Virtualized Server Adapter. These were originally released from - Neterion, which was later acquired by Exar. So, the adapters might be - labeled as either one, depending on its age. - - More specific information on configuring the driver is in - <file:Documentation/networking/device_drivers/ethernet/neterion/vxge.rst>. - - To compile this driver as a module, choose M here. The module - will be called vxge. - -config VXGE_DEBUG_TRACE_ALL - bool "Enabling All Debug trace statements in driver" - default n - depends on VXGE - help - Say Y here if you want to enabling all the debug trace statements in - the vxge driver. By default only few debug trace statements are - enabled. - endif # NET_VENDOR_NETERION
drivers/net/ethernet/neterion/Makefile +0 -1
@@ -4,4 +4,3 @@ # obj-$(CONFIG_S2IO) += s2io.o -obj-$(CONFIG_VXGE) += vxge/
drivers/net/ethernet/neterion/vxge/Makefile deleted +0 -8
@@ -1,8 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -# -# Makefile for Exar Corp's X3100 Series 10 GbE PCIe I/O -# Virtualized Server Adapter linux driver - -obj-$(CONFIG_VXGE) += vxge.o - -vxge-objs := vxge-config.o vxge-traffic.o vxge-ethtool.o vxge-main.o
drivers/net/ethernet/neterion/vxge/vxge-config.c deleted +0 -5099
2,825 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-config.h deleted +0 -2086
2,086 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-ethtool.c deleted +0 -1154
1,154 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-ethtool.h deleted +0 -48
48 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-main.c deleted +0 -4808
4,808 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-main.h deleted +0 -516
516 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-reg.h deleted +0 -4636
4,636 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-traffic.c deleted +0 -2428
2,428 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-traffic.h deleted +0 -2290
2,290 lines not on this page · raw message
drivers/net/ethernet/neterion/vxge/vxge-version.h deleted +0 -49
49 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.36.1
Part of the diff is not shown here. View the raw message.
Quoted 3 lines · Fri, Jul 01, 2022 at 06:42:34AM CEST, [email protected] wrote:
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
Hmm, I can understand what for driver for HW that is no longer developed, the driver changes might be very minimal. The fact that the code does not change for years does not mean that there are users of this NIC which this patch would break :/
Isn't there some obsoletion scheme globally applied to kernel device support? I would expect something like that.
[culled Cc:]
Quoted 9 lines · Jiri Pirko
Quoted 3 lines · Fri, Jul 01, 2022 at 06:42:34AM CEST, [email protected] wrote:
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
Hmm, I can understand what for driver for HW that is no longer developed, the driver changes might be very minimal. The fact that the code does not change for years does not mean that there are users of this NIC which this patch would break :/
As a "reference datapoint", I'm a user that was affected by the removal of the Mellanox SwitchX-2 driver about a year ago. But that was a bit different since the driver was apparently rather incomplete (I don't know the details, was still messing around to even get things going.)
(FWIW my use case is in giving old hardware a second life, in this case completely throwing away the PowerPC control board from Mellanox SX6000 series switches and replacing it with a new custom CPU board... I might well be the only person interested in that driver.
Quoted 2 lines
Isn't there some obsoletion scheme globally applied to kernel device support? I would expect something like that.
I have the same question - didn't see any such policy but didn't look particularly hard. But would like to avoid putting time into making something work just to have the kernel driver yanked shortly after :)
-David
Quoted 8 lines · Fri, Jul 01, 2022 at 03:17:32PM CEST, [email protected] wrote:
[culled Cc:]
Quoted 5 lines · Jiri Pirko
Quoted 3 lines · Fri, Jul 01, 2022 at 06:42:34AM CEST, [email protected] wrote:
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
Quoted 7 lines
Quoted 4 lines
Hmm, I can understand what for driver for HW that is no longer developed, the driver changes might be very minimal. The fact that the code does not change for years does not mean that there are users of this NIC which this patch would break :/
As a "reference datapoint", I'm a user that was affected by the removal of the Mellanox SwitchX-2 driver about a year ago. But that was a bit
You could not be. There was really no functionality implemented in switchx2 driver. I doubt you used 32x40G port switch with slow-path forwarding through kernel with total max bandwidth of like 1-2G for the whole switch :)
Quoted 17 lines
different since the driver was apparently rather incomplete (I don't know the details, was still messing around to even get things going.)
(FWIW my use case is in giving old hardware a second life, in this case completely throwing away the PowerPC control board from Mellanox SX6000 series switches and replacing it with a new custom CPU board... I might well be the only person interested in that driver.
Quoted 2 lines
Isn't there some obsoletion scheme globally applied to kernel device support? I would expect something like that.
I have the same question - didn't see any such policy but didn't look particularly hard. But would like to avoid putting time into making something work just to have the kernel driver yanked shortly after :)
-David
Quoted 8 lines · Jiri Pirko
Quoted 2 lines · Fri, Jul 01, 2022 at 03:17:32PM CEST, [email protected] wrote:
As a "reference datapoint", I'm a user that was affected by the removal of the Mellanox SwitchX-2 driver about a year ago. But that was a bit
You could not be. There was really no functionality implemented in switchx2 driver. I doubt you used 32x40G port switch with slow-path forwarding through kernel with total max bandwidth of like 1-2G for the whole switch :)
Funny you would mention that, that's exactly as far as I got - on some attempts at least, when I didn't get an initialization failure after a 15 minute reset timer ;D
Jakub Kicinski
maintainerQuoted 4 lines · On Fri, 1 Jul 2022 15:17:32 +0200 David Lamparter wrote:
Quoted 4 lines
Hmm, I can understand what for driver for HW that is no longer developed, the driver changes might be very minimal. The fact that the code does not change for years does not mean that there are users of this NIC which this patch would break :/
Nah, bugs will be discovered. Look at mlx4 or ixgbe, those are similarly old yet we still occasionally get a fix for a 10 year old bug. The only bug report I could find for vxge is RH bugzilla filed likely by RH QA themselves, 11 years ago.
Quoted 5 lines
Quoted 2 lines
Isn't there some obsoletion scheme globally applied to kernel device support? I would expect something like that.
I have the same question - didn't see any such policy but didn't look particularly hard.
I don't know of any one that works, that's the problem. I think previous discussions were about more serious stuff like uAPI.
I don't really care about vxge in particular, I was already looking for something to delete and the bad patch I mention in the commit msg came up. What I'm mostly interested in is getting some experience to inform a deletion policy. We can't come up with one by just talking. I'm hoping to make this a topic for the maintainer's summit as well.
We are pretty open to taking in new drivers, (necessarily) even without users, I think the flip side of that coin has to be that we delete unused stuff. We're not a code storage service.
Here are some facts:
- driver is not actively maintained (Jon did not nack the bad patch)
- driver has no known users (it's unlikely they exist)
- driver is not of great quality (constant stream of bot fixes)
- driver is of significant complexity and needs to be adjusted each time we change core APIs
It's been over a decade of no development, let's delete this code.
If someone complains we can quickly revert the deletion in stable (CCing Greg to keep me honest, I haven't actually talked to him). I'm obviously responsible for the deletion so I'll prepare the revert.
Jakub Kicinski <[email protected]> :
Quoted 3 lines
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
It was used with some success in 2017:
https://bugzilla.kernel.org/show_bug.cgi?id=197881
Quoted 5 lines
Because of the size of this driver there is a nontrivial maintenance cost to keeping this code around, in the last 2 years we're averaging more than 1 change a month. Some of which require nontrivial review effort, see commit
877fe9d49b74("Revert "drivers/net/ethernet/neterion/vxge:
Fix a use-after-free bug invxge-main.c"") for example.
vxge_remove() calls vxge_device_unregister().
vxge_device_unregister() does unregister_netdev() + ... + free_netdev().
vxge_remove() keeps using netdev_priv() pointer... :o/
Imho it is not nontrivial enough that top-level maintainers must handle it but it is just mvho that maintainers handle too much low-value stuff.
Regarding the unused hardware side of the problem, it's a bit sad that there still is no centralized base of interested users for a given piece of hardware in 2022.
Signature · 1 line
Ueimor
Jakub Kicinski
maintainerQuoted 8 lines · On Fri, 1 Jul 2022 19:12:43 +0200 Francois Romieu wrote:
Jakub Kicinski <[email protected]> :
Quoted 3 lines
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
It was used with some success in 2017:
Nice find! Quoting for the list:
vxge.ko can work nicely for kernel version 4.1 (I tried 4.1.44) However, for any version beyond that (I tried 4.4, 4.8, 4.13) the card can be initiated - but when I tried to do some network transfer (for example, ssh) I saw something like....
[Tx queue timeout stack trace follows]
I didn't see any fixes since 2017 so the problem must still be there. Could be just a particular version of FW that's broken, tho.
Quoted 6 lines
Quoted 5 lines
Because of the size of this driver there is a nontrivial maintenance cost to keeping this code around, in the last 2 years we're averaging more than 1 change a month. Some of which require nontrivial review effort, see commit
877fe9d49b74("Revert "drivers/net/ethernet/neterion/vxge:
Fix a use-after-free bug invxge-main.c"") for example.
Quoted 8 lines
vxge_remove()callsvxge_device_unregister().
vxge_device_unregister()doesunregister_netdev()+ ... +free_netdev().
vxge_remove()keeps usingnetdev_priv()pointer... :o/Imho it is not nontrivial enough that top-level maintainers must handle it but it is just mvho that maintainers handle too much low-value stuff.
Ack, this particular bug is just an excuse, it can be fixed.
Quoted 3 lines
Regarding the unused hardware side of the problem, it's a bit sad that there still is no centralized base of interested users for a given piece of hardware in 2022.
100%, I really wish something like that existed. I have a vague memory of Fedora or some other distro collecting HW data. Maybe it died because of privacy issues?
Knowing that stuff gets used would be a great motivation. Handling all the academic / bot patches for stuff I think goes completely unused is weighing down my psyche.
Quoted 2 lines · Jiri Pirko
Isn't there some obsoletion scheme globally applied to kernel device support? I would expect something like that.
The only thing I've found is that stuff gets marked with DEPRECATED in Kconfig.
Having an official CONFIG_DEPRECATED option could be a way to formalise this more, but I'm not sure if that is needed.
Martin
Paolo Abeni
maintainerQuoted 3 lines · Jakub Kicinski
100%, I really wish something like that existed. I have a vague memory of Fedora or some other distro collecting HW data. Maybe it died because of privacy issues?
AFAICS that database still exists and is active:
https://linux-hardware.org/?view=search&vendor=neterion&d=All
It shows no usage at all for the relevant vendor.
On the flip side, it looks like the data points come mostly/exclusively from desktop systems, not very relevant in this specific case.
/P
Jakub Kicinski
maintainerQuoted 5 lines · On Tue, 05 Jul 2022 08:17:24 +0200 Paolo Abeni wrote:
Quoted 3 lines · Jakub Kicinski
100%, I really wish something like that existed. I have a vague memory of Fedora or some other distro collecting HW data. Maybe it died because of privacy issues?
Quoted 8 lines
AFAICS that database still exists and is active:
https://linux-hardware.org/?view=search&vendor=neterion&d=All
It shows no usage at all for the relevant vendor.
On the flip side, it looks like the data points come mostly/exclusively from desktop systems, not very relevant in this specific case.
GTK! There is a whole bunch of old Mellanox NICs reported so I think there is _some_ server coverage. I'm leaning towards applying the patch.
Quoted 10 lines · On Tue, 5 Jul 2022 11:06:34 -0700 Jakub Kicinski <[email protected]> wrote:
Quoted 9 lines · On Tue, 05 Jul 2022 08:17:24 +0200 Paolo Abeni wrote:
Quoted 3 lines · Jakub Kicinski
100%, I really wish something like that existed. I have a vague memory of Fedora or some other distro collecting HW data. Maybe it died because of privacy issues?
AFAICS that database still exists and is active:
https://linux-hardware.org/?view=search&vendor=neterion&d=All
Quoted 7 lines
Quoted 4 lines
It shows no usage at all for the relevant vendor.
On the flip side, it looks like the data points come mostly/exclusively from desktop systems, not very relevant in this specific case.
GTK! There is a whole bunch of old Mellanox NICs reported so I think there is _some_ server coverage. I'm leaning towards applying the patch.
Looks like S2IO became Neterion and then was acquired by Exar in 2010. Then MaxLinear acquired Exar in 2017.
Looks like they dropped out of NIC business and only do switches??
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Thu, 30 Jun 2022 21:42:34 -0700 you wrote:
The last meaningful change to this driver was made by Jon in 2011. As much as we'd like to believe that this is because the code is perfect the chances are nobody is using this hardware.
Because of the size of this driver there is a nontrivial maintenance cost to keeping this code around, in the last 2 years we're averaging more than 1 change a month. Some of which require nontrivial review effort, see commit
877fe9d49b74("Revert "drivers/net/ethernet/neterion/vxge:
Fix a use-after-free bug invxge-main.c"") for example.[...]
Here is the summary with links:
- [net-next] eth: remove neterion/vxge
https://git.kernel.org/netdev/net-next/c/f05643a0f60b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Stephen Hemminger <[email protected]> :
Quoted 12 lines
Quoted 10 lines · On Tue, 5 Jul 2022 11:06:34 -0700 Jakub Kicinski <[email protected]> wrote:
Quoted 9 lines · On Tue, 05 Jul 2022 08:17:24 +0200 Paolo Abeni wrote:
Quoted 3 lines · Jakub Kicinski
100%, I really wish something like that existed. I have a vague memory of Fedora or some other distro collecting HW data. Maybe it died because of privacy issues?
AFAICS that database still exists and is active:
https://linux-hardware.org/?view=search&vendor=neterion&d=AllRC
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
It shows no usage at all for the relevant vendor.
On the flip side, it looks like the data points come mostly/exclusively from desktop systems, not very relevant in this specific case.
GTK! There is a whole bunch of old Mellanox NICs reported so I think there is _some_ server coverage. I'm leaning towards applying the patch.
There are 1182 servers per
https://linux-hardware.org/?view=computers&type=Server
Quoted 3 lines
Looks like S2IO became Neterion and then was acquired by Exar in 2010. Then MaxLinear acquired Exar in 2017.
Looks like they dropped out of NIC business and only do switches??
Maxlinear keeps some archive material around:
https://www.maxlinear.com/Files/Documents/X3100Linux_GeneralInfo-FAQ.pdf
A search on linux-hardware with S2io vendor id from above (17d5) does not find any part.
Patches aside, MARC does not find recent vxge material.
The driver is stable and the systems wherein it is used are (too) stable as well. See for instance:
https://bugzilla.redhat.com/buglist.cgi?bug_status=__all__&content=vxge
Active maintenance seems useless.
Signature · 1 line
Ueimor