Skip to contentSkip to conversation

ASoC: codecs: wsa883x: fix fallthrough error

PATCH In review Tom Rix 2 participants 2 messages Jul 1, 2022

Subsystems (3)
Sound ASoC Qualcomm audio (ASoC) drivers
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 ASoC: codecs: wsa883x: fix fallthrough error

clang build fails with
sound/soc/codecs/wsa883x.c:1207:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
default:

Add the missing break.

Fixes cdb09e623143 ("ASoC: codecs: wsa883x: add control, dapm widgets and map")
Signed-off-by Tom Rix <[email protected]>
---
 sound/soc/codecs/wsa883x.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/wsa883x.c +1 -0
index 40c7d64a9c41..dcd88175b9cd 100644
@@ -1204,6 +1204,7 @@ static int wsa883x_spkr_event(struct snd_soc_dapm_widget *w,
 						      WSA883X_SPKR_PWM_FREQ_F300KHZ);
 			snd_soc_component_write_field(component, WSA883X_DRE_CTL_0,
 						       WSA883X_DRE_PROG_DELAY_MASK, 0x9);
+			break;
 		default:
 			break;
 		}
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 3 lines · Tom Rix

clang build fails with
sound/soc/codecs/wsa883x.c:1207:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
default:

Thanks but I already applied a patch for this from Srinivas.