Skip to contentSkip to conversation

misc: rtsx_usb: set return value in rsp_buf alloc err path

PATCH RESEND New Shuah Khan 1 participant 1 message Jul 1, 2022 Char and misc drivers

lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

PATCH RESEND 1/1 misc: rtsx_usb: set return value in rsp_buf alloc err path

Set return value in rsp_buf alloc error path before going to error handling.

drivers/misc/cardreader/rtsx_usb.c:639:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]

           if (!ucr->rsp_buf)
               ^~~~~~~~~~~~~
   drivers/misc/cardreader/rtsx_usb.c:678:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/misc/cardreader/rtsx_usb.c:639:2: note: remove the 'if' if its condition is always false
           if (!ucr->rsp_buf)
           ^~~~~~~~~~~~~~~~~~
   drivers/misc/cardreader/rtsx_usb.c:622:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
Fixes 3776c7855985 ("misc: rtsx_usb: use separate command and response buffers")

---
Sorry the first attempt had typo in the to list

 drivers/misc/cardreader/rtsx_usb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/misc/cardreader/rtsx_usb.c +3 -1
index 4e2108052509..f150d8769f19 100644
@@ -636,8 +636,10 @@ static int rtsx_usb_probe(struct usb_interface *intf,
 		return -ENOMEM;
 
 	ucr->rsp_buf = kmalloc(IOBUF_SIZE, GFP_KERNEL);
-	if (!ucr->rsp_buf)
+	if (!ucr->rsp_buf) {
+		ret = -ENOMEM;
 		goto out_free_cmd_buf;
+	}
 
 	usb_set_intfdata(intf, ucr);
 
Signature · 1 line
2.34.1