Skip to contentSkip to conversation

statx.2: correctly document STATX_ALL

PATCH RESEND In review Eric Biggers 4 participants 4 messages Jul 5, 2022 – Jul 6, 2022

Subsystems (2)
VFS Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7
lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH RESEND 1/1 statx.2: correctly document STATX_ALL

From: Eric Biggers <[email protected]>

Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"), STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't include any future flags. Update the man page accordingly.

Signed-off-by Eric Biggers <[email protected]>
---
 man2/statx.2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
man2/statx.2 +2 -1
index a8620be6f..561e64f7b 100644
@@ -244,8 +244,9 @@ STATX_SIZE	Want stx_size
 STATX_BLOCKS	Want stx_blocks
 STATX_BASIC_STATS	[All of the above]
 STATX_BTIME	Want stx_btime
+STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
+         	This is deprecated and should not be used.
 STATX_MNT_ID	Want stx_mnt_id (since Linux 5.8)
-STATX_ALL	[All currently available fields]
 .TE
 .in
 .PP

base-commit: 88646725187456fad6f17552e96c50c93bd361dc

Signature · 1 line
2.37.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"), STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't include any future flags. Update the man page accordingly.

Signed-off-by Eric Biggers <[email protected]>
Reviewed-by Andreas Dilger <[email protected]>
Quoted 20 lines

---
man2/statx.2 | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
man2/statx.2 +0 -0
index a8620be6f..561e64f7b 100644
@@ -244,8 +244,9 @@ STATX_SIZE	Want stx_size

STATX_BLOCKS Want stx_blocks
STATX_BASIC_STATS [All of the above]
STATX_BTIME Want stx_btime

man2/statx.2 +2 -0
+STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
+         	This is deprecated and should not be used.

STATX_MNT_ID Want stx_mnt_id (since Linux 5.8)
-STATX_ALL [All currently available fields]
.TE
.in
.PP

Quoted 4 lines

base-commit: 88646725187456fad6f17552e96c50c93bd361dc --
2.37.0

Cheers, Andreas

Reviewed-by on v1 1/1
#2 lore raw
In reply to Eric Biggers
Quoted 7 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"), STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't include any future flags. Update the man page accordingly.

Signed-off-by Eric Biggers <[email protected]>

As the last idiot to trip over this,

Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 24 lines
---
 man2/statx.2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
man2/statx.2 +2 -1
index a8620be6f..561e64f7b 100644
@@ -244,8 +244,9 @@ STATX_SIZE	Want stx_size
 STATX_BLOCKS	Want stx_blocks
 STATX_BASIC_STATS	[All of the above]
 STATX_BTIME	Want stx_btime
+STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
+         	This is deprecated and should not be used.
 STATX_MNT_ID	Want stx_mnt_id (since Linux 5.8)
-STATX_ALL	[All currently available fields]
 .TE
 .in
 .PP

base-commit: 88646725187456fad6f17552e96c50c93bd361dc

Signature · 1 line
2.37.0
#3 lore raw

Hi,

Quoted 8 lines · Darrick J. Wong
Quoted 7 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"), STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't include any future flags. Update the man page accordingly.

Signed-off-by Eric Biggers <[email protected]>

Thanks for the patch! Applied.

Quoted 3 lines

As the last idiot to trip over this,

Reviewed-by Darrick J. Wong <[email protected]>

And thanks for the reviews, Andreas and Darrick, I added both of your tags.

Cheers,

Alex

Quoted 27 lines

--D

Quoted 24 lines
---
  man2/statx.2 | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
man2/statx.2 +2 -1
index a8620be6f..561e64f7b 100644
@@ -244,8 +244,9 @@ STATX_SIZE	Want stx_size
  STATX_BLOCKS	Want stx_blocks
  STATX_BASIC_STATS	[All of the above]
  STATX_BTIME	Want stx_btime
+STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
+         	This is deprecated and should not be used.
  STATX_MNT_ID	Want stx_mnt_id (since Linux 5.8)
-STATX_ALL	[All currently available fields]
  .TE
  .in
  .PP

base-commit: 88646725187456fad6f17552e96c50c93bd361dc

Signature · 1 line
2.37.0
Signature · 2 lines
Alejandro Colomar
<http://www.alejandro-colomar.es/>