cache: release pending rules when chain binding lookup fails
Pablo Neira Ayuso
maintainerPATCH 1/1 cache: release pending rules when chain binding lookup fails
If the implicit chain is not in the cache, release pending rules in ctx->list and report EINTR to let the cache core retry to populate a consistent cache.
Fixes c330152b7f77 ("src: support for implicit chain bindings")
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/cache.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
src/cache.c +10 -1
@@ -847,12 +847,21 @@ static int rule_init_cache(struct netlink_ctx *ctx, struct table *table, chain =chain_binding_lookup (table, rule->handle.chain.name);if (!chain) -return -1 ; + goto err_ctx_list;list_move_tail (&rule->list, &chain->rules); }return ret; + +err_ctx_list: +list_for_each_entry_safe (rule, nrule, &ctx->list, list) { +list_del (&rule->list); +rule_free (rule); + } + errno =EINTR ; + +return -1 ; } static int implicit_chain_cache(struct netlink_ctx *ctx, struct table *table,
Signature · 1 line
2.30.2