drm/msm/dpu: Fix for non-visible planes
PATCH 1/1 drm/msm/dpu: Fix for non-visible planes
From: Rob Clark <[email protected]>
Fixes kms_cursor_crc --run-subtest cursor-offscreen.. when the cursor moves offscreen the plane becomes non-visible, so we need to skip over it in crtc atomic test and mixer setup.
Signed-off-by Rob Clark <[email protected]>
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +6 -0
@@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,if (!state)continue ; +if (!state->visible) +continue ; + pstate =to_dpu_plane_state (state); fb = state->fb;
@@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,if (cnt >=DPU_STAGE_MAX *4 )continue ; +if (!pstate->visible) +continue ; + pstates[cnt].dpu_pstate = dpu_pstate; pstates[cnt].drm_pstate = pstate; pstates[cnt].stage = pstate->normalized_zpos;
Signature · 1 line
2.36.1
Quoted 7 lines · Rob Clark
From: Rob Clark <[email protected]>
Fixes
kms_cursor_crc --run-subtest cursor-offscreen.. when the cursor moves offscreen the plane becomes non-visible, so we need to skip over it in crtc atomic test and mixer setup.Signed-off-by Rob Clark <[email protected]>
Fixes 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reviewed-by Dmitry Baryshkov <[email protected]>
Quoted 28 lines
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +6
-0@@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,if (!state)continue ; +if (!state->visible) +continue ; + pstate =to_dpu_plane_state (state); fb = state->fb;@@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,if (cnt >=DPU_STAGE_MAX *4 )continue ; +if (!pstate->visible) +continue ; + pstates[cnt].dpu_pstate = dpu_pstate; pstates[cnt].drm_pstate = pstate; pstates[cnt].stage = pstate->normalized_zpos;
Signature · 2 lines
With best wishes Dmitry
Quoted 7 lines · Rob Clark
From: Rob Clark <[email protected]>
Fixes
kms_cursor_crc --run-subtest cursor-offscreen.. when the cursor moves offscreen the plane becomes non-visible, so we need to skip over it in crtc atomic test and mixer setup.Signed-off-by Rob Clark <[email protected]>
Reviewed-by Abhinav Kumar <[email protected]>
Will pick up the fixes tag from Dmitry's r-b.
Quoted 28 lines
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +6
-0@@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,if (!state)continue ; +if (!state->visible) +continue ; + pstate =to_dpu_plane_state (state); fb = state->fb;@@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,if (cnt >=DPU_STAGE_MAX *4 )continue ; +if (!pstate->visible) +continue ; + pstates[cnt].dpu_pstate = dpu_pstate; pstates[cnt].drm_pstate = pstate; pstates[cnt].stage = pstate->normalized_zpos;