drm/i915/display: Ensure PSR gets disabled if no encoders in new state
Subsystems (3)
PATCH 1/1 drm/i915/display: Ensure PSR gets disabled if no encoders in new state
Currently PSR is left enabled when all planes are disabled if there is no attached encoder in new state. This seems to be causing FIFO underruns.
Fix this by checking if old and new crtc encoder masks are differing. PSR is disabled for encoders not in new crtc state encoder mask.
--- drivers/gpu/drm/i915/display/intel_psr.c | 72 +++++++++++++++++------- 1 file changed, 51 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +51 -21
@@ -1863,36 +1863,66 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state, struct intel_crtc *crtc) {struct drm_i915_private *i915 =to_i915 (state->base.dev); -const struct intel_crtc_state *crtc_state = -intel_atomic_get_new_crtc_state (state, crtc); +struct intel_crtc_state *new_crtc_state, *old_crtc_state;struct intel_encoder *encoder; +struct intel_dp *intel_dp; +struct intel_psr *psr; +int i;if (!HAS_PSR (i915))return ; -for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, - crtc_state->uapi.encoder_mask) { -struct intel_dp *intel_dp =enc_to_intel_dp (encoder); -struct intel_psr *psr = &intel_dp->psr; -bool needs_to_disable = false; - -mutex_lock (&psr->lock); - +for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, + new_crtc_state, i) {/* -* Reasons to disable: -* - PSR disabled in new state -* - All planes will go inactive -* - Changing between PSR versions +* Check if encoder exists in new state and disable +* psr if it doesn't. Otherwise we will end update +* having all planes disabled and psr enabled which +* seems to be causing problems. */ - needs_to_disable |=intel_crtc_needs_modeset (crtc_state); - needs_to_disable |= !crtc_state->has_psr; - needs_to_disable |= !crtc_state->active_planes; - needs_to_disable |= crtc_state->has_psr2 != psr->psr2_enabled; +if (old_crtc_state->uapi.encoder_mask != new_crtc_state->uapi.encoder_mask) { +for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, + old_crtc_state->uapi.encoder_mask) { + intel_dp =enc_to_intel_dp (encoder); + psr = &intel_dp->psr; -if (psr->enabled && needs_to_disable) -intel_psr_disable_locked (intel_dp); +if (new_crtc_state->uapi.encoder_mask & +drm_encoder_mask (&(encoder)->base)) +continue ; -mutex_unlock (&psr->lock); +mutex_lock (&psr->lock); + +if (psr->enabled) +intel_psr_disable_locked (intel_dp); + +mutex_unlock (&psr->lock); + } + } +for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, + new_crtc_state->uapi.encoder_mask) { +bool needs_to_disable = false; + + intel_dp =enc_to_intel_dp (encoder); + psr = &intel_dp->psr; + +mutex_lock (&psr->lock); + +/* +* Reasons to disable: +* - PSR disabled in new state +* - All planes will go inactive +* - Changing between PSR versions +*/ + needs_to_disable |=intel_crtc_needs_modeset (new_crtc_state); + needs_to_disable |= !new_crtc_state->has_psr; + needs_to_disable |= !new_crtc_state->active_planes; + needs_to_disable |= new_crtc_state->has_psr2 != psr->psr2_enabled; + +if (psr->enabled && needs_to_disable) +intel_psr_disable_locked (intel_dp); + +mutex_unlock (&psr->lock); + } } }
Signature · 1 line
2.25.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Ensure PSR gets disabled if no encoders in new state
== Series Details ==
== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
URL : https://patchwork.freedesktop.org/series/106168/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11862 -> Patchwork_106168v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/index.html
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-cml-u2 fi-bxt-dsi fi-hsw-4200u fi-icl-u2 fi-ctg-p8600
Known issues
------------
Here are the changes found in Patchwork_106168v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_module_load@reload:
- {bat-adln-1}: [DMESG-WARN][1] ([i915#6297]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/bat-adln-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/bat-adln-1/igt@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-4: [DMESG-WARN][3] ([i915#3576]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/bat-adlp-4/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/bat-adlp-4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- {bat-adlp-6}: [DMESG-WARN][5] ([i915#3576]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/bat-adlp-6/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/bat-adlp-6/igt@kms_flip@[email protected]
* igt@vgem_basic@setversion:
- fi-kbl-soraka: [INCOMPLETE][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/fi-kbl-soraka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/fi-kbl-soraka/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
Build changes
-------------
* Linux: CI_DRM_11862 -> Patchwork_106168v1
CI-20190529: 20190529
CI_DRM_11862: ffee806d103b9604db7eb9cd689c098aca1ffa96 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6563: 7d43b49bf10788d4870668f93a800888fc8ab339 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106168v1: ffee806d103b9604db7eb9cd689c098aca1ffa96 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7734dd805b56 drm/i915/display: Ensure PSR gets disabled if no encoders in new state
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Ensure PSR gets disabled if no encoders in new state
In reply to Jouni Högander== Series Details ==
== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
URL : https://patchwork.freedesktop.org/series/106168/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11862_full -> Patchwork_106168v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106168v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_106168v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 13)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106168v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_invalid_mode@[email protected]
Known issues
------------
Here are the changes found in Patchwork_106168v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][2] ([i915#4991])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#4991])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][4] -> [FAIL][5] ([i915#6268])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb3/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb7/igt@[email protected]
* igt@gem_ctx_persistence@engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-snb4/igt@[email protected]
* igt@gem_ctx_persistence@hostile:
- shard-tglb: NOTRUN -> [FAIL][7] ([i915#2410])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@gem_exec_balancer@parallel-balancer:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271]) +26 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-snb4/igt@[email protected]
* igt@gem_exec_endless@dispatch@vecs0:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([i915#3778])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb3/igt@gem_exec_endless@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb1/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl1/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb1/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk9/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@[email protected]
* igt@gem_pxp@create-regular-context-1:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#4270])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@gem_softpin@evict-snoop-interruptible:
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109312])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][23] ([i915#3318])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-apl3/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
- shard-skl: [PASS][26] -> [INCOMPLETE][27] ([i915#4939] / [i915#5129])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl10/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl9/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-glk: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#454])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglb: NOTRUN -> [WARN][31] ([i915#2681]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][32] ([i915#1886])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl10/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#3743])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl9/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +6 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#3886])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#3689]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3886]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#6095]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111615] / [i915#3689])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_chamelium@dp-hpd-after-suspend:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-snb4/igt@[email protected]
* igt@kms_chamelium@dp-hpd-fast:
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk2/igt@[email protected]
* igt@kms_chamelium@hdmi-frame-dump:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +10 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl1/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#1063])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-kbl: NOTRUN -> [TIMEOUT][45] ([i915#1319]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@[email protected]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109274] / [fdo#111825])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][47] -> [FAIL][48] ([i915#2346]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk1/igt@kms_cursor_legacy@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk3/igt@kms_cursor_legacy@[email protected]
- shard-skl: NOTRUN -> [FAIL][49] ([i915#2346]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl9/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109274] / [fdo#111825] / [i915#3637])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][51] -> [FAIL][52] ([i915#79])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl1/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#2122]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl1/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [PASS][55] -> [DMESG-WARN][56] ([i915#180])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl7/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#2672] / [i915#3555])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][58] ([i915#2672]) +6 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#5439])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271]) +100 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl9/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109280] / [fdo#111825]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [PASS][63] -> [FAIL][64] ([i915#1188])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl1/igt@kms_hdr@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl6/igt@kms_hdr@[email protected]
* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109289]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1:
- shard-glk: [PASS][66] -> [FAIL][67] ([i915#1888]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk7/igt@kms_plane_lowres@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk9/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][68] -> [SKIP][69] ([i915#5235]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb3/igt@kms_plane_scaling@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][71] -> [SKIP][72] ([fdo#109642] / [fdo#111068] / [i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb7/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-wait-busy-hang:
- shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271]) +16 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk2/igt@[email protected]
* igt@perf@polling:
- shard-skl: [PASS][76] -> [FAIL][77] ([i915#1542])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl4/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl1/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [PASS][78] -> [FAIL][79] ([i915#5639])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk7/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk5/igt@[email protected]
* igt@perf@polling-small-buf:
- shard-skl: [PASS][80] -> [FAIL][81] ([i915#1722])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl6/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl1/igt@[email protected]
* igt@prime_nv_api@i915_nv_import_twice:
- shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109291])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@prime_nv_api@i915_nv_import_twice.html
* igt@sw_sync@sync_merge_same:
- shard-skl: NOTRUN -> [FAIL][83] ([i915#6140])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl7/igt@sw_sync@sync_merge_same.html
* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl9/igt@[email protected]
* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@[email protected]
* igt@tools_test@sysfs_l3_parity:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271]) +124 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl4/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@gem_busy@close-race:
- shard-snb: [TIMEOUT][87] ([i915#5748]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-snb6/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-snb4/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90] +9 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl7/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [FAIL][91] ([i915#5784]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][93] ([i915#4525]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb3/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [FAIL][95] ([i915#2842]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl7/igt@gem_exec_fair@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][97] ([i915#2849]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb6/igt@gem_exec_fair@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][99] ([i915#118]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk3/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [INCOMPLETE][101] ([i915#3614] / [i915#4939] / [i915#794]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl4/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl1/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [DMESG-WARN][103] ([i915#5566] / [i915#716]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl9/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl10/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [TIMEOUT][105] ([i915#3953]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][107] ([i915#3921]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-snb6/igt@i915_selftest@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-snb7/igt@i915_selftest@[email protected]
- shard-tglb: [DMESG-WARN][109] ([i915#5591]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb3/igt@i915_selftest@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb2/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-apl4/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][113] ([i915#2521]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl4/igt@kms_async_flips@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl1/igt@kms_async_flips@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor@atomic-transitions-varying-size:
- shard-skl: [FAIL][115] -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl3/igt@kms_cursor_legacy@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl4/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1:
- shard-kbl: [FAIL][117] ([i915#2122]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl6/igt@kms_flip@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][119] ([i915#2122]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl5/igt@kms_flip@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_plane@plane-position-covered@pipe-b-planes:
- shard-tglb: [INCOMPLETE][121] -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-tglb8/igt@kms_plane@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-tglb3/igt@kms_plane@[email protected]
* igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-2:
- shard-glk: [FAIL][123] ([i915#1888]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-glk7/igt@kms_plane_lowres@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-glk9/igt@kms_plane_lowres@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][125] ([fdo#109441]) -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][127] ([i915#1888] / [i915#5639]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-skl7/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-skl6/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][129] ([i915#658]) -> [SKIP][130] ([i915#588])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb1/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-iclb: [FAIL][131] ([i915#2684]) -> [WARN][132] ([i915#2684])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb3/igt@i915_pm_rc6_residency@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb6/igt@i915_pm_rc6_residency@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [DMESG-FAIL][133] ([i915#180]) -> [FAIL][134] ([i915#1188])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-kbl1/igt@kms_hdr@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-kbl6/igt@kms_hdr@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][135] ([i915#2920]) -> [SKIP][136] ([i915#658])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb2/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][137] ([fdo#111068] / [i915#658]) -> [SKIP][138] ([i915#2920])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-iclb3/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-apl8/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11862/shard-apl4/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl4/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl6/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/shard-apl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3953]: https://gitlab.freedesktop.org/drm/intel/issues/3953
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4462]: https://gitlab.freedesktop.org/drm/intel/issues/4462
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4904]: https://gitlab.freedesktop.org/drm/intel/issues/4904
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5129]: https://gitlab.freedesktop.org/drm/intel/issues/5129
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5264]: https://gitlab.freedesktop.org/drm/intel/issues/5264
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6141]: https://gitlab.freedesktop.org/drm/intel/issues/6141
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6331]: https://gitlab.freedesktop.org/drm/intel/issues/6331
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
Build changes
-------------
* Linux: CI_DRM_11862 -> Patchwork_106168v1
CI-20190529: 20190529
CI_DRM_11862: ffee806d103b9604db7eb9cd689c098aca1ffa96 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6563: 7d43b49bf10788d4870668f93a800888fc8ab339 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106168v1: ffee806d103b9604db7eb9cd689c098aca1ffa96 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106168v1/index.html
Quoted 95 lines · Jouni Högander
Currently PSR is left enabled when all planes are disabled if there is no attached encoder in new state. This seems to be causing FIFO underruns.
Fix this by checking if old and new crtc encoder masks are differing. PSR is disabled for encoders not in new crtc state encoder mask.
Cc Mika Kahola <[email protected]>Reported-by Stanislav Lisovskiy <[email protected]>Signed-off-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 72 +++++++++++++++++------- 1 file changed, 51 insertions(+), 21 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +43
-21@@ -1863,36 +1863,66 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state, struct intel_crtc *crtc) {struct drm_i915_private *i915 =to_i915 (state->base.dev); -const struct intel_crtc_state *crtc_state = -intel_atomic_get_new_crtc_state (state, crtc); +struct intel_crtc_state *new_crtc_state, *old_crtc_state;struct intel_encoder *encoder; +struct intel_dp *intel_dp; +struct intel_psr *psr; +int i;if (!HAS_PSR (i915))return ; -for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, - crtc_state->uapi.encoder_mask) { -struct intel_dp *intel_dp =enc_to_intel_dp (encoder); -struct intel_psr *psr = &intel_dp->psr; -bool needs_to_disable = false; - -mutex_lock (&psr->lock); - +for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, + new_crtc_state, i) {/* -* Reasons to disable: -* - PSR disabled in new state -* - All planes will go inactive -* - Changing between PSR versions +* Check if encoder exists in new state and disable +* psr if it doesn't. Otherwise we will end update +* having all planes disabled and psr enabled which +* seems to be causing problems. */ - needs_to_disable |=intel_crtc_needs_modeset (crtc_state); - needs_to_disable |= !crtc_state->has_psr; - needs_to_disable |= !crtc_state->active_planes; - needs_to_disable |= crtc_state->has_psr2 != psr->psr2_enabled; +if (old_crtc_state->uapi.encoder_mask != new_crtc_state->uapi.encoder_mask) { +for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, + old_crtc_state->uapi.encoder_mask) { + intel_dp =enc_to_intel_dp (encoder); + psr = &intel_dp->psr; -if (psr->enabled && needs_to_disable) -intel_psr_disable_locked (intel_dp); +if (new_crtc_state->uapi.encoder_mask & +drm_encoder_mask (&(encoder)->base)) +continue ; -mutex_unlock (&psr->lock); +mutex_lock (&psr->lock); + +if (psr->enabled) +intel_psr_disable_locked (intel_dp); + +mutex_unlock (&psr->lock); + } + } +for_each_intel_encoder_mask_with_psr (state->base.dev, encoder, + new_crtc_state->uapi.encoder_mask) { +bool needs_to_disable = false; + + intel_dp =enc_to_intel_dp (encoder); + psr = &intel_dp->psr; + +mutex_lock (&psr->lock); + +/* +* Reasons to disable: +* - PSR disabled in new state +* - All planes will go inactive +* - Changing between PSR versions +*/ + needs_to_disable |=intel_crtc_needs_modeset (new_crtc_state); + needs_to_disable |= !new_crtc_state->has_psr;
drivers/gpu/drm/i915/display/intel_psr.c void intel_psr_pre_plane_update(struct intel_atomic_state *state, · line 1927
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_psr.c +8
-0+ needs_to_disable |= !new_crtc_state->active_planes; + needs_to_disable |= new_crtc_state->has_psr2 != psr->psr2_enabled; + +if (psr->enabled && needs_to_disable) +intel_psr_disable_locked (intel_dp); + +mutex_unlock (&psr->lock); + } } }
Looks correct to me, the only thing that we could probable unite both for_each_intel_encoder_mask_with_psr cycles and also then get rid of if (old_crtc_state->uapi.encoder_mask != new_crtc_state->uapi.encoder_mask) check by doing something like:
old_new_encoder_mask = old_crtc_state->uapi.encoder_mask | new_crtc_state->uapi.encoder_mask;
for_each_intel_encoder_mask_with_psr(state->base.dev, encoder, old_new_encoder_mask) {
bool needs_to_disable = false;
intel_dp = enc_to_intel_dp(encoder);
psr = &intel_dp->psr;
mutex_lock(&psr->lock);
needs_to_disable |= intel_crtc_needs_modeset(new_crtc_state);
needs_to_disable |= !new_crtc_state->has_psr;
needs_to_disable |= !new_crtc_state->active_planes;
needs_to_disable |= new_crtc_state->has_psr2 != psr->psr2_enabled;
/* Check if this encoder isn't present in new mask */
needs_to_disable |= !(new_crtc_state->uapi.encoder_mask & drm_encoder_mask(&(encoder)->base));
if (psr->enabled && needs_to_disable)
intel_psr_disable_locked(intel_dp);
mutex_unlock(&psr_lock);
}So basically we make non-presence of the encoder in new mask to be just one more check for needs_to_disable and have a single place where we turn it off..
Stan
Quoted 4 lines
Signature · 2 lines
-- 2.25.1