ASoC: SOF: ipc3-topology: Prevent double freeing of ipc_control_data via load_bytes
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 1/1 ASoC: SOF: ipc3-topology: Prevent double freeing of ipc_control_data via load_bytes
We have sanity checks for byte controls and if any of the fail the locally allocated scontrol->ipc_control_data is freed up, but not set to NULL.
On a rollback path of the error the higher level code will also try to free the scontrol->ipc_control_data which will eventually going to lead to memory corruption as double freeing memory is not a good thing.
--- sound/soc/sof/ipc3-topology.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/sof/ipc3-topology.c +1 -0
@@ -1644,6 +1644,7 @@ static int sof_ipc3_control_load_bytes(struct snd_sof_dev *sdev, struct snd_sof_return 0 ; err:kfree (scontrol->ipc_control_data); + scontrol->ipc_control_data =NULL ;return ret; }
Signature · 1 line
2.37.0
Mark Brown
maintainerQuoted 8 lines · Peter Ujfalusi
We have sanity checks for byte controls and if any of the fail the locally allocated
scontrol->ipc_control_datais freed up, but not set to NULL.On a rollback path of the error the higher level code will also try to free the
scontrol->ipc_control_datawhich will eventually going to lead to memory corruption as double freeing memory is not a good thing.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: ipc3-topology: Prevent double freeing of ipc_control_data via load_bytes
commit: d5bd47f3ca124058a8e87eae4508afeda2132611
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark