PCI/ASPM: Should not report ASPM support to BIOS if FADT indicates ASPM is unsupported
PATCH 1/1 PCI/ASPM: Should not report ASPM support to BIOS if FADT indicates ASPM is unsupported
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)
drivers/pci/pcie/aspm.c +1 -0
@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false; } }
Signature · 1 line
2.20.1
[+cc Kai-Heng, Vidya, who also have ASPM patches in flight]
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
Can you elaborate on the connection between the FADT ASPM bit and the AER logs above?
What problem are we solving here? A single corrected error being logged? An infinite stream of errors? A device that doesn't work at all?
We don't need the dmesg timestamps unless they contribute to understanding the problem. I don't think they do in this case.
Quoted 10 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +0
-0
drivers/pci/pcie/aspm.c void pcie_no_aspm(void) · line 1362
Quoted 4 lines
drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false;
This makes pcie_no_aspm() work the same as booting with "pcie_aspm=off". That might be reasonable.
I do wonder why we need both "aspm_disabled" and "aspm_support_enabled". And I wonder why we need to set "aspm_policy" when we're disabling ASPM. But those aren't really connected to your change here.
Quoted 8 lines
drivers/pci/pcie/aspm.c +0
-0} }Signature · 1 line
2.20.1
[+Cc Matthew]
Quoted 13 lines · Bjorn Helgaas
[+cc Kai-Heng, Vidya, who also have ASPM patches in flight]
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
Quoted 6 lines
Can you elaborate on the connection between the FADT ASPM bit and the AER logs above?
What problem are we solving here? A single corrected error being logged? An infinite stream of errors? A device that doesn't work at all?
Agree, what's the real symptom of the issue?
Quoted 3 lines
We don't need the dmesg timestamps unless they contribute to understanding the problem. I don't think they do in this case.
According to commit 387d37577fdd ("PCI: Don't clear ASPM bits when the FADT declares it's unsupported"), the bit means "just use the ASPM bits handed over by BIOS".
However, I do wonder why both drivers/pci/pci-acpi.c and drivers/acpi/pci_root.c are doing the ACPI_FADT_NO_ASPM check, maybe one of them should be removed?
Quoted 19 lines
Quoted 11 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +0
-0drivers/pci/pcie/aspm.c void pcie_no_aspm(void) · line 1362
Quoted 4 lines
drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false;This makes
pcie_no_aspm()work the same as booting with "pcie_aspm=off". That might be reasonable.
Quoted 4 lines
I do wonder why we need both "
aspm_disabled" and "aspm_support_enabled". And I wonder why we need to set "aspm_policy" when we're disabling ASPM. But those aren't really connected to your change here.
From what I can understand "aspm_disabled" means "don't touch ASPM left by BIOS", and "aspm_support_enabled" means "whether ASPM is disabled via command line".
There seems to be some overlaps though.
Kai-Heng
Quoted 9 lines
Quoted 9 lines
drivers/pci/pcie/aspm.c +0
-1} } --2.20.1
Quoted 2 lines · Kai-Heng Feng
According to commit
387d37577fdd("PCI: Don't clear ASPM bits when the FADT declares it's unsupported"), the bit means "just use the ASPM
Yes, the assumption is that if the BIOS set up ASPM but FADT indicates it's unsupported, just trust that the BIOS did the right thing and don't interfere. It's been a long time, but when we were clearing the ASPM bits in response to this FADT setting, a bunch of machines suddenly started consuming a lot more power than when running Windows.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · Manyi Li
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245
Hmm. The only case where changing aspm_support_enabled to false should matter is in pcie_aspm_init_link_state(), where it looks like we'll potentially rewrite some registers even if aspm_disabled is true. I think in theory we shouldn't actually modify anything as a result, and the lspcis from the bug don't show any ASPM values having changed, but I don't trust Realtek hardware in the general case so maybe it gets upset here? If the proposed patch is to just set aspm_support_enabled to false when we see the FADT bit set then I think this is fine.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 18 lines · Manyi Li
Quoted 5 lines · Matthew Garrett
Quoted 2 lines · Manyi Li
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Quoted 9 lines
Hmm. The only case where changing
aspm_support_enabledto false should matter is inpcie_aspm_init_link_state(), where it looks like we'll potentially rewrite some registers even ifaspm_disabledis true. I think in theory we shouldn't actually modify anything as a result, and the lspcis from the bug don't show any ASPM values having changed, but I don't trust Realtek hardware in the general case so maybe it gets upset here? If the proposed patch is to just setaspm_support_enabledto false when we see the FADT bit set then I think this is fine.
Quoted 6 lines
"
aspm_support_enabled" alse be used incalculate_support():
if (pcie_aspm_support_enabled())support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT;When set
OSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORT, cause this AER issue. I want don't setOSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORTwhen we see the FADT bit set.
Oh hm. Are you sure it's the OSC call that breaks it? I have some recollection that I verified the behaviour of Windows here, but it's been over 10 years since I touched this so I could well be wrong. I can try to set up a test env to verify the behaviour of Windows when it comes to _OSC if the FADT says ASPM is unsupported.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Rafael J. Wysocki
maintainerQuoted 57 lines · Manyi Li
Quoted 19 lines · Matthew Garrett
Quoted 18 lines · Manyi Li
Quoted 14 lines · Matthew Garrett
Quoted 2 lines · Manyi Li
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Hmm. The only case where changing
aspm_support_enabledto false should matter is inpcie_aspm_init_link_state(), where it looks like we'll potentially rewrite some registers even ifaspm_disabledis true. I think in theory we shouldn't actually modify anything as a result, and the lspcis from the bug don't show any ASPM values having changed, but I don't trust Realtek hardware in the general case so maybe it gets upset here? If the proposed patch is to just setaspm_support_enabledto false when we see the FADT bit set then I think this is fine.Quoted 8 lines
Quoted 6 lines
"
aspm_support_enabled" alse be used incalculate_support():
if (pcie_aspm_support_enabled())support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT;When set
OSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORT, cause this AER issue. I want don't setOSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORTwhen we see the FADT bit set.Oh hm. Are you sure it's the OSC call that breaks it? I have some
I don't sure.
Quoted 5 lines
recollection that I verified the behaviour of Windows here, but it's been over 10 years since I touched this so I could well be wrong. I can try to set up a test env to verify the behaviour of Windows when it comes to
_OSCif the FADT says ASPM is unsupported.but, I did a test,this modification also solves the problem:
drivers/acpi/pci_root.c +2
-2@@ -494,8 +494,8 @@ static u32 calculate_support(void) support |=OSC_PCI_HPX_TYPE_3_SUPPORT ;if (pci_ext_cfg_avail ()) support |=OSC_PCI_EXT_CONFIG_SUPPORT ; -if (pcie_aspm_support_enabled ()) - support |=OSC_PCI_ASPM_SUPPORT |OSC_PCI_CLOCK_PM_SUPPORT ; +// if (pcie_aspm_support_enabled()) +// support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT; if (pci_msi_enabled ()) support |=OSC_PCI_MSI_SUPPORT ;if (IS_ENABLED (CONFIG_PCIE_EDR ))
Quoted 6 lines
This issue occur in the Notebook: ASUSTeK COMPUTER INC. X456UJ (ASUS-NotebookSKU) Notebook
log "AER: Corrected error received: 0000:00:1c.5" is in the device:
00:1c.5 PCI bridge [0604]: Intel Corporation Sunrise Point-LP PCI Express Root Port #6 [8086:9d15] (rev f1)
So it looks like the BIOS sets ACPI_FADT_NO_ASPM and then happily grants control of ASPM via _OSC. That's somewhat contradictory.
I would rather look at adjusting pcie_aspm_sanity_check() to this case instead of wholesale changing the way _OSC is handled at the host bridge level.
Rafael J. Wysocki
maintainerQuoted 69 lines · Rafael J. Wysocki
Quoted 57 lines · Manyi Li
Quoted 19 lines · Matthew Garrett
Quoted 18 lines · Manyi Li
Quoted 14 lines · Matthew Garrett
Quoted 2 lines · Manyi Li
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Hmm. The only case where changing
aspm_support_enabledto false should matter is inpcie_aspm_init_link_state(), where it looks like we'll potentially rewrite some registers even ifaspm_disabledis true. I think in theory we shouldn't actually modify anything as a result, and the lspcis from the bug don't show any ASPM values having changed, but I don't trust Realtek hardware in the general case so maybe it gets upset here? If the proposed patch is to just setaspm_support_enabledto false when we see the FADT bit set then I think this is fine.Quoted 8 lines
Quoted 6 lines
"
aspm_support_enabled" alse be used incalculate_support():
if (pcie_aspm_support_enabled())support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT;When set
OSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORT, cause this AER issue. I want don't setOSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORTwhen we see the FADT bit set.Oh hm. Are you sure it's the OSC call that breaks it? I have some
I don't sure.
Quoted 5 lines
recollection that I verified the behaviour of Windows here, but it's been over 10 years since I touched this so I could well be wrong. I can try to set up a test env to verify the behaviour of Windows when it comes to
_OSCif the FADT says ASPM is unsupported.but, I did a test,this modification also solves the problem:
drivers/acpi/pci_root.c +2
-2@@ -494,8 +494,8 @@ static u32 calculate_support(void) support |=OSC_PCI_HPX_TYPE_3_SUPPORT ;if (pci_ext_cfg_avail ()) support |=OSC_PCI_EXT_CONFIG_SUPPORT ; -if (pcie_aspm_support_enabled ()) - support |=OSC_PCI_ASPM_SUPPORT |OSC_PCI_CLOCK_PM_SUPPORT ; +// if (pcie_aspm_support_enabled()) +// support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT; if (pci_msi_enabled ()) support |=OSC_PCI_MSI_SUPPORT ;if (IS_ENABLED (CONFIG_PCIE_EDR ))Quoted 6 lines
This issue occur in the Notebook: ASUSTeK COMPUTER INC. X456UJ (ASUS-NotebookSKU) Notebook
log "AER: Corrected error received: 0000:00:1c.5" is in the device:
00:1c.5 PCI bridge [0604]: Intel Corporation Sunrise Point-LP PCI Express Root Port #6 [8086:9d15] (rev f1)So it looks like the BIOS sets
ACPI_FADT_NO_ASPMand then happily grants control of ASPM via_OSC. That's somewhat contradictory.
Quoted 3 lines
I would rather look at adjusting
pcie_aspm_sanity_check()to this case instead of wholesale changing the way_OSCis handled at the host bridge level.
Actually, if ACPI_FADT_NO_ASPM is set in the FADT, aspm_disabled should be set already when negotiate_os_control() runs?
Can you please check if this is the case on the affected system?
In that case, negotiate_os_control() doesn't need to set *no_aspm, because it only causes pcie_no_aspm() to be called, but it should have been called already.
Manyi, FYI, your emails aren't making it to the linux-pci list (or to me), so I'm missing most of this conversation.
If you look at the lore archive:
https://lore.kernel.org/all/[email protected]/
you'll see all the message-ids that are not found.
Maybe you're sending HTML or something else vger doesn't like?
http://vger.kernel.org/majordomo-info.html#taboo
Quoted 29 lines · Matthew Garrett
Quoted 16 lines · Manyi Li
Quoted 5 lines · Matthew Garrett
Quoted 2 lines · Manyi Li
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Quoted 9 lines
Hmm. The only case where changing
aspm_support_enabledto false should matter is inpcie_aspm_init_link_state(), where it looks like we'll potentially rewrite some registers even ifaspm_disabledis true. I think in theory we shouldn't actually modify anything as a result, and the lspcis from the bug don't show any ASPM values having changed, but I don't trust Realtek hardware in the general case so maybe it gets upset here? If the proposed patch is to just setaspm_support_enabledto false when we see the FADT bit set then I think this is fine.Quoted 6 lines
"
aspm_support_enabled" alse be used incalculate_support():
if (pcie_aspm_support_enabled())support |= OSC_PCI_ASPM_SUPPORT | OSC_PCI_CLOCK_PM_SUPPORT;When set
OSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORT, cause this AER issue. I want don't setOSC_PCI_ASPM_SUPPORT|OSC_PCI_CLOCK_PM_SUPPORTwhen we see the FADT bit set.Oh hm. Are you sure it's the OSC call that breaks it? I have some recollection that I verified the behaviour of Windows here, but it's been over 10 years since I touched this so I could well be wrong. I can try to set up a test env to verify the behaviour of Windows when it comes to
_OSCif the FADT says ASPM is unsupported.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Rafael J. Wysocki
maintainerQuoted 26 lines · Manyi Li
Quoted 18 lines · Kai-Heng Feng
[+Cc Matthew]
Quoted 15 lines · Bjorn Helgaas
[+cc Kai-Heng, Vidya, who also have ASPM patches in flight]
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5Can you elaborate on the connection between the FADT ASPM bit and the AER logs above?
Sorry,I don't know about that.
Quoted 1 line
Quoted 1 line
Quoted 20 lines
Quoted 5 lines
Quoted 3 lines
What problem are we solving here? A single corrected error being logged? An infinite stream of errors? A device that doesn't work at all?
Agree, what's the real symptom of the issue?
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Quoted 11 lines
Quoted 4 lines
We don't need the dmesg timestamps unless they contribute to understanding the problem. I don't think they do in this case.
According to commit
387d37577fdd("PCI: Don't clear ASPM bits when the FADT declares it's unsupported"), the bit means "just use the ASPM bits handed over by BIOS".However, I do wonder why both
drivers/pci/pci-acpi.canddrivers/acpi/pci_root.care doing theACPI_FADT_NO_ASPMcheck,
Because pci_root.c doesn't read aspm_disabled.
Quoted 1 line
Quoted 1 line
maybe one of them should be removed?
Arguably, pci_root.c could look at aspm_disabled instead of looking at the FADT flag directly.
Quoted 9 lines
I think duplicate work has been done, but comment in
drivers/acpi/pci_root.cis
* We want to disable ASPM here, butaspm_disabled
* needs to remain in its state from boot so that we
* properly handle PCIe 1.1 devices. So we set this
* flag here, to defer the action until after the ACPI
* root scan.I don't understand this logic.
This is about the case after failing acpi_pci_osc_control_set() and generally we need to defer setting aspm_disabled because of pcie_aspm_sanity_check().
Quoted 25 lines
Quoted 25 lines
Quoted 24 lines
Quoted 12 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +0
-0drivers/pci/pcie/aspm.c void pcie_no_aspm(void) · line 1362
Quoted 4 lines
drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false;This makes
pcie_no_aspm()work the same as booting with "pcie_aspm=off". That might be reasonable.I do wonder why we need both "
aspm_disabled" and "aspm_support_enabled". And I wonder why we need to set "aspm_policy" when we're disabling ASPM. But those aren't really connected to your change here.
Quoted 8 lines
Quoted 4 lines
From what I can understand "
aspm_disabled" means "don't touch ASPM
left by BIOS", and "aspm_support_enabled" means "whether ASPM is disabled via command line".
There seems to be some overlaps though.According to commit
8b8bae901ce23("PCI/ACPI: Report ASPM support to BIOS if not disabled from command line"), "aspm_support_enabled" means whether or not report ASPM support to the BIOS through_OSC.
Right.
Rafael J. Wysocki
maintainerQuoted 42 lines · Rafael J. Wysocki
Quoted 40 lines · Manyi Li
Quoted 18 lines · Kai-Heng Feng
[+Cc Matthew]
Quoted 15 lines · Bjorn Helgaas
[+cc Kai-Heng, Vidya, who also have ASPM patches in flight]
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5Can you elaborate on the connection between the FADT ASPM bit and the AER logs above?
Sorry,I don't know about that.
Quoted 6 lines
Quoted 4 lines
What problem are we solving here? A single corrected error being logged? An infinite stream of errors? A device that doesn't work at all?
Agree, what's the real symptom of the issue?
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Quoted 5 lines
Quoted 4 lines
We don't need the dmesg timestamps unless they contribute to understanding the problem. I don't think they do in this case.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
According to commit
387d37577fdd("PCI: Don't clear ASPM bits when the FADT declares it's unsupported"), the bit means "just use the ASPM bits handed over by BIOS".However, I do wonder why both
drivers/pci/pci-acpi.canddrivers/acpi/pci_root.care doing theACPI_FADT_NO_ASPMcheck,Because
pci_root.cdoesn't readaspm_disabled.
I've recalled a bit in the meantime.
First off, ACPI_FADT_NO_ASPM forbids the OS from enabling ASPM control (quite literally). It doesn't mean that the OS should not enumerate ASPM and it doesn't mean that it should not report ASPM support to the firmware via _OSC. Moreover, there are (or at least there were) systems where the firmware expected ASPM support to be reported via _OSC anyway (see commit 8b8bae901ce2 PCI/ACPI: Report ASPM support to BIOS if not disabled from command line).
Thus, if ASPM is not disabled from command line, it would be consistent to carry out the _OSC negotiation as usual regardless of ACPI_FADT_NO_ASPM and then handle the case in which it is set in the same way as the case in which the firmware doesn't grant the kernel control of some PCIe features. Does this sound reasonable?
If it does, I think that ASPM should be enumerated regardless of ACPI_FADT_NO_ASPM, but we need to ensure that its configuration is not changed in any way if ACPI_FADT_NO_ASPM is set and I'm not sure if that is the case now.
Of course, the same needs to happen when the kernel doesn't get full control over PCIe features via _OSC, but AFAICS that case is handled in the same way as the above already.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
maybe one of them should be removed?
Arguably,
pci_root.ccould look ataspm_disabledinstead of looking at the FADT flag directly.
Second, if the former does sound reasonable, I'd rather avoid setting aspm_disabled from drivers/pci/pci-acpi.c upfront when ACPI_FADT_NO_ASPM is set, because doing that is not consistent with the above.
Now, there may be BIOSes that don't expect to be informed of the OS support for ASPM via _OSC if ACPI_FADT_NO_ASPM is set, and the question is what to do with them. They clearly are at odds with the BIOSes that do expect that to happen (mentioned above), so honestly I'm not sure.
Quoted 49 lines
Quoted 9 lines
I think duplicate work has been done, but comment in
drivers/acpi/pci_root.cis
* We want to disable ASPM here, butaspm_disabled
* needs to remain in its state from boot so that we
* properly handle PCIe 1.1 devices. So we set this
* flag here, to defer the action until after the ACPI
* root scan.I don't understand this logic.
This is about the case after failing
acpi_pci_osc_control_set()and generally we need to defer settingaspm_disabledbecause ofpcie_aspm_sanity_check().Quoted 25 lines
Quoted 25 lines
Quoted 24 lines
Quoted 12 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +0
-0drivers/pci/pcie/aspm.c void pcie_no_aspm(void) · line 1362
Quoted 4 lines
drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false;This makes
pcie_no_aspm()work the same as booting with "pcie_aspm=off". That might be reasonable.I do wonder why we need both "
aspm_disabled" and "aspm_support_enabled". And I wonder why we need to set "aspm_policy" when we're disabling ASPM. But those aren't really connected to your change here.Quoted 8 lines
Quoted 4 lines
From what I can understand "
aspm_disabled" means "don't touch ASPM
left by BIOS", and "aspm_support_enabled" means "whether ASPM is disabled via command line".
There seems to be some overlaps though.According to commit
8b8bae901ce23("PCI/ACPI: Report ASPM support to BIOS if not disabled from command line"), "aspm_support_enabled" means whether or not report ASPM support to the BIOS through_OSC.Right.
Quoted 62 lines · Rafael J. Wysocki
Quoted 42 lines · Rafael J. Wysocki
Quoted 40 lines · Manyi Li
Quoted 18 lines · Kai-Heng Feng
[+Cc Matthew]
Quoted 15 lines · Bjorn Helgaas
[+cc Kai-Heng, Vidya, who also have ASPM patches in flight]
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5Can you elaborate on the connection between the FADT ASPM bit and the AER logs above?
Sorry,I don't know about that.
Quoted 6 lines
Quoted 4 lines
What problem are we solving here? A single corrected error being logged? An infinite stream of errors? A device that doesn't work at all?
Agree, what's the real symptom of the issue?
Please see the details of this issus:
https://bugzilla.kernel.org/show_bug.cgi?id=216245Quoted 5 lines
Quoted 4 lines
We don't need the dmesg timestamps unless they contribute to understanding the problem. I don't think they do in this case.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
According to commit
387d37577fdd("PCI: Don't clear ASPM bits when the FADT declares it's unsupported"), the bit means "just use the ASPM bits handed over by BIOS".However, I do wonder why both
drivers/pci/pci-acpi.canddrivers/acpi/pci_root.care doing theACPI_FADT_NO_ASPMcheck,Because
pci_root.cdoesn't readaspm_disabled.I've recalled a bit in the meantime.
First off,
ACPI_FADT_NO_ASPMforbids the OS from enabling ASPM control (quite literally). It doesn't mean that the OS should not enumerate ASPM and it doesn't mean that it should not report ASPM support to the firmware via_OSC. Moreover, there are (or at least there were) systems where the firmware expected ASPM support to be reported via_OSCanyway (see commit8b8bae901ce2PCI/ACPI: Report ASPM support to BIOS if not disabled from command line).
Quoted 5 lines
Thus, if ASPM is not disabled from command line, it would be consistent to carry out the
_OSCnegotiation as usual regardless ofACPI_FADT_NO_ASPMand then handle the case in which it is set in the same way as the case in which the firmware doesn't grant the kernel control of some PCIe features. Does this sound reasonable
This sound reasonable.
Quoted 20 lines
If it does, I think that ASPM should be enumerated regardless of
ACPI_FADT_NO_ASPM, but we need to ensure that its configuration is not changed in any way ifACPI_FADT_NO_ASPMis set and I'm not sure if that is the case now.Of course, the same needs to happen when the kernel doesn't get full control over PCIe features via
_OSC, but AFAICS that case is handled in the same way as the above already.Quoted 4 lines
Quoted 1 line
Quoted 1 line
maybe one of them should be removed?
Arguably,
pci_root.ccould look ataspm_disabledinstead of looking at the FADT flag directly.Second, if the former does sound reasonable, I'd rather avoid setting
aspm_disabledfromdrivers/pci/pci-acpi.cupfront whenACPI_FADT_NO_ASPMis set, because doing that is not consistent with the above.
Quoted 5 lines
Now, there may be BIOSes that don't expect to be informed of the OS support for ASPM via
_OSCifACPI_FADT_NO_ASPMis set, and the question is what to do with them. They clearly are at odds with the BIOSes that do expect that to happen (mentioned above), so honestly I'm not sure.
I'm not sure my issues is caused by report ASPM support to the firmware via _OSC.My issues is the same as this link:
https://groups.google.com/g/fa.linux.kernel/c/0uz8Nr_NVOI
Links to other discussions on this issue:
https://lore.kernel.org/all/20151229155822.GA17321@localhost/T/#u
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1521173
Quoted 51 lines
Quoted 50 lines
Quoted 10 lines
I think duplicate work has been done, but comment in
drivers/acpi/pci_root.cis
* We want to disable ASPM here, butaspm_disabled
* needs to remain in its state from boot so that we
* properly handle PCIe 1.1 devices. So we set this
* flag here, to defer the action until after the ACPI
* root scan.I don't understand this logic.
This is about the case after failing
acpi_pci_osc_control_set()and generally we need to defer settingaspm_disabledbecause ofpcie_aspm_sanity_check().Quoted 25 lines
Quoted 25 lines
Quoted 24 lines
Quoted 12 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +0
-0drivers/pci/pcie/aspm.c void pcie_no_aspm(void) · line 1362
Quoted 4 lines
drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false;This makes
pcie_no_aspm()work the same as booting with "pcie_aspm=off". That might be reasonable.I do wonder why we need both "
aspm_disabled" and "aspm_support_enabled". And I wonder why we need to set "aspm_policy" when we're disabling ASPM. But those aren't really connected to your change here.Quoted 8 lines
Quoted 4 lines
From what I can understand "
aspm_disabled" means "don't touch ASPM
left by BIOS", and "aspm_support_enabled" means "whether ASPM is disabled via command line".
There seems to be some overlaps though.According to commit
8b8bae901ce23("PCI/ACPI: Report ASPM support to BIOS if not disabled from command line"), "aspm_support_enabled" means whether or not report ASPM support to the BIOS through_OSC.Right.
Signature · 1 line
Manyi Li
Subject line should say what the patch *does*, not what *should* happen.
Quoted 8 lines · Manyi Li
Startup log of ASUSTeK X456UJ Notebook show:
[ 0.130563] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 48.092472] pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID) [ 48.092479] pcieport 0000:00:1c.5: device [8086:9d15] error status/mask=00000001/00002000 [ 48.092481] pcieport 0000:00:1c.5: [ 0] RxErr [ 48.092490] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5 [ 48.092504] pcieport 0000:00:1c.5: AER: can't find device of ID00e5 [ 48.092506] pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
No need for timestamps in commit log because they're not relevant to this issue. Please use quote style, i.e., blank line before and after the quote and indent the quote two spaces:
Startup log of ... shows:
ACPI FADT declares the system doesn't support PCIe ASPM, so disable it
...
pcieport 0000:00:1c.5: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
Can you please open a report at https://bugzilla.kernel.org and attach the complete dmesg log and the complete "sudo lspci -vv" output before and after this patch? Then include the bugzilla URL in the commit log.
I assume the patch prevents the RxErr from being reported, but I'd like to know why, or at least have a plausible explanation of how enabling ASPM might lead to a Receiver Error.
I'd also like to know why the "can't find device of ID00e5" happens.
Since it's not obvious from the patch, mention that "reporting ASPM support to BIOS" happens via the _OSC Support field.
Quoted 22 lines
Signed-off-by Manyi Li <[email protected]>--- drivers/pci/pcie/aspm.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/pcie/aspm.c +1
-0@@ -1359,6 +1359,7 @@ void pcie_no_aspm(void)if (!aspm_force) { aspm_policy =POLICY_DEFAULT ; aspm_disabled =1 ; + aspm_support_enabled = false; } }Signature · 1 line
2.20.1