mm/damon/lru_sort: fix potential memory leak in damon_lru_sort_init()
Subsystems (2)
SeongJae Park
maintainerPATCH 1/1 mm/damon/lru_sort: fix potential memory leak in damon_lru_sort_init()
'damon_lru_sort_init()' returns an error when 'damon_select_ops()' fails without freeing 'ctx' which allocated before. This commit fixes the potential memory leak by freeing 'ctx' under the situation.
Commit 40e983cca927 ("mm/damon: introduce DAMON-based LRU-lists Sorting"), which caused the problem is not in the mainline but mm-stable. Please meld this into the commit.
Fixes 40e983cca927 ("mm/damon: introduce DAMON-based LRU-lists Sorting")
Signed-off-by SeongJae Park <[email protected]>
--- mm/damon/lru_sort.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mm/damon/lru_sort.c +3 -1
@@ -524,8 +524,10 @@ static int __init damon_lru_sort_init(void)if (!ctx)return -ENOMEM ; -if (damon_select_ops (ctx,DAMON_OPS_PADDR )) +if (damon_select_ops (ctx,DAMON_OPS_PADDR )) { +damon_destroy_ctx (ctx);return -EINVAL ; + } ctx->callback.after_wmarks_check = damon_lru_sort_after_wmarks_check; ctx->callback.after_aggregation = damon_lru_sort_after_aggregation;
Signature · 1 line
2.25.1