arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU
Subsystems (2)
PATCH 1/1 arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU
Custom ARM version of pci_remap_iospace() is implemented only for MMU kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU.
See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/
---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/
If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
--- arch/arm/include/asm/io.h | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/include/asm/io.h +2 -0
@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);static inline void pci_ioremap_set_mem_type (int mem_type) {}#endif +#ifdef CONFIG_MMU struct resource ;#define pci_remap_iospace pci_remap_iospaceint pci_remap_iospace (const struct resource *res,phys_addr_t phys_addr); +#endif /* * PCI configuration space mapping function.
Signature · 1 line
2.20.1
Russell King (Oracle)
maintainerQuoted 19 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
Quoted 8 lines
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
It needs to be sent to the patch system to be merged, which has been the process with 32-bit ARM for getting on the last quarter of a century.
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
[+cc linux-pci, update Lorenzo's email addr]
Hi Pali,
Thanks for cc'ing me. I think your previous notes didn't include linux-pci or me, so I missed them.
It looks like bc02973a06a6 was merged via the PCI tree for v5.17 [1], so we should probably merge the fix the same way.
Russell, let me know if you object. Otherwise, I put it on pci/misc for v5.20.
[1] https://lore.kernel.org/r/20220114155608.GA557997(a)bhelgaas
Quoted 56 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
--- arch/arm/include/asm/io.h | 2 ++ 1 file changed, 2 insertions(+)arch/arm/include/asm/io.h +2
-0@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);static inline void pci_ioremap_set_mem_type (int mem_type) {}#endif +#ifdef CONFIG_MMU struct resource ;#define pci_remap_iospace pci_remap_iospaceint pci_remap_iospace (const struct resource *res,phys_addr_t phys_addr); +#endif /* * PCI configuration space mapping function. Signature · 7 lines
2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel(a)lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 20 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
Quoted 6 lines
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/
Are you sure this still happens in mainline kernels? Since commit 2f618d5ef5dd ("ARM: remove support for NOMMU ARMv4/v5") it should no longer be possible to disable the MMU in any Arm machines other than the Cortex-M based ones, which do not support PCI.
Arnd
Quoted 28 lines · On Thursday 14 July 2022 22:19:51 Arnd Bergmann wrote:
Quoted 20 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
Quoted 6 lines
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/
Quoted 6 lines
Are you sure this still happens in mainline kernels? Since commit
2f618d5ef5dd("ARM: remove support for NOMMU ARMv4/v5") it should no longer be possible to disable the MMU in any Arm machines other than the Cortex-M based ones, which do not support PCI.Arnd
I do not know, it it bot who is complaining.
Quoted 26 lines · On Thursday 14 July 2022 20:48:15 Russell King (Oracle) wrote:
Quoted 25 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/
Quoted 12 lines
Quoted 2 lines
If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
It needs to be sent to the patch system to be merged, which has been the process with 32-bit ARM for getting on the last quarter of a century.
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
I do not need this patch. It is bot who is complaining. So if you do neither, then please STOP sending me these emails.
Quoted 6 lines · On Thursday 14 July 2022 15:04:43 Bjorn Helgaas wrote:
[+cc linux-pci, update Lorenzo's email addr]
Hi Pali,
Thanks for cc'ing me. I think your previous notes didn't include linux-pci or me, so I missed them.
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
Quoted 65 lines
It looks like
bc02973a06a6was merged via the PCI tree for v5.17 [1], so we should probably merge the fix the same way.Russell, let me know if you object. Otherwise, I put it on pci/misc for v5.20.
[1] https://lore.kernel.org/r/20220114155608.GA557997(a)bhelgaas
Quoted 56 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
--- arch/arm/include/asm/io.h | 2 ++ 1 file changed, 2 insertions(+)arch/arm/include/asm/io.h +2
-0@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);static inline void pci_ioremap_set_mem_type (int mem_type) {}#endif +#ifdef CONFIG_MMU struct resource ;#define pci_remap_iospace pci_remap_iospaceint pci_remap_iospace (const struct resource *res,phys_addr_t phys_addr); +#endif /* * PCI configuration space mapping function. Signature · 7 lines
2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel(a)lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 9 lines · Pali Rohár
Quoted 6 lines · On Thursday 14 July 2022 15:04:43 Bjorn Helgaas wrote:
[+cc linux-pci, update Lorenzo's email addr]
Hi Pali,
Thanks for cc'ing me. I think your previous notes didn't include linux-pci or me, so I missed them.
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
Sorry I missed it!
Quoted 26 lines · Arnd Bergmann
Quoted 19 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
Quoted 5 lines
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/
Quoted 4 lines
Are you sure this still happens in mainline kernels? Since commit
2f618d5ef5dd("ARM: remove support for NOMMU ARMv4/v5") it should no longer be possible to disable the MMU in any Arm machines other than the Cortex-M based ones, which do not support PCI.
I don't know whether it happens in mainline kernels either.
But even if the 2f618d5ef5dd Kconfiggery makes MMU mostly obsolete for Arm, it seems a little weird that io.h unconditionally promises an arch-specific implementation of pci_remap_iospace(), but we only provide it when CONFIG_MMU=y.
It seems like it'd be a little cleaner if the same condition determined visibility of both the declaration and the definition.
Bjorn
Russell King (Oracle)
maintainerQuoted 34 lines · Pali Rohár
Quoted 33 lines · On Thursday 14 July 2022 20:48:15 Russell King (Oracle) wrote:
Quoted 19 lines · Pali Rohár
Custom ARM version of
pci_remap_iospace()is implemented only for MMU kernel builds. So do not definepci_remap_iospace()withoutCONFIG_MMU.See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/Fixes bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")Reported-by kernel test robot <[email protected]>Signed-off-by Pali Rohár <[email protected]>---
PING!!!! Is somebody interested in fixing these compile errors? As nobody answered to my emails where I proposed this fix more than half year ago and asked for opinion...
Quoted 8 lines
https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/If nobody is interested then please STOP sending me these Intel "0-DAY CI Kernel Test Service" emails. Thanks!
It needs to be sent to the patch system to be merged, which has been the process with 32-bit ARM for getting on the last quarter of a century.
Quoted 8 lines
Quoted 5 lines
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!I do not need this patch. It is bot who is complaining. So if you do neither, then please STOP sending me these emails.
I don't need the patch, but I'm not sending you those emails.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!