regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
PATCH 1/1 regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
We should call the of_node_put() for the reference returned by of_get_child_by_name() which has increased the refcount.
---
I think no matter what the 'suspend_state' value is, it should call of_node_put() when 'suspend_np' is not NULL as it will be replaced in 'continue' to next loop.
drivers/regulator/of_regulator.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/regulator/of_regulator.c +5 -1
@@ -264,8 +264,12 @@ static int of_get_regulation_constraints(struct device *dev, } suspend_np =of_get_child_by_name (np, regulator_states[i]); -if (!suspend_np || !suspend_state) +if (!suspend_np)continue ; +if (!suspend_state) { +of_node_put (suspend_np); +continue ; + }if (!of_property_read_u32 (suspend_np,"regulator-mode" , &pval)) {
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 4 lines · Liang He
We should call the
of_node_put()for the reference returned byof_get_child_by_name()which has increased the refcount.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
commit: 66efb665cd5ad69b27dca8571bf89fc6b9c628a4
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark