Skip to contentSkip to conversation

Add MediaTek MT6370 PMIC support

PATCH Superseded ChiaEn Wu 8 participants 38 messages Jul 15, 2022 – Jul 21, 2022

Subsystems (11)

v5 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

ChiaEn Wu

author
#0 lore raw

v5 cover Add MediaTek MT6370 PMIC support

From: ChiaEn Wu <[email protected]>

This patch series add MediaTek MT6370 PMIC support. The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In this series of patches, we based on Andy Shevchenko's mfd patch used to adjust the Makefile order.
(https://lore.kernel.org/all/[email protected]/)
Among with this, we took some changes for MT6370 and refined the MT6370 device tree files to comply with DT specifications.

"[PATCH v5 06/13] dt-bindings: mfd: Add MediaTek MT6370" depends on previous DT binding patches, so before applying this patch, please apply other DT patches first. Thanks!

Thank you,
ChiaEn Wu

---
Changes in v5:
- In patch 07/13:
- Add the comma in the last REGMAP_IRQ_REG_LINE(), DEFINE_RES_IRQ_NAMED() and MFD_CELL_RES()
- Add the prefix in the first parameter of all mfd_cell
- Move enum and struct mt6370_info to mt6370.h
- Remove struct device *dev in struct mt6370_info
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

- In patch 08/13:
- Add comma for the last index of mt6370_reg_init.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine kconfig text.
- Remove both 'else' in set_vbus callback.
- Remove comma for of_device_id if the assigned member is only one.

- In patch 09/13:
- Replace using snprintf() with sysfs_emit() in mt6370_adc_read_label()
- Remove macro ADC_CONV_TIME_US
- Revise all variable ordering
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

- In patch 10/13:
- Replace unsigned int type of pwr_rdy with bool in mt6370_chg_set_online()
- Remove redundant 'else' in mt6370_chg_field_get()
- Revise 'if-else' in mt6370_chg_field_set()
- Revise 'if' condition in mt6370_chg_enable_irq()
- Revise all text 'otg' --> 'OTG'
- Revise MT6370_MIVR_IBUS_TH_100_MA --> MT6370_MIVR_IBUS_TH_100_mA
- Revise the description of Kconfig help text

- In patch 12/13:
- Refine descriptions.
- Refine the macro name.
- Refine the bracket and blanks.

- In patch 13/13:
- Add missed <mod_devicetable.h>
- Add struct device *dev in probe() to make code cleaning
- Remove useless including header file <gpio/driver.h>, <of.h>
- Remove useless variable uasage in mt6370_init_backlight_properties()
- Remove redundant checking enable_gpio in mt6370_bl_update_status()
- Remove redundant parentheses in mt6370_bl_get_brightness()
- Revise the description of Kconfig help text
- Revise the calculation of hys_th_steps

Changes in v4:
- In patch 02/13:
- Add minItems of "io-channel-names"
- Replace text "Mediatek" with "MediaTek"

- In patch 06/13:
- Roll back all "$ref: " to v2 patch style (using "/schemas/...")

- In patch 07/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first break and then return" with "return directly" in "mt6370_check_vendor_info()"
- Add module name related description in Kconfig helptext
- Add Copyright in the source code
- Add header file "mt6370.h" for all "#define IRQ"
- Adjust Makefile order of MT6370
- Refine "bank_idx" and "bank_addr" in "mt6375_regmap_read()" / "mt6375_regmap_write()"
- Refine redundant "else if" in "mt6370_regmap_read()"

- In patch 08/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace "first ret=regulator_(dis/en)able and then return" with "return directly" in "mt6370_tcpc_set_vbus()"
- Replace header file <linux/of.h> with <linux/mod_devicetable.h>
- Add Copyright in the source code
- Add module name related description in Kconfig helptext
- Remove header file <linux/of.h>
- Refine all probe error by using dev_err_probe()

- In patch 09/13:
- Replace text "Mediatek" with "MediaTek"
- Replace all "first dev_err() and then return" with "return dev_err_probe()"
- Add Copyright in the source code
- Add module name related description in Kconfig
- Add unit suffix of macro "ADC_CONV_POLLING_TIME"
- Add new macro "ADC_CONV_TIME_MS"
- Adjust the position of include file <mediatek,mt6370_adc.h>
- Adjust the postions between <linux/module.h> and <linux/mod_devicetable.h>
- Fix some incorrect characters

- In patch 10/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig and MODULE_DESCRIPTION()
- Replace "mt6370_chg_val_to_reg" and "mt6370_chg_reg_to_val" with "linear_range" API
- Replace "first break and then return" with "return directly" in all cases of get/set power_supply_property
- Replace all "first dev_err() and then return" with "return dev_err_probe()"
- Replace all "return IS_ERR(priv->rdev) ? PTR_ERR(priv->rdev) : 0" with "PTR_ERR_OR_ZERO()"
- Replace "priv->dev->of_node" with "dev_of_node()"
- Add Copyright in the source code
- Add module name related description in Kconfig helptext
- Add proper unit of "MT6370_MIVR_IBUS_TH"
- Add error check in "mt6370_chg_get_status"
- Remove including <mediatek,mt6370_adc.h> header file
- Remove redundant comma of every enum terminator line
- Remove unwanted blank lines
- Remove the useless label (toggle_cfo_exit:)
- Remove using atomic
- Remove using of_match_ptr()
- Fix some incorrect characters
- Fix updating wrong bits when using ena_gpiod of OTG regulator
- Adjust the probe order in probe()

- In patch 11/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Replace text "const" with "constant" in Kconfig
- Add Copyright in the source code

- In patch 12/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code

- In patch 13/13:
- Replace text "Mediatek" with "MediaTek" in Kconfig
- Add Copyright in the source code
- Revise the comment of "PWM HYS STEPS"

Changes in v3:
- Remove ADC ABI file, which is added in v2 Patch 7
- In patch 02/14:
- Add items and remove maxItems of io-channels
- Add io-channel-names and describe each item
- Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator"
- Rename "enable-gpio" to "enable-gpios" in "usb-otg-vbus-regulator"
- In patch 03/14:
- Use leds-class-multicolor.yaml instead of common.yaml.
- Split multi-led and led node.
- Add subdevice "led" in "multi-led".
- In patch 04/14:
- Remove the description of enum.
- In patch 05/14:
- Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps"
- Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum values
- In patch 06/14:
- Use " in entire patchset
- Refine ADC description
- Rename "enable-gpio" to "enable-gpios" in "regualtor"
- In patch 07/14:
- Refine Kconfig help text
- Refine error message of unknown vendor ID in mt6370_check_vendor_info()
- Refine return value handling of mt6370_regmap_read()
- Refine all probe error by using dev_err_probe()
- Refine "bank_idx" and "bank_addr" in mt6370_regmap_read() and mt6370_regmap_write()
- Add "#define VENID*" and drop the comments in mt6370_check_vendor_info()
- Drop "MFD" in MODULE_DESCRIPTION()
- In patch 09/14:
- Refine Kconfig help text
- In patch 10/14:
- Refine Kconfig help text
- Refine all channel value in read_scale()
a. current: uA --> mA
b. voltage: uV --> mV
c. temperature: degrees Celsius --> milli degrees Celsius
- Add "default:" condition of switch statement in read_scale() and read_raw()
- Add error message for reading ADC register failed
- Add the comment for adc_lock
- Add <linux/mod_devicetable.h> header file for struct of_device_id
- Replace "adc" text with "ADC" in all of the error messages
- In patch 12/14:
- Refine the grammer of the Kconfig.
- Change reg mode to the const current mode.
- In patch 14/14:
- Refine bool properties parsing (pwm-enable, ovp-shutdown, ocp-shutdown) in DT parsing function
- Refine u32 and u8 properties parsing (pwm-hys-input-th-steps, ovp-microvolt, ocp-microamp), from using register value to using actual value
- Refine error string of "channle-use" parsing failed
- Refine Kconfig help text

Changes in v2:
- In patch 01/15:
- Add "unevaluatedProperties: false".
- Delete "DT bindings".
- Refine the description to fit in 80 columns.
- Skip the connector description.
- In patch 02/15:
- Refine items description of interrupt-name
- Rename "usb-otg-vbus" to "usb-otg-vbus-regulator"
- Add constraint properties for ADC
- In patch 03/15:
- Skip not useful description of "^(multi-)?led@[0-3]$" and reg.
- Due to the dependency, remove the mention of mfd document directory.
- Delete Soft-start property. In design aspect, we think soft-restart should always be enabled, our new chip has deleted the related setting register , also, we don’t allow user adjust this parameter in this chip.
- Refine the commit message.
- In patch 04/15:
- Skip not useful description of "^led@[0-1]$" and reg.
- Add apace after '#'.
- Refine the commit message.
- In patch 05/15:
- Remove "binding documentation" in subject title
- Refine description of mt6370 backlight binding document
- Refine properties name(bled-pwm-hys-input-bit, bled-ovp-microvolt, bled-ocp-microamp) and their description
- In patch 06/15:
- Refine ADC and Regulator descriptions
- Refine include header usage in example
- Refine node name to generic node name("pmic@34")
- Refine led example indentation
- Refine license of mediatek,mt6370_adc.h
- Rename the dts example from IRQ define to number.
- Remove mediatek,mt6370.h
- In patch 07/15:
- Add ABI documentation for mt6370 non-standard ADC sysfs interfaces.
- In patch 08/15:
- Add all IRQ define into mt6370.c.
- Refine include header usage
- In patch 09/15:
- No changes.
- In patch 10/15:
- Use 'gpiod_get_from_of_node' to replace 'fwnode_gpiod_get_index'.
- In patch 11/15:
- Refine Kconfig mt6370 help text
- Refine mask&shift to FIELD_PREP()
- Refine mutex lock name ("lock" -> "adc_lock")
- Refine mt6370_adc_read_scale()
- Refine mt6370_adc_read_offset()
- Refine mt6370_channel_labels[] by using enum to index chan spec
- Refine MT6370_ADC_CHAN()
- Refine indio_dev->name
- Remove useless include header files
- In patch 12/15:

	- Refine mt6370_chg_otg_rdesc.of_match
	  ("mt6370,otg-vbus" -> "usb-otg-vbus-regulator") to match
	  DT binding

- In patch 13/15:
- Refine Kconfig description.
- Remove include "linux/of.h" and use "linux/mod_devicetable.h".
- Place a comma for the last element of the const unsigned int array.
- Add a comment line for the mutex 'lock'.
- In probe function, use 'dev_err_probe' in some judgement to reduce the LOC.
- Refine include header usage.
BIT/GENMASK -> linux/bits.h
FIELD_GET -> linux/bitfield.h
- In patch 14/15:
- Add blank line.
- Replace container_of() with to_mt6370_led() .
- Refine description of ramping.
- Refine the mt6370_init_common_properties function.
- Refine the probe return.
- In patch 15/15:
- Refine MT6370 help text in Kconfig
- Refine DT Parse function
- Remove useless enum
- Add comment for 6372 backward compatible in bl_update_status() and
check_vendor_info()
- Using dev_err_probe(); insteads dev_err()&return; in the probe()

Alice Chen (2):
dt-bindings: leds: Add MediaTek MT6370 flashlight
leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support

ChiYuan Huang (7):
dt-bindings: usb: Add MediaTek MT6370 TCPC
dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED
indicator
dt-bindings: backlight: Add MediaTek MT6370 backlight
dt-bindings: mfd: Add MediaTek MT6370
mfd: mt6370: Add MediaTek MT6370 support
usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator
support

ChiaEn Wu (4):
dt-bindings: power: supply: Add MediaTek MT6370 Charger
iio: adc: mt6370: Add MediaTek MT6370 support
power: supply: mt6370: Add MediaTek MT6370 charger driver
video: backlight: mt6370: Add MediaTek MT6370 support

 .../leds/backlight/mediatek,mt6370-backlight.yaml  |   92 ++
 .../bindings/leds/mediatek,mt6370-flashlight.yaml  |   41 +
 .../bindings/leds/mediatek,mt6370-indicator.yaml   |   77 ++
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml   |  280 ++++++
 .../power/supply/mediatek,mt6370-charger.yaml      |   88 ++
 .../bindings/usb/mediatek,mt6370-tcpc.yaml         |   36 +
 drivers/iio/adc/Kconfig                            |   12 +
 drivers/iio/adc/Makefile                           |    1 +
 drivers/iio/adc/mt6370-adc.c                       |  273 +++++
 drivers/leds/Kconfig                               |   14 +
 drivers/leds/Makefile                              |    1 +
 drivers/leds/flash/Kconfig                         |   12 +
 drivers/leds/flash/Makefile                        |    1 +
 drivers/leds/flash/leds-mt6370-flash.c             |  661 ++++++++++++
 drivers/leds/leds-mt6370.c                         |  994 ++++++++++++++++++
 drivers/mfd/Kconfig                                |   16 +
 drivers/mfd/Makefile                               |    1 +
 drivers/mfd/mt6370.c                               |  281 ++++++
 drivers/mfd/mt6370.h                               |   99 ++
 drivers/power/supply/Kconfig                       |   14 +
 drivers/power/supply/Makefile                      |    1 +
 drivers/power/supply/mt6370-charger.c              | 1062 ++++++++++++++++++++
 drivers/usb/typec/tcpm/Kconfig                     |   11 +
 drivers/usb/typec/tcpm/Makefile                    |    1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c              |  207 ++++
 drivers/video/backlight/Kconfig                    |   12 +
 drivers/video/backlight/Makefile                   |    1 +
 drivers/video/backlight/mt6370-backlight.c         |  339 +++++++
 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h  |   18 +
 29 files changed, 4646 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
 create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
 create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
 create mode 100644 drivers/iio/adc/mt6370-adc.c
 create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
 create mode 100644 drivers/leds/leds-mt6370.c
 create mode 100644 drivers/mfd/mt6370.c
 create mode 100644 drivers/mfd/mt6370.h
 create mode 100644 drivers/power/supply/mt6370-charger.c
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
 create mode 100644 drivers/video/backlight/mt6370-backlight.c
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v5 1/13 dt-bindings: usb: Add MediaTek MT6370 TCPC

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 TCPC binding documentation.

---
 .../bindings/usb/mediatek,mt6370-tcpc.yaml         | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml new file +36 -0
new file mode 100644
index 0000000..72f56cc
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/usb/mediatek,mt6370-tcpc.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MediatTek MT6370 Type-C Port Switch and Power Delivery controller
+
+maintainers:
+  - ChiYuan Huang <[email protected]>
+
+description: |
+  MediaTek MT6370 is a multi-functional device.
+  It integrates charger, ADC, flash, RGB indicators,
+  regulators (DSV/VIBLDO), and TypeC Port Switch with Power Delivery controller.
+  This document only describes MT6370 Type-C Port Switch and
+  Power Delivery controller.
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt6370-tcpc
+
+  interrupts:
+    maxItems: 1
+
+  connector:
+    type: object
+    $ref: /schemas/connector/usb-connector.yaml#
+    unevaluatedProperties: false
+
+additionalProperties: false
+
+required:
+  - compatible
+  - interrupts
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v5 2/13 dt-bindings: power: supply: Add MediaTek MT6370 Charger

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

Add MediaTek MT6370 Charger binding documentation.

---
 .../power/supply/mediatek,mt6370-charger.yaml      | 88 ++++++++++++++++++++++
 1 file changed, 88 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml new file +88 -0
new file mode 100644
index 0000000..bd09a0a
@@ -0,0 +1,88 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 Battery Charger
+
+maintainers:
+  - ChiaEn Wu <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
+
+properties:
+  compatible:
+    const: mediatek,mt6370-charger
+
+  interrupts:
+    description: |
+      Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
+      "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
+      are required.
+    items:
+      - description: BC1.2 done irq
+      - description: usb plug in irq
+      - description: mivr irq
+
+  interrupt-names:
+    items:
+      - const: attach_i
+      - const: uvp_d_evt
+      - const: mivr
+
+  io-channels:
+    description: |
+      Use ADC channel to read VBUS, IBUS, IBAT, etc., info.
+    minItems: 1
+    items:
+      - description: |
+          VBUS voltage with lower accuracy (+-75mV) but higher measure
+          range (1~22V)
+      - description: |
+          VBUS voltage with higher accuracy (+-30mV) but lower measure
+          range (1~9.76V)
+      - description: the main system input voltage
+      - description: battery voltage
+      - description: battery temperature-sense input voltage
+      - description: IBUS current (required)
+      - description: battery current
+      - description: |
+          regulated output voltage to supply for the PWM low-side gate driver
+          and the bootstrap capacitor
+      - description: IC junction temperature
+
+  io-channel-names:
+    minItems: 1
+    items:
+      - const: vbusdiv5
+      - const: vbusdiv2
+      - const: vsys
+      - const: vbat
+      - const: ts_bat
+      - const: ibus
+      - const: ibat
+      - const: chg_vddp
+      - const: temp_jc
+
+  usb-otg-vbus-regulator:
+    type: object
+    description: OTG boost regulator.
+    unevaluatedProperties: false
+    $ref: /schemas/regulator/regulator.yaml#
+
+    properties:
+      enable-gpios:
+        maxItems: 1
+
+required:
+  - compatible
+  - interrupts
+  - interrupt-names
+  - io-channels
+
+additionalProperties: false
+
+...
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH v5 3/13 dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 current sink type LED indicator binding documentation.

---
 .../bindings/leds/mediatek,mt6370-indicator.yaml   | 77 ++++++++++++++++++++++
 1 file changed, 77 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml new file +77 -0
new file mode 100644
index 0000000..45030f3
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+  - Alice Chen <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode
+
+allOf:
+  - $ref: leds-class-multicolor.yaml#
+
+properties:
+  compatible:
+    const: mediatek,mt6370-indicator
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^multi-led@[0-3]$":
+    type: object
+
+    properties:
+      reg:
+        enum: [0, 1, 2, 3]
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^led@[0-2]$":
+        type: object
+        $ref: common.yaml#
+        unevaluatedProperties: false
+
+        required:
+          - reg
+          - color
+
+    required:
+      - reg
+      - color
+      - "#address-cells"
+      - "#size-cells"
+
+  "^led@[0-3]$":
+    type: object
+    $ref: common.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        enum: [0, 1, 2, 3]
+
+    required:
+      - reg
+      - color
+
+required:
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
Signature · 1 line
2.7.4
author
#4 lore raw

PATCH v5 4/13 dt-bindings: leds: Add MediaTek MT6370 flashlight

In reply to ChiaEn Wu

From: Alice Chen <[email protected]>

Add MediaTek MT6370 flashlight binding documentation.

---
 .../bindings/leds/mediatek,mt6370-flashlight.yaml  | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml
Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml new file +41 -0
new file mode 100644
index 0000000..e9d02ed
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/mediatek,mt6370-flashlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Flash LED driver for MT6370 PMIC from MediaTek Integrated.
+
+maintainers:
+  - Alice Chen <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode.
+
+properties:
+  compatible:
+    const: mediatek,mt6370-flashlight
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^led@[0-1]$":
+    type: object
+    $ref: common.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        enum: [0, 1]
+
+required:
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
Signature · 1 line
2.7.4
author
#5 lore raw

PATCH v5 5/13 dt-bindings: backlight: Add MediaTek MT6370 backlight

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MT6370 backlight binding documentation.

---
 .../leds/backlight/mediatek,mt6370-backlight.yaml  | 92 ++++++++++++++++++++++
 1 file changed, 92 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml new file +92 -0
new file mode 100644
index 0000000..d674212
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 Backlight
+
+maintainers:
+  - ChiaEn Wu <[email protected]>
+
+description: |
+  This module is part of the MT6370 MFD device.
+  The MT6370 Backlight WLED driver supports up to a 29V output voltage for
+  4 channels of 8 series WLEDs. Each channel supports up to 30mA of current
+  capability with 2048 current steps (11 bits) in exponential or linear
+  mapping curves.
+
+allOf:
+  - $ref: common.yaml#
+
+properties:
+  compatible:
+    const: mediatek,mt6370-backlight
+
+  default-brightness:
+    minimum: 0
+    maximum: 2048
+
+  max-brightness:
+    minimum: 0
+    maximum: 2048
+
+  enable-gpios:
+    description: External backlight 'enable' pin
+    maxItems: 1
+
+  mediatek,bled-pwm-enable:
+    description: |
+      Enable external PWM input for backlight dimming
+    type: boolean
+
+  mediatek,bled-pwm-hys-enable:
+    description: |
+      Enable the backlight input-hysteresis for PWM mode
+    type: boolean
+
+  mediatek,bled-pwm-hys-input-th-steps:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    enum: [1, 4, 16, 64]
+    description: |
+      The selection of the upper and lower bounds threshold of backlight
+      PWM resolution. If we choose selection 64, the variation of PWM
+      resolution needs more than 64 steps.
+
+  mediatek,bled-ovp-shutdown:
+    description: |
+      Enable the backlight shutdown when OVP level triggered
+    type: boolean
+
+  mediatek,bled-ovp-microvolt:
+    enum: [17000000, 21000000, 25000000, 29000000]
+    description: |
+      Backlight OVP level selection.
+
+  mediatek,bled-ocp-shutdown:
+    description: |
+      Enable the backlight shutdown when OCP level triggerred.
+    type: boolean
+
+  mediatek,bled-ocp-microamp:
+    enum: [900000, 1200000, 1500000, 1800000]
+    description: |
+      Backlight OC level selection.
+
+  mediatek,bled-channel-use:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    description: |
+      Backlight LED channel to be used.
+      Each bit mapping to:
+        - 0: CH4
+        - 1: CH3
+        - 2: CH2
+        - 3: CH1
+    minimum: 1
+    maximum: 15
+
+required:
+  - compatible
+  - mediatek,bled-channel-use
+
+additionalProperties: false
Signature · 1 line
2.7.4
author
#6 lore raw

PATCH v5 6/13 dt-bindings: mfd: Add MediaTek MT6370

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 binding documentation.

---
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml   | 280 +++++++++++++++++++++
 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h  |  18 ++
 2 files changed, 298 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml new file +280 -0
new file mode 100644
index 0000000..410e2d4
@@ -0,0 +1,280 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mediatek,mt6370.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT6370 SubPMIC
+
+maintainers:
+  - ChiYuan Huang <[email protected]>
+
+description: |
+  MT6370 is a highly-integrated smart power management IC, which includes a
+  single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
+  Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
+  driver, a backlight WLED driver, a display bias driver and a general LDO for
+  portable devices.
+
+properties:
+  compatible:
+    const: mediatek,mt6370
+
+  reg:
+    maxItems: 1
+
+  wakeup-source: true
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 1
+
+  adc:
+    type: object
+    description: |
+      Provides 9 channels for system monitoring, including VBUSDIV5 (lower
+      accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower
+      measure range), VBAT, VSYS, CHG_VDDP, TS_BAT, IBUS, IBAT, and TEMP_JC.
+
+    properties:
+      compatible:
+        const: mediatek,mt6370-adc
+
+      "#io-channel-cells":
+        const: 1
+
+    required:
+      - compatible
+      - "#io-channel-cells"
+
+  backlight:
+    type: object
+    $ref: /schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
+
+  charger:
+    type: object
+    $ref: /schemas/power/supply/mediatek,mt6370-charger.yaml#
+
+  tcpc:
+    type: object
+    $ref: /schemas/usb/mediatek,mt6370-tcpc.yaml#
+
+  indicator:
+    type: object
+    $ref: /schemas/leds/mediatek,mt6370-indicator.yaml#
+
+  flashlight:
+    type: object
+    $ref: /schemas/leds/mediatek,mt6370-flashlight.yaml#
+
+  regulators:
+    type: object
+    description: |
+      List all supported regulators, which support the control for DisplayBias
+      voltages and one general purpose LDO which commonly used to drive the
+      vibrator.
+
+    patternProperties:
+      "^(dsvbst|vibldo)$":
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+        unevaluatedProperties: false
+
+      "^(dsvpos|dsvneg)$":
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+        unevaluatedProperties: false
+
+        properties:
+          enable-gpios:
+            maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - "#interrupt-cells"
+  - regulators
+  - adc
+  - backlight
+  - indicator
+  - tcpc
+  - charger
+  - flashlight
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/leds/common.h>
+    #include <dt-bindings/iio/adc/mediatek,mt6370_adc.h>
+    #include <dt-bindings/usb/pd.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+        pmic@34 {
+        compatible = "mediatek,mt6370";
+        reg = <0x34>;
+        wakeup-source;
+        interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-controller;
+        #interrupt-cells = <1>;
+
+        mt6370_adc: adc {
+          compatible = "mediatek,mt6370-adc";
+          #io-channel-cells = <1>;
+        };
+
+        backlight {
+          compatible = "mediatek,mt6370-backlight";
+          mediatek,bled-channel-use = /bits/ 8 <15>;
+        };
+
+        charger {
+          compatible = "mediatek,mt6370-charger";
+          interrupts = <48>, <68>, <6>;
+          interrupt-names = "attach_i", "uvp_d_evt", "mivr";
+          io-channels = <&mt6370_adc MT6370_CHAN_IBUS>;
+
+          mt6370_otg_vbus: usb-otg-vbus-regulator {
+            regulator-name = "mt6370-usb-otg-vbus";
+            regulator-min-microvolt = <4350000>;
+            regulator-max-microvolt = <5800000>;
+            regulator-min-microamp = <500000>;
+            regulator-max-microamp = <3000000>;
+          };
+        };
+
+        indicator {
+          compatible = "mediatek,mt6370-indicator";
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          multi-led@0 {
+            reg = <0>;
+            function = LED_FUNCTION_INDICATOR;
+            color = <LED_COLOR_ID_RGB>;
+            led-max-microamp = <24000>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            led@0 {
+              reg = <0>;
+              color = <LED_COLOR_ID_RED>;
+            };
+            led@1 {
+              reg = <1>;
+              color = <LED_COLOR_ID_GREEN>;
+            };
+            led@2 {
+              reg = <2>;
+              color = <LED_COLOR_ID_BLUE>;
+            };
+          };
+          led@3 {
+            reg = <3>;
+            function = LED_FUNCTION_INDICATOR;
+            color = <LED_COLOR_ID_WHITE>;
+            led-max-microamp = <6000>;
+          };
+        };
+
+        flashlight {
+          compatible = "mediatek,mt6370-flashlight";
+          #address-cells = <1>;
+          #size-cells = <0>;
+          led@0 {
+            reg = <0>;
+            led-sources = <0>;
+            function = LED_FUNCTION_FLASH;
+            color = <LED_COLOR_ID_WHITE>;
+            function-enumerator = <1>;
+            led-max-microamp = <200000>;
+            flash-max-microamp = <500000>;
+            flash-max-timeout-us = <1248000>;
+          };
+          led@1 {
+            reg = <1>;
+            led-sources = <1>;
+            function = LED_FUNCTION_FLASH;
+            color = <LED_COLOR_ID_WHITE>;
+            function-enumerator = <2>;
+            led-max-microamp = <200000>;
+            flash-max-microamp = <500000>;
+            flash-max-timeout-us = <1248000>;
+          };
+        };
+
+        tcpc {
+          compatible = "mediatek,mt6370-tcpc";
+          interrupts-extended = <&gpio26 4 IRQ_TYPE_LEVEL_LOW>;
+
+          connector {
+            compatible = "usb-c-connector";
+            label = "USB-C";
+            vbus-supply = <&mt6370_otg_vbus>;
+            data-role = "dual";
+            power-role = "dual";
+            try-power-role = "sink";
+            source-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+            sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
+            op-sink-microwatt = <10000000>;
+
+            ports {
+              #address-cells = <1>;
+              #size-cells = <0>;
+
+              port@0 {
+                reg = <0>;
+                endpoint {
+                  remote-endpoint = <&usb_hs>;
+                };
+              };
+              port@1 {
+                reg = <1>;
+                endpoint {
+                  remote-endpoint = <&usb_ss>;
+                };
+              };
+              port@2 {
+                reg = <2>;
+                endpoint {
+                  remote-endpoint = <&dp_aux>;
+                };
+              };
+            };
+          };
+        };
+
+        regulators {
+          dsvbst {
+            regulator-name = "mt6370-dsv-vbst";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6200000>;
+          };
+          dsvpos {
+            regulator-name = "mt6370-dsv-vpos";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6000000>;
+            regulator-boot-on;
+          };
+          dsvneg {
+            regulator-name = "mt6370-dsv-vneg";
+            regulator-min-microvolt = <4000000>;
+            regulator-max-microvolt = <6000000>;
+            regulator-boot-on;
+          };
+          vibldo {
+            regulator-name = "mt6370-vib-ldo";
+            regulator-min-microvolt = <1600000>;
+            regulator-max-microvolt = <4000000>;
+          };
+        };
+      };
+    };
include/dt-bindings/iio/adc/mediatek,mt6370_adc.h new file +18 -0
new file mode 100644
index 0000000..6ee7255
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
+
+#ifndef __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+#define __DT_BINDINGS_MEDIATEK_MT6370_ADC_H__
+
+/* ADC Channel Index */
+#define MT6370_CHAN_VBUSDIV5	0
+#define MT6370_CHAN_VBUSDIV2	1
+#define MT6370_CHAN_VSYS	2
+#define MT6370_CHAN_VBAT	3
+#define MT6370_CHAN_TS_BAT	4
+#define MT6370_CHAN_IBUS	5
+#define MT6370_CHAN_IBAT	6
+#define MT6370_CHAN_CHG_VDDP	7
+#define MT6370_CHAN_TEMP_JC	8
+#define MT6370_CHAN_MAX		9
+
+#endif
Signature · 1 line
2.7.4
author
#8 lore raw

PATCH v5 7/13 mfd: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

---
v5

- Add the comma in the last REGMAP_IRQ_REG_LINE(), DEFINE_RES_IRQ_NAMED() and MFD_CELL_RES()
- Add the prefix in the first parameter of all mfd_cell
- Move enum and struct mt6370_info to mt6370.h
- Remove struct device *dev in struct mt6370_info
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

---
 drivers/mfd/Kconfig  |  16 +++
 drivers/mfd/Makefile |   1 +
 drivers/mfd/mt6370.c | 281 +++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/mfd/mt6370.h |  99 ++++++++++++++++++
 4 files changed, 397 insertions(+)
 create mode 100644 drivers/mfd/mt6370.c
 create mode 100644 drivers/mfd/mt6370.h
drivers/mfd/Kconfig +16 -0
index 3b59456..a9bcae3 100644
@@ -937,6 +937,22 @@ config MFD_MT6360
 	  PMIC part includes 2-channel BUCKs and 2-channel LDOs
 	  LDO part includes 4-channel LDOs
 
+config MFD_MT6370
+	tristate "MediaTek MT6370 SubPMIC"
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	depends on I2C
+	help
+	  Say Y here to enable MT6370 SubPMIC functional support.
+	  It consists of a single cell battery charger with ADC monitoring, RGB
+	  LEDs, dual channel flashlight, WLED backlight driver, display bias
+	  voltage supply, one general purpose LDO, and the USB Type-C & PD
+	  controller complies with the latest USB Type-C and PD standards.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370".
+
 config MFD_MT6397
 	tristate "MediaTek MT6397 PMIC Support"
 	select MFD_CORE
drivers/mfd/Makefile +1 -0
index 8c69867..81dbed3 100644
@@ -173,6 +173,7 @@ obj-$(CONFIG_MFD_MAX8998)	+= max8998.o max8998-irq.o
 obj-$(CONFIG_MFD_MP2629)	+= mp2629.o
 
 obj-$(CONFIG_MFD_MT6360)	+= mt6360-core.o
+obj-$(CONFIG_MFD_MT6370)	+= mt6370.o
 mt6397-objs			:= mt6397-core.o mt6397-irq.o mt6358-irq.o
 obj-$(CONFIG_MFD_MT6397)	+= mt6397.o
 
drivers/mfd/mt6370.c new file +281 -0

281 lines not on this page · raw message

drivers/mfd/mt6370.h new file +99 -0

99 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#10 lore raw

PATCH v5 8/13 usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

This commit add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

---

v5
- Add comma for the last index of mt6370_reg_init.
- Use dev_err_probe to decrease LOC.
- Use 'dev' variable to make probe function more clean.
- Refine kconfig text.
- Remove both 'else' in set_vbus callback.
- Remove comma for of_device_id if the assigned member is only one.

---
 drivers/usb/typec/tcpm/Kconfig        |  11 ++
 drivers/usb/typec/tcpm/Makefile       |   1 +
 drivers/usb/typec/tcpm/tcpci_mt6370.c | 207 ++++++++++++++++++++++++++++++++++
 3 files changed, 219 insertions(+)
 create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6370.c
drivers/usb/typec/tcpm/Kconfig +11 -0
index 073fd2e..e6b88ca 100644
@@ -35,6 +35,17 @@ config TYPEC_MT6360
 	  USB Type-C. It works with Type-C Port Controller Manager
 	  to provide USB PD and USB Type-C functionalities.
 
+config TYPEC_TCPCI_MT6370
+	tristate "MediaTek MT6370 Type-C driver"
+	depends on MFD_MT6370
+	help
+	  MediaTek MT6370 is a multi-functional IC that includes
+	  USB Type-C. It works with Type-C Port Controller Manager
+	  to provide USB PD and USB Type-C functionalities.
+
+	  This driver can also be built as a module. The module
+	  will be called "tcpci_mt6370".
+
 config TYPEC_TCPCI_MAXIM
 	tristate "Maxim TCPCI based Type-C chip driver"
 	help
drivers/usb/typec/tcpm/Makefile +1 -0
index 7d499f3..906d9dc 100644
@@ -6,4 +6,5 @@ typec_wcove-y				:= wcove.o
 obj-$(CONFIG_TYPEC_TCPCI)		+= tcpci.o
 obj-$(CONFIG_TYPEC_RT1711H)		+= tcpci_rt1711h.o
 obj-$(CONFIG_TYPEC_MT6360)		+= tcpci_mt6360.o
+obj-$(CONFIG_TYPEC_TCPCI_MT6370)	+= tcpci_mt6370.o
 obj-$(CONFIG_TYPEC_TCPCI_MAXIM)		+= tcpci_maxim.o
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +207 -0

207 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#16 lore raw

PATCH v5 9/13 iio: adc: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds support the MT6370 ADC driver for system monitoring, including charger current, voltage, and temperature.

---

v5
- Replace using snprintf() with sysfs_emit() in mt6370_adc_read_label()
- Remove macro ADC_CONV_TIME_US
- Revise all variable ordering
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

---
 drivers/iio/adc/Kconfig      |  12 ++
 drivers/iio/adc/Makefile     |   1 +
 drivers/iio/adc/mt6370-adc.c | 273 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 286 insertions(+)
 create mode 100644 drivers/iio/adc/mt6370-adc.c
drivers/iio/adc/Kconfig +12 -0
index 48ace74..60bcc28 100644
@@ -737,6 +737,18 @@ config MEDIATEK_MT6360_ADC
 	  is used in smartphones and tablets and supports a 11 channel
 	  general purpose ADC.
 
+config MEDIATEK_MT6370_ADC
+	tristate "MediaTek MT6370 ADC driver"
+	depends on MFD_MT6370
+	help
+	  Say yes here to enable MediaTek MT6370 ADC support.
+
+	  This ADC driver provides 9 channels for system monitoring (charger
+	  current, voltage, and temperature).
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-adc".
+
 config MEDIATEK_MT6577_AUXADC
 	tristate "MediaTek AUXADC driver"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
drivers/iio/adc/Makefile +1 -0
index 39d806f..0ce285c 100644
@@ -68,6 +68,7 @@ obj-$(CONFIG_MCP320X) += mcp320x.o
 obj-$(CONFIG_MCP3422) += mcp3422.o
 obj-$(CONFIG_MCP3911) += mcp3911.o
 obj-$(CONFIG_MEDIATEK_MT6360_ADC) += mt6360-adc.o
+obj-$(CONFIG_MEDIATEK_MT6370_ADC) += mt6370-adc.o
 obj-$(CONFIG_MEDIATEK_MT6577_AUXADC) += mt6577_auxadc.o
 obj-$(CONFIG_MEN_Z188_ADC) += men_z188_adc.o
 obj-$(CONFIG_MESON_SARADC) += meson_saradc.o
drivers/iio/adc/mt6370-adc.c new file +273 -0

273 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#19 lore raw

PATCH v5 10/13 power: supply: mt6370: Add MediaTek MT6370 charger driver

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds MediaTek MT6370 Charger driver support. The charger module of MT6370 supports High-Accuracy Voltage/Current Regulation, Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2.

---

v5
- Replace unsigned int type of pwr_rdy with bool in mt6370_chg_set_online()
- Remove redundant 'else' in mt6370_chg_field_get()
- Revise 'if-else' in mt6370_chg_field_set()
- Revise 'if' condition in mt6370_chg_enable_irq()
- Revise all text 'otg' --> 'OTG'
- Revise MT6370_MIVR_IBUS_TH_100_MA --> MT6370_MIVR_IBUS_TH_100_mA
- Revise the description of Kconfig help text

---
 drivers/power/supply/Kconfig          |   14 +
 drivers/power/supply/Makefile         |    1 +
 drivers/power/supply/mt6370-charger.c | 1062 +++++++++++++++++++++++++++++++++
 3 files changed, 1077 insertions(+)
 create mode 100644 drivers/power/supply/mt6370-charger.c
drivers/power/supply/Kconfig +14 -0
index 1aa8323..591deb8 100644
@@ -619,6 +619,20 @@ config CHARGER_MT6360
 	  Average Input Current Regulation, Battery Temperature Sensing,
 	  Over-Temperature Protection, DPDM Detection for BC1.2.
 
+config CHARGER_MT6370
+	tristate "MediaTek MT6370 Charger Driver"
+	depends on MFD_MT6370
+	depends on REGULATOR
+	select LINEAR_RANGES
+	help
+	  Say Y here to enable MT6370 Charger Part.
+	  The device supports High-Accuracy Voltage/Current Regulation,
+	  Average Input Current Regulation, Battery Temperature Sensing,
+	  Over-Temperature Protection, DPDM Detection for BC1.2.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-charger".
+
 config CHARGER_QCOM_SMBB
 	tristate "Qualcomm Switch-Mode Battery Charger and Boost"
 	depends on MFD_SPMI_PMIC || COMPILE_TEST
drivers/power/supply/Makefile +1 -0
index 7f02f36..8c95276 100644
@@ -82,6 +82,7 @@ obj-$(CONFIG_CHARGER_MAX8997)	+= max8997_charger.o
 obj-$(CONFIG_CHARGER_MAX8998)	+= max8998_charger.o
 obj-$(CONFIG_CHARGER_MP2629)	+= mp2629_charger.o
 obj-$(CONFIG_CHARGER_MT6360)	+= mt6360_charger.o
+obj-$(CONFIG_CHARGER_MT6370)	+= mt6370-charger.o
 obj-$(CONFIG_CHARGER_QCOM_SMBB)	+= qcom_smbb.o
 obj-$(CONFIG_CHARGER_BQ2415X)	+= bq2415x_charger.o
 obj-$(CONFIG_CHARGER_BQ24190)	+= bq24190_charger.o
drivers/power/supply/mt6370-charger.c new file +1062 -0

1,062 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#22 lore raw

PATCH v5 11/13 leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

---
 drivers/leds/Kconfig       |  14 +
 drivers/leds/Makefile      |   1 +
 drivers/leds/leds-mt6370.c | 994 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1009 insertions(+)
 create mode 100644 drivers/leds/leds-mt6370.c
drivers/leds/Kconfig +14 -0
index a49979f..71bacb5 100644
@@ -244,6 +244,20 @@ config LEDS_MT6323
 	  This option enables support for on-chip LED drivers found on
 	  Mediatek MT6323 PMIC.
 
+config LEDS_MT6370_RGB
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
+	  Isink4 channel can also be used as a CHG_VIN power good indicator.
+
+	  This driver can also be built as a module. If so the module
+	  will be called "leds-mt6370.ko".
+
 config LEDS_S3C24XX
 	tristate "LED Support for Samsung S3C24XX GPIO LEDs"
 	depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
index 4fd2f92..557be42 100644
@@ -62,6 +62,7 @@ obj-$(CONFIG_LEDS_MIKROTIK_RB532)	+= leds-rb532.o
 obj-$(CONFIG_LEDS_MLXCPLD)		+= leds-mlxcpld.o
 obj-$(CONFIG_LEDS_MLXREG)		+= leds-mlxreg.o
 obj-$(CONFIG_LEDS_MT6323)		+= leds-mt6323.o
+obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370.o
 obj-$(CONFIG_LEDS_NET48XX)		+= leds-net48xx.o
 obj-$(CONFIG_LEDS_NETXBIG)		+= leds-netxbig.o
 obj-$(CONFIG_LEDS_NIC78BX)		+= leds-nic78bx.o
drivers/leds/leds-mt6370.c new file +994 -0

994 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#31 lore raw

PATCH v5 12/13 leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu

From: Alice Chen <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, whichincludes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

The Flash LED in MT6370 has 2 channel and support torch/strobe mode. The commit add the support of MT6370 FLASH LED.

---

v5
- Refine descriptions.
- Refine the macro name.
- Refine the brackets and blanks.

---
 drivers/leds/flash/Kconfig             |  12 +
 drivers/leds/flash/Makefile            |   1 +
 drivers/leds/flash/leds-mt6370-flash.c | 661 +++++++++++++++++++++++++++++++++
 3 files changed, 674 insertions(+)
 create mode 100644 drivers/leds/flash/leds-mt6370-flash.c
drivers/leds/flash/Kconfig +12 -0
index d3eb689..d5761ed 100644
@@ -90,4 +90,16 @@ config LEDS_SGM3140
 	  This option enables support for the SGM3140 500mA Buck/Boost Charge
 	  Pump LED Driver.
 
+config LEDS_MT6370_FLASHLIGHT
+	tristate "Flash LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	help
+	  Support 2 channels and torch/strobe mode.
+	  Say Y here to enable support for
+	  MT6370_FLASH_LED device.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "leds-mt6370-flash".
+
 endif # LEDS_CLASS_FLASH
drivers/leds/flash/Makefile +1 -0
index 0acbddc..4c4c171 100644
@@ -9,3 +9,4 @@ obj-$(CONFIG_LEDS_MAX77693)	+= leds-max77693.o
 obj-$(CONFIG_LEDS_RT4505)	+= leds-rt4505.o
 obj-$(CONFIG_LEDS_RT8515)	+= leds-rt8515.o
 obj-$(CONFIG_LEDS_SGM3140)	+= leds-sgm3140.o
+obj-$(CONFIG_LEDS_MT6370_FLASHLIGHT)	+= leds-mt6370-flash.o
drivers/leds/flash/leds-mt6370-flash.c new file +661 -0

661 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#33 lore raw

PATCH v5 13/13 video: backlight: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds support for MediaTek MT6370 Backlight driver. It's commonly used to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

---

v5
- Add missed <mod_devicetable.h>
- Add struct device *dev in probe() to make code cleaning
- Remove useless including header file <gpio/driver.h>, <of.h>
- Remove useless variable uasage in mt6370_init_backlight_properties()
- Remove redundant checking enable_gpio in mt6370_bl_update_status()
- Remove redundant parentheses in mt6370_bl_get_brightness()
- Revise the description of Kconfig help text
- Revise the calculation of hys_th_steps

---
 drivers/video/backlight/Kconfig            |  12 +
 drivers/video/backlight/Makefile           |   1 +
 drivers/video/backlight/mt6370-backlight.c | 339 +++++++++++++++++++++++++++++
 3 files changed, 352 insertions(+)
 create mode 100644 drivers/video/backlight/mt6370-backlight.c
drivers/video/backlight/Kconfig +12 -0
index a003e02..846dbe7 100644
@@ -268,6 +268,18 @@ config BACKLIGHT_MAX8925
 	  If you have a LCD backlight connected to the WLED output of MAX8925
 	  WLED output, say Y here to enable this driver.
 
+config BACKLIGHT_MT6370
+	tristate "MediaTek MT6370 Backlight Driver"
+	depends on MFD_MT6370
+	help
+	  This enables support for Mediatek MT6370 Backlight driver.
+	  It's commonly used to drive the display WLED. There are 4 channels
+	  inside, and each channel supports up to 30mA of current capability
+	  with 2048 current steps in exponential or linear mapping curves.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-backlight".
+
 config BACKLIGHT_APPLE
 	tristate "Apple Backlight Driver"
 	depends on X86 && ACPI
drivers/video/backlight/Makefile +1 -0
index cae2c83..e815f3f 100644
@@ -44,6 +44,7 @@ obj-$(CONFIG_BACKLIGHT_LP855X)		+= lp855x_bl.o
 obj-$(CONFIG_BACKLIGHT_LP8788)		+= lp8788_bl.o
 obj-$(CONFIG_BACKLIGHT_LV5207LP)	+= lv5207lp.o
 obj-$(CONFIG_BACKLIGHT_MAX8925)		+= max8925_bl.o
+obj-$(CONFIG_BACKLIGHT_MT6370)		+= mt6370-backlight.o
 obj-$(CONFIG_BACKLIGHT_OMAP1)		+= omap1_bl.o
 obj-$(CONFIG_BACKLIGHT_PANDORA)		+= pandora_bl.o
 obj-$(CONFIG_BACKLIGHT_PCF50633)	+= pcf50633-backlight.o
drivers/video/backlight/mt6370-backlight.c new file +339 -0

339 lines not on this page · raw message

Signature · 1 line
2.7.4
#34 lore raw

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Quoted 6 lines

This adds support for MediaTek MT6370 Backlight driver. It's commonly used to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

Hello ChiaEn,

I propose to move this one to drivers/leds (or drivers/pwm) and, instead of registering a backlight device, register a PWM device.

This way you will be able to reuse the generic backlight-pwm driver, as you'd be feeding the PWM device exposed by this driver to the generic one: this will most importantly make it easy to chain it with MTK_DISP_PWM (mtk-pwm-disp) with a devicetree that looks like...

	pwmleds-disp {

		compatible = "pwm-leds";



		disp_led: disp-pwm {

			label = "backlight-pwm";

			pwms = <&pwm0 0 500000>;

			max-brightness = <1024>;

		};

	};



	backlight_lcd0: backlight {

		compatible = "led-backlight";

		leds = <&disp_led>, <&pmic_bl_led>;



		default-brightness-level = <300>;

	};

Regards,
Angelo

maintainer Reviewed-by on v5 9/13
#17 lore raw

Re: [PATCH v5 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Quoted 4 lines

This adds support the MT6370 ADC driver for system monitoring, including charger current, voltage, and temperature.

maintainer Reviewed-by on v5 8/13
#11 lore raw

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiYuan Huang <[email protected]>

The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 4 lines

This commit add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC.

#23 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 158 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

---
  drivers/leds/Kconfig       |  14 +
  drivers/leds/Makefile      |   1 +
  drivers/leds/leds-mt6370.c | 994 +++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 1009 insertions(+)

create mode 100644 drivers/leds/leds-mt6370.c

drivers/leds/Kconfig +14 -0
index a49979f..71bacb5 100644
@@ -244,6 +244,20 @@ config LEDS_MT6323
  	  This option enables support for on-chip LED drivers found on
  	  Mediatek MT6323 PMIC.
 
+config LEDS_MT6370_RGB
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
+	  Isink4 channel can also be used as a CHG_VIN power good indicator.
+
+	  This driver can also be built as a module. If so the module
+	  will be called "leds-mt6370.ko".
+
  config LEDS_S3C24XX
  	tristate "LED Support for Samsung S3C24XX GPIO LEDs"
  	depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
index 4fd2f92..557be42 100644
@@ -62,6 +62,7 @@ obj-$(CONFIG_LEDS_MIKROTIK_RB532)	+= leds-rb532.o
  obj-$(CONFIG_LEDS_MLXCPLD)		+= leds-mlxcpld.o
  obj-$(CONFIG_LEDS_MLXREG)		+= leds-mlxreg.o
  obj-$(CONFIG_LEDS_MT6323)		+= leds-mt6323.o
+obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370.o
  obj-$(CONFIG_LEDS_NET48XX)		+= leds-net48xx.o
  obj-$(CONFIG_LEDS_NETXBIG)		+= leds-netxbig.o
  obj-$(CONFIG_LEDS_NIC78BX)		+= leds-nic78bx.o
drivers/leds/leds-mt6370.c new file +95 -0
new file mode 100644
index 0000000..1038232
@@ -0,0 +1,994 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: Alice Chen <[email protected]>
+ */
+
+#include <linux/bitops.h>
+#include <linux/kernel.h>
+#include <linux/led-class-multicolor.h>
+#include <linux/linear_range.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/regmap.h>
+
+enum {
+	MT6370_LED_ISNK1 = 0,
+	MT6370_LED_ISNK2,
+	MT6370_LED_ISNK3,
+	MT6370_LED_ISNK4,
+	MT6370_MAX_LEDS
+};
+
+enum mt6370_led_mode {
+	MT6370_LED_PWM_MODE = 0,
+	MT6370_LED_BREATH_MODE,
+	MT6370_LED_REG_MODE,
+	MT6370_LED_MAX_MODE
+};
+
+enum mt6370_led_field {
+	F_RGB_EN = 0,
+	F_CHGIND_EN,
+	F_LED1_CURR,
+	F_LED2_CURR,
+	F_LED3_CURR,
+	F_LED4_CURR,
+	F_LED1_MODE,
+	F_LED2_MODE,
+	F_LED3_MODE,
+	F_LED4_MODE,
+	F_LED1_DUTY,
+	F_LED2_DUTY,
+	F_LED3_DUTY,
+	F_LED4_DUTY,
+	F_LED1_FREQ,
+	F_LED2_FREQ,
+	F_LED3_FREQ,
+	F_LED4_FREQ,
+	F_MAX_FIELDS
+};
+
+enum mt6370_led_ranges {
+	R_LED123_CURR = 0,
+	R_LED4_CURR,
+	R_LED_TRFON,
+	R_LED_TOFF,
+	R_MAX_RANGES,
+};
+
+enum mt6370_pattern {
+	P_LED_TR1 = 0,
+	P_LED_TR2,
+	P_LED_TF1,
+	P_LED_TF2,
+	P_LED_TON,
+	P_LED_TOFF,
+	P_MAX_PATTERNS
+};
+
+#define MT6370_REG_DEV_INFO			0x100
+#define MT6370_REG_RGB1_DIM			0x182
+#define MT6370_REG_RGB2_DIM			0x183
+#define MT6370_REG_RGB3_DIM			0x184
+#define MT6370_REG_RGB_EN			0x185
+#define MT6370_REG_RGB1_ISNK			0x186
+#define MT6370_REG_RGB2_ISNK			0x187
+#define MT6370_REG_RGB3_ISNK			0x188
+#define MT6370_REG_RGB1_TR			0x189
+#define MT6370_REG_RGB_CHRIND_DIM		0x192
+#define MT6370_REG_RGB_CHRIND_CTRL		0x193
+#define MT6370_REG_RGB_CHRIND_TR		0x194
+
+#define MT6372_REG_RGB_EN			0x182
+#define MT6372_REG_RGB1_ISNK			0x183
+#define MT6372_REG_RGB2_ISNK			0x184
+#define MT6372_REG_RGB3_ISNK			0x185
+#define MT6372_REG_RGB4_ISNK			0x186
+#define MT6372_REG_RGB1_DIM			0x187
+#define MT6372_REG_RGB2_DIM			0x188
+#define MT6372_REG_RGB3_DIM			0x189
+#define MT6372_REG_RGB4_DIM			0x18A

drivers/leds/leds-mt6370.c line 105

Quoted 10 lines
drivers/leds/leds-mt6370.c new file +10 -0
+#define MT6372_REG_RGB12_FREQ			0x18B
+#define MT6372_REG_RGB34_FREQ			0x18C
+#define MT6372_REG_RGB1_TR			0x18D
+
+#define MT6370_VENID_MASK			GENMASK(7, 4)
+#define MT6370_CHEN_BIT(id)			BIT(MT6370_LED_ISNK4 - id)
+#define MT6370_VIRTUAL_MULTICOLOR		5
+#define MC_CHANNEL_NUM				3
+#define MT6370_PWM_DUTY				31
+#define MT6372_PMW_DUTY				255

Please fix this typo: PMW -> PWM

drivers/leds/leds-mt6370.c line 109

Quoted 4 lines
drivers/leds/leds-mt6370.c new file +4 -0
+
+#define STATE_OFF				0
+#define STATE_KEEP				1
+#define STATE_ON				2

I propose, instead:

enum mt6370_state {
	STATE_OFF = 0,
	STATE_KEEP,
	STATE_ON,
	STATE_MAX,
};
Quoted 13 lines
drivers/leds/leds-mt6370.c new file +13 -0
+
+struct mt6370_led {
+	union {
+		struct led_classdev isink;
+		struct led_classdev_mc mc;
+	};
+	struct mt6370_priv *priv;
+	u32 default_state;
+	u32 index;
+};
+
+struct mt6370_priv {
+	/* Per LED access lock */

drivers/leds/leds-mt6370.c line 132

Quoted 10 lines
drivers/leds/leds-mt6370.c new file +10 -0
+	struct mutex lock;
+	struct device *dev;
+	struct regmap *regmap;
+	struct regmap_field *fields[F_MAX_FIELDS];
+	const struct reg_field *reg_fields;
+	const struct linear_range *ranges;
+	struct reg_cfg *reg_cfgs;
+	unsigned int leds_count;
+	unsigned int leds_active;
+	bool is_mt6372;

Instead of using a bool for that, you can enhance the flexibility of this driver (and also somewhat reduce cpu cycles) by using:

	struct mt6370_pdata *pdata;

where a good definition of that structure would be...

struct mt6370_pdata {

	const unsigned int *tfreq;

	unsigned int tfreq_len;

	u8 pwm_duty;

	u8 reg_rgb1_tr;	



	/*

	 * You can set this one to -1 on MT6372 to indicate that

	 * this register does not exist (hence use that in function

	 * mt6370_get_breath_reg_base() to replace priv->is_mt6372)

	 */

	s16 reg_rgb_chrind_tr;

};

Quoted 126 lines
drivers/leds/leds-mt6370.c new file +126 -0
+	struct mt6370_led leds[];
+};
+
+static const struct reg_field common_reg_fields[F_MAX_FIELDS] = {
+	[F_RGB_EN]	= REG_FIELD(MT6370_REG_RGB_EN, 4, 7),
+	[F_CHGIND_EN]	= REG_FIELD(MT6370_REG_RGB_CHRIND_DIM, 7, 7),
+	[F_LED1_CURR]	= REG_FIELD(MT6370_REG_RGB1_ISNK, 0, 2),
+	[F_LED2_CURR]	= REG_FIELD(MT6370_REG_RGB2_ISNK, 0, 2),
+	[F_LED3_CURR]	= REG_FIELD(MT6370_REG_RGB3_ISNK, 0, 2),
+	[F_LED4_CURR]	= REG_FIELD(MT6370_REG_RGB_CHRIND_CTRL, 0, 1),
+	[F_LED1_MODE]	= REG_FIELD(MT6370_REG_RGB1_DIM, 5, 6),
+	[F_LED2_MODE]	= REG_FIELD(MT6370_REG_RGB2_DIM, 5, 6),
+	[F_LED3_MODE]	= REG_FIELD(MT6370_REG_RGB3_DIM, 5, 6),
+	[F_LED4_MODE]	= REG_FIELD(MT6370_REG_RGB_CHRIND_DIM, 5, 6),
+	[F_LED1_DUTY]	= REG_FIELD(MT6370_REG_RGB1_DIM, 0, 4),
+	[F_LED2_DUTY]	= REG_FIELD(MT6370_REG_RGB2_DIM, 0, 4),
+	[F_LED3_DUTY]	= REG_FIELD(MT6370_REG_RGB3_DIM, 0, 4),
+	[F_LED4_DUTY]	= REG_FIELD(MT6370_REG_RGB_CHRIND_DIM, 0, 4),
+	[F_LED1_FREQ]	= REG_FIELD(MT6370_REG_RGB1_ISNK, 3, 5),
+	[F_LED2_FREQ]	= REG_FIELD(MT6370_REG_RGB2_ISNK, 3, 5),
+	[F_LED3_FREQ]	= REG_FIELD(MT6370_REG_RGB3_ISNK, 3, 5),
+	[F_LED4_FREQ]	= REG_FIELD(MT6370_REG_RGB_CHRIND_CTRL, 2, 4)
+};
+
+static const struct reg_field mt6372_reg_fields[F_MAX_FIELDS] = {
+	[F_RGB_EN]	= REG_FIELD(MT6372_REG_RGB_EN, 4, 7),
+	[F_CHGIND_EN]	= REG_FIELD(MT6372_REG_RGB_EN, 3, 3),
+	[F_LED1_CURR]	= REG_FIELD(MT6372_REG_RGB1_ISNK, 0, 3),
+	[F_LED2_CURR]	= REG_FIELD(MT6372_REG_RGB2_ISNK, 0, 3),
+	[F_LED3_CURR]	= REG_FIELD(MT6372_REG_RGB3_ISNK, 0, 3),
+	[F_LED4_CURR]	= REG_FIELD(MT6372_REG_RGB4_ISNK, 0, 3),
+	[F_LED1_MODE]	= REG_FIELD(MT6372_REG_RGB1_ISNK, 6, 7),
+	[F_LED2_MODE]	= REG_FIELD(MT6372_REG_RGB2_ISNK, 6, 7),
+	[F_LED3_MODE]	= REG_FIELD(MT6372_REG_RGB3_ISNK, 6, 7),
+	[F_LED4_MODE]	= REG_FIELD(MT6372_REG_RGB4_ISNK, 6, 7),
+	[F_LED1_DUTY]	= REG_FIELD(MT6372_REG_RGB1_DIM, 0, 7),
+	[F_LED2_DUTY]	= REG_FIELD(MT6372_REG_RGB2_DIM, 0, 7),
+	[F_LED3_DUTY]	= REG_FIELD(MT6372_REG_RGB3_DIM, 0, 7),
+	[F_LED4_DUTY]	= REG_FIELD(MT6372_REG_RGB4_DIM, 0, 7),
+	[F_LED1_FREQ]	= REG_FIELD(MT6372_REG_RGB12_FREQ, 5, 7),
+	[F_LED2_FREQ]	= REG_FIELD(MT6372_REG_RGB12_FREQ, 2, 4),
+	[F_LED3_FREQ]	= REG_FIELD(MT6372_REG_RGB34_FREQ, 5, 7),
+	[F_LED4_FREQ]	= REG_FIELD(MT6372_REG_RGB34_FREQ, 2, 4)
+};
+
+/* Current unit: microamp, time unit: millisecond */
+static const struct linear_range common_led_ranges[R_MAX_RANGES] = {
+	[R_LED123_CURR]	= { 4000, 1, 6, 4000 },
+	[R_LED4_CURR]	= { 2000, 1, 3, 2000 },
+	[R_LED_TRFON]	= { 125, 0, 15, 200 },
+	[R_LED_TOFF]	= { 250, 0, 15, 400 }
+};
+
+static const struct linear_range mt6372_led_ranges[R_MAX_RANGES] = {
+	[R_LED123_CURR]	= { 2000, 1, 14, 2000 },
+	[R_LED4_CURR]	= { 2000, 1, 14, 2000 },
+	[R_LED_TRFON]	= { 125, 0, 15, 250 },
+	[R_LED_TOFF]	= { 250, 0, 15, 500 }
+};
+
+static enum mt6370_led_field mt6370_get_led_current_field(unsigned int led_no)
+{
+	switch (led_no) {
+	case MT6370_LED_ISNK1:
+		return F_LED1_CURR;
+	case MT6370_LED_ISNK2:
+		return F_LED2_CURR;
+	case MT6370_LED_ISNK3:
+		return F_LED3_CURR;
+	default:
+		return F_LED4_CURR;
+	}
+}
+
+static int mt6370_set_led_brightness(struct mt6370_priv *priv,
+				     unsigned int led_no, unsigned int level)
+{
+	enum mt6370_led_field sel_field;
+
+	sel_field = mt6370_get_led_current_field(led_no);
+
+	return regmap_field_write(priv->fields[sel_field], level);
+}
+
+static int mt6370_get_led_brightness(struct mt6370_priv *priv,
+				     unsigned int led_no, unsigned int *level)
+{
+	enum mt6370_led_field sel_field;
+
+	sel_field = mt6370_get_led_current_field(led_no);
+
+	return regmap_field_read(priv->fields[sel_field], level);
+}
+
+static int mt6370_set_led_duty(struct mt6370_priv *priv, unsigned int led_no,
+			       unsigned int ton, unsigned int toff)
+{
+	enum mt6370_led_field sel_field;
+	unsigned int divisor, ratio;
+
+	divisor = priv->is_mt6372 ? MT6372_PMW_DUTY : MT6370_PWM_DUTY;
+	ratio = ton * divisor / (ton + toff);
+
+	switch (led_no) {
+	case MT6370_LED_ISNK1:
+		sel_field = F_LED1_DUTY;
+		break;
+	case MT6370_LED_ISNK2:
+		sel_field = F_LED2_DUTY;
+		break;
+	case MT6370_LED_ISNK3:
+		sel_field = F_LED3_DUTY;
+		break;
+	default:
+		sel_field = F_LED4_DUTY;
+	}
+
+	return regmap_field_write(priv->fields[sel_field], ratio);
+}
+
+static const unsigned int common_tfreqs[] = {
+	10000, 5000, 2000, 1000, 500, 200, 5, 1,
+};
+
+static const unsigned int mt6372_tfreqs[] = {
+	8000, 4000, 2000, 1000, 500, 250, 8, 4,

drivers/leds/leds-mt6370.c line 268

Quoted 10 lines
drivers/leds/leds-mt6370.c new file +10 -0
+};
+
+static int mt6370_set_led_freq(struct mt6370_priv *priv, unsigned int led_no,
+			       unsigned int ton, unsigned int toff)
+{
+	enum mt6370_led_field sel_field;
+	const unsigned int *tfreq;
+	unsigned int tfreq_len, tsum;
+	int i;
+

...so, if you have pdata, here you'll do:

	struct mt6370_pdata *pdata = priv->pdata;

drivers/leds/leds-mt6370.c line 279

Quoted 11 lines
drivers/leds/leds-mt6370.c new file +11 -0
+	if (priv->is_mt6372) {
+		tfreq = mt6372_tfreqs;
+		tfreq_len = ARRAY_SIZE(mt6372_tfreqs);
+	} else {
+		tfreq = common_tfreqs;
+		tfreq_len = ARRAY_SIZE(common_tfreqs);
+	}
+
+	tsum = ton + toff;
+
+	if (tsum > tfreq[0] || tsum < tfreq[tfreq_len - 1])
	if (tsum > pdata->tfreq[0] || tsum < pdata->tfreq[pdata->tfreq_len - 1])

( etc etc etc )

Quoted 17 lines
drivers/leds/leds-mt6370.c new file +17 -0
+		return -EOPNOTSUPP;
+
+	for (i = 0; i < tfreq_len; i++) {
+		if (tsum >= tfreq[i])
+			break;
+	}
+
+	switch (led_no) {
+	case MT6370_LED_ISNK1:
+		sel_field = F_LED1_FREQ;
+		break;
+	case MT6370_LED_ISNK2:
+		sel_field = F_LED2_FREQ;
+		break;
+	case MT6370_LED_ISNK3:
+		sel_field = F_LED3_FREQ;
+		break;

drivers/leds/leds-mt6370.c line 306

Quoted 10 lines
drivers/leds/leds-mt6370.c new file +10 -0
+	default:
+		sel_field = F_LED4_FREQ;
+	}
+
+	return regmap_field_write(priv->fields[sel_field], i);
+}
+
+static void mt6370_get_breath_reg_base(struct mt6370_priv *priv,
+				       unsigned int led_no, unsigned int *base)
+{
	if (pdata->reg_rgb_chrind_tr < 0) {
		*base = pdata->reg_rgb1_tr + led_no * 3;
		return;
	}
Quoted 566 lines
drivers/leds/leds-mt6370.c new file +566 -0
+	if (priv->is_mt6372) {
+		*base = MT6372_REG_RGB1_TR + led_no * 3;
+		return;
+	}
+
+	switch (led_no) {
+	case MT6370_LED_ISNK1:
+	case MT6370_LED_ISNK2:
+	case MT6370_LED_ISNK3:
+		*base = MT6370_REG_RGB1_TR + led_no * 3;
+		break;
+	default:
+		*base = MT6370_REG_RGB_CHRIND_TR;
+	}
+}
+
+static int mt6370_gen_breath_pattern(struct mt6370_priv *priv,
+				     struct led_pattern *pattern, u32 len,
+				     u8 *pattern_val, u32 val_len)
+{
+	enum mt6370_led_ranges sel_range;
+	struct led_pattern *curr;
+	unsigned int sel;
+	u8 val[P_MAX_PATTERNS / 2] = {0};
+	int i;
+
+	if (len < P_MAX_PATTERNS && val_len < P_MAX_PATTERNS / 2)
+		return -EINVAL;
+
+	/*
+	 * Pattern list
+	 * tr1:	byte 0, b'[7: 4]
+	 * tr2:	byte 0, b'[3: 0]
+	 * tf1:	byte 1, b'[7: 4]
+	 * tf2:	byte 1, b'[3: 0]
+	 * ton:	byte 2, b'[7: 4]
+	 * toff: byte 2, b'[3: 0]
+	 */
+	for (i = 0; i < P_MAX_PATTERNS; i++) {
+		curr = pattern + i;
+
+		sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+		linear_range_get_selector_within(priv->ranges + sel_range,
+						 curr->delta_t, &sel);
+
+		val[i / 2] |= sel << (4 * ((i + 1) % 2));
+	}
+
+	memcpy(pattern_val, val, 3);
+	return 0;
+}
+
+static int mt6370_set_led_mode(struct mt6370_priv *priv, unsigned int led_no,
+			       enum mt6370_led_mode mode)
+{
+	enum mt6370_led_field sel_field;
+
+	switch (led_no) {
+	case MT6370_LED_ISNK1:
+		sel_field = F_LED1_MODE;
+		break;
+	case MT6370_LED_ISNK2:
+		sel_field = F_LED2_MODE;
+		break;
+	case MT6370_LED_ISNK3:
+		sel_field = F_LED3_MODE;
+		break;
+	default:
+		sel_field = F_LED4_MODE;
+	}
+
+	return regmap_field_write(priv->fields[sel_field], mode);
+}
+
+static int mt6370_mc_brightness_set(struct led_classdev *lcdev,
+				    enum led_brightness level)
+{
+	struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
+	struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
+	struct mt6370_priv *priv = led->priv;
+	struct mc_subled *subled;
+	unsigned int enable, disable;
+	int i, ret;
+
+	mutex_lock(&priv->lock);
+
+	led_mc_calc_color_components(mccdev, level);
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		goto out;
+
+	disable = enable;
+
+	for (i = 0; i < mccdev->num_colors; i++) {
+		u32 brightness;
+
+		subled = mccdev->subled_info + i;
+		brightness = min(subled->brightness, lcdev->max_brightness);
+		disable &= ~MT6370_CHEN_BIT(subled->channel);
+
+		if (level == LED_OFF) {
+			enable &= ~MT6370_CHEN_BIT(subled->channel);
+
+			ret = mt6370_set_led_mode(priv, subled->channel,
+						  MT6370_LED_REG_MODE);
+			if (ret)
+				goto out;
+
+			continue;
+		}
+
+		if (brightness == LED_OFF) {
+			enable &= ~MT6370_CHEN_BIT(subled->channel);
+			continue;
+		}
+
+		enable |= MT6370_CHEN_BIT(subled->channel);
+
+		ret = mt6370_set_led_brightness(priv, subled->channel,
+						brightness);
+		if (ret)
+			goto out;
+	}
+
+	ret = regmap_field_write(priv->fields[F_RGB_EN], disable);
+	if (ret)
+		goto out;
+
+	ret = regmap_field_write(priv->fields[F_RGB_EN], enable);
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static int mt6370_mc_blink_set(struct led_classdev *lcdev,
+			       unsigned long *delay_on,
+			       unsigned long *delay_off)
+{
+	struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
+	struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
+	struct mt6370_priv *priv = led->priv;
+	struct mc_subled *subled;
+	unsigned int enable, disable;
+	int i, ret;
+
+	mutex_lock(&priv->lock);
+
+	if (!*delay_on && !*delay_off)
+		*delay_on = *delay_off = 500;
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		goto out;
+
+	disable = enable;
+
+	for (i = 0; i < mccdev->num_colors; i++) {
+		subled = mccdev->subled_info + i;
+
+		disable &= ~MT6370_CHEN_BIT(subled->channel);
+
+		ret = mt6370_set_led_duty(priv, subled->channel, *delay_on,
+					  *delay_off);
+		if (ret)
+			goto out;
+
+		ret = mt6370_set_led_freq(priv, subled->channel, *delay_on,
+					  *delay_off);
+		if (ret)
+			goto out;
+
+		ret = mt6370_set_led_mode(priv, subled->channel,
+					  MT6370_LED_PWM_MODE);
+		if (ret)
+			goto out;
+	}
+
+	/* Toggle to make pattern timing the same */
+	ret = regmap_field_write(priv->fields[F_RGB_EN], disable);
+	if (ret)
+		goto out;
+
+	ret = regmap_field_write(priv->fields[F_RGB_EN], enable);
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static int mt6370_mc_pattern_set(struct led_classdev *lcdev,
+			struct led_pattern *pattern, u32 len, int repeat)
+{
+	struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
+	struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
+	struct mt6370_priv *priv = led->priv;
+	struct mc_subled *subled;
+	unsigned int reg_base, enable, disable;
+	u8 params[P_MAX_PATTERNS / 2];
+	int i, ret;
+
+	mutex_lock(&priv->lock);
+
+	ret = mt6370_gen_breath_pattern(priv, pattern, len, params,
+					sizeof(params));
+	if (ret)
+		goto out;
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		goto out;
+
+	disable = enable;
+
+	for (i = 0; i < mccdev->num_colors; i++) {
+		subled = mccdev->subled_info + i;
+
+		mt6370_get_breath_reg_base(priv, subled->channel, &reg_base);
+		disable &= ~MT6370_CHEN_BIT(subled->channel);
+
+		ret = regmap_raw_write(priv->regmap, reg_base, params,
+				       sizeof(params));
+		if (ret)
+			goto out;
+
+		ret = mt6370_set_led_mode(priv, subled->channel,
+					  MT6370_LED_BREATH_MODE);
+		if (ret)
+			goto out;
+	}
+
+	/* Toggle to make pattern timing be the same */
+	ret = regmap_field_write(priv->fields[F_RGB_EN], disable);
+	if (ret)
+		goto out;
+
+	ret = regmap_field_write(priv->fields[F_RGB_EN], enable);
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
+{
+	struct led_classdev_mc *mccdev = lcdev_to_mccdev(lcdev);
+	struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
+	struct mt6370_priv *priv = led->priv;
+	struct mc_subled *subled;
+	int i, ret = 0;
+
+	mutex_lock(&led->priv->lock);
+
+	for (i = 0; i < mccdev->num_colors; i++) {
+		subled = mccdev->subled_info + i;
+
+		ret = mt6370_set_led_mode(priv, subled->channel,
+					  MT6370_LED_REG_MODE);
+		if (ret)
+			break;
+	}
+
+	mutex_unlock(&led->priv->lock);
+
+	return ret;
+}
+
+static int mt6370_isnk_brightness_set(struct led_classdev *lcdev,
+				      enum led_brightness level)
+{
+	struct mt6370_led *led = container_of(lcdev, struct mt6370_led, isink);
+	struct mt6370_priv *priv = led->priv;
+	unsigned int enable;
+	int ret;
+
+	mutex_lock(&priv->lock);
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		goto out;
+
+	if (level == LED_OFF) {
+		enable &= ~MT6370_CHEN_BIT(led->index);
+
+		ret = mt6370_set_led_mode(priv, led->index,
+					  MT6370_LED_REG_MODE);
+		if (ret)
+			goto out;
+
+		ret = regmap_field_write(priv->fields[F_RGB_EN], enable);
+	} else {
+		enable |= MT6370_CHEN_BIT(led->index);
+
+		ret = mt6370_set_led_brightness(priv, led->index, level);
+		if (ret)
+			goto out;
+
+		ret = regmap_field_write(priv->fields[F_RGB_EN], enable);
+	}
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static int mt6370_isnk_blink_set(struct led_classdev *lcdev,
+				 unsigned long *delay_on,
+				 unsigned long *delay_off)
+{
+	struct mt6370_led *led = container_of(lcdev, struct mt6370_led, isink);
+	struct mt6370_priv *priv = led->priv;
+	int ret;
+
+	mutex_lock(&priv->lock);
+
+	if (!*delay_on && !*delay_off)
+		*delay_on = *delay_off = 500;
+
+	ret = mt6370_set_led_duty(priv, led->index, *delay_on, *delay_off);
+	if (ret)
+		goto out;
+
+	ret = mt6370_set_led_freq(priv, led->index, *delay_on, *delay_off);
+	if (ret)
+		goto out;
+
+	ret = mt6370_set_led_mode(priv, led->index, MT6370_LED_PWM_MODE);
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static int mt6370_isnk_pattern_set(struct led_classdev *lcdev,
+				   struct led_pattern *pattern, u32 len,
+				   int repeat)
+{
+	struct mt6370_led *led = container_of(lcdev, struct mt6370_led, isink);
+	struct mt6370_priv *priv = led->priv;
+	unsigned int reg_base;
+	u8 params[P_MAX_PATTERNS / 2];
+	int ret;
+
+	mutex_lock(&priv->lock);
+
+	ret = mt6370_gen_breath_pattern(priv, pattern, len, params,
+					sizeof(params));
+	if (ret)
+		goto out;
+
+	mt6370_get_breath_reg_base(priv, led->index, &reg_base);
+
+	ret = regmap_raw_write(priv->regmap, reg_base, params, sizeof(params));
+	if (ret)
+		goto out;
+
+	ret = mt6370_set_led_mode(priv, led->index, MT6370_LED_BREATH_MODE);
+
+out:
+	mutex_unlock(&priv->lock);
+
+	return ret;
+}
+
+static inline int mt6370_isnk_pattern_clear(struct led_classdev *lcdev)
+{
+	struct mt6370_led *led = container_of(lcdev, struct mt6370_led, isink);
+	struct mt6370_priv *priv = led->priv;
+	int ret;
+
+	mutex_lock(&led->priv->lock);
+	ret = mt6370_set_led_mode(priv, led->index, MT6370_LED_REG_MODE);
+	mutex_unlock(&led->priv->lock);
+
+	return ret;
+}
+
+static int mt6370_init_led_properties(struct mt6370_led *led,
+				      struct led_init_data *init_data)
+{
+	struct mt6370_priv *priv = led->priv;
+	struct led_classdev *lcdev;
+	struct fwnode_handle *child;
+	enum mt6370_led_ranges sel_range;
+	u32 max_uA, max_level;
+	const char * const states[] = { "off", "keep", "on" };
+	const char *stat_str;
+	int ret;
+
+	if (led->index == MT6370_VIRTUAL_MULTICOLOR) {
+		struct mc_subled *sub_led;
+		u32 num_color = 0;
+
+		sub_led = devm_kzalloc(priv->dev,
+				       sizeof(*sub_led) * MC_CHANNEL_NUM,
+				       GFP_KERNEL);
+		if (!sub_led)
+			return -ENOMEM;
+
+		fwnode_for_each_child_node(init_data->fwnode, child) {
+			u32 reg, color;
+
+			ret = fwnode_property_read_u32(child, "reg", &reg);
+			if (ret || reg > MT6370_LED_ISNK3 ||
+			    priv->leds_active & BIT(reg))
+				return -EINVAL;
+
+			ret = fwnode_property_read_u32(child, "color", &color);
+			if (ret) {
+				dev_err(priv->dev,
+					"led %d, no color specified\n",
+					led->index);
+				return ret;
+			}
+
+			priv->leds_active |= BIT(reg);
+			sub_led[num_color].color_index = color;
+			sub_led[num_color].channel = reg;
+			num_color++;
+		}
+
+		if (num_color < 2) {
+			dev_err(priv->dev,
+				"Multicolor must include 2 or more led channel\n");
+			return -EINVAL;
+		}
+
+		led->mc.num_colors = num_color;
+		led->mc.subled_info = sub_led;
+
+		lcdev = &led->mc.led_cdev;
+		lcdev->brightness_set_blocking = mt6370_mc_brightness_set;
+		lcdev->blink_set = mt6370_mc_blink_set;
+		lcdev->pattern_set = mt6370_mc_pattern_set;
+		lcdev->pattern_clear = mt6370_mc_pattern_clear;
+	} else {
+		lcdev = &led->isink;
+		lcdev->brightness_set_blocking = mt6370_isnk_brightness_set;
+		lcdev->blink_set = mt6370_isnk_blink_set;
+		lcdev->pattern_set = mt6370_isnk_pattern_set;
+		lcdev->pattern_clear = mt6370_isnk_pattern_clear;
+	}
+
+	ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp",
+				       &max_uA);
+	if (ret) {
+		dev_warn(priv->dev,
+		   "Not specified led-max-microamp, config to the minimum\n");
+		max_uA = 0;
+	}
+
+	if (led->index == MT6370_LED_ISNK4)
+		sel_range = R_LED4_CURR;
+	else
+		sel_range = R_LED123_CURR;
+
+	linear_range_get_selector_within(priv->ranges + sel_range, max_uA,
+					 &max_level);
+
+	lcdev->max_brightness = max_level;
+
+	fwnode_property_read_string(init_data->fwnode, "linux,default-trigger",
+			&lcdev->default_trigger);
+
+	if (!fwnode_property_read_string(init_data->fwnode, "default-state",
+					 &stat_str)) {
+		ret = match_string(states, ARRAY_SIZE(states), stat_str);
+		if (ret < 0)
+			ret = STATE_OFF;
+
+		led->default_state = ret;
+	}
+
+	return 0;
+}
+
+static int mt6370_isnk_init_default_state(struct mt6370_led *led)
+{
+	struct mt6370_priv *priv = led->priv;
+	unsigned int enable, level;
+	int ret;
+
+	ret = mt6370_get_led_brightness(priv, led->index, &level);
+	if (ret)
+		return ret;
+
+	ret = regmap_field_read(priv->fields[F_RGB_EN], &enable);
+	if (ret)
+		return ret;
+
+	if (!(enable & MT6370_CHEN_BIT(led->index)))
+		level = LED_OFF;
+
+	switch (led->default_state) {
+	case STATE_ON:
+		led->isink.brightness = led->isink.max_brightness;
+		break;
+	case STATE_KEEP:
+		led->isink.brightness = min(level, led->isink.max_brightness);
+		break;
+	default:
+		led->isink.brightness = LED_OFF;
+	}
+
+	return mt6370_isnk_brightness_set(&led->isink, led->isink.brightness);
+}
+
+static int mt6370_led_register(struct device *parent, struct mt6370_led *led,
+			       struct led_init_data *init_data)
+{
+	struct mt6370_priv *priv = led->priv;
+	int ret;
+
+	if (led->index == MT6370_VIRTUAL_MULTICOLOR) {
+		ret = mt6370_mc_brightness_set(&led->mc.led_cdev, LED_OFF);
+		if (ret) {
+			dev_err(parent, "Couldn't set multicolor brightness\n");
+			return ret;
+		}
+
+		ret = devm_led_classdev_multicolor_register_ext(parent,
+								&led->mc,
+								init_data);
+		if (ret) {
+			dev_err(parent, "Couldn't register multicolor\n");
+			return ret;
+		}
+	} else {
+		if (led->index == MT6370_LED_ISNK4) {
+			ret = regmap_field_write(priv->fields[F_CHGIND_EN], 1);
+			if (ret) {
+				dev_err(parent, "Failed to set CHRIND to SW\n");
+				return ret;
+			}
+		}
+
+		ret = mt6370_isnk_init_default_state(led);
+		if (ret) {
+			dev_err(parent, "Failed to init %d isnk state\n",
+				led->index);
+			return ret;
+		}
+
+		ret = devm_led_classdev_register_ext(parent, &led->isink,
+						     init_data);
+		if (ret) {
+			dev_err(parent, "Couldn't register isink %d\n",
+				led->index);
+			return ret;
+		}
+	}
+
+	return 0;
+}
+
+static int mt6370_check_vendor_info(struct mt6370_priv *priv)
+{
+	unsigned int devinfo, vid;
+	int ret;

drivers/leds/leds-mt6370.c line 882

Quoted 10 lines
drivers/leds/leds-mt6370.c new file +10 -0
+
+	ret = regmap_read(priv->regmap, MT6370_REG_DEV_INFO, &devinfo);
+	if (ret)
+		return ret;
+
+	vid = FIELD_GET(MT6370_VENID_MASK, devinfo);
+	if (vid == 0x9 || vid == 0xb) {
+		priv->reg_fields = mt6372_reg_fields;
+		priv->ranges = mt6372_led_ranges;
+		priv->is_mt6372 = true;
		priv->pdata = &mt6372_pdata;

drivers/leds/leds-mt6370.c line 885

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+	} else {
+		priv->reg_fields = common_reg_fields;
+		priv->ranges = common_led_ranges;
		priv->pdata = &mt6370_pdata;

drivers/leds/leds-mt6370.c line 358

Quoted 4 lines
drivers/leds/leds-mt6370.c new file +4 -0
+	}
+
+	return 0;
+}

Regards,
Angelo

Reviewed-by on v5 7/13
#9 lore raw

Re: [PATCH v5 07/13] mfd: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu
Quoted 8 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

This adds support for the MediaTek MT6370 SubPMIC. MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

FWIW,

Quoted 454 lines

---
v5

- Add the comma in the last REGMAP_IRQ_REG_LINE(), DEFINE_RES_IRQ_NAMED() and MFD_CELL_RES()
- Add the prefix in the first parameter of all mfd_cell
- Move enum and struct mt6370_info to mt6370.h
- Remove struct device *dev in struct mt6370_info
- Revise the description of Kconfig help text
- Revise MODULE_DESCRIPTION()

---
 drivers/mfd/Kconfig  |  16 +++
 drivers/mfd/Makefile |   1 +
 drivers/mfd/mt6370.c | 281 +++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/mfd/mt6370.h |  99 ++++++++++++++++++
 4 files changed, 397 insertions(+)
 create mode 100644 drivers/mfd/mt6370.c
 create mode 100644 drivers/mfd/mt6370.h
drivers/mfd/Kconfig +16 -0
index 3b59456..a9bcae3 100644
@@ -937,6 +937,22 @@ config MFD_MT6360
          PMIC part includes 2-channel BUCKs and 2-channel LDOs
          LDO part includes 4-channel LDOs
 
+config MFD_MT6370
+       tristate "MediaTek MT6370 SubPMIC"
+       select MFD_CORE
+       select REGMAP_I2C
+       select REGMAP_IRQ
+       depends on I2C
+       help
+         Say Y here to enable MT6370 SubPMIC functional support.
+         It consists of a single cell battery charger with ADC monitoring, RGB
+         LEDs, dual channel flashlight, WLED backlight driver, display bias
+         voltage supply, one general purpose LDO, and the USB Type-C & PD
+         controller complies with the latest USB Type-C and PD standards.
+
+         This driver can also be built as a module. If so, the module
+         will be called "mt6370".
+
 config MFD_MT6397
        tristate "MediaTek MT6397 PMIC Support"
        select MFD_CORE
drivers/mfd/Makefile +1 -0
index 8c69867..81dbed3 100644
@@ -173,6 +173,7 @@ obj-$(CONFIG_MFD_MAX8998)   += max8998.o max8998-irq.o
 obj-$(CONFIG_MFD_MP2629)       += mp2629.o
 
 obj-$(CONFIG_MFD_MT6360)       += mt6360-core.o
+obj-$(CONFIG_MFD_MT6370)       += mt6370.o
 mt6397-objs                    := mt6397-core.o mt6397-irq.o mt6358-irq.o
 obj-$(CONFIG_MFD_MT6397)       += mt6397.o
 
drivers/mfd/mt6370.c new file +281 -0
new file mode 100644
index 0000000..070c1c7
@@ -0,0 +1,281 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiYuan Huang <[email protected]>
+ */
+
+#include <linux/bits.h>
+#include <linux/bitfield.h>
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/mfd/core.h>
+#include <linux/module.h>
+#include <linux/regmap.h>
+
+#include "mt6370.h"
+
+#define MT6370_REG_DEV_INFO    0x100
+#define MT6370_REG_CHG_IRQ1    0x1C0
+#define MT6370_REG_CHG_MASK1   0x1E0
+
+#define MT6370_VENID_MASK      GENMASK(7, 4)
+
+#define MT6370_NUM_IRQREGS     16
+#define MT6370_USBC_I2CADDR    0x4E
+#define MT6370_REG_ADDRLEN     2
+#define MT6370_REG_MAXADDR     0x1FF
+
+#define MT6370_VENID_RT5081    0x8
+#define MT6370_VENID_RT5081A   0xA
+#define MT6370_VENID_MT6370    0xE
+#define MT6370_VENID_MT6371    0xF
+#define MT6370_VENID_MT6372P   0x9
+#define MT6370_VENID_MT6372CP  0xB
+
+static const struct regmap_irq mt6370_irqs[] = {
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHGON, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_TREG, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_AICR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_MIVR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_PWR_RDY, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FL_CHG_VINOVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_VSYSUV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_VSYSOV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_VBATOV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_VINOVPCHG, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TS_BAT_COLD, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TS_BAT_COOL, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TS_BAT_WARM, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TS_BAT_HOT, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TS_STATC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_FAULT, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_STATC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_TMR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_BATABS, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_ADPBAD, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_RVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_TSHUTDOWN, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_IINMEAS, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_ICCMEAS, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHGDET_DONE, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_WDTMR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_SSFINISH, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_RECHG, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_TERM, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHG_IEOC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_ADC_DONE, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_PUMPX_DONE, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_BST_BATUV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_BST_MIDOV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_BST_OLP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_ATTACH, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DETACH, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_HVDCP_STPDONE, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_HVDCP_VBUSDET_DONE, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_HVDCP_DET, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_CHGDET, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DCDT, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHG_VGOK, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHG_WDTMR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHG_UC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHG_OC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DIRCHG_OV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OVPCTRL_SWON, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OVPCTRL_UVP_D, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OVPCTRL_UVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OVPCTRL_OVP_D, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OVPCTRL_OVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED_STRBPIN, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED_TORPIN, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED_TX, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED_LVF, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_SHORT, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_SHORT, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_STRB, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB, 8),
+       REGMAP_IRQ_REG_LINE(mT6370_IRQ_FLED2_STRB_TO, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_STRB_TO, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED2_TOR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_FLED1_TOR, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_OTP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_VDDA_OVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_VDDA_UV, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_LDO_OC, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_BLED_OCP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_BLED_OVP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DSV_VNEG_OCP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DSV_VPOS_OCP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DSV_BST_OCP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DSV_VNEG_SCP, 8),
+       REGMAP_IRQ_REG_LINE(MT6370_IRQ_DSV_VPOS_SCP, 8),
+};
+
+static const struct regmap_irq_chip mt6370_irq_chip = {
+       .name           = "mt6370-irqs",
+       .status_base    = MT6370_REG_CHG_IRQ1,
+       .mask_base      = MT6370_REG_CHG_MASK1,
+       .num_regs       = MT6370_NUM_IRQREGS,
+       .irqs           = mt6370_irqs,
+       .num_irqs       = ARRAY_SIZE(mt6370_irqs),
+};
+
+static const struct resource mt6370_regulator_irqs[] = {
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_DSV_VPOS_SCP, "db_vpos_scp"),
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_DSV_VNEG_SCP, "db_vneg_scp"),
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_DSV_BST_OCP, "db_vbst_ocp"),
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_DSV_VPOS_OCP, "db_vpos_ocp"),
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_DSV_VNEG_OCP, "db_vneg_ocp"),
+       DEFINE_RES_IRQ_NAMED(MT6370_IRQ_LDO_OC, "ldo_oc"),
+};
+
+static const struct mfd_cell mt6370_devices[] = {
+       MFD_CELL_OF("mt6370-adc",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-adc"),
+       MFD_CELL_OF("mt6370-charger",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-charger"),
+       MFD_CELL_OF("mt6370-backlight",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-backlight"),
+       MFD_CELL_OF("mt6370-flashlight",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-flashlight"),
+       MFD_CELL_OF("mt6370-indicator",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-indicator"),
+       MFD_CELL_OF("mt6370-tcpc",
+                   NULL, NULL, 0, 0, "mediatek,mt6370-tcpc"),
+       MFD_CELL_RES("mt6370-regulator", mt6370_regulator_irqs),
+};
+
+static int mt6370_check_vendor_info(struct device *dev, struct regmap *rmap)
+{
+       unsigned int devinfo;
+       int ret;
+
+       ret = regmap_read(rmap, MT6370_REG_DEV_INFO, &devinfo);
+       if (ret)
+               return ret;
+
+       switch (FIELD_GET(MT6370_VENID_MASK, devinfo)) {
+       case MT6370_VENID_RT5081:
+       case MT6370_VENID_RT5081A:
+       case MT6370_VENID_MT6370:
+       case MT6370_VENID_MT6371:
+       case MT6370_VENID_MT6372P:
+       case MT6370_VENID_MT6372CP:
+               return 0;
+       default:
+               dev_err(dev, "Unknown Vendor ID 0x%02x\n", devinfo);
+               return -ENODEV;
+       }
+}
+
+static int mt6370_regmap_read(void *context, const void *reg_buf,
+                             size_t reg_size, void *val_buf, size_t val_size)
+{
+       struct mt6370_info *info = context;
+       const u8 *u8_buf = reg_buf;
+       u8 bank_idx, bank_addr;
+       int ret;
+
+       bank_idx = u8_buf[0];
+       bank_addr = u8_buf[1];
+
+       ret = i2c_smbus_read_i2c_block_data(info->i2c[bank_idx], bank_addr,
+                                           val_size, val_buf);
+       if (ret < 0)
+               return ret;
+
+       if (ret != val_size)
+               return -EIO;
+
+       return 0;
+}
+
+static int mt6370_regmap_write(void *context, const void *data, size_t count)
+{
+       struct mt6370_info *info = context;
+       const u8 *u8_buf = data;
+       u8 bank_idx, bank_addr;
+       int len = count - MT6370_REG_ADDRLEN;
+
+       bank_idx = u8_buf[0];
+       bank_addr = u8_buf[1];
+
+       return i2c_smbus_write_i2c_block_data(info->i2c[bank_idx], bank_addr,
+                                             len, data + MT6370_REG_ADDRLEN);
+}
+
+static const struct regmap_bus mt6370_regmap_bus = {
+       .read           = mt6370_regmap_read,
+       .write          = mt6370_regmap_write,
+};
+
+static const struct regmap_config mt6370_regmap_config = {
+       .reg_bits               = 16,
+       .val_bits               = 8,
+       .reg_format_endian      = REGMAP_ENDIAN_BIG,
+       .max_register           = MT6370_REG_MAXADDR,
+};
+
+static int mt6370_probe(struct i2c_client *i2c)
+{
+       struct mt6370_info *info;
+       struct i2c_client *usbc_i2c;
+       struct regmap *regmap;
+       struct device *dev = &i2c->dev;
+       int ret;
+
+       info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
+       if (!info)
+               return -ENOMEM;
+
+       usbc_i2c = devm_i2c_new_dummy_device(dev, i2c->adapter,
+                                            MT6370_USBC_I2CADDR);
+       if (IS_ERR(usbc_i2c))
+               return dev_err_probe(dev, PTR_ERR(usbc_i2c),
+                                    "Failed to register USBC I2C client\n");
+
+       /* Assign I2C client for PMU and TypeC */
+       info->i2c[MT6370_PMU_I2C] = i2c;
+       info->i2c[MT6370_USBC_I2C] = usbc_i2c;
+
+       regmap = devm_regmap_init(dev, &mt6370_regmap_bus,
+                                 info, &mt6370_regmap_config);
+       if (IS_ERR(regmap))
+               return dev_err_probe(dev, PTR_ERR(regmap),
+                                    "Failed to init regmap\n");
+
+       ret = mt6370_check_vendor_info(dev, regmap);
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to check vendor info\n");
+
+       ret = devm_regmap_add_irq_chip(dev, regmap, i2c->irq,
+                                      IRQF_ONESHOT, -1, &mt6370_irq_chip,
+                                      &info->irq_data);
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to add irq chip\n");
+
+       return devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO,
+                                   mt6370_devices, ARRAY_SIZE(mt6370_devices),
+                                   NULL, 0,
+                                   regmap_irq_get_domain(info->irq_data));
+}
+
+static const struct of_device_id mt6370_match_table[] = {
+       { .compatible = "mediatek,mt6370" },
+       {}
+};
+MODULE_DEVICE_TABLE(of, mt6370_match_table);
+
+static struct i2c_driver mt6370_driver = {
+       .driver = {
+               .name = "mt6370",
+               .of_match_table = mt6370_match_table,
+       },
+       .probe_new = mt6370_probe,
+};
+module_i2c_driver(mt6370_driver);
+
+MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
+MODULE_DESCRIPTION("MediaTek MT6370 SubPMIC Driver");
+MODULE_LICENSE("GPL v2");
drivers/mfd/mt6370.h new file +99 -1
new file mode 100644
index 0000000..094e59e
@@ -0,0 +1,99 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiYuan Huang <[email protected]>
+ */
+
+#ifndef __MFD_MT6370_H__
+#define __MFD_MT6370_H__
+
+/* IRQ definitions */
+#define MT6370_IRQ_DIRCHGON            0
+#define MT6370_IRQ_CHG_TREG            4
+#define MT6370_IRQ_CHG_AICR            5
+#define MT6370_IRQ_CHG_MIVR            6
+#define MT6370_IRQ_PWR_RDY             7
+#define MT6370_IRQ_FL_CHG_VINOVP       11
+#define MT6370_IRQ_CHG_VSYSUV          12
+#define MT6370_IRQ_CHG_VSYSOV          13
+#define MT6370_IRQ_CHG_VBATOV          14
+#define MT6370_IRQ_CHG_VINOVPCHG       15
+#define MT6370_IRQ_TS_BAT_COLD         20
+#define MT6370_IRQ_TS_BAT_COOL         21
+#define MT6370_IRQ_TS_BAT_WARM         22
+#define MT6370_IRQ_TS_BAT_HOT          23
+#define MT6370_IRQ_TS_STATC            24
+#define MT6370_IRQ_CHG_FAULT           25
+#define MT6370_IRQ_CHG_STATC           26
+#define MT6370_IRQ_CHG_TMR             27
+#define MT6370_IRQ_CHG_BATABS          28
+#define MT6370_IRQ_CHG_ADPBAD          29
+#define MT6370_IRQ_CHG_RVP             30
+#define MT6370_IRQ_TSHUTDOWN           31
+#define MT6370_IRQ_CHG_IINMEAS         32
+#define MT6370_IRQ_CHG_ICCMEAS         33
+#define MT6370_IRQ_CHGDET_DONE         34
+#define MT6370_IRQ_WDTMR               35
+#define MT6370_IRQ_SSFINISH            36
+#define MT6370_IRQ_CHG_RECHG           37
+#define MT6370_IRQ_CHG_TERM            38
+#define MT6370_IRQ_CHG_IEOC            39
+#define MT6370_IRQ_ADC_DONE            40
+#define MT6370_IRQ_PUMPX_DONE          41
+#define MT6370_IRQ_BST_BATUV           45
+#define MT6370_IRQ_BST_MIDOV           46
+#define MT6370_IRQ_BST_OLP             47
+#define MT6370_IRQ_ATTACH              48
+#define MT6370_IRQ_DETACH              49
+#define MT6370_IRQ_HVDCP_STPDONE       51
+#define MT6370_IRQ_HVDCP_VBUSDET_DONE  52
+#define MT6370_IRQ_HVDCP_DET           53
+#define MT6370_IRQ_CHGDET              54
+#define MT6370_IRQ_DCDT                        55
+#define MT6370_IRQ_DIRCHG_VGOK         59
+#define MT6370_IRQ_DIRCHG_WDTMR                60
+#define MT6370_IRQ_DIRCHG_UC           61
+#define MT6370_IRQ_DIRCHG_OC           62
+#define MT6370_IRQ_DIRCHG_OV           63
+#define MT6370_IRQ_OVPCTRL_SWON                67
+#define MT6370_IRQ_OVPCTRL_UVP_D       68
+#define MT6370_IRQ_OVPCTRL_UVP         69
+#define MT6370_IRQ_OVPCTRL_OVP_D       70
+#define MT6370_IRQ_OVPCTRL_OVP         71
+#define MT6370_IRQ_FLED_STRBPIN                72
+#define MT6370_IRQ_FLED_TORPIN         73
+#define MT6370_IRQ_FLED_TX             74
+#define MT6370_IRQ_FLED_LVF            75
+#define MT6370_IRQ_FLED2_SHORT         78
+#define MT6370_IRQ_FLED1_SHORT         79
+#define MT6370_IRQ_FLED2_STRB          80
+#define MT6370_IRQ_FLED1_STRB          81
+#define mT6370_IRQ_FLED2_STRB_TO       82
+#define MT6370_IRQ_FLED1_STRB_TO       83
+#define MT6370_IRQ_FLED2_TOR           84
+#define MT6370_IRQ_FLED1_TOR           85
+#define MT6370_IRQ_OTP                 93
+#define MT6370_IRQ_VDDA_OVP            94
+#define MT6370_IRQ_VDDA_UV             95
+#define MT6370_IRQ_LDO_OC              103
+#define MT6370_IRQ_BLED_OCP            118
+#define MT6370_IRQ_BLED_OVP            119
+#define MT6370_IRQ_DSV_VNEG_OCP                123
+#define MT6370_IRQ_DSV_VPOS_OCP                124
+#define MT6370_IRQ_DSV_BST_OCP         125
+#define MT6370_IRQ_DSV_VNEG_SCP                126
+#define MT6370_IRQ_DSV_VPOS_SCP                127
+
+enum {
+       MT6370_USBC_I2C = 0,
+       MT6370_PMU_I2C,
+       MT6370_MAX_I2C
+};
+
+struct mt6370_info {
+       struct i2c_client *i2c[MT6370_MAX_I2C];
+       struct regmap_irq_chip_data *irq_data;
+};
+
+#endif /* __MFD_MT6375_H__ */
--

2.7.4

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#24 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to AngeloGioacchino Del Regno
Quoted 1 line · AngeloGioacchino Del Regno

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

...

Quoted 6 lines

drivers/leds/leds-mt6370.c line 109

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+#define STATE_OFF                            0
+#define STATE_KEEP                           1
+#define STATE_ON                             2

I propose, instead:

Quoted 6 lines
enum mt6370_state {
        STATE_OFF = 0,
        STATE_KEEP,
        STATE_ON,

        STATE_MAX,

Usually we don't put commas at the terminator entries.

Quoted 1 line

};

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#12 lore raw

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiaEn Wu
Quoted 7 lines · ChiaEn Wu

The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

This commit add support for the Type-C & Power Delivery controller in

This commit add -> Add

Quoted 38 lines

MediaTek MT6370 IC.

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +35 -0
+static int mt6370_tcpc_probe(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->dev = dev;
+       platform_set_drvdata(pdev, priv);
+
+       priv->tcpci_data.regmap = dev_get_regmap(dev->parent, NULL);
+       if (!priv->tcpci_data.regmap)
+               return dev_err_probe(dev, -ENODEV, "Failed to init regmap\n");
+
+       ret = mt6370_check_vendor_info(priv);
+       if (ret)
+               return ret;
+
+       priv->irq = platform_get_irq(pdev, 0);
+       if (priv->irq < 0)
+               return priv->irq;
+
+       /* Assign TCPCI feature and ops */
+       priv->tcpci_data.auto_discharge_disconnect = 1;
+       priv->tcpci_data.init = mt6370_tcpc_init;
+       priv->tcpci_data.set_vconn = mt6370_tcpc_set_vconn;
+
+       priv->vbus = devm_regulator_get_optional(dev, "vbus");
+       if (!IS_ERR(priv->vbus))
+               priv->tcpci_data.set_vbus = mt6370_tcpc_set_vbus;
+
+       priv->tcpci = tcpci_register_port(dev, &priv->tcpci_data);

drivers/usb/typec/tcpm/tcpci_mt6370.c line 167

Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +9 -0
+       if (IS_ERR(priv->tcpci))
+               return dev_err_probe(dev, PTR_ERR(priv->tcpci),
+                                    "Failed to register tcpci port\n");
+
+       ret = devm_request_threaded_irq(dev, priv->irq, NULL,
+                                       mt6370_irq_handler, IRQF_ONESHOT,
+                                       dev_name(dev), priv);
+       if (ret) {
 
+               tcpci_unregister_port(priv->tcpci);

This is wrong.
You mixed devm_ with non-devm. Either drop devm_ *after* the first non-devm_ call, or convert everything to be managed.

Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4 -0
+               return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+       }
+
+       device_init_wakeup(dev, true);

drivers/usb/typec/tcpm/tcpci_mt6370.c line 181

Quoted 10 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +9 -0
+       dev_pm_set_wake_irq(dev, priv->irq);
+
+       return 0;
+}
+
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv = platform_get_drvdata(pdev);
 
+       disable_irq(priv->irq);

Why?
An ugly workaround due to ordering issues in ->probe()?

Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+       tcpci_unregister_port(priv->tcpci);
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
+
+       return 0;
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#18 lore raw

Re: [PATCH v5 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

In reply to ChiaEn Wu
Quoted 10 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds support the MT6370 ADC driver for system monitoring, including

This adds --> Add a

Quoted 1 line

charger current, voltage, and temperature.

...

Quoted 10 lines
drivers/iio/adc/mt6370-adc.c new file +10 -0
+#include <linux/bits.h>
+#include <linux/bitfield.h>
+#include <linux/iio/iio.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/sysfs.h>

...

drivers/iio/adc/mt6370-adc.c line 32

Quoted 3 lines
drivers/iio/adc/mt6370-adc.c new file +3 -0
+#define MT6370_AICR_400MA              0x6
+#define MT6370_ICHG_500MA              0x4
+#define MT6370_ICHG_900MA              0x8

_mA ?

...

drivers/iio/adc/mt6370-adc.c line 68

Quoted 5 lines
drivers/iio/adc/mt6370-adc.c new file +5 -0
+       ret = regmap_read_poll_timeout(priv->regmap,
+                                      MT6370_REG_CHG_ADC, reg_val,
+                                      !(reg_val & MT6370_ADC_START_MASK),
+                                      ADC_CONV_POLLING_TIME_US,
+                                      ADC_CONV_TIME_MS * 1000 * 3);

1000 --> MILLI ?

...

drivers/iio/adc/mt6370-adc.c line 223

Quoted 2 lines
drivers/iio/adc/mt6370-adc.c new file +2 -0
+static int mt6370_adc_probe(struct platform_device *pdev)
+{

Given comment in one place in the entire series would be good to use in another where appropriate. For example, here it would also be nice to have a temporary variable

  struct device *dev = &pdev->dev;

It will shorten some lines.

Quoted 6 lines
drivers/iio/adc/mt6370-adc.c new file +5 -0
+       struct mt6370_adc_data *priv;
+       struct iio_dev *indio_dev;
+       struct regmap *regmap;
+       int ret;
 
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#7 lore raw

Re: [PATCH v5 06/13] dt-bindings: mfd: Add MediaTek MT6370

In reply to ChiaEn Wu
Quoted 4 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

Add MediaTek MT6370 binding documentation.

Quoted 9 lines
---
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml   | 280 +++++++++++++++++++++
 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h  |  18 ++
 2 files changed, 298 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
 create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6370_adc.h

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: pmic@34: indicator:multi-led@0:led@0: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: pmic@34: indicator:multi-led@0:led@1: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: pmic@34: indicator:multi-led@0:led@2: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: indicator: multi-led@0:led@0: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: indicator: multi-led@0:led@1: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb: indicator: multi-led@0:led@2: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#35 lore raw

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

In reply to AngeloGioacchino Del Regno
Quoted 18 lines · AngeloGioacchino Del Regno

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Quoted 6 lines

This adds support for MediaTek MT6370 Backlight driver. It's commonly used to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

Hello ChiaEn,

Quoted 7 lines

I propose to move this one to drivers/leds (or drivers/pwm) and, instead of registering a backlight device, register a PWM device.

This way you will be able to reuse the generic backlight-pwm driver, as you'd be feeding the PWM device exposed by this driver to the generic one: this will most importantly make it easy to chain it with MTK_DISP_PWM (mtk-pwm-disp) with a devicetree that looks like...

Out of interest, does MT6370 have the same structure for backlights as the prior systems using mtk-pwm-disp or was mtk-pwm-disp simply a normal(-ish) PWM that relied on something on the board for all the constant current driver hardware?

Quoted 16 lines
	pwmleds-disp {
		compatible = "pwm-leds";

		disp_led: disp-pwm {
			label = "backlight-pwm";
			pwms = <&pwm0 0 500000>;
			max-brightness = <1024>;
		};
	};

	backlight_lcd0: backlight {
		compatible = "led-backlight";
		leds = <&disp_led>, <&pmic_bl_led>;
		default-brightness-level = <300>;
	};

I think this proposal has to start with the devicetree bindings rather than the driver. Instead I think the question is: does this proposal result in DT bindings that better describe the underlying hardware?

This device has lots of backlight centric features (OCP, OVP, single control with multiple outputs, exponential curves, etc) and its not clear where they would fit into the "PWM" bindings.

Come to think of it I'm also a little worried also about the whole linear versus exponential curve thing since I thought LED drivers were required to use exponential curves.

Daniel.

#20 lore raw

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

In reply to ChiaEn Wu
Quoted 13 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

This adds MediaTek MT6370 Charger driver support. The charger module of MT6370 supports High-Accuracy Voltage/Current Regulation, Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2.

...

Quoted 35 lines
drivers/power/supply/mt6370-charger.c new file +35 -0
+static int mt6370_chg_probe(struct platform_device *pdev)
+{
+       int ret;
+       struct mt6370_priv *priv;
+
+       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->dev = &pdev->dev;
+
+       priv->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+       if (!priv->regmap)
+               return dev_err_probe(&pdev->dev, -ENODEV,
+                                    "Failed to get regmap\n");
+
+       ret = mt6370_chg_init_rmap_fields(priv);
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret,
+                                    "Failed to init regmap fields\n");
+
+       platform_set_drvdata(pdev, priv);
+
+       priv->iio_adcs = devm_iio_channel_get_all(priv->dev);
+       if (IS_ERR(priv->iio_adcs))
+               return dev_err_probe(&pdev->dev, PTR_ERR(priv->iio_adcs),
+                                    "Failed to get iio adc\n");
+
+       ret = mt6370_chg_init_otg_regulator(priv);
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret,
+                                    "Failed to init otg regulator\n");
+
+       ret = mt6370_chg_init_psy(priv);
+       if (ret)

drivers/power/supply/mt6370-charger.c line 1004

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +9 -0
+               return dev_err_probe(&pdev->dev, ret, "Failed to init psy\n");
+
+       mutex_init(&priv->attach_lock);
+       priv->attach = MT6370_ATTACH_STAT_DETACH;
+
+       priv->wq = create_singlethread_workqueue(dev_name(priv->dev));
+       if (IS_ERR(priv->wq))
 
+               return dev_err_probe(priv->dev, PTR_ERR(priv->wq),
+                                    "Failed to create workqueue\n");

You need either wrap mutex to be deallocated by devm or don't use dev_err_probe() here.

Quoted 37 lines
drivers/power/supply/mt6370-charger.c new file +37 -0
+       INIT_WORK(&priv->bc12_work, mt6370_chg_bc12_work_func);
+       INIT_DELAYED_WORK(&priv->mivr_dwork, mt6370_chg_mivr_dwork_func);
+
+       ret = mt6370_chg_init_setting(priv);
+       if (ret) {
+               dev_err(&pdev->dev, "Failed to init mt6370 charger setting\n");
+               goto probe_out;
+       }
+
+       ret = mt6370_chg_init_irq(priv);
+       if (ret)
+               goto probe_out;
+
+       mt6370_chg_pwr_rdy_check(priv);
+
+       return 0;
+
+probe_out:
+       cancel_delayed_work_sync(&priv->mivr_dwork);
+       flush_workqueue(priv->wq);
+       destroy_workqueue(priv->wq);
+       mutex_destroy(&priv->attach_lock);
+
+       return ret;
+}
+
+static int mt6370_chg_remove(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv = platform_get_drvdata(pdev);
+
+       cancel_delayed_work_sync(&priv->mivr_dwork);
+       flush_workqueue(priv->wq);
+       destroy_workqueue(priv->wq);
+       mutex_destroy(&priv->attach_lock);
+
+       return 0;
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#32 lore raw

Re: [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support

In reply to ChiaEn Wu
Quoted 2 lines · ChiaEn Wu

The MediaTek MT6370 is a highly-integrated smart power management IC, whichincludes a single cell Li-Ion/Li-Polymer switching battery

which includes

Quoted 5 lines

charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

The Flash LED in MT6370 has 2 channel and support torch/strobe mode.

channels

Quoted 1 line

The commit add the support of MT6370 FLASH LED.

Add the

...

Quoted 1 line

+#define MT6370_FLCSEN_MASK_ALL (BIT(0) | BIT(1))

GENMASK()

...

Quoted 4 lines
drivers/leds/flash/leds-mt6370-flash.c new file +4 -0
+               for (i = 0; i < MT6370_MAX_LEDS; i++) {
+                       ret = regmap_update_bits(priv->regmap,
+                                               MT6370_REG_FLEDISTRB(i),
+                                               MT6370_ISTROBE_MASK, flevel[i]);

drivers/leds/flash/leds-mt6370-flash.c line 198

Quoted 10 lines
drivers/leds/flash/leds-mt6370-flash.c new file +9 -0
+                       if (ret)
+                               return ret;
+               }
+       } else {
 
+               ret = regmap_update_bits(priv->regmap,
+                                        MT6370_REG_FLEDISTRB(led->led_no),
+                                        MT6370_ISTROBE_MASK, val);
+       }
+       return ret;
    return regmap_update_bits(...);

}

return 0;

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       /*
+        * If the flash need to be on,

needs

Quoted 3 lines
drivers/leds/flash/leds-mt6370-flash.c new file +3 -0
+        * config the flash current ramping up to the setting value.
+        * Else, always recover back to the minimum one.
+        */

...

Quoted 1 line

+ /* For the flash turn on/off, need to wait HW ramping up/down time

to turn

drivers/leds/flash/leds-mt6370-flash.c line 255

Quoted 2 lines
drivers/leds/flash/leds-mt6370-flash.c new file +2 -0
+        * 5ms/500us to prevent the unexpected problem.
+        */

Wrong multi-line comment style.

Quoted 1 line

+

No need for a blank line.

Quoted 4 lines
drivers/leds/flash/leds-mt6370-flash.c new file +4 -0
+       if (!prev && curr)
+               usleep_range(5000, 6000);
+       else if (prev && !curr)
+               udelay(500);

...

drivers/leds/flash/leds-mt6370-flash.c line 429

Quoted 11 lines
drivers/leds/flash/leds-mt6370-flash.c new file +11 -0
+static int mt6370_led_register(struct device *parent, struct mt6370_led *led,
+                               struct led_init_data *init_data)
+{
+       struct v4l2_flash_config v4l2_config = {0};
+       int ret;
+
+       ret = devm_led_classdev_flash_register_ext(parent, &led->flash,
+                                                  init_data);
+       if (ret) {
+               dev_err(parent, "Couldn't register flash %d\n", led->led_no);
+               return ret;

return dev_err_probe() here and everywhere where it is about probe stage.

Quoted 13 lines
drivers/leds/flash/leds-mt6370-flash.c new file +13 -0
+       }
+
+       mt6370_init_v4l2_flash_config(led, &v4l2_config);
+       led->v4l2_flash = v4l2_flash_init(parent, init_data->fwnode,
+                                         &led->flash, &v4l2_flash_ops,
+                                         &v4l2_config);
+       if (IS_ERR(led->v4l2_flash)) {
+               dev_err(parent, "Failed to register %d v4l2 sd\n", led->led_no);
+               return PTR_ERR(led->v4l2_flash);
+       }
+
+       return 0;
+}

...

drivers/leds/flash/leds-mt6370-flash.c line 470

Quoted 5 lines
drivers/leds/flash/leds-mt6370-flash.c new file +5 -0
+       num = fwnode_property_count_u32(init_data->fwnode, "led-sources");
+       if (num < 1 || num > MT6370_MAX_LEDS) {
+               dev_err(priv->dev,
+                       "Not specified or wrong number of led-sources\n");
+               return -EINVAL;

Ditto.

Quoted 1 line

+ }

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp",
+                                      &val);

One line?

...

drivers/leds/flash/leds-mt6370-flash.c line 539

Quoted 2 lines
drivers/leds/flash/leds-mt6370-flash.c new file +2 -0
+               val = clamp_align(val, MT6370_STRBTO_MIN_US, MT6370_STRBTO_MAX_US,
+                                 MT6370_STRBTO_STEP_US);

I would name it mt6370_clamp() to avoid potential collision in the global namespace in the future.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#25 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu
Quoted 12 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

...

Quoted 1 line

+ This driver can also be built as a module. If so the module

so, the

Quoted 1 line

+ will be called "leds-mt6370.ko".

No ".ko".

Why did you ignore these comments? Please go and fix _everywhere_ in your series.
It's basically the rule of thumb, if the reviewer gives a comment against an occurrence of something, go through entire series and check if there are other places like commented one and address them all.

...

Quoted 1 line

+ * Author: Alice Chen <[email protected]>

Strange, the commit message doesn't have a corresponding SoB, why?

...

drivers/leds/leds-mt6370.c line 105

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+#define MT6370_PWM_DUTY                                31
+#define MT6372_PMW_DUTY                                255

Looks like these are limits by hardware?
Check with the datasheet if (BIT(x) - 1) makes more sense here.

...

drivers/leds/leds-mt6370.c line 247

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_DUTY;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_DUTY;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_DUTY;
+               break;
+       default:
+               sel_field = F_LED4_DUTY;

Missed break;

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 298

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_FREQ;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_FREQ;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_FREQ;
+               break;
+       default:
+               sel_field = F_LED4_FREQ;

Ditto.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 319

Quoted 8 lines
drivers/leds/leds-mt6370.c new file +8 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+       case MT6370_LED_ISNK2:
+       case MT6370_LED_ISNK3:
+               *base = MT6370_REG_RGB1_TR + led_no * 3;
+               break;
+       default:
+               *base = MT6370_REG_RGB_CHRIND_TR;

Ditto.
It seems you dropped them for all switch-cases. It's not goot, please restore them back.

Quoted 1 line

+ }

...

Quoted 1 line

+ u8 val[P_MAX_PATTERNS / 2] = {0};

{ } should suffice

Quoted 23 lines
drivers/leds/leds-mt6370.c new file +23 -0
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);
+       return 0;
+}

...

Quoted 1 line

+out:

out_unlock:

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;

...

Quoted 1 line

+out:

Ditto. And so on.

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;

...

drivers/leds/leds-mt6370.c line 709

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+               sub_led = devm_kzalloc(priv->dev,
+                                      sizeof(*sub_led) * MC_CHANNEL_NUM,
+                                      GFP_KERNEL);

NIH devm_kcalloc(). Also check if you really need zeroed data.

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+               if (!sub_led)
+                       return -ENOMEM;

...

drivers/leds/leds-mt6370.c line 726

Quoted 6 lines
drivers/leds/leds-mt6370.c new file +6 -0
+                       ret = fwnode_property_read_u32(child, "color", &color);
+                       if (ret) {
+                               dev_err(priv->dev,
+                                       "led %d, no color specified\n",
+                                       led->index);
+                               return ret;

return dev_err_probe(...) ; ?

Ditto for many places in your entire series.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 907

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       priv = devm_kzalloc(&pdev->dev,
+                           struct_size(priv, leds, count), GFP_KERNEL);

At least one parameter can be placed on the previous line.

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       if (!priv)
+               return -ENOMEM;
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#21 lore raw

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

In reply to ChiaEn Wu

Hi,

Quoted 8 lines · ChiaEn Wu

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Quoted 7 lines

This adds MediaTek MT6370 Charger driver support. The charger module of MT6370 supports High-Accuracy Voltage/Current Regulation, Average Input Current Regulation, Battery Temperature Sensing, Over-Temperature Protection, DPDM Detection for BC1.2.

---

Please provide a dump from '/sys/class/power_supply/<charger-name>/uevent' below the fold in the next revision. I would like to check that you got the units right in the next submission (in this one they are definetly not correct).

Quoted 361 lines

v5
- Replace unsigned int type of pwr_rdy with bool in mt6370_chg_set_online()
- Remove redundant 'else' in mt6370_chg_field_get()
- Revise 'if-else' in mt6370_chg_field_set()
- Revise 'if' condition in mt6370_chg_enable_irq()
- Revise all text 'otg' --> 'OTG'
- Revise MT6370_MIVR_IBUS_TH_100_MA --> MT6370_MIVR_IBUS_TH_100_mA
- Revise the description of Kconfig help text

---
 drivers/power/supply/Kconfig          |   14 +
 drivers/power/supply/Makefile         |    1 +
 drivers/power/supply/mt6370-charger.c | 1062 +++++++++++++++++++++++++++++++++
 3 files changed, 1077 insertions(+)
 create mode 100644 drivers/power/supply/mt6370-charger.c
drivers/power/supply/Kconfig +14 -0
index 1aa8323..591deb8 100644
@@ -619,6 +619,20 @@ config CHARGER_MT6360
 	  Average Input Current Regulation, Battery Temperature Sensing,
 	  Over-Temperature Protection, DPDM Detection for BC1.2.
 
+config CHARGER_MT6370
+	tristate "MediaTek MT6370 Charger Driver"
+	depends on MFD_MT6370
+	depends on REGULATOR
+	select LINEAR_RANGES
+	help
+	  Say Y here to enable MT6370 Charger Part.
+	  The device supports High-Accuracy Voltage/Current Regulation,
+	  Average Input Current Regulation, Battery Temperature Sensing,
+	  Over-Temperature Protection, DPDM Detection for BC1.2.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called "mt6370-charger".
+
 config CHARGER_QCOM_SMBB
 	tristate "Qualcomm Switch-Mode Battery Charger and Boost"
 	depends on MFD_SPMI_PMIC || COMPILE_TEST
drivers/power/supply/Makefile +1 -0
index 7f02f36..8c95276 100644
@@ -82,6 +82,7 @@ obj-$(CONFIG_CHARGER_MAX8997)	+= max8997_charger.o
 obj-$(CONFIG_CHARGER_MAX8998)	+= max8998_charger.o
 obj-$(CONFIG_CHARGER_MP2629)	+= mp2629_charger.o
 obj-$(CONFIG_CHARGER_MT6360)	+= mt6360_charger.o
+obj-$(CONFIG_CHARGER_MT6370)	+= mt6370-charger.o
 obj-$(CONFIG_CHARGER_QCOM_SMBB)	+= qcom_smbb.o
 obj-$(CONFIG_CHARGER_BQ2415X)	+= bq2415x_charger.o
 obj-$(CONFIG_CHARGER_BQ24190)	+= bq24190_charger.o
drivers/power/supply/mt6370-charger.c new file +302 -0
new file mode 100644
index 0000000..76a8c91
@@ -0,0 +1,1062 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2022 Richtek Technology Corp.
+ *
+ * Author: ChiaEn Wu <[email protected]>
+ */
+
+#include <linux/bitfield.h>
+#include <linux/bits.h>
+#include <linux/gpio/consumer.h>
+#include <linux/iio/consumer.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/linear_range.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/power_supply.h>
+#include <linux/regmap.h>
+#include <linux/regulator/driver.h>
+#include <linux/workqueue.h>
+
+#define MT6370_REG_CHG_CTRL1		0x111
+#define MT6370_REG_CHG_CTRL2		0x112
+#define MT6370_REG_CHG_CTRL3		0x113
+#define MT6370_REG_CHG_CTRL4		0x114
+#define MT6370_REG_CHG_CTRL5		0x115
+#define MT6370_REG_CHG_CTRL6		0x116
+#define MT6370_REG_CHG_CTRL7		0x117
+#define MT6370_REG_CHG_CTRL8		0x118
+#define MT6370_REG_CHG_CTRL9		0x119
+#define MT6370_REG_CHG_CTRL10		0x11A
+#define MT6370_REG_DEVICE_TYPE		0x122
+#define MT6370_REG_USB_STATUS1		0x127
+#define MT6370_REG_CHG_STAT		0x14A
+#define MT6370_REG_FLED_EN		0x17E
+#define MT6370_REG_CHG_STAT1		0X1D0
+#define MT6370_REG_OVPCTRL_STAT		0x1D8
+
+#define MT6370_VOBST_MASK		GENMASK(7, 2)
+#define MT6370_OTG_PIN_EN_MASK		BIT(1)
+#define MT6370_OPA_MODE_MASK		BIT(0)
+#define MT6370_OTG_OC_MASK		GENMASK(2, 0)
+
+#define MT6370_MIVR_IBUS_TH_100_mA	100000
+#define MT6370_ADC_CHAN_IBUS		5
+#define MT6370_ADC_CHAN_MAX		9
+
+enum mt6370_chg_reg_field {
+	/* MT6370_REG_CHG_CTRL2 */
+	F_IINLMTSEL, F_CFO_EN, F_CHG_EN,
+	/* MT6370_REG_CHG_CTRL3 */
+	F_IAICR, F_AICR_EN, F_ILIM_EN,
+	/* MT6370_REG_CHG_CTRL4 */
+	F_VOREG,
+	/* MT6370_REG_CHG_CTRL6 */
+	F_VMIVR,
+	/* MT6370_REG_CHG_CTRL7 */
+	F_ICHG,
+	/* MT6370_REG_CHG_CTRL8 */
+	F_IPREC,
+	/* MT6370_REG_CHG_CTRL9 */
+	F_IEOC,
+	/* MT6370_REG_DEVICE_TYPE */
+	F_USBCHGEN,
+	/* MT6370_REG_USB_STATUS1 */
+	F_USB_STAT, F_CHGDET,
+	/* MT6370_REG_CHG_STAT */
+	F_CHG_STAT, F_BOOST_STAT, F_VBAT_LVL,
+	/* MT6370_REG_FLED_EN */
+	F_FL_STROBE,
+	/* MT6370_REG_CHG_STAT1 */
+	F_CHG_MIVR_STAT,
+	/* MT6370_REG_OVPCTRL_STAT */
+	F_UVP_D_STAT,
+	F_MAX
+};
+
+struct mt6370_priv {
+	struct device *dev;
+	struct iio_channel *iio_adcs;
+	struct mutex attach_lock;
+	struct power_supply *psy;
+	struct power_supply_desc *psy_desc;
+	struct regmap *regmap;
+	struct regmap_field *rmap_fields[F_MAX];
+	struct regulator_dev *rdev;
+	struct workqueue_struct *wq;
+	struct work_struct bc12_work;
+	struct delayed_work mivr_dwork;
+	int attach;
+	int psy_usb_type;
+	bool pwr_rdy;
+};
+
+enum mt6370_usb_status {
+	MT6370_USB_STAT_NO_VBUS = 0,
+	MT6370_USB_STAT_VBUS_FLOW_IS_UNDER_GOING,
+	MT6370_USB_STAT_SDP,
+	MT6370_USB_STAT_SDP_NSTD,
+	MT6370_USB_STAT_DCP,
+	MT6370_USB_STAT_CDP,
+	MT6370_USB_STAT_MAX
+};
+
+struct mt6370_chg_field {
+	const char *name;
+	const struct linear_range *range;
+	struct reg_field field;
+};
+
+enum {
+	MT6370_RANGE_F_IAICR = 0,
+	MT6370_RANGE_F_VOREG,
+	MT6370_RANGE_F_VMIVR,
+	MT6370_RANGE_F_ICHG,
+	MT6370_RANGE_F_IPREC,
+	MT6370_RANGE_F_IEOC,
+	MT6370_RANGE_F_MAX
+};
+
+#define MT6370_CHG_LINEAR_RANGE(_rfd, _min, _min_sel, _max_sel, _step)	\
+[_rfd] = {								\
+	.min = _min,							\
+	.min_sel = _min_sel,						\
+	.max_sel = _max_sel,						\
+	.step = _step,							\
+}
+
+/* unit: mA or mV */
+static const struct linear_range mt6370_chg_ranges[MT6370_RANGE_F_MAX] = {
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_IAICR, 100, 0x0, 0x3F, 50),
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_VOREG, 3900, 0x0, 0x51, 10),
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_VMIVR, 3900, 0x0, 0x5F, 100),
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_ICHG, 900, 0x08, 0x31, 100),
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_IPREC, 100, 0x0, 0x0F, 50),
+	MT6370_CHG_LINEAR_RANGE(MT6370_RANGE_F_IEOC, 100, 0x0, 0x0F, 50),
+};
+
+#define MT6370_CHG_FIELD(_fd, _reg, _lsb, _msb)				\
+[_fd] = {								\
+	.name = #_fd,							\
+	.range = NULL,							\
+	.field = REG_FIELD(_reg, _lsb, _msb),				\
+}
+
+#define MT6370_CHG_FIELD_RANGE(_fd, _reg, _lsb, _msb)			\
+[_fd] = {								\
+	.name = #_fd,							\
+	.range = &mt6370_chg_ranges[MT6370_RANGE_##_fd],		\
+	.field = REG_FIELD(_reg, _lsb, _msb),				\
+}
+
+static const struct mt6370_chg_field mt6370_chg_fields[F_MAX] = {
+	MT6370_CHG_FIELD(F_IINLMTSEL, MT6370_REG_CHG_CTRL2, 2, 3),
+	MT6370_CHG_FIELD(F_CFO_EN, MT6370_REG_CHG_CTRL2, 1, 1),
+	MT6370_CHG_FIELD(F_CHG_EN, MT6370_REG_CHG_CTRL2, 0, 0),
+	MT6370_CHG_FIELD_RANGE(F_IAICR, MT6370_REG_CHG_CTRL3, 2, 7),
+	MT6370_CHG_FIELD(F_AICR_EN, MT6370_REG_CHG_CTRL3, 1, 1),
+	MT6370_CHG_FIELD(F_ILIM_EN, MT6370_REG_CHG_CTRL3, 0, 0),
+	MT6370_CHG_FIELD_RANGE(F_VOREG, MT6370_REG_CHG_CTRL4, 1, 7),
+	MT6370_CHG_FIELD_RANGE(F_VMIVR, MT6370_REG_CHG_CTRL6, 1, 7),
+	MT6370_CHG_FIELD_RANGE(F_ICHG, MT6370_REG_CHG_CTRL7, 2, 7),
+	MT6370_CHG_FIELD_RANGE(F_IPREC, MT6370_REG_CHG_CTRL8, 0, 3),
+	MT6370_CHG_FIELD_RANGE(F_IEOC, MT6370_REG_CHG_CTRL9, 4, 7),
+	MT6370_CHG_FIELD(F_USBCHGEN, MT6370_REG_DEVICE_TYPE, 7, 7),
+	MT6370_CHG_FIELD(F_USB_STAT, MT6370_REG_USB_STATUS1, 4, 6),
+	MT6370_CHG_FIELD(F_CHGDET, MT6370_REG_USB_STATUS1, 3, 3),
+	MT6370_CHG_FIELD(F_CHG_STAT, MT6370_REG_CHG_STAT, 6, 7),
+	MT6370_CHG_FIELD(F_BOOST_STAT, MT6370_REG_CHG_STAT, 3, 3),
+	MT6370_CHG_FIELD(F_VBAT_LVL, MT6370_REG_CHG_STAT, 5, 5),
+	MT6370_CHG_FIELD(F_FL_STROBE, MT6370_REG_FLED_EN, 2, 2),
+	MT6370_CHG_FIELD(F_CHG_MIVR_STAT, MT6370_REG_CHG_STAT1, 6, 6),
+	MT6370_CHG_FIELD(F_UVP_D_STAT, MT6370_REG_OVPCTRL_STAT, 4, 4),
+};
+
+static inline int mt6370_chg_field_get(struct mt6370_priv *priv,
+				       enum mt6370_chg_reg_field fd,
+				       unsigned int *val)
+{
+	int ret;
+	unsigned int reg_val;
+
+	ret = regmap_field_read(priv->rmap_fields[fd], &reg_val);
+	if (ret < 0)
+		return ret;
+
+	if (mt6370_chg_fields[fd].range)
+		return linear_range_get_value(mt6370_chg_fields[fd].range,
+					      reg_val, val);
+
+	*val = reg_val;
+	return 0;
+}
+
+static inline int mt6370_chg_field_set(struct mt6370_priv *priv,
+				       enum mt6370_chg_reg_field fd,
+				       unsigned int val)
+{
+	int ret;
+	bool f;
+	const struct linear_range *r;
+
+	if (mt6370_chg_fields[fd].range) {
+		r = mt6370_chg_fields[fd].range;
+
+		if (fd == F_VMIVR) {
+			ret = linear_range_get_selector_high(r, val, &val, &f);
+			if (!ret)
+				val = r->max_sel;
+		} else {
+			linear_range_get_selector_within(r, val, &val);
+		}
+	}
+
+	return regmap_field_write(priv->rmap_fields[fd], val);
+}
+
+enum {
+	MT6370_CHG_STAT_READY = 0,
+	MT6370_CHG_STAT_CHARGE_IN_PROGRESS,
+	MT6370_CHG_STAT_DONE,
+	MT6370_CHG_STAT_FAULT,
+	MT6370_CHG_STAT_MAX
+};
+
+enum {
+	MT6370_ATTACH_STAT_DETACH = 0,
+	MT6370_ATTACH_STAT_ATTACH_BC12_NOT_DONE,
+	MT6370_ATTACH_STAT_ATTACH_BC12_DONE,
+	MT6370_ATTACH_STAT_ATTACH_MAX
+};
+
+static int mt6370_chg_otg_of_parse_cb(struct device_node *of,
+				      const struct regulator_desc *rdesc,
+				      struct regulator_config *rcfg)
+{
+	struct mt6370_priv *priv = rcfg->driver_data;
+
+	rcfg->ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(of),
+						 "enable", 0, GPIOD_OUT_LOW |
+						 GPIOD_FLAGS_BIT_NONEXCLUSIVE,
+						 rdesc->name);
+	if (IS_ERR(rcfg->ena_gpiod)) {
+		rcfg->ena_gpiod = NULL;
+		return 0;
+	}
+
+	return regmap_update_bits(priv->regmap, MT6370_REG_CHG_CTRL1,
+				  MT6370_OTG_PIN_EN_MASK,
+				  MT6370_OTG_PIN_EN_MASK);
+}
+
+static void mt6370_chg_bc12_work_func(struct work_struct *work)
+{
+	struct mt6370_priv *priv = container_of(work, struct mt6370_priv,
+						bc12_work);
+	int ret;
+	bool rpt_psy = false;
+	unsigned int attach, usb_stat;
+
+	mutex_lock(&priv->attach_lock);
+	attach = priv->attach;
+
+	switch (attach) {
+	case MT6370_ATTACH_STAT_DETACH:
+		usb_stat = 0;
+		break;
+	case MT6370_ATTACH_STAT_ATTACH_BC12_DONE:
+		ret = mt6370_chg_field_get(priv, F_USB_STAT, &usb_stat);
+		if (ret < 0) {
+			dev_err(priv->dev, "Failed to get USB status\n");
+			goto bc12_work_func_out;
+		}
+		break;
+	case MT6370_ATTACH_STAT_ATTACH_BC12_NOT_DONE:
+		ret = mt6370_chg_field_set(priv, F_USBCHGEN, attach);
+		if (ret < 0)
+			dev_err(priv->dev, "Failed to enable USB CHG EN\n");
+		goto bc12_work_func_out;
+	default:
+		dev_err(priv->dev, "Invalid attach state\n");
+		goto bc12_work_func_out;
+	}
+
+	rpt_psy = true;
+
+	switch (usb_stat) {
+	case MT6370_USB_STAT_SDP:
+		priv->psy_desc->type = POWER_SUPPLY_TYPE_USB;
+		priv->psy_usb_type = POWER_SUPPLY_USB_TYPE_SDP;
+		break;
+	case MT6370_USB_STAT_SDP_NSTD:
+		priv->psy_desc->type = POWER_SUPPLY_TYPE_USB;
+		priv->psy_usb_type = POWER_SUPPLY_USB_TYPE_DCP;
+		break;
+	case MT6370_USB_STAT_DCP:
+		priv->psy_desc->type = POWER_SUPPLY_TYPE_USB_DCP;
+		priv->psy_usb_type = POWER_SUPPLY_USB_TYPE_DCP;
+		break;
+	case MT6370_USB_STAT_CDP:

drivers/power/supply/mt6370-charger.c line 312

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+		priv->psy_desc->type = POWER_SUPPLY_TYPE_USB_CDP;
+		priv->psy_usb_type = POWER_SUPPLY_USB_TYPE_CDP;
+		break;
+	case MT6370_USB_STAT_NO_VBUS:
+	case MT6370_USB_STAT_VBUS_FLOW_IS_UNDER_GOING:
+	default:
+		priv->psy_desc->type = POWER_SUPPLY_TYPE_USB;
+		priv->psy_usb_type = POWER_SUPPLY_USB_TYPE_UNKNOWN;
+		break;
+	}

Please don't change psy_desc->type. POWER_SUPPLY_TYPE_USB_DCP and POWER_SUPPLY_TYPE_USB_CDP are deprecated and should not be used in new code. Just use constant POWER_SUPPLY_TYPE_USB and expose the details via the 'new' POWER_SUPPLY_PROP_USB_TYPE property (as you are already doing).

Quoted 285 lines
drivers/power/supply/mt6370-charger.c new file +285 -0
+bc12_work_func_out:
+	mutex_unlock(&priv->attach_lock);
+
+	if (rpt_psy)
+		power_supply_changed(priv->psy);
+}
+
+static inline void mt6370_chg_enable_irq(struct mt6370_priv *priv,
+					 const char *irq_name, bool en)
+{
+	int irq_num;
+	struct platform_device *pdev = to_platform_device(priv->dev);
+
+	irq_num = platform_get_irq_byname(pdev, irq_name);
+	if (irq_num < 0)
+		return;
+
+	if (en)
+		enable_irq(irq_num);
+	else
+		disable_irq_nosync(irq_num);
+}
+
+static int mt6370_chg_toggle_cfo(struct mt6370_priv *priv)
+{
+	int ret;
+	unsigned int fl_strobe;
+
+	/* check if flash led in strobe mode */
+	ret = mt6370_chg_field_get(priv, F_FL_STROBE, &fl_strobe);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get FL_STROBE_EN\n");
+		return ret;
+	}
+
+	if (fl_strobe) {
+		dev_err(priv->dev, "Flash led is still in strobe mode\n");
+		return ret;
+	}
+
+	/* cfo off */
+	ret = mt6370_chg_field_set(priv, F_CFO_EN, 0);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to disable CFO_EN\n");
+		return ret;
+	}
+
+	/* cfo on */
+	ret = mt6370_chg_field_set(priv, F_CFO_EN, 1);
+	if (ret < 0)
+		dev_err(priv->dev, "Failed to enable CFO_EN\n");
+
+	return ret;
+}
+
+static int mt6370_chg_read_adc_chan(struct mt6370_priv *priv, unsigned int chan,
+				    int *val)
+{
+	int ret;
+
+	if (chan >= MT6370_ADC_CHAN_MAX)
+		return -EINVAL;
+
+	ret = iio_read_channel_processed(&priv->iio_adcs[chan], val);
+	if (ret)
+		dev_err(priv->dev, "Failed to read ADC\n");
+
+	return ret;
+}
+
+static void mt6370_chg_mivr_dwork_func(struct work_struct *work)
+{
+	struct mt6370_priv *priv = container_of(work, struct mt6370_priv,
+						mivr_dwork.work);
+	int ret;
+	unsigned int mivr_stat, ibus;
+
+	ret = mt6370_chg_field_get(priv, F_CHG_MIVR_STAT, &mivr_stat);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get mivr state\n");
+		goto mivr_handler_out;
+	}
+
+	if (!mivr_stat)
+		goto mivr_handler_out;
+
+	ret = mt6370_chg_read_adc_chan(priv, MT6370_ADC_CHAN_IBUS, &ibus);
+	if (ret) {
+		dev_err(priv->dev, "Failed to get ibus\n");
+		goto mivr_handler_out;
+	}
+
+	if (ibus < MT6370_MIVR_IBUS_TH_100_mA) {
+		ret = mt6370_chg_toggle_cfo(priv);
+		if (ret)
+			dev_err(priv->dev, "Failed to toggle cfo\n");
+	}
+
+mivr_handler_out:
+	mt6370_chg_enable_irq(priv, "mivr", true);
+	pm_relax(priv->dev);
+}
+
+static void mt6370_chg_pwr_rdy_check(struct mt6370_priv *priv)
+{
+	int ret;
+	unsigned int pwr_rdy, otg_en;
+	union power_supply_propval val;
+
+	/* Check in OTG mode or not */
+	ret = mt6370_chg_field_get(priv, F_BOOST_STAT, &otg_en);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get OTG state\n");
+		return;
+	}
+
+	if (otg_en)
+		return;
+
+	ret = mt6370_chg_field_get(priv, F_UVP_D_STAT, &pwr_rdy);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get pwr_rdy state reg\n");
+		return;
+	}
+
+	val.intval = !pwr_rdy;
+
+	ret = power_supply_set_property(priv->psy, POWER_SUPPLY_PROP_ONLINE,
+					&val);
+	if (ret < 0)
+		dev_err(priv->dev, "Failed to start attach/detach flow\n");
+}
+
+static int mt6370_chg_get_online(struct mt6370_priv *priv,
+				 union power_supply_propval *val)
+{
+	mutex_lock(&priv->attach_lock);
+	val->intval = !!priv->attach;
+	mutex_unlock(&priv->attach_lock);
+
+	return 0;
+}
+
+static int mt6370_chg_get_status(struct mt6370_priv *priv,
+				 union power_supply_propval *val)
+{
+	int ret;
+	unsigned int chg_stat;
+	union power_supply_propval online;
+
+	ret = power_supply_get_property(priv->psy, POWER_SUPPLY_PROP_ONLINE,
+					&online);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get online status\n");
+		return ret;
+	}
+
+	if (!online.intval) {
+		val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
+		return 0;
+	}
+
+	ret = mt6370_chg_field_get(priv, F_CHG_STAT, &chg_stat);
+	if (ret < 0)
+		return ret;
+
+	switch (chg_stat) {
+	case MT6370_CHG_STAT_READY:
+	case MT6370_CHG_STAT_FAULT:
+		val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
+		return ret;
+	case MT6370_CHG_STAT_CHARGE_IN_PROGRESS:
+		val->intval = POWER_SUPPLY_STATUS_CHARGING;
+		return ret;
+	case MT6370_CHG_STAT_DONE:
+		val->intval = POWER_SUPPLY_STATUS_FULL;
+		return ret;
+	default:
+		val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
+		return ret;
+	}
+}
+
+static int mt6370_chg_get_charge_type(struct mt6370_priv *priv,
+				      union power_supply_propval *val)
+{
+	int type, ret;
+	unsigned int chg_stat, vbat_lvl;
+
+	ret = mt6370_chg_field_get(priv, F_CHG_STAT, &chg_stat);
+	if (ret < 0)
+		return ret;
+
+	ret = mt6370_chg_field_get(priv, F_VBAT_LVL, &vbat_lvl);
+	if (ret < 0)
+		return ret;
+
+	switch (chg_stat) {
+	case MT6370_CHG_STAT_CHARGE_IN_PROGRESS:
+		if (vbat_lvl)
+			type = POWER_SUPPLY_CHARGE_TYPE_FAST;
+		else
+			type = POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
+		break;
+	case MT6370_CHG_STAT_READY:
+	case MT6370_CHG_STAT_DONE:
+	case MT6370_CHG_STAT_FAULT:
+	default:
+		type = POWER_SUPPLY_CHARGE_TYPE_NONE;
+		break;
+	}
+
+	val->intval = type;
+
+	return 0;
+}
+
+static int mt6370_chg_get_ichg(struct mt6370_priv *priv,
+			       union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_ICHG, &val->intval);
+}
+
+static int mt6370_chg_get_max_ichg(struct mt6370_priv *priv,
+				   union power_supply_propval *val)
+{
+	val->intval = linear_range_get_max_value(
+			&mt6370_chg_ranges[MT6370_RANGE_F_ICHG]);
+	return 0;
+}
+
+static int mt6370_chg_get_cv(struct mt6370_priv *priv,
+			     union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_VOREG, &val->intval);
+}
+
+static int mt6370_chg_get_max_cv(struct mt6370_priv *priv,
+				 union power_supply_propval *val)
+{
+	val->intval = linear_range_get_max_value(
+			&mt6370_chg_ranges[MT6370_RANGE_F_VOREG]);
+	return 0;
+}
+
+static int mt6370_chg_get_aicr(struct mt6370_priv *priv,
+			       union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_IAICR, &val->intval);
+}
+
+static int mt6370_chg_get_mivr(struct mt6370_priv *priv,
+			       union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_VMIVR, &val->intval);
+}
+
+static int mt6370_chg_get_iprechg(struct mt6370_priv *priv,
+				  union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_IPREC, &val->intval);
+}
+
+static int mt6370_chg_get_ieoc(struct mt6370_priv *priv,
+			       union power_supply_propval *val)
+{
+	return mt6370_chg_field_get(priv, F_IEOC, &val->intval);
+}
+
+static int mt6370_chg_set_online(struct mt6370_priv *priv,
+				 const union power_supply_propval *val)
+{
+	bool pwr_rdy = !!val->intval;
+
+	mutex_lock(&priv->attach_lock);
+	if (pwr_rdy == !!priv->attach) {
+		dev_err(priv->dev, "pwr_rdy is same(%d)\n", pwr_rdy);
+		mutex_unlock(&priv->attach_lock);
+		return 0;
+	}
+
+	priv->attach = pwr_rdy;
+	mutex_unlock(&priv->attach_lock);
+
+	if (!queue_work(priv->wq, &priv->bc12_work))

drivers/power/supply/mt6370-charger.c line 608

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+		dev_err(priv->dev, "bc12 work has already queued\n");
+
+	return 0;
+}
+
+static int mt6370_chg_set_ichg(struct mt6370_priv *priv,
+			       const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_ICHG, val->intval);
+}

You are directly feeding sysfs value into F_ICHG register, but the register is in mA accordering to the setup code. The power-supply ABI is in uA and uV, see

Documentation/ABI/testing/sysfs-class-power

Quoted 19 lines
drivers/power/supply/mt6370-charger.c new file +19 -0
+static int mt6370_chg_set_cv(struct mt6370_priv *priv,
+			     const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_VOREG, val->intval);
+}
+
+static int mt6370_chg_set_aicr(struct mt6370_priv *priv,
+			       const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_IAICR, val->intval);
+}
+
+static int mt6370_chg_set_mivr(struct mt6370_priv *priv,
+			       const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_VMIVR, val->intval);
+}
+
+static int mt6370_chg_set_iprechg(struct mt6370_priv *priv,

drivers/power/supply/mt6370-charger.c line 638

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+				  const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_IPREC, val->intval);
+}
+
+static int mt6370_chg_set_ieoc(struct mt6370_priv *priv,
+			       const union power_supply_propval *val)
+{
+	return mt6370_chg_field_set(priv, F_IEOC, val->intval);
+}

All these one line functions are pretty pointless, you can just call mt6370_chg_field_set directly.

Quoted 97 lines
drivers/power/supply/mt6370-charger.c new file +97 -0
+static int mt6370_chg_get_property(struct power_supply *psy,
+				   enum power_supply_property psp,
+				   union power_supply_propval *val)
+{
+	struct mt6370_priv *priv = power_supply_get_drvdata(psy);
+
+	switch (psp) {
+	case POWER_SUPPLY_PROP_ONLINE:
+		return mt6370_chg_get_online(priv, val);
+	case POWER_SUPPLY_PROP_STATUS:
+		return mt6370_chg_get_status(priv, val);
+	case POWER_SUPPLY_PROP_CHARGE_TYPE:
+		return mt6370_chg_get_charge_type(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+		return mt6370_chg_get_ichg(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX:
+		return mt6370_chg_get_max_ichg(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+		return mt6370_chg_get_cv(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
+		return mt6370_chg_get_max_cv(priv, val);
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+		return mt6370_chg_get_aicr(priv, val);
+	case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+		return mt6370_chg_get_mivr(priv, val);
+	case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+		return mt6370_chg_get_iprechg(priv, val);
+	case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+		return mt6370_chg_get_ieoc(priv, val);
+	case POWER_SUPPLY_PROP_TYPE:
+		val->intval = priv->psy_desc->type;
+		return 0;
+	case POWER_SUPPLY_PROP_USB_TYPE:
+		val->intval = priv->psy_usb_type;
+		return 0;
+	default:
+		return -EINVAL;
+	}
+}
+
+static int mt6370_chg_set_property(struct power_supply *psy,
+				   enum power_supply_property psp,
+				   const union power_supply_propval *val)
+{
+	struct mt6370_priv *priv = power_supply_get_drvdata(psy);
+
+	switch (psp) {
+	case POWER_SUPPLY_PROP_ONLINE:
+		return mt6370_chg_set_online(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+		return mt6370_chg_set_ichg(priv, val);
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+		return mt6370_chg_set_cv(priv, val);
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+		return mt6370_chg_set_aicr(priv, val);
+	case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+		return mt6370_chg_set_mivr(priv, val);
+	case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+		return mt6370_chg_set_iprechg(priv, val);
+	case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+		return mt6370_chg_set_ieoc(priv, val);
+	default:
+		return -EINVAL;
+	}
+}
+
+static int mt6370_chg_property_is_writeable(struct power_supply *psy,
+					    enum power_supply_property psp)
+{
+	switch (psp) {
+	case POWER_SUPPLY_PROP_ONLINE:
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
+	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
+	case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
+	case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
+	case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
+	case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
+		return 1;
+	default:
+		return 0;
+	}
+}
+
+static enum power_supply_property mt6370_chg_properties[] = {
+	POWER_SUPPLY_PROP_ONLINE,
+	POWER_SUPPLY_PROP_STATUS,
+	POWER_SUPPLY_PROP_CHARGE_TYPE,
+	POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT,
+	POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX,
+	POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE,
+	POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX,
+	POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT,
+	POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT,
+	POWER_SUPPLY_PROP_PRECHARGE_CURRENT,
+	POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT,
+	POWER_SUPPLY_PROP_TYPE,
+	POWER_SUPPLY_PROP_USB_TYPE,

drivers/power/supply/mt6370-charger.c line 746

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+};
+
+static enum power_supply_usb_type mt6370_chg_usb_types[] = {
+	POWER_SUPPLY_USB_TYPE_UNKNOWN,
+	POWER_SUPPLY_USB_TYPE_SDP,
+	POWER_SUPPLY_USB_TYPE_CDP,
+	POWER_SUPPLY_USB_TYPE_DCP,
+};
+
+static struct power_supply_desc mt6370_chg_psy_desc = {

After fixing the code writing to the .type field use 'static const'.

Quoted 261 lines
drivers/power/supply/mt6370-charger.c new file +261 -0
+	.type = POWER_SUPPLY_TYPE_USB,
+	.properties = mt6370_chg_properties,
+	.num_properties = ARRAY_SIZE(mt6370_chg_properties),
+	.get_property = mt6370_chg_get_property,
+	.set_property = mt6370_chg_set_property,
+	.property_is_writeable = mt6370_chg_property_is_writeable,
+	.usb_types = mt6370_chg_usb_types,
+	.num_usb_types = ARRAY_SIZE(mt6370_chg_usb_types),
+};
+
+static const struct regulator_ops mt6370_chg_otg_ops = {
+	.list_voltage = regulator_list_voltage_linear,
+	.enable = regulator_enable_regmap,
+	.disable = regulator_disable_regmap,
+	.is_enabled = regulator_is_enabled_regmap,
+	.set_voltage_sel = regulator_set_voltage_sel_regmap,
+	.get_voltage_sel = regulator_get_voltage_sel_regmap,
+	.set_current_limit = regulator_set_current_limit_regmap,
+	.get_current_limit = regulator_get_current_limit_regmap,
+};
+
+static const u32 mt6370_chg_otg_oc_ma[] = {
+	500000, 700000, 1100000, 1300000, 1800000, 2100000, 2400000,
+};
+
+static const struct regulator_desc mt6370_chg_otg_rdesc = {
+	.of_match = "usb-otg-vbus-regulator",
+	.of_parse_cb = mt6370_chg_otg_of_parse_cb,
+	.name = "mt6370-usb-otg-vbus",
+	.ops = &mt6370_chg_otg_ops,
+	.owner = THIS_MODULE,
+	.type = REGULATOR_VOLTAGE,
+	.min_uV = 4425000,
+	.uV_step = 25000,
+	.n_voltages = 57,
+	.vsel_reg = MT6370_REG_CHG_CTRL5,
+	.vsel_mask = MT6370_VOBST_MASK,
+	.enable_reg = MT6370_REG_CHG_CTRL1,
+	.enable_mask = MT6370_OPA_MODE_MASK,
+	.curr_table = mt6370_chg_otg_oc_ma,
+	.n_current_limits = ARRAY_SIZE(mt6370_chg_otg_oc_ma),
+	.csel_reg = MT6370_REG_CHG_CTRL10,
+	.csel_mask = MT6370_OTG_OC_MASK,
+};
+
+static int mt6370_chg_init_rmap_fields(struct mt6370_priv *priv)
+{
+	int i;
+	const struct mt6370_chg_field *fds = mt6370_chg_fields;
+
+	for (i = 0; i < F_MAX; i++) {
+		priv->rmap_fields[i] = devm_regmap_field_alloc(priv->dev,
+							       priv->regmap,
+							       fds[i].field);
+		if (IS_ERR(priv->rmap_fields[i]))
+			return dev_err_probe(priv->dev,
+					PTR_ERR(priv->rmap_fields[i]),
+					"Failed to allocate regmapfield[%s]\n",
+					fds[i].name);
+	}
+
+	return 0;
+}
+
+static int mt6370_chg_init_setting(struct mt6370_priv *priv)
+{
+	int ret;
+
+	/* Disable usb_chg_en */
+	ret = mt6370_chg_field_set(priv, F_USBCHGEN, 0);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to disable usb_chg_en\n");
+		return ret;
+	}
+
+	/* ICHG/IEOC Workaround, ICHG can not be set less than 900mA */
+	ret = mt6370_chg_field_set(priv, F_ICHG, 900);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to set ICHG to 900mA");
+		return ret;
+	}
+
+	/* Change input current limit selection to using IAICR results */
+	ret = mt6370_chg_field_set(priv, F_IINLMTSEL, 3);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to set IINLMTSEL\n");
+		return ret;
+	}
+
+	return 0;
+}
+
+#define MT6370_CHG_DT_PROP_DECL(_name, _type, _field)	\
+{							\
+	.name = "mediatek,chg-" #_name,			\
+	.type = MT6370_PARSE_TYPE_##_type,		\
+	.fd = _field,					\
+}
+
+static int mt6370_chg_init_otg_regulator(struct mt6370_priv *priv)
+{
+	struct regulator_config rcfg = {
+		.dev = priv->dev,
+		.regmap = priv->regmap,
+		.driver_data = priv,
+	};
+
+	priv->rdev = devm_regulator_register(priv->dev, &mt6370_chg_otg_rdesc,
+					     &rcfg);
+
+	return PTR_ERR_OR_ZERO(priv->rdev);
+}
+
+static int mt6370_chg_init_psy(struct mt6370_priv *priv)
+{
+	struct power_supply_config cfg = {
+		.drv_data = priv,
+		.of_node = dev_of_node(priv->dev),
+	};
+
+	priv->psy_desc = &mt6370_chg_psy_desc;
+	priv->psy_desc->name = dev_name(priv->dev);
+	priv->psy = devm_power_supply_register(priv->dev, priv->psy_desc, &cfg);
+
+	return PTR_ERR_OR_ZERO(priv->psy);
+}
+
+static irqreturn_t mt6370_attach_i_handler(int irq, void *data)
+{
+	struct mt6370_priv *priv = data;
+	unsigned int otg_en;
+	int ret;
+
+	/* Check in otg mode or not */
+	ret = mt6370_chg_field_get(priv, F_BOOST_STAT, &otg_en);
+	if (ret < 0) {
+		dev_err(priv->dev, "Failed to get otg state\n");
+		return IRQ_NONE;
+	}
+
+	if (otg_en)
+		return IRQ_HANDLED;
+
+	mutex_lock(&priv->attach_lock);
+	priv->attach = MT6370_ATTACH_STAT_ATTACH_BC12_DONE;
+	mutex_unlock(&priv->attach_lock);
+
+	if (!queue_work(priv->wq, &priv->bc12_work))
+		dev_err(priv->dev, "bc12 work has already queued\n");
+
+	return IRQ_HANDLED;
+}
+
+static irqreturn_t mt6370_uvp_d_evt_handler(int irq, void *data)
+{
+	struct mt6370_priv *priv = data;
+
+	mt6370_chg_pwr_rdy_check(priv);
+
+	return IRQ_HANDLED;
+}
+
+static irqreturn_t mt6370_mivr_handler(int irq, void *data)
+{
+	struct mt6370_priv *priv = data;
+
+	pm_stay_awake(priv->dev);
+	mt6370_chg_enable_irq(priv, "mivr", false);
+	schedule_delayed_work(&priv->mivr_dwork, msecs_to_jiffies(200));
+
+	return IRQ_HANDLED;
+}
+
+#define MT6370_CHG_IRQ(_name)						\
+{									\
+	.name = #_name,							\
+	.handler = mt6370_##_name##_handler,				\
+}
+
+static int mt6370_chg_init_irq(struct mt6370_priv *priv)
+{
+	int i, ret;
+	const struct {
+		char *name;
+		irq_handler_t handler;
+	} mt6370_chg_irqs[] = {
+		MT6370_CHG_IRQ(attach_i),
+		MT6370_CHG_IRQ(uvp_d_evt),
+		MT6370_CHG_IRQ(mivr),
+	};
+
+	for (i = 0; i < ARRAY_SIZE(mt6370_chg_irqs); i++) {
+		ret = platform_get_irq_byname(to_platform_device(priv->dev),
+					      mt6370_chg_irqs[i].name);
+		if (ret < 0)
+			return dev_err_probe(priv->dev, ret,
+					     "Failed to get irq %s\n",
+					     mt6370_chg_irqs[i].name);
+
+		ret = devm_request_threaded_irq(priv->dev, ret, NULL,
+						mt6370_chg_irqs[i].handler,
+						IRQF_TRIGGER_FALLING,
+						dev_name(priv->dev),
+						priv);
+
+		if (ret < 0)
+			return dev_err_probe(priv->dev, ret,
+					     "Failed to request irq %s\n",
+					     mt6370_chg_irqs[i].name);
+	}
+
+	return 0;
+}
+
+static int mt6370_chg_probe(struct platform_device *pdev)
+{
+	int ret;
+	struct mt6370_priv *priv;
+
+	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->dev = &pdev->dev;
+
+	priv->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+	if (!priv->regmap)
+		return dev_err_probe(&pdev->dev, -ENODEV,
+				     "Failed to get regmap\n");
+
+	ret = mt6370_chg_init_rmap_fields(priv);
+	if (ret)
+		return dev_err_probe(&pdev->dev, ret,
+				     "Failed to init regmap fields\n");
+
+	platform_set_drvdata(pdev, priv);
+
+	priv->iio_adcs = devm_iio_channel_get_all(priv->dev);
+	if (IS_ERR(priv->iio_adcs))
+		return dev_err_probe(&pdev->dev, PTR_ERR(priv->iio_adcs),
+				     "Failed to get iio adc\n");
+
+	ret = mt6370_chg_init_otg_regulator(priv);
+	if (ret)
+		return dev_err_probe(&pdev->dev, ret,
+				     "Failed to init otg regulator\n");
+
+	ret = mt6370_chg_init_psy(priv);
+	if (ret)
+		return dev_err_probe(&pdev->dev, ret, "Failed to init psy\n");
+
+	mutex_init(&priv->attach_lock);
+	priv->attach = MT6370_ATTACH_STAT_DETACH;
+
+	priv->wq = create_singlethread_workqueue(dev_name(priv->dev));
+	if (IS_ERR(priv->wq))
+		return dev_err_probe(priv->dev, PTR_ERR(priv->wq),
+				     "Failed to create workqueue\n");
+
+	INIT_WORK(&priv->bc12_work, mt6370_chg_bc12_work_func);
+	INIT_DELAYED_WORK(&priv->mivr_dwork, mt6370_chg_mivr_dwork_func);

drivers/power/supply/mt6370-charger.c line 1017

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+
+	ret = mt6370_chg_init_setting(priv);
+	if (ret) {
+		dev_err(&pdev->dev, "Failed to init mt6370 charger setting\n");
+		goto probe_out;
+	}
+
+	ret = mt6370_chg_init_irq(priv);
+	if (ret)
+		goto probe_out;

Please don't allocate resource using devm_ infrastructure after manual allocation. This will use incorrect order during driver removal (interrupts will be released too late). Either interrupts need to be managed manually, or you need to use devm_add_action() for handling of the workqueue/delayed_work/mutex.

Quoted 35 lines
drivers/power/supply/mt6370-charger.c new file +35 -0
+
+	mt6370_chg_pwr_rdy_check(priv);
+
+	return 0;
+
+probe_out:
+	cancel_delayed_work_sync(&priv->mivr_dwork);
+	flush_workqueue(priv->wq);
+	destroy_workqueue(priv->wq);
+	mutex_destroy(&priv->attach_lock);
+
+	return ret;
+}
+
+static int mt6370_chg_remove(struct platform_device *pdev)
+{
+	struct mt6370_priv *priv = platform_get_drvdata(pdev);
+
+	cancel_delayed_work_sync(&priv->mivr_dwork);
+	flush_workqueue(priv->wq);
+	destroy_workqueue(priv->wq);
+	mutex_destroy(&priv->attach_lock);
+
+	return 0;
+}
+
+static const struct of_device_id mt6370_chg_of_match[] = {
+	{ .compatible = "mediatek,mt6370-charger", },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mt6370_chg_of_match);
+
+static struct platform_driver mt6370_chg_driver = {
+	.probe = mt6370_chg_probe,
+	.remove = mt6370_chg_remove,

drivers/power/supply/mt6370-charger.c line 1062

Quoted 10 lines
drivers/power/supply/mt6370-charger.c new file +10 -0
+	.driver = {
+		.name = "mt6370-charger",
+		.of_match_table = mt6370_chg_of_match,
+	},
+};
+module_platform_driver(mt6370_chg_driver);
+
+MODULE_AUTHOR("ChiaEn Wu <[email protected]>");
+MODULE_DESCRIPTION("MediaTek MT6370 Charger Driver");
+MODULE_LICENSE("GPL v2");

-- Sebastian

#29 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to ChiaEn Wu

Hi!

Quoted 19 lines

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

index a49979f..71bacb5 100644

drivers/leds/Kconfig +0 -0
@@ -244,6 +244,20 @@ config LEDS_MT6323
 	  This option enables support for on-chip LED drivers found on
 	  Mediatek MT6323 PMIC.
 

drivers/leds/Kconfig config LEDS_MT6323 · line 256

Quoted 10 lines
drivers/leds/Kconfig +10 -0
+config LEDS_MT6370_RGB
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
+	  Isink4 channel can also be used as a CHG_VIN power good

Should this go to leds/rgb directory, and should it depend on multicolor framework?

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
#13 lore raw

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · ChiaEn Wu

The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

Quoted 4 lines
Quoted 1 line

This commit add support for the Type-C & Power Delivery controller in

This commit add -> Add

Upper case? Or rewrite it as 'This commit is to add .....'?

Quoted 48 lines
Quoted 47 lines

MediaTek MT6370 IC.

drivers/usb/typec/tcpm/tcpci_mt6370.c new file +43 -0
+static int mt6370_tcpc_probe(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->dev = dev;
+       platform_set_drvdata(pdev, priv);
+
+       priv->tcpci_data.regmap = dev_get_regmap(dev->parent, NULL);
+       if (!priv->tcpci_data.regmap)
+               return dev_err_probe(dev, -ENODEV, "Failed to init regmap\n");
+
+       ret = mt6370_check_vendor_info(priv);
+       if (ret)
+               return ret;
+
+       priv->irq = platform_get_irq(pdev, 0);
+       if (priv->irq < 0)
+               return priv->irq;
+
+       /* Assign TCPCI feature and ops */
+       priv->tcpci_data.auto_discharge_disconnect = 1;
+       priv->tcpci_data.init = mt6370_tcpc_init;
+       priv->tcpci_data.set_vconn = mt6370_tcpc_set_vconn;
+
+       priv->vbus = devm_regulator_get_optional(dev, "vbus");
+       if (!IS_ERR(priv->vbus))
+               priv->tcpci_data.set_vbus = mt6370_tcpc_set_vbus;
+
+       priv->tcpci = tcpci_register_port(dev, &priv->tcpci_data);
+       if (IS_ERR(priv->tcpci))
+               return dev_err_probe(dev, PTR_ERR(priv->tcpci),
+                                    "Failed to register tcpci port\n");
+
+       ret = devm_request_threaded_irq(dev, priv->irq, NULL,
+                                       mt6370_irq_handler, IRQF_ONESHOT,
+                                       dev_name(dev), priv);
+       if (ret) {
Quoted 6 lines
Quoted 1 line

+ tcpci_unregister_port(priv->tcpci);

This is wrong.
You mixed devm_ with non-devm. Either drop devm_ *after* the first non-devm_ call, or convert everything to be managed.

How about to add 'devm_add_action_or_reset' for tcpci_unregister_port? This will convert all as 'devm_' version.

Quoted 13 lines
Quoted 12 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +12 -0
+               return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+       }
+
+       device_init_wakeup(dev, true);
+       dev_pm_set_wake_irq(dev, priv->irq);
+
+       return 0;
+}
+
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv = platform_get_drvdata(pdev);
Quoted 5 lines
Quoted 1 line

+ disable_irq(priv->irq);

Why?
An ugly workaround due to ordering issues in ->probe()?

Yes, due to the ordering in probe.
'bus remove' will be called before device resource releases.

Like as you said, another way is to convert all as non-devm version after 'tcpci_unregister_port'.

If to keep the original order, 'disable_irq' before 'tcpci_unregister_port' can make the flow more safe.

Or you can think one case if irq triggers after
'tcpci_unregister_port'. Null pointer occurs.

Anyway, in next revision, I'll convert all to be 'devm_' version. For this remove callback, only 'dev_pm_clear_wake_irq' and 'device_init_wakeup' will be kept.

Is this better?

Quoted 10 lines
Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+       tcpci_unregister_port(priv->tcpci);
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
+
+       return 0;
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#36 lore raw

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

In reply to Daniel Thompson

Il 15/07/22 18:29, Daniel Thompson ha scritto:

Quoted 27 lines · AngeloGioacchino Del Regno
Quoted 18 lines

Il 15/07/22 13:26, ChiaEn Wu ha scritto:

Quoted 8 lines

From: ChiaEn Wu <[email protected]>

MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight driver, display bias voltage supply, one general purpose LDO, and the USB Type-C & PD controller complies with the latest USB Type-C and PD standards.

Quoted 6 lines

This adds support for MediaTek MT6370 Backlight driver. It's commonly used to drive the display WLED. There are 4 channels inside, and each channel supports up to 30mA of current capability with 2048 current steps in exponential or linear mapping curves.

Hello ChiaEn,

Quoted 7 lines

I propose to move this one to drivers/leds (or drivers/pwm) and, instead of registering a backlight device, register a PWM device.

This way you will be able to reuse the generic backlight-pwm driver, as you'd be feeding the PWM device exposed by this driver to the generic one: this will most importantly make it easy to chain it with MTK_DISP_PWM (mtk-pwm-disp) with a devicetree that looks like...

Quoted 6 lines

Out of interest, does MT6370 have the same structure for backlights as the prior systems using mtk-pwm-disp or was mtk-pwm-disp simply a normal(-ish) PWM that relied on something on the board for all the constant current driver hardware?

As per my understanding, mtk-pwm-disp is chained to other multimedia features of the display block of MediaTek SoCs, such as the AAL (adaptive ambient light), CABC (content adaptive backlight control) etc, other than being a normal(ish) PWM... that's the reason of my request.

Moreover, in the end, this PMIC's backlight controller is just a "fancy" PWM controller, with OCP/OVP.

Quoted 17 lines
Quoted 16 lines
	pwmleds-disp {
		compatible = "pwm-leds";

		disp_led: disp-pwm {
			label = "backlight-pwm";
			pwms = <&pwm0 0 500000>;
			max-brightness = <1024>;
		};
	};

	backlight_lcd0: backlight {
		compatible = "led-backlight";
		leds = <&disp_led>, <&pmic_bl_led>;
		default-brightness-level = <300>;
	};
Quoted 4 lines

I think this proposal has to start with the devicetree bindings rather than the driver. Instead I think the question is: does this proposal result in DT bindings that better describe the underlying hardware?

From how I understand it - yes: we have a fancy PWM (&pwm0) that we use to control display backlight (backlight-pwm)...

Obviously, here we're not talking about OLEDs, but LCDs, where the backlight is made of multiple strings of WhiteLED (effectively, a "pwm-leds" controlled "led-backlight").

Using PWM will also allow for a little more fine-grained board specific configuration, as I think that this PMIC (and/or variants of it) will be used in completely different form factors: I think that's going to be both smartphones and tablets/laptops... and I want to avoid vendor properties to configure the PWM part in a somehow different way.

Quoted 4 lines

This device has lots of backlight centric features (OCP, OVP, single control with multiple outputs, exponential curves, etc) and its not clear where they would fit into the "PWM" bindings.

For OCP and OVP, the only bindings that fit would be regulators, but that's not a regulator... and that's about it - I don't really have arguments for that.

What I really want to see here is usage of "generic" drivers like led_bl and/or pwm_bl as to get some "standardization" around with all the benefits that this carries.

Quoted 4 lines

Come to think of it I'm also a little worried also about the whole linear versus exponential curve thing since I thought LED drivers were required to use exponential curves.

That probably depends on how the controller interprets the data, I guess, but I agree with you on this thought.

Regards,
Angelo

author
#37 lore raw

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

Quoted 1 line · AngeloGioacchino Del Regno

<snip>

Quoted 74 lines
Quoted 11 lines
Quoted 10 lines

Hello ChiaEn,

I propose to move this one to drivers/leds (or drivers/pwm) and, instead of registering a backlight device, register a PWM device.

This way you will be able to reuse the generic backlight-pwm driver, as you'd be feeding the PWM device exposed by this driver to the generic one: this will most importantly make it easy to chain it with MTK_DISP_PWM (mtk-pwm-disp) with a devicetree that looks like...

Quoted 6 lines

Out of interest, does MT6370 have the same structure for backlights as the prior systems using mtk-pwm-disp or was mtk-pwm-disp simply a normal(-ish) PWM that relied on something on the board for all the constant current driver hardware?

As per my understanding, mtk-pwm-disp is chained to other multimedia features of the display block of MediaTek SoCs, such as the AAL (adaptive ambient light), CABC (content adaptive backlight control) etc, other than being a normal(ish) PWM... that's the reason of my request.

Moreover, in the end, this PMIC's backlight controller is just a "fancy" PWM controller, with OCP/OVP.

Quoted 17 lines
Quoted 16 lines
     pwmleds-disp {
             compatible = "pwm-leds";

             disp_led: disp-pwm {
                     label = "backlight-pwm";
                     pwms = <&pwm0 0 500000>;
                     max-brightness = <1024>;
             };
     };

     backlight_lcd0: backlight {
             compatible = "led-backlight";
             leds = <&disp_led>, <&pmic_bl_led>;
             default-brightness-level = <300>;
     };
Quoted 4 lines

I think this proposal has to start with the devicetree bindings rather than the driver. Instead I think the question is: does this proposal result in DT bindings that better describe the underlying hardware?

From how I understand it - yes: we have a fancy PWM (&pwm0) that we use
to control display backlight (backlight-pwm)...

Obviously, here we're not talking about OLEDs, but LCDs, where the backlight is made of multiple strings of WhiteLED (effectively, a "pwm-leds" controlled "led-backlight").

Using PWM will also allow for a little more fine-grained board specific configuration, as I think that this PMIC (and/or variants of it) will be used in completely different form factors: I think that's going to be both smartphones and tablets/laptops... and I want to avoid vendor properties to configure the PWM part in a somehow different way.

Quoted 4 lines

This device has lots of backlight centric features (OCP, OVP, single control with multiple outputs, exponential curves, etc) and its not clear where they would fit into the "PWM" bindings.

For OCP and OVP, the only bindings that fit would be regulators, but that's not a regulator... and that's about it - I don't really have arguments for that.

What I really want to see here is usage of "generic" drivers like led_bl and/or pwm_bl as to get some "standardization" around with all the benefits that this carries.

Quoted 7 lines
Quoted 4 lines

Come to think of it I'm also a little worried also about the whole linear versus exponential curve thing since I thought LED drivers were required to use exponential curves.

That probably depends on how the controller interprets the data, I guess, but I agree with you on this thought.

Hi Angelo,

MT6370 is just a SubPMIC, not an SoC, and is applied in cellular telephones, tablet PCs, and portable instruments.
And the PWM mode of the MT6370 backlight driver is optional, and not must be enabled.
From our perspective, this MT6370 backlight driver is not the same as mtk-pwm-disp related driver.
Thanks!

Quoted 3 lines

Regards,
Angelo

Signature · 2 lines
Best Regards,
ChiaEn Wu
#14 lore raw

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

In reply to ChiYuan Huang
Quoted 2 lines · ChiYuan Huang
Quoted 1 line · Andy Shevchenko

On Fri, Jul 15, 2022 at 1:28 PM ChiaEn Wu <[email protected]> wrote:

...

Quoted 5 lines
Quoted 4 lines
Quoted 1 line

This commit add support for the Type-C & Power Delivery controller in

This commit add -> Add

Upper case? Or rewrite it as 'This commit is to add .....'?

Please, read this documentation [1] for better understanding. It should clarify this and perhaps other possible questions.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Quoted 1 line
Quoted 1 line
Quoted 1 line

MediaTek MT6370 IC.

...

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4 -0
+       ret = devm_request_threaded_irq(dev, priv->irq, NULL,
+                                       mt6370_irq_handler, IRQF_ONESHOT,
+                                       dev_name(dev), priv);
+       if (ret) {
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

+ tcpci_unregister_port(priv->tcpci);

This is wrong.
You mixed devm_ with non-devm. Either drop devm_ *after* the first non-devm_ call, or convert everything to be managed.

How about to add 'devm_add_action_or_reset' for tcpci_unregister_port? This will convert all as 'devm_' version.

I think it would work, that wrapper was designed to cover cases like this.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(quoted diff) +2 -0
+               return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+       }

...

Quoted 18 lines
Quoted 9 lines

drivers/usb/typec/tcpm/tcpci_mt6370.c line 181

Quoted 5 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4 -0
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv = platform_get_drvdata(pdev);
 
+       disable_irq(priv->irq);

Why?
An ugly workaround due to ordering issues in ->probe()?

Yes, due to the ordering in probe.
'bus remove' will be called before device resource releases.

Like as you said, another way is to convert all as non-devm version after 'tcpci_unregister_port'.

If to keep the original order, 'disable_irq' before 'tcpci_unregister_port' can make the flow more safe.

Quoted 8 lines

Or you can think one case if irq triggers after
'tcpci_unregister_port'. Null pointer occurs.

Anyway, in next revision, I'll convert all to be 'devm_' version. For this remove callback, only 'dev_pm_clear_wake_irq' and 'device_init_wakeup' will be kept.

Is this better?

Sounds like a plan!

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+       tcpci_unregister_port(priv->tcpci);
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
+
+       return 0;
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#15 lore raw

Re: [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

Andy Shevchenko <[email protected]> 於 2022年7月18日 週一 晚上7:39寫道:

Quoted 9 lines · ChiYuan Huang
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · ChiaEn Wu

...

Quoted 2 lines
Quoted 2 lines
Quoted 1 line

This commit add support for the Type-C & Power Delivery controller in

Quoted 9 lines
Quoted 3 lines
Quoted 2 lines

This commit add -> Add

Upper case? Or rewrite it as 'This commit is to add .....'?

Please, read this documentation [1] for better understanding. It should clarify this and perhaps other possible questions.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

I'm thinking why to change it from 'add' to "Add'. Ah, I misunderstand it.

Quoted 46 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

MediaTek MT6370 IC.

...

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4 -0
+       ret = devm_request_threaded_irq(dev, priv->irq, NULL,
+                                       mt6370_irq_handler, IRQF_ONESHOT,
+                                       dev_name(dev), priv);
+       if (ret) {
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

+ tcpci_unregister_port(priv->tcpci);

This is wrong.
You mixed devm_ with non-devm. Either drop devm_ *after* the first non-devm_ call, or convert everything to be managed.

How about to add 'devm_add_action_or_reset' for tcpci_unregister_port? This will convert all as 'devm_' version.

I think it would work, that wrapper was designed to cover cases like this.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(quoted diff) +2 -0
+               return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+       }

...

Quoted 21 lines
Quoted 9 lines

drivers/usb/typec/tcpm/tcpci_mt6370.c line 181

Quoted 5 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +4 -0
+static int mt6370_tcpc_remove(struct platform_device *pdev)
+{
+       struct mt6370_priv *priv = platform_get_drvdata(pdev);
 
+       disable_irq(priv->irq);

Why?
An ugly workaround due to ordering issues in ->probe()?

Yes, due to the ordering in probe.
'bus remove' will be called before device resource releases.

Like as you said, another way is to convert all as non-devm version after 'tcpci_unregister_port'.

If to keep the original order, 'disable_irq' before 'tcpci_unregister_port' can make the flow more safe.

Or you can think one case if irq triggers after
'tcpci_unregister_port'. Null pointer occurs.

Quoted 8 lines
Quoted 5 lines

Anyway, in next revision, I'll convert all to be 'devm_' version. For this remove callback, only 'dev_pm_clear_wake_irq' and 'device_init_wakeup' will be kept.

Is this better?

Sounds like a plan!

Already did. Just to double confirm the changes.
Thanks. All are clear.

Quoted 10 lines
Quoted 6 lines
Quoted 6 lines

drivers/usb/typec/tcpm/tcpci_mt6370.c line 187

Quoted 6 lines
drivers/usb/typec/tcpm/tcpci_mt6370.c new file +6 -0
+       tcpci_unregister_port(priv->tcpci);
+       dev_pm_clear_wake_irq(&pdev->dev);
+       device_init_wakeup(&pdev->dev, false);
+
+       return 0;
+}

--
With Best Regards,
Andy Shevchenko

#26 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to Andy Shevchenko
Quoted 30 lines · Andy Shevchenko
Quoted 12 lines · ChiaEn Wu

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

...

Quoted 1 line

+ This driver can also be built as a module. If so the module

so, the

Quoted 1 line

+ will be called "leds-mt6370.ko".

No ".ko".

Why did you ignore these comments? Please go and fix _everywhere_ in your series.
It's basically the rule of thumb, if the reviewer gives a comment against an occurrence of something, go through entire series and check if there are other places like commented one and address them all.

Quoted 6 lines

...

Quoted 1 line

+ * Author: Alice Chen <[email protected]>

Strange, the commit message doesn't have a corresponding SoB, why?

Yes, there're two authors Alice and me.
I'll correct it in next.

Quoted 61 lines

...

drivers/leds/leds-mt6370.c line 105

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+#define MT6370_PWM_DUTY                                31
+#define MT6372_PMW_DUTY                                255

Looks like these are limits by hardware?
Check with the datasheet if (BIT(x) - 1) makes more sense here.

...

drivers/leds/leds-mt6370.c line 247

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_DUTY;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_DUTY;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_DUTY;
+               break;
+       default:
+               sel_field = F_LED4_DUTY;

Missed break;

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 298

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_FREQ;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_FREQ;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_FREQ;
+               break;
+       default:
+               sel_field = F_LED4_FREQ;

Ditto.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 319

Quoted 8 lines
drivers/leds/leds-mt6370.c new file +8 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+       case MT6370_LED_ISNK2:
+       case MT6370_LED_ISNK3:
+               *base = MT6370_REG_RGB1_TR + led_no * 3;
+               break;
+       default:
+               *base = MT6370_REG_RGB_CHRIND_TR;

Ditto.
It seems you dropped them for all switch-cases. It's not goot, please restore them back.

Quoted 9 lines
Quoted 1 line

+ }

...

Quoted 1 line

+ u8 val[P_MAX_PATTERNS / 2] = {0};

{ } should suffice

In the above range selector, we use the 'logic or' to generate the pattern values.

If to change it from '{0} to '{ }', is it correct?

Quoted 44 lines
Quoted 23 lines
drivers/leds/leds-mt6370.c new file +23 -0
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);
+       return 0;
+}

...

Quoted 1 line

+out:

out_unlock:

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;

...

Quoted 1 line

+out:

Ditto. And so on.

drivers/leds/leds-mt6370.c line 442

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;
Quoted 8 lines

...

drivers/leds/leds-mt6370.c line 709

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+               sub_led = devm_kzalloc(priv->dev,
+                                      sizeof(*sub_led) * MC_CHANNEL_NUM,
+                                      GFP_KERNEL);

NIH devm_kcalloc(). Also check if you really need zeroed data.

Ok, and after the check, I also need to add one line to set the intensity to 0.

Quoted 31 lines
Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+               if (!sub_led)
+                       return -ENOMEM;

...

drivers/leds/leds-mt6370.c line 726

Quoted 6 lines
drivers/leds/leds-mt6370.c new file +6 -0
+                       ret = fwnode_property_read_u32(child, "color", &color);
+                       if (ret) {
+                               dev_err(priv->dev,
+                                       "led %d, no color specified\n",
+                                       led->index);
+                               return ret;

return dev_err_probe(...) ; ?

Ditto for many places in your entire series.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 907

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       priv = devm_kzalloc(&pdev->dev,
+                           struct_size(priv, leds, count), GFP_KERNEL);

At least one parameter can be placed on the previous line.

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       if (!priv)
+               return -ENOMEM;
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#27 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

ChiYuan Huang <[email protected]> 於 2022年7月20日 週三 下午5:45寫道:

Quoted 103 lines · Andy Shevchenko
Quoted 30 lines · ChiaEn Wu
Quoted 12 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

...

Quoted 1 line

+ This driver can also be built as a module. If so the module

so, the

Quoted 1 line

+ will be called "leds-mt6370.ko".

No ".ko".

Why did you ignore these comments? Please go and fix _everywhere_ in your series.
It's basically the rule of thumb, if the reviewer gives a comment against an occurrence of something, go through entire series and check if there are other places like commented one and address them all.

Quoted 6 lines

...

Quoted 1 line

+ * Author: Alice Chen <[email protected]>

Strange, the commit message doesn't have a corresponding SoB, why?

Yes, there're two authors Alice and me.
I'll correct it in next.

Quoted 63 lines

...

drivers/leds/leds-mt6370.c line 105

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+#define MT6370_PWM_DUTY                                31
+#define MT6372_PMW_DUTY                                255

Looks like these are limits by hardware?
Check with the datasheet if (BIT(x) - 1) makes more sense here.

...

drivers/leds/leds-mt6370.c line 247

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_DUTY;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_DUTY;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_DUTY;
+               break;
+       default:
+               sel_field = F_LED4_DUTY;

Missed break;

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 298

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_FREQ;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_FREQ;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_FREQ;
+               break;
+       default:
+               sel_field = F_LED4_FREQ;

Ditto.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 319

Quoted 8 lines
drivers/leds/leds-mt6370.c new file +8 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+       case MT6370_LED_ISNK2:
+       case MT6370_LED_ISNK3:
+               *base = MT6370_REG_RGB1_TR + led_no * 3;
+               break;
+       default:
+               *base = MT6370_REG_RGB_CHRIND_TR;

Ditto.
It seems you dropped them for all switch-cases. It's not goot, please restore them back.

Quoted 1 line

+ }

Quoted 8 lines
Quoted 7 lines

...

Quoted 1 line

+ u8 val[P_MAX_PATTERNS / 2] = {0};

{ } should suffice

In the above range selector, we use the 'logic or' to generate the

typo, it's 'below'.

Quoted 87 lines

pattern values.

If to change it from '{0} to '{ }', is it correct?

Quoted 44 lines
Quoted 23 lines
drivers/leds/leds-mt6370.c new file +23 -0
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);
+       return 0;
+}

...

Quoted 1 line

+out:

out_unlock:

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;

...

Quoted 1 line

+out:

Ditto. And so on.

drivers/leds/leds-mt6370.c line 442

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;
Quoted 8 lines

...

drivers/leds/leds-mt6370.c line 709

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+               sub_led = devm_kzalloc(priv->dev,
+                                      sizeof(*sub_led) * MC_CHANNEL_NUM,
+                                      GFP_KERNEL);

NIH devm_kcalloc(). Also check if you really need zeroed data.

Ok, and after the check, I also need to add one line to set the intensity to 0.

Quoted 31 lines
Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+               if (!sub_led)
+                       return -ENOMEM;

...

drivers/leds/leds-mt6370.c line 726

Quoted 6 lines
drivers/leds/leds-mt6370.c new file +6 -0
+                       ret = fwnode_property_read_u32(child, "color", &color);
+                       if (ret) {
+                               dev_err(priv->dev,
+                                       "led %d, no color specified\n",
+                                       led->index);
+                               return ret;

return dev_err_probe(...) ; ?

Ditto for many places in your entire series.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 907

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       priv = devm_kzalloc(&pdev->dev,
+                           struct_size(priv, leds, count), GFP_KERNEL);

At least one parameter can be placed on the previous line.

drivers/leds/leds-mt6370.c line 909

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       if (!priv)
+               return -ENOMEM;

--
With Best Regards,
Andy Shevchenko

#28 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

ChiYuan Huang <[email protected]> 於 2022年7月20日 週三 下午5:48寫道:

Quoted 107 lines

ChiYuan Huang <[email protected]> 於 2022年7月20日 週三 下午5:45寫道:

Quoted 105 lines · Andy Shevchenko
Quoted 30 lines · ChiaEn Wu
Quoted 12 lines

From: ChiYuan Huang <[email protected]>

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

...

Quoted 1 line

+ This driver can also be built as a module. If so the module

so, the

Quoted 1 line

+ will be called "leds-mt6370.ko".

No ".ko".

Why did you ignore these comments? Please go and fix _everywhere_ in your series.
It's basically the rule of thumb, if the reviewer gives a comment against an occurrence of something, go through entire series and check if there are other places like commented one and address them all.

Quoted 6 lines

...

Quoted 1 line

+ * Author: Alice Chen <[email protected]>

Strange, the commit message doesn't have a corresponding SoB, why?

Yes, there're two authors Alice and me.
I'll correct it in next.

Quoted 65 lines

...

drivers/leds/leds-mt6370.c line 105

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+#define MT6370_PWM_DUTY                                31
+#define MT6372_PMW_DUTY                                255

Looks like these are limits by hardware?
Check with the datasheet if (BIT(x) - 1) makes more sense here.

...

drivers/leds/leds-mt6370.c line 247

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_DUTY;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_DUTY;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_DUTY;
+               break;
+       default:
+               sel_field = F_LED4_DUTY;

Missed break;

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 298

Quoted 12 lines
drivers/leds/leds-mt6370.c new file +12 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+               sel_field = F_LED1_FREQ;
+               break;
+       case MT6370_LED_ISNK2:
+               sel_field = F_LED2_FREQ;
+               break;
+       case MT6370_LED_ISNK3:
+               sel_field = F_LED3_FREQ;
+               break;
+       default:
+               sel_field = F_LED4_FREQ;

Ditto.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 319

Quoted 8 lines
drivers/leds/leds-mt6370.c new file +8 -0
+       switch (led_no) {
+       case MT6370_LED_ISNK1:
+       case MT6370_LED_ISNK2:
+       case MT6370_LED_ISNK3:
+               *base = MT6370_REG_RGB1_TR + led_no * 3;
+               break;
+       default:
+               *base = MT6370_REG_RGB_CHRIND_TR;

Ditto.
It seems you dropped them for all switch-cases. It's not goot, please restore them back.

Quoted 1 line

+ }

...

Quoted 9 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

+ u8 val[P_MAX_PATTERNS / 2] = {0};

{ } should suffice

In the above range selector, we use the 'logic or' to generate the

typo, it's 'below'.

Quoted 2 lines

pattern values.

Ah, found in c11 standard 6.7.9 item 21
It is the same as 'static storage duration'.
I will follow your comment to revise it.
Thanks.

Quoted 85 lines
Quoted 85 lines

If to change it from '{0} to '{ }', is it correct?

Quoted 44 lines
Quoted 23 lines
drivers/leds/leds-mt6370.c new file +23 -0
+       /*
+        * Pattern list
+        * tr1: byte 0, b'[7: 4]
+        * tr2: byte 0, b'[3: 0]
+        * tf1: byte 1, b'[7: 4]
+        * tf2: byte 1, b'[3: 0]
+        * ton: byte 2, b'[7: 4]
+        * toff: byte 2, b'[3: 0]
+        */
+       for (i = 0; i < P_MAX_PATTERNS; i++) {
+               curr = pattern + i;
+
+               sel_range = i == P_LED_TOFF ? R_LED_TOFF : R_LED_TRFON;
+
+               linear_range_get_selector_within(priv->ranges + sel_range,
+                                                curr->delta_t, &sel);
+
+               val[i / 2] |= sel << (4 * ((i + 1) % 2));
+       }
+
+       memcpy(pattern_val, val, 3);
+       return 0;
+}

...

Quoted 1 line

+out:

out_unlock:

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;

...

Quoted 1 line

+out:

Ditto. And so on.

drivers/leds/leds-mt6370.c line 442

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+       mutex_unlock(&priv->lock);
+
+       return ret;
Quoted 8 lines

...

drivers/leds/leds-mt6370.c line 709

Quoted 3 lines
drivers/leds/leds-mt6370.c new file +3 -0
+               sub_led = devm_kzalloc(priv->dev,
+                                      sizeof(*sub_led) * MC_CHANNEL_NUM,
+                                      GFP_KERNEL);

NIH devm_kcalloc(). Also check if you really need zeroed data.

Ok, and after the check, I also need to add one line to set the intensity to 0.

Quoted 31 lines
Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+               if (!sub_led)
+                       return -ENOMEM;

...

drivers/leds/leds-mt6370.c line 726

Quoted 6 lines
drivers/leds/leds-mt6370.c new file +6 -0
+                       ret = fwnode_property_read_u32(child, "color", &color);
+                       if (ret) {
+                               dev_err(priv->dev,
+                                       "led %d, no color specified\n",
+                                       led->index);
+                               return ret;

return dev_err_probe(...) ; ?

Ditto for many places in your entire series.

Quoted 1 line

+ }

...

drivers/leds/leds-mt6370.c line 907

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       priv = devm_kzalloc(&pdev->dev,
+                           struct_size(priv, leds, count), GFP_KERNEL);

At least one parameter can be placed on the previous line.

drivers/leds/leds-mt6370.c line 909

Quoted 2 lines
drivers/leds/leds-mt6370.c new file +2 -0
+       if (!priv)
+               return -ENOMEM;

--
With Best Regards,
Andy Shevchenko

#30 lore raw

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

In reply to Pavel Machek
Quoted 21 lines · Pavel Machek

Hi!

Quoted 19 lines

The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices.

In MediaTek MT6370, there are four channel current-sink RGB LEDs that support hardware pattern for constant current, PWM, and breath mode. Isink4 channel can also be used as a CHG_VIN power good indicator.

index a49979f..71bacb5 100644

drivers/leds/Kconfig +0 -0
@@ -244,6 +244,20 @@ config LEDS_MT6323
 	  This option enables support for on-chip LED drivers found on
 	  Mediatek MT6323 PMIC.
 
Quoted 13 lines

drivers/leds/Kconfig config LEDS_MT6323

Quoted 10 lines
drivers/leds/Kconfig +10 -0
+config LEDS_MT6370_RGB
+	tristate "LED Support for MediaTek MT6370 PMIC"
+	depends on LEDS_CLASS
+	depends on MFD_MT6370
+	select LINEAR_RANGE
+	help
+	  Say Y here to enable support for MT6370_RGB LED device.
+	  In MT6370, there are four channel current-sink LED drivers that
+	  support hardware pattern for constant current, PWM, and breath mode.
+	  Isink4 channel can also be used as a CHG_VIN power good

Should this go to leds/rgb directory, and should it depend on multicolor framework?

Yes, and I may also want to change the file name from 'leds-mt6370' to 'leds-mt6370-rgb'. Is it ok?

Quoted 5 lines

Best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.