Skip to contentSkip to conversation

char: ipmi: kcs: add Arbel NPCM8XX support

PATCH In review Tomer Maimon 3 participants 10 messages Jul 17, 2022 – Aug 4, 2022

Subsystems (3)
Device tree bindings IPMI Arm/nuvoton npcm architecture
lore
Share & tools
lore

Tomer Maimon

author maintainer
#0 lore raw

cover char: ipmi: kcs: add Arbel NPCM8XX support

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Signature · 1 line
2.33.0
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: ipmi: Add npcm845 compatible

Add a compatible string for Nuvoton BMC NPCM845 KCS and modify NPCM KCS description to support all NPCM BMC SoC.

Signed-off-by Tomer Maimon <[email protected]>
---
 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt +3 -2
index 352f5e9c759b..cbc10a68ddef 100644
@@ -1,12 +1,13 @@
-* Nuvoton NPCM7xx KCS (Keyboard Controller Style) IPMI interface
+* Nuvoton NPCM KCS (Keyboard Controller Style) IPMI interface
 
-The Nuvoton SOCs (NPCM7xx) are commonly used as BMCs
+The Nuvoton SOCs (NPCM) are commonly used as BMCs
 (Baseboard Management Controllers) and the KCS interface can be
 used to perform in-band IPMI communication with their host.
 
 Required properties:
 - compatible : should be one of
     "nuvoton,npcm750-kcs-bmc"
+    "nuvoton,npcm845-kcs-bmc"
 - interrupts : interrupt generated by the controller
 - kcs_chan : The KCS channel number in the controller
Signature · 1 line
2.33.0
author maintainer
#3 lore raw

PATCH 2/2 char: ipmi: modify NPCM KCS configuration

In reply to Tomer Maimon

Modify NPCM IPMI KCS configuration to support all NPCM BMC SoC.

Signed-off-by Tomer Maimon <[email protected]>
---
 drivers/char/ipmi/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/ipmi/Kconfig +3 -3
index b061e6b513ed..39565cf74b2c 100644
@@ -119,13 +119,13 @@ config ASPEED_KCS_IPMI_BMC
 	  provides the access of KCS IO space for BMC side.
 
 config NPCM7XX_KCS_IPMI_BMC
-	depends on ARCH_NPCM7XX || COMPILE_TEST
+	depends on ARCH_NPCM || COMPILE_TEST
 	select IPMI_KCS_BMC
 	select REGMAP_MMIO
-	tristate "NPCM7xx KCS IPMI BMC driver"
+	tristate "NPCM KCS IPMI BMC driver"
 	help
 	  Provides a driver for the KCS (Keyboard Controller Style) IPMI
-	  interface found on Nuvoton NPCM7xx SOCs.
+	  interface found on Nuvoton NPCM SOCs.
 
 	  The driver implements the BMC side of the KCS contorller, it
 	  provides the access of KCS IO space for BMC side.
Signature · 1 line
2.33.0
#4 lore raw
In reply to Tomer Maimon
Quoted 4 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 12 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Signature · 1 line
2.33.0
author maintainer
#5 lore raw

Hi Corey,

Quoted 5 lines · Corey Minyard
Quoted 3 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

Quoted 19 lines
Quoted 1 line

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 12 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

--
2.33.0

Sorry but I need to do a little fix in the document file.

Can I do it or have you already applied the patches?

Thanks,

Tomer

#6 lore raw
Quoted 25 lines · Tomer Maimon

Hi Corey,

Quoted 21 lines · Corey Minyard
Quoted 4 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 9 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

--
2.33.0

Sorry but I need to do a little fix in the document file.

Can I do it or have you already applied the patches?

At this point I'd prefer a patch on top of what is there. 5.19 isn't released yet, so the window isn't open, but that will happen soon and I don't want to rebase at this point.

-corey

Quoted 4 lines

Thanks,

Tomer

author maintainer
#7 lore raw

Hi Corey,

Quoted 31 lines · Corey Minyard
Quoted 29 lines · Tomer Maimon

Hi Corey,

Quoted 24 lines · Corey Minyard
Quoted 4 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 12 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

--
2.33.0

Quoted 7 lines
Quoted 3 lines

Sorry but I need to do a little fix in the document file.

Can I do it or have you already applied the patches?

At this point I'd prefer a patch on top of what is there. 5.19 isn't released yet, so the window isn't open, but that will happen soon and I don't want to rebase at this point.

O.K. thanks,
I will wait until 5.19 is released and then I will send the patch.

Quoted 7 lines

-corey

Quoted 4 lines

Thanks,

Tomer

Best regards,

Tomer

#8 lore raw
Quoted 36 lines · Tomer Maimon

Hi Corey,

Quoted 33 lines · Corey Minyard
Quoted 31 lines · Tomer Maimon

Hi Corey,

Quoted 5 lines · Corey Minyard
Quoted 3 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

Quoted 19 lines
Quoted 1 line

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 12 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

--
2.33.0

Sorry but I need to do a little fix in the document file.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Can I do it or have you already applied the patches?

At this point I'd prefer a patch on top of what is there. 5.19 isn't released yet, so the window isn't open, but that will happen soon and I don't want to rebase at this point.

O.K. thanks,
I will wait until 5.19 is released and then I will send the patch.

Oh, sorry I wasn't clear. You can send it now, I just don't want to rebase what I have already. Just a new patch on top of it, and I'll get it in to 5.19.

-corey

author maintainer
#9 lore raw

Hi Corey,

Sorry, miss this email...

Quoted 43 lines · Corey Minyard
Quoted 41 lines · Tomer Maimon

Hi Corey,

Quoted 38 lines · Corey Minyard
Quoted 25 lines · Tomer Maimon

Hi Corey,

Quoted 21 lines · Corey Minyard
Quoted 4 lines · Tomer Maimon

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree. If anyone has any issues with this, please respond.

-corey

Quoted 9 lines

Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

--
2.33.0

Sorry but I need to do a little fix in the document file.

Can I do it or have you already applied the patches?

At this point I'd prefer a patch on top of what is there. 5.19 isn't released yet, so the window isn't open, but that will happen soon and I don't want to rebase at this point.

Quoted 8 lines
Quoted 2 lines

O.K. thanks,
I will wait until 5.19 is released and then I will send the patch.

Oh, sorry I wasn't clear. You can send it now, I just don't want to rebase what I have already. Just a new patch on top of it, and I'll get it in to 5.19.

-corey

Sent a patch now.

Best regards,

Tomer