Skip to contentSkip to conversation

lib-ts_bmc-remove-redundant-store-to-variable-consumed-after-addition.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Jul 18, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: lib/ts_bm.c: remove redundant store to variable consumed after addition
has been removed from the -mm tree. Its filename was
lib-ts_bmc-remove-redundant-store-to-variable-consumed-after-addition.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Colin Ian King <[email protected]>
Subject: lib/ts_bm.c: remove redundant store to variable consumed after addition
Date: Mon, 4 Jul 2022 22:53:25 +0100

There is no need to store the result of the addition back to variable consumed after the addition. The store is redundant, replace += with just +

Cleans up clang scan build warning: lib/ts_bm.c:83:11: warning: Although the value stored to 'consumed' is used in the enclosing expression, the value is never actually read from 'consumed' [deadcode.DeadStores]

---

 lib/ts_bm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/ts_bm.c renamed from lib/ts_bm.c~lib-ts_bmc-remove-redundant-store-to-variable-consumed-after-addition +1 -1
@@ -80,7 +80,7 @@ static unsigned int bm_find(struct ts_co
 
 			/* London calling... */
 			DEBUGP("found!\n");
-			return consumed += (shift-(bm->patlen-1));
+			return consumed + (shift-(bm->patlen-1));
 
 next:			bs = bm->bad_shift[text[shift-i]];
 

_

Patches currently in -mm which might be from [email protected] are