Skip to contentSkip to conversation

apparmor: Mark alloc_unconfined() as static

PATCH In review Souptick Joarder 2 participants 2 messages Jul 19, 2022 – Jul 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apparmor: Mark alloc_unconfined() as static

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot throws below warning -> security/apparmor/policy_ns.c:83:20: warning: no previous prototype for function 'alloc_unconfined' [-Wmissing-prototypes]

Mark it as static.

---
 security/apparmor/policy_ns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/apparmor/policy_ns.c +1 -1
index 300953a02a24..4f6e9b3c24e6 100644
@@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
 	return aa_hidden_ns_name;
 }
 
-struct aa_profile *alloc_unconfined(const char *name)
+static struct aa_profile *alloc_unconfined(const char *name)
 {
 	struct aa_profile *profile;
 
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Souptick Joarder

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot throws below warning -> security/apparmor/policy_ns.c:83:20: warning: no previous prototype for function 'alloc_unconfined' [-Wmissing-prototypes]

Mark it as static.

Thanks, I have pulled this into apparmor-next

Quoted 17 lines
---
  security/apparmor/policy_ns.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
security/apparmor/policy_ns.c +1 -1
index 300953a02a24..4f6e9b3c24e6 100644
@@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
  	return aa_hidden_ns_name;
  }
 
-struct aa_profile *alloc_unconfined(const char *name)
+static struct aa_profile *alloc_unconfined(const char *name)
  {
  	struct aa_profile *profile;