ufs: host: ufshcd-pltfrm: Hold reference returned by of_parse_phandle()
PATCH v3 1/1 ufs: host: ufshcd-pltfrm: Hold reference returned by of_parse_phandle()
In ufshcd_populate_vreg(), we should hold the reference returned by of_parse_phandle() and then use it to call of_node_put() for refcount balance.
---
changelog:
v3: fix indentation problem and use 'ret parse_np != NULL'
v2: change helper name
v1: fix holding bug
Here we also change the indentation of original 'ufshcd_populate_vreg()'
drivers/ufs/host/ufshcd-pltfrm.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
drivers/ufs/host/ufshcd-pltfrm.c +13 -2
@@ -108,9 +108,20 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)return ret; } +static bool phandle_exists (const struct device_node *np, +const char *phandle_name,int index) +{ +struct device_node *parse_np =of_parse_phandle (np, phandle_name, index); + +if (parse_np) +of_node_put (parse_np); + +return parse_np !=NULL ; +} +#define MAX_PROP_SIZE 32static int ufshcd_populate_vreg (struct device *dev,const char *name, -struct ufs_vreg **out_vreg) +struct ufs_vreg **out_vreg) {char prop_name[MAX_PROP_SIZE ];struct ufs_vreg *vreg =NULL ;
@@ -122,7 +133,7 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, }snprintf (prop_name,MAX_PROP_SIZE ,"%s-supply" , name); -if (!of_parse_phandle (np, prop_name,0 )) { +if (!phandle_exists (np, prop_name,0 )) {dev_info (dev,"%s: Unable to find %s regulator, assuming enabled\n" , __func__, prop_name); goto out;
Signature · 1 line
2.25.1
Quoted 3 lines · Liang He
In
ufshcd_populate_vreg(), we should hold the reference returned byof_parse_phandle()and then use it to callof_node_put()for refcount balance.
Martin K. Petersen
AppliedQuoted 5 lines · Liang He
In
ufshcd_populate_vreg(), we should hold the reference returned byof_parse_phandle()and then use it to callof_node_put()for refcount balance.
Applied to 5.19/scsi-fixes, thanks!
[1/1] ufs: host: ufshcd-pltfrm: Hold reference returned by of_parse_phandle()
https://git.kernel.org/mkp/scsi/c/a3435afba87d
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering