ACPI: remove useless comparisons in acpi_pci_link_check_possible(), acpi_pci_link_check_current()
PATCH 1/1 ACPI: remove useless comparisons in acpi_pci_link_check_possible(), acpi_pci_link_check_current()
Local variable 'p' is initialized by an address
of field of acpi_resource, so it does not make
sense to compare 'p' with NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
--- drivers/acpi/pci_link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/acpi/pci_link.c +4 -4
@@ -95,7 +95,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {acpi_handle_debug (handle,"Blank _PRS IRQ resource\n" );return AE_OK ;
@@ -121,7 +121,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {acpi_handle_debug (handle,"Blank _PRS EXT IRQ resource\n" );return AE_OK ;
@@ -182,7 +182,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * IRQ descriptors may have no IRQ# bits set, * particularly those w/ _STA disabled
@@ -197,7 +197,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * extended IRQ descriptors must * return at least 1 IRQ
Signature · 1 line
2.25.1
Since this only affects pci_link.c, I would update the subject to match the style of previous commits:
ACPI/PCI: Remove useless NULL pointer checks
Quoted 3 lines · Andrey Strachuk
Local variable 'p' is initialized by an address
of field ofacpi_resource, so it does not make
sense to compare 'p' with NULL.
Rewrap to fill 75 columns, which is the typical width of commit logs.
Quoted 4 lines
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by Andrey Strachuk <[email protected]>Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
I think you should drop this Fixes: tag because it's not useful.
Quoted 47 lines
--- drivers/acpi/pci_link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/acpi/pci_link.c +4
-4@@ -95,7 +95,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {acpi_handle_debug (handle,"Blank _PRS IRQ resource\n" );return AE_OK ;@@ -121,7 +121,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {acpi_handle_debug (handle,"Blank _PRS EXT IRQ resource\n" );return AE_OK ;@@ -182,7 +182,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * IRQ descriptors may have no IRQ# bits set, * particularly those w/ _STA disabled @@ -197,7 +197,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * extended IRQ descriptors must * return at least 1 IRQ Signature · 1 line
2.25.1