Skip to contentSkip to conversation

migration: add remaining params->has_* = true in migration_instance_init()

PATCH In review Leonardo Bras 3 participants 4 messages Jul 26, 2022 – Aug 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 migration: add remaining params->has_* = true in migration_instance_init()

Some of params->has_* = true are missing in migration_instance_init, this causes migrate_params_check() to skip some tests, allowing some unsupported scenarios.

Fix this by adding all missing params->has_* = true in migration_instance_init().

---
 migration/migration.c | 4 ++++
 1 file changed, 4 insertions(+)
migration/migration.c +4 -0
index e03f698a3c..82fbe0cf55 100644
@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
     /* Set has_* up only for parameter checks */
     params->has_compress_level = true;
     params->has_compress_threads = true;
+    params->has_compress_wait_thread = true;
     params->has_decompress_threads = true;
     params->has_throttle_trigger_threshold = true;
     params->has_cpu_throttle_initial = true;
@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
     params->has_announce_max = true;
     params->has_announce_rounds = true;
     params->has_announce_step = true;
+    params->has_tls_creds = true;
+    params->has_tls_hostname = true;
+    params->has_tls_authz = true;
 
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
Signature · 1 line
2.37.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 37 lines · Leonardo Bras

Some of params->has_* = true are missing in migration_instance_init, this causes migrate_params_check() to skip some tests, allowing some unsupported scenarios.

Fix this by adding all missing params->has_* = true in migration_instance_init().

---
 migration/migration.c | 4 ++++
 1 file changed, 4 insertions(+)
migration/migration.c +4 -0
index e03f698a3c..82fbe0cf55 100644
@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
     /* Set has_* up only for parameter checks */
     params->has_compress_level = true;
     params->has_compress_threads = true;
+    params->has_compress_wait_thread = true;
     params->has_decompress_threads = true;
     params->has_throttle_trigger_threshold = true;
     params->has_cpu_throttle_initial = true;
@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
     params->has_announce_max = true;
     params->has_announce_rounds = true;
     params->has_announce_step = true;
+    params->has_tls_creds = true;
+    params->has_tls_hostname = true;
+    params->has_tls_authz = true;
 
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
Signature · 1 line
2.37.1
Signature · 1 line
Peter Xu
#2 lore raw
In reply to Leonardo Bras

Please include:

Fixes 69ef1f36b0 ("migration: define 'tls-creds' and 'tls-hostname'

migration parameters")

Fixes 1d58872a91 ("migration: do not wait for free thread")
Fixes d2f1d29b95 ("migration: add support for a "tls-authz" migration

parameter")

Quoted 38 lines · Leonardo Bras

Some of params->has_* = true are missing in migration_instance_init, this causes migrate_params_check() to skip some tests, allowing some unsupported scenarios.

Fix this by adding all missing params->has_* = true in migration_instance_init().

---
 migration/migration.c | 4 ++++
 1 file changed, 4 insertions(+)
migration/migration.c +4 -1
index e03f698a3c..82fbe0cf55 100644
@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
     /* Set has_* up only for parameter checks */
     params->has_compress_level = true;
     params->has_compress_threads = true;
+    params->has_compress_wait_thread = true;
     params->has_decompress_threads = true;
     params->has_throttle_trigger_threshold = true;
     params->has_cpu_throttle_initial = true;
@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
     params->has_announce_max = true;
     params->has_announce_rounds = true;
     params->has_announce_step = true;
+    params->has_tls_creds = true;
+    params->has_tls_hostname = true;
+    params->has_tls_authz = true;
 
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
--

2.37.1

#3 lore raw
Quoted 7 lines · * Leonardo Bras Soares Passos ([email protected]) wrote:

Please include:

Fixes 69ef1f36b0 ("migration: define 'tls-creds' and 'tls-hostname'

migration parameters")

Fixes 1d58872a91 ("migration: do not wait for free thread")
Fixes d2f1d29b95 ("migration: add support for a "tls-authz" migration

parameter")

Queued

Quoted 41 lines · Leonardo Bras
Quoted 38 lines

Some of params->has_* = true are missing in migration_instance_init, this causes migrate_params_check() to skip some tests, allowing some unsupported scenarios.

Fix this by adding all missing params->has_* = true in migration_instance_init().

---
 migration/migration.c | 4 ++++
 1 file changed, 4 insertions(+)
migration/migration.c +4 -1
index e03f698a3c..82fbe0cf55 100644
@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
     /* Set has_* up only for parameter checks */
     params->has_compress_level = true;
     params->has_compress_threads = true;
+    params->has_compress_wait_thread = true;
     params->has_decompress_threads = true;
     params->has_throttle_trigger_threshold = true;
     params->has_cpu_throttle_initial = true;
@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
     params->has_announce_max = true;
     params->has_announce_rounds = true;
     params->has_announce_step = true;
+    params->has_tls_creds = true;
+    params->has_tls_hostname = true;
+    params->has_tls_authz = true;
 
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
--

2.37.1

Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK