iio: pressure: dlhl60d: Don't take garbage into consideration when reading data
PATCH 1/1 iio: pressure: dlhl60d: Don't take garbage into consideration when reading data
Both pressure and temperature are 24-bit long. Use proper accessors instead of overlapping readings.
--- drivers/iio/pressure/dlhl60d.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/pressure/dlhl60d.c +2 -3
@@ -129,9 +129,8 @@ static int dlh_read_direct(struct dlh_state *st,if (ret)return ret; - *pressure =get_unaligned_be32 (&st->rx_buf[1 ]) >>8 ; - *temperature =get_unaligned_be32 (&st->rx_buf[3 ]) & -GENMASK (DLH_NUM_TEMP_BITS -1 ,0 ); + *pressure =get_unaligned_be24 (&st->rx_buf[1 ]); + *temperature =get_unaligned_be24 (&st->rx_buf[4 ]);return 0 ; }
Signature · 1 line
2.35.1
Jonathan Cameron
maintainerQuoted 4 lines · On Tue, 26 Jul 2022 17:20:48 +0300 Andy Shevchenko…
Both pressure and temperature are 24-bit long. Use proper accessors instead of overlapping readings.
Signed-off-by Andy Shevchenko <[email protected]>
Looks correct to me, but it made me scratch my head just enough that I'd like Tomislav to take a look if possible. So give me a poke if this hasn't progressed in a few weeks time.
Thanks,
Jonathan
Quoted 20 lines
--- drivers/iio/pressure/dlhl60d.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/iio/pressure/dlhl60d.c +2
-3@@ -129,9 +129,8 @@ static int dlh_read_direct(struct dlh_state *st,if (ret)return ret; - *pressure =get_unaligned_be32 (&st->rx_buf[1 ]) >>8 ; - *temperature =get_unaligned_be32 (&st->rx_buf[3 ]) & -GENMASK (DLH_NUM_TEMP_BITS -1 ,0 ); + *pressure =get_unaligned_be24 (&st->rx_buf[1 ]); + *temperature =get_unaligned_be24 (&st->rx_buf[4 ]);return 0 ; }
Jonathan Cameron
maintainerQuoted 10 lines · On Sun, 31 Jul 2022 13:33:57 +0100 Jonathan Cameron <[email protected]> wrote:
Quoted 4 lines · On Tue, 26 Jul 2022 17:20:48 +0300 Andy Shevchenko…
Both pressure and temperature are 24-bit long. Use proper accessors instead of overlapping readings.
Signed-off-by Andy Shevchenko <[email protected]>Looks correct to me, but it made me scratch my head just enough that I'd like Tomislav to take a look if possible. So give me a poke if this hasn't progressed in a few weeks time.
Long enough.
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
Quoted 26 lines
Thanks,
Jonathan
Quoted 20 lines
--- drivers/iio/pressure/dlhl60d.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/iio/pressure/dlhl60d.c +2
-3@@ -129,9 +129,8 @@ static int dlh_read_direct(struct dlh_state *st,if (ret)return ret; - *pressure =get_unaligned_be32 (&st->rx_buf[1 ]) >>8 ; - *temperature =get_unaligned_be32 (&st->rx_buf[3 ]) & -GENMASK (DLH_NUM_TEMP_BITS -1 ,0 ); + *pressure =get_unaligned_be24 (&st->rx_buf[1 ]); + *temperature =get_unaligned_be24 (&st->rx_buf[4 ]);return 0 ; }