fstests: add test case to make sure btrfs can handle one corrupted device
PATCH v2 1/1 fstests: add test case to make sure btrfs can handle one corrupted device
The new test case will verify that btrfs can handle one corrupted device without affecting the consistency of the filesystem.
Unlike a missing device, one corrupted device can return garbage to the fs, thus btrfs has to utilize its data/metadata checksum to verify which data is correct.
The test case will:
- Create a small fs
Mostly to speedup the test
- Fill the fs with a regular file
- Use fsstress to create some contents
- Save the fssum for later verification
- Corrupt one device with garbage but keep the primary superblock untouched
- Run fssum verification
- Run scrub to fix the fs
- Run scrub again to make sure the fs is fine
---
Changelog:
v2:
- Use _btrfs_get_profile_configs() helper to grab the mkfs options
- Use fixed number of devices 4 to co-operate with above change
- Remove a not-so-helpful debug output into $seqres.full
- Add to group auto and volume
- Use $SCRATCH_DEV as the first device and target to corrupt
--- tests/btrfs/261 | 90 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/261.out | 2 + 2 files changed, 92 insertions(+) create mode 100755 tests/btrfs/261 create mode 100644 tests/btrfs/261.out
tests/btrfs/261 new file +90 -0
@@ -0,0 +1,90 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2022 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 261 +# +# Make sure btrfs raid profiles can handling one corrupted device +# without affecting the consistency of the fs. +# +. ./common/preamble +_begin_fstest auto volume raid + +. ./common/filter +. ./common/populate + +_supported_fs btrfs +_require_scratch_dev_pool 4 +_btrfs_get_profile_configs replace-missing +_require_fssum + +prepare_fs() +{ + local mkfs_opts=$1 + + # We don't want too large fs which can take too long to populate + # And the extra redirection of stderr is to avoid the RAID56 warning + # message to polluate the golden output + _scratch_pool_mkfs $mkfs_opts -b 1G >> $seqres.full 2>&1 + if [ $? -ne 0 ]; then + _fail "mkfs $mkfs_opts failed" + fi + + # Disable compression, as compressed read repair is known to have problems + _scratch_mount -o compress=no + + # Fill some part of the fs first + $XFS_IO_PROG -f -c "pwrite -S 0xfe 0 400M" $SCRATCH_MNT/garbage > /dev/null 2>&1 + + # Then use fsstress to generate some extra contents. + # Disable setattr related operations, as it may set NODATACOW which will + # not allow us to use btrfs checksum to verify the content. + $FSSTRESS_PROG -f setattr=0 -d $SCRATCH_MNT -w -n 3000 > /dev/null 2>&1 + sync + + # Save the fssum of this fs + $FSSUM_PROG -A -f -w $tmp.saved_fssum $SCRATCH_MNT + _scratch_unmount +} + +workload() +{ + local mkfs_opts=$1 + local num_devs=$2 + + _scratch_dev_pool_get 4 + echo "=== Testing profile $mkfs_opts ===" >> $seqres.full + rm -f -- $tmp.saved_fssum + prepare_fs "$mkfs_opts" + + # $SCRATCH_DEV is always the first device of dev pool. + # Corrupt the disk but keep the primary superblock. + $XFS_IO_PROG -c "pwrite 1M 1023M" $SCRATCH_DEV > /dev/null 2>&1 + + _scratch_mount + + # All content should be fine + $FSSUM_PROG -r $tmp.saved_fssum $SCRATCH_MNT > /dev/null + + # Scrub to fix the fs, this is known to report various correctable + # errors + $BTRFS_UTIL_PROG scrub start -B $SCRATCH_MNT >> $seqres.full 2>&1 + + # Make sure above scrub fixed the fs + $BTRFS_UTIL_PROG scrub start -Br $SCRATCH_MNT >> $seqres.full + if [ $? -ne 0 ]; then + echo "scrub failed to fix the fs for profile $mkfs_opts" + fi + _scratch_unmount + _scratch_dev_pool_put +} + +for t in "${_btrfs_profile_configs[@]}"; do + workload "$t" +done + +echo "Silence is golden" + +# success, all done +status=0 +exit
tests/btrfs/261.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 261 +Silence is golden
Signature · 1 line
2.36.1
Quoted 54 lines · Qu Wenruo
The new test case will verify that btrfs can handle one corrupted device without affecting the consistency of the filesystem.
Unlike a missing device, one corrupted device can return garbage to the fs, thus btrfs has to utilize its data/metadata checksum to verify which data is correct.
The test case will:
- Create a small fs
Mostly to speedup the test- Fill the fs with a regular file
- Use fsstress to create some contents
- Save the fssum for later verification
- Corrupt one device with garbage but keep the primary superblock untouched
- Run fssum verification
- Run scrub to fix the fs
- Run scrub again to make sure the fs is fine
Signed-off-by Qu Wenruo <[email protected]>Reviewed-by Boris Burkov <[email protected]>---
Changelog:
v2:
- Use_btrfs_get_profile_configs()helper to grab the mkfs options
- Use fixed number of devices 4 to co-operate with above change
- Remove a not-so-helpful debug output into $seqres.full
- Add to group auto and volume
- Use $SCRATCH_DEV as the first device and target to corrupt--- tests/btrfs/261 | 90 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/261.out | 2 + 2 files changed, 92 insertions(+) create mode 100755 tests/btrfs/261 create mode 100644 tests/btrfs/261.outtests/btrfs/261 new file +4
-0@@ -0,0 +1,90 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2022 SUSE Linux Products GmbH. All Rights Reserved. +#
tests/btrfs/261 line 14
Quoted 10 lines
tests/btrfs/261 new file +10
-0+# FS QA Test 261 +# +# Make sure btrfs raid profiles can handling one corrupted device +# without affecting the consistency of the fs. +# +. ./common/preamble +_begin_fstest auto volume raid + +. ./common/filter +. ./common/populate
By checking the code, I can't find anything depends on these two common files. So I think it's fine to remove these two include files (correct me if I'm wrong)
Others looks good to me, as you've gotten a review from btrfs list, I'll merge this patch if no more objection.
Thanks,
Zorro
Quoted 87 lines
tests/btrfs/261 new file +76
-0+ +_supported_fs btrfs +_require_scratch_dev_pool 4 +_btrfs_get_profile_configs replace-missing +_require_fssum + +prepare_fs() +{ + local mkfs_opts=$1 + + # We don't want too large fs which can take too long to populate + # And the extra redirection of stderr is to avoid the RAID56 warning + # message to polluate the golden output + _scratch_pool_mkfs $mkfs_opts -b 1G >> $seqres.full 2>&1 + if [ $? -ne 0 ]; then + _fail "mkfs $mkfs_opts failed" + fi + + # Disable compression, as compressed read repair is known to have problems + _scratch_mount -o compress=no + + # Fill some part of the fs first + $XFS_IO_PROG -f -c "pwrite -S 0xfe 0 400M" $SCRATCH_MNT/garbage > /dev/null 2>&1 + + # Then use fsstress to generate some extra contents. + # Disable setattr related operations, as it may set NODATACOW which will + # not allow us to use btrfs checksum to verify the content. + $FSSTRESS_PROG -f setattr=0 -d $SCRATCH_MNT -w -n 3000 > /dev/null 2>&1 + sync + + # Save the fssum of this fs + $FSSUM_PROG -A -f -w $tmp.saved_fssum $SCRATCH_MNT + _scratch_unmount +} + +workload() +{ + local mkfs_opts=$1 + local num_devs=$2 + + _scratch_dev_pool_get 4 + echo "=== Testing profile $mkfs_opts ===" >> $seqres.full + rm -f -- $tmp.saved_fssum + prepare_fs "$mkfs_opts" + + # $SCRATCH_DEV is always the first device of dev pool. + # Corrupt the disk but keep the primary superblock. + $XFS_IO_PROG -c "pwrite 1M 1023M" $SCRATCH_DEV > /dev/null 2>&1 + + _scratch_mount + + # All content should be fine + $FSSUM_PROG -r $tmp.saved_fssum $SCRATCH_MNT > /dev/null + + # Scrub to fix the fs, this is known to report various correctable + # errors + $BTRFS_UTIL_PROG scrub start -B $SCRATCH_MNT >> $seqres.full 2>&1 + + # Make sure above scrub fixed the fs + $BTRFS_UTIL_PROG scrub start -Br $SCRATCH_MNT >> $seqres.full + if [ $? -ne 0 ]; then + echo "scrub failed to fix the fs for profile $mkfs_opts" + fi + _scratch_unmount + _scratch_dev_pool_put +} + +for t in "${_btrfs_profile_configs[@]}"; do + workload "$t" +done + +echo "Silence is golden" + +# success, all done +status=0 +exittests/btrfs/261.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 261 +Silence is goldenSignature · 1 line
2.36.1