Skip to contentSkip to conversation

arm: mvebu: turris_omnia: Fix mpp26 pin name and comment

PATCH In review Marek Behún 2 participants 3 messages Jul 27, 2022 – Jul 29, 2022 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: turris_omnia: Fix mpp26 pin name and comment

There is a bug in Turris Omnia's schematics, whereupon the MPP[26] pin, which is routed to CN11 pin header, is documented as SPI CS1, but MPP[26] pin does not support this function. Instead it controls chip select 2 if in "spi0" mode.

Fix the name of the pin node in pinctrl node and fix the comment in SPI node.

---
The same patch is being sent to linux,
https://lore.kernel.org/linux-arm-kernel/[email protected]/

---
 arch/arm/dts/armada-385-turris-omnia.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/armada-385-turris-omnia.dts +2 -2
index 7f1478edfd..617522be17 100644
@@ -345,7 +345,7 @@
 		marvell,function = "spi0";
 	};
 
-	spi0cs1_pins: spi0cs1-pins {
+	spi0cs2_pins: spi0cs2-pins {
 		marvell,pins = "mpp26";
 		marvell,function = "spi0";
 	};
@@ -380,7 +380,7 @@
 		};
 	};
 
-	/* MISO, MOSI, SCLK and CS1 are routed to pin header CN11 */
+	/* MISO, MOSI, SCLK and CS2 are routed to pin header CN11 */
 };
 
 &uart0 {
Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Marek Behún

There is a bug in Turris Omnia's schematics, whereupon the MPP[26] pin, which is routed to CN11 pin header, is documented as SPI CS1, but MPP[26] pin does not support this function. Instead it controls chip select 2 if in "spi0" mode.

Fix the name of the pin node in pinctrl node and fix the comment in SPI node.

Thanks,
Stefan

Quoted 21 lines

---
The same patch is being sent to linux,
https://lore.kernel.org/linux-arm-kernel/[email protected]/

---
  arch/arm/dts/armada-385-turris-omnia.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/armada-385-turris-omnia.dts +1 -1
index 7f1478edfd..617522be17 100644
@@ -345,7 +345,7 @@
  		marvell,function = "spi0";
  	};
 
-	spi0cs1_pins: spi0cs1-pins {
+	spi0cs2_pins: spi0cs2-pins {
  		marvell,pins = "mpp26";
  		marvell,function = "spi0";
  	};

arch/arm/dts/armada-385-turris-omnia.dts line 386

Quoted 8 lines
arch/arm/dts/armada-385-turris-omnia.dts +1 -1
@@ -380,7 +380,7 @@
  		};
  	};
 
-	/* MISO, MOSI, SCLK and CS1 are routed to pin header CN11 */
+	/* MISO, MOSI, SCLK and CS2 are routed to pin header CN11 */
  };
 
  &uart0 {

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Marek Behún
Quoted 9 lines · Marek Behún

There is a bug in Turris Omnia's schematics, whereupon the MPP[26] pin, which is routed to CN11 pin header, is documented as SPI CS1, but MPP[26] pin does not support this function. Instead it controls chip select 2 if in "spi0" mode.

Fix the name of the pin node in pinctrl node and fix the comment in SPI node.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 21 lines

---
The same patch is being sent to linux,
https://lore.kernel.org/linux-arm-kernel/[email protected]/

---
  arch/arm/dts/armada-385-turris-omnia.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/armada-385-turris-omnia.dts +1 -1
index 7f1478edfd..617522be17 100644
@@ -345,7 +345,7 @@
  		marvell,function = "spi0";
  	};
 
-	spi0cs1_pins: spi0cs1-pins {
+	spi0cs2_pins: spi0cs2-pins {
  		marvell,pins = "mpp26";
  		marvell,function = "spi0";
  	};

arch/arm/dts/armada-385-turris-omnia.dts line 386

Quoted 8 lines
arch/arm/dts/armada-385-turris-omnia.dts +1 -1
@@ -380,7 +380,7 @@
  		};
  	};
 
-	/* MISO, MOSI, SCLK and CS1 are routed to pin header CN11 */
+	/* MISO, MOSI, SCLK and CS2 are routed to pin header CN11 */
  };
 
  &uart0 {

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]