mmc: sdhci-pci-o2micro: fix some SD cards compatibility issue at DDR50 mode
PATCH v2 1/1 mmc: sdhci-pci-o2micro: fix some SD cards compatibility issue at DDR50 mode
Bayhub chips have better compatibility support for SDR50 than DDR50 and both mode have the same R/W performance when clock frequency >= 100MHz. Disable DDR50 mode and use SDR50 instead.
---
Changes on V1:
1.Set quirks2 flag SDHCI_QUIRK2_BROKEN_DDR50 for bayhub chips.
2.Use bayhub hardware input tuning for SDR50 mode instead of standard tuning flow.
Changes on V2:
Update commit format and information.
--- drivers/mmc/host/sdhci-pci-o2micro.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-pci-o2micro.c +5 -2
@@ -317,11 +317,12 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)u32 reg_val;/* -* This handler only implements the eMMC tuning that is specific to +* This handler implements the hardware tuning that is specific to * this controller. Fall back to the standard method for other TIMING. */ if ((host->timing !=MMC_TIMING_MMC_HS200 ) && - (host->timing !=MMC_TIMING_UHS_SDR104 )) + (host->timing !=MMC_TIMING_UHS_SDR104 ) && + (host->timing !=MMC_TIMING_UHS_SDR50 ))return sdhci_execute_tuning (mmc, opcode); if (WARN_ON((opcode != MMC_SEND_TUNING_BLOCK_HS200) &&
@@ -631,6 +632,8 @@ static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)if (reg &0x1 ) host->quirks |=SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 ; + host->quirks2 |=SDHCI_QUIRK2_BROKEN_DDR50 ; +sdhci_pci_o2_enable_msi (chip, host);if (chip->pdev->device ==PCI_DEVICE_ID_O2_SEABIRD0 ) {
base-commit: 68e77ffbfd06ae3ef8f2abf1c3b971383c866983
Signature · 1 line
2.32.0
Quoted 5 lines · Chevron Li
Bayhub chips have better compatibility support for SDR50 than DDR50 and both mode have the same R/W performance when clock frequency >= 100MHz. Disable DDR50 mode and use SDR50 instead.
Signed-off-by Chevron Li <[email protected]>
Quoted 41 lines
---
Changes on V1:
1.Set quirks2 flagSDHCI_QUIRK2_BROKEN_DDR50for bayhub chips.
2.Use bayhub hardware input tuning for SDR50 mode instead of standard tuning flow.Changes on V2:
Update commit format and information.--- drivers/mmc/host/sdhci-pci-o2micro.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-o2micro.c +5
-2@@ -317,11 +317,12 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)u32 reg_val;/* -* This handler only implements the eMMC tuning that is specific to +* This handler implements the hardware tuning that is specific to * this controller. Fall back to the standard method for other TIMING. */ if ((host->timing !=MMC_TIMING_MMC_HS200 ) && - (host->timing !=MMC_TIMING_UHS_SDR104 )) + (host->timing !=MMC_TIMING_UHS_SDR104 ) && + (host->timing !=MMC_TIMING_UHS_SDR50 ))return sdhci_execute_tuning (mmc, opcode); if (WARN_ON((opcode != MMC_SEND_TUNING_BLOCK_HS200) &&@@ -631,6 +632,8 @@ static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)if (reg &0x1 ) host->quirks |=SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 ; + host->quirks2 |=SDHCI_QUIRK2_BROKEN_DDR50 ; +sdhci_pci_o2_enable_msi (chip, host);if (chip->pdev->device ==PCI_DEVICE_ID_O2_SEABIRD0 ) {base-commit:
68e77ffbfd06ae3ef8f2abf1c3b971383c866983
Quoted 6 lines · Chevron Li
Bayhub chips have better compatibility support for SDR50 than DDR50 and both mode have the same R/W performance when clock frequency >= 100MHz. Disable DDR50 mode and use SDR50 instead.
Signed-off-by Chevron Li <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 44 lines
---
Changes on V1:
1.Set quirks2 flagSDHCI_QUIRK2_BROKEN_DDR50for bayhub chips.
2.Use bayhub hardware input tuning for SDR50 mode instead of standard tuning flow.Changes on V2:
Update commit format and information.--- drivers/mmc/host/sdhci-pci-o2micro.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-o2micro.c +5
-2@@ -317,11 +317,12 @@ static int sdhci_o2_execute_tuning(struct mmc_host *mmc, u32 opcode)u32 reg_val;/* -* This handler only implements the eMMC tuning that is specific to +* This handler implements the hardware tuning that is specific to * this controller. Fall back to the standard method for other TIMING. */ if ((host->timing !=MMC_TIMING_MMC_HS200 ) && - (host->timing !=MMC_TIMING_UHS_SDR104 )) + (host->timing !=MMC_TIMING_UHS_SDR104 ) && + (host->timing !=MMC_TIMING_UHS_SDR50 ))return sdhci_execute_tuning (mmc, opcode); if (WARN_ON((opcode != MMC_SEND_TUNING_BLOCK_HS200) &&@@ -631,6 +632,8 @@ static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)if (reg &0x1 ) host->quirks |=SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 ; + host->quirks2 |=SDHCI_QUIRK2_BROKEN_DDR50 ; +sdhci_pci_o2_enable_msi (chip, host);if (chip->pdev->device ==PCI_DEVICE_ID_O2_SEABIRD0 ) {base-commit:
68e77ffbfd06ae3ef8f2abf1c3b971383c866983--
2.32.0