Skip to contentSkip to conversation

getrlimit.2: tfix

PATCH In review Štěpán Němec 2 participants 3 messages Jul 29, 2022 – Aug 1, 2022 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 getrlimit.2: tfix

---
 man2/getrlimit.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man2/getrlimit.2 +2 -2
index 6cda4d48a982..bd330289a8fc 100644
@@ -452,14 +452,14 @@ and
 .PP
 If the
 .I new_limit
-argument is a not NULL, then the
+argument is not NULL, then the
 .I rlimit
 structure to which it points is used to set new values for
 the soft and hard limits for
 .IR resource .
 If the
 .I old_limit
-argument is a not NULL, then a successful call to
+argument is not NULL, then a successful call to
 .BR prlimit ()
 places the previous soft and hard limits for
 .I resource

base-commit: 5fa2ecb53656c9fdcbd5a21972906e3da33cb504

Signature · 1 line
2.37.1
#1 lore raw

Hi Štěpán,

Quoted 1 line · Štěpán Němec

I applied the 6 patches from the patch set, including the controversial \~ vs '\ ' one. I think that fix is better as a separate one, which should include references to the SI that I quoted.

I'll try to apply a global fix about spacing. Anyway, could you please share the grep commands you used to find it? It might help me see you command, in case I miss some corner cases.

Cheers,

Alex

Quoted 27 lines
---
  man2/getrlimit.2 | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
man2/getrlimit.2 +2 -2
index 6cda4d48a982..bd330289a8fc 100644
@@ -452,14 +452,14 @@ and
  .PP
  If the
  .I new_limit
-argument is a not NULL, then the
+argument is not NULL, then the
  .I rlimit
  structure to which it points is used to set new values for
  the soft and hard limits for
  .IR resource .
  If the
  .I old_limit
-argument is a not NULL, then a successful call to
+argument is not NULL, then a successful call to
  .BR prlimit ()
  places the previous soft and hard limits for
  .I resource

base-commit: 5fa2ecb53656c9fdcbd5a21972906e3da33cb504

Signature · 2 lines
Alejandro Colomar
<http://www.alejandro-colomar.es/>
#2 lore raw
Quoted 6 lines · On Mon, 01 Aug 2022 15:03:29 +0200 Alejandro Colomar wrote:
Quoted 1 line · Štěpán Němec

I applied the 6 patches from the patch set, including the controversial \~ vs '\ ' one. I think that fix is better as a separate one, which should include references to the SI that I quoted.

Thank you. For convenience, here is the one '\~' outlier (I was sitting on that one in case Branden or anyone else would still want to chime in:
the conflict with groff_man(7) does seem unfortunate), feel free to do with it as you please:

-- >8 --
From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20N=C4=9Bmec?= <[email protected]>
Date: Sat, 30 Jul 2022 20:42:03 +0200
Subject: [PATCH] ioctl_fideduperange.2: use '\ ' instead of '\~' between
number and unit

---
 man2/ioctl_fideduperange.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man2/ioctl_fideduperange.2 +1 -1
index 8bf114e8bb3b..585ed8beb9d7 100644
@@ -100,7 +100,7 @@ and the struct
 array must not exceed the system page size.
 The maximum size of
 .I src_length
-is filesystem dependent and is typically 16\~MiB.
+is filesystem dependent and is typically 16\ MiB.
 This limit will be enforced silently by the filesystem.
 By convention, the storage used by
 .I src_fd

-- 8< --

Quoted 3 lines

I'll try to apply a global fix about spacing. Anyway, could you please share the grep commands you used to find it? It might help me see you command, in case I miss some corner cases.

Oh, nothing fancy at all, just grepping for '\ ' or '\~', e.g.

grep -R '\\~' man*

Signature · 1 line
Štěpán