Skip to contentSkip to conversation

selftests-vm-silence-uninitialized-variable-warning.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jul 30, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: tools/testing/selftests/vm/hugetlb-madvise.c: silence uninitialized variable warning
has been removed from the -mm tree. Its filename was
selftests-vm-silence-uninitialized-variable-warning.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Dan Carpenter <[email protected]>
Subject: tools/testing/selftests/vm/hugetlb-madvise.c: silence uninitialized variable warning
Date: Tue, 19 Jul 2022 12:42:48 +0300

This code just reads from memory without caring about the data itself. However static checkers complain that "tmp" is never properly initialized. Initialize it to zero and change the name to "dummy" to show that we don't care about the value stored in it.

Fixes c4b6cb884011 ("selftests/vm: add hugetlb madvise MADV_DONTNEED MADV_REMOVE test")
Cc Shuah Khan <[email protected]>

---

 tools/testing/selftests/vm/hugetlb-madvise.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tools/testing/selftests/vm/hugetlb-madvise.c renamed from tools/testing/selftests/vm/hugetlb-madvise.c~selftests-vm-silence-uninitialized-variable-warning +3 -2
@@ -89,10 +89,11 @@ void write_fault_pages(void *addr, unsig
 
 void read_fault_pages(void *addr, unsigned long nr_pages)
 {
-	unsigned long i, tmp;
+	unsigned long dummy = 0;
+	unsigned long i;
 
 	for (i = 0; i < nr_pages; i++)
-		tmp += *((unsigned long *)(addr + (i * huge_page_size)));
+		dummy += *((unsigned long *)(addr + (i * huge_page_size)));
 }
 
 int main(int argc, char **argv)

_

Patches currently in -mm which might be from [email protected] are