RDMA/mlx5: unchecked return value
Subsystems (2)
PATCH 1/1 RDMA/mlx5: unchecked return value
Unchecked return value warning as reported by Coverity static analyzer tool. check the return value of mlx5_ib_ft_type_to_namespace().
Signed-off-by Sebin Sebastian <[email protected]>
--- drivers/infiniband/hw/mlx5/fs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/fs.c +4 -1
@@ -2079,9 +2079,12 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs,return err;if (flags) { -mlx5_ib_ft_type_to_namespace ( + err =mlx5_ib_ft_type_to_namespace (MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX , &obj->ns_type); +if (err) +return err; +return 0 ; } }
Signature · 1 line
2.34.1
Quoted 7 lines · Sebin Sebastian
Unchecked return value warning as reported by Coverity static analyzer tool. check the return value of
mlx5_ib_ft_type_to_namespace().Signed-off-by Sebin Sebastian <[email protected]>--- drivers/infiniband/hw/mlx5/fs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks, I had similar patch in my internal queue.
https://lore.kernel.org/linux-rdma/7b9ceda217d9368a51dc47a46b769bad4af9ac92.1659256069.git.leonro@nvidia.com/T/#u
Quoted 22 lines
drivers/infiniband/hw/mlx5/fs.c +4
-1@@ -2079,9 +2079,12 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs,return err;if (flags) { -mlx5_ib_ft_type_to_namespace ( + err =mlx5_ib_ft_type_to_namespace (MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX , &obj->ns_type); +if (err) +return err; +return 0 ; } }Signature · 1 line
2.34.1
Jason Gunthorpe
maintainerQuoted 7 lines · Sebin Sebastian
Unchecked return value warning as reported by Coverity static analyzer tool. check the return value of
mlx5_ib_ft_type_to_namespace().Signed-off-by Sebin Sebastian <[email protected]>--- drivers/infiniband/hw/mlx5/fs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Leon's is cleaner and has a proper fixes line, so I will use his
Thanks,
Jason