Skip to contentSkip to conversation

media: atomisp_gmin_platform: Switch to use acpi_evaluate_dsm_typed()

PATCH In review Andy Shevchenko 2 participants 2 messages Jul 30, 2022 – Aug 1, 2022

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH v2 1/1 media: atomisp_gmin_platform: Switch to use acpi_evaluate_dsm_typed()

The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by Andy Shevchenko <[email protected]>

---
v2: fixed 80 character overgo (Sakari)

 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +3 -5
index bf527b366ab3..f7fc5137199c 100644
@@ -1207,16 +1207,14 @@ static int gmin_get_config_dsm_var(struct device *dev,
 	if (!strcmp(var, "CamClk"))
 		return -EINVAL;
 
-	obj = acpi_evaluate_dsm(handle, &atomisp_dsm_guid, 0, 0, NULL);
+	/* Return on unexpected object type */
+	obj = acpi_evaluate_dsm_typed(handle, &atomisp_dsm_guid, 0, 0, NULL,
+				      ACPI_TYPE_PACKAGE);
 	if (!obj) {
 		dev_info_once(dev, "Didn't find ACPI _DSM table.\n");
 		return -EINVAL;
 	}
 
-	/* Return on unexpected object type */
-	if (obj->type != ACPI_TYPE_PACKAGE)
-		return -EINVAL;
-
 #if 0 /* Just for debugging purposes */
 	for (i = 0; i < obj->package.count; i++) {
 		union acpi_object *cur = &obj->package.elements[i];
Signature · 1 line
2.35.1