Skip to contentSkip to conversation

iio: Add names for function definition arguments.

PATCH In review Joe Simmons-Talbott 2 participants 2 messages Jul 31, 2022 – Aug 6, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: Add names for function definition arguments.

As reported by checkpatch.pl add missing names for function definition arguments.

---
 drivers/iio/industrialio-event.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/iio/industrialio-event.c +4 -3
index b5e059e15b0a..0e2056894965 100644
@@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
 	enum iio_shared_by shared_by, const unsigned long *mask)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	ssize_t (*show)(struct device *, struct device_attribute *, char *);
-	ssize_t (*store)(struct device *, struct device_attribute *,
-		const char *, size_t);
+	ssize_t (*show)(struct device *dev, struct device_attribute *attr,
+		char *buf);
+	ssize_t (*store)(struct device *dev, struct device_attribute *attr,
+		const char *buf, size_t len);
 	unsigned int attrcount = 0;
 	unsigned int i;
 	char *postfix;
Signature · 1 line
2.37.1
maintainer
#1 lore raw
Quoted 4 lines · On Sun, 31 Jul 2022 12:01:20 -0400 Joe Simmons-Talbott <[email protected]>…

As reported by checkpatch.pl add missing names for function definition arguments.

Hi Joe,

I took this last week. Not sure why email didn't hit the list.

Thanks,

Jonathan

Quoted 22 lines
---
 drivers/iio/industrialio-event.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/iio/industrialio-event.c +4 -3
index b5e059e15b0a..0e2056894965 100644
@@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
 	enum iio_shared_by shared_by, const unsigned long *mask)
 {
 	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
-	ssize_t (*show)(struct device *, struct device_attribute *, char *);
-	ssize_t (*store)(struct device *, struct device_attribute *,
-		const char *, size_t);
+	ssize_t (*show)(struct device *dev, struct device_attribute *attr,
+		char *buf);
+	ssize_t (*store)(struct device *dev, struct device_attribute *attr,
+		const char *buf, size_t len);
 	unsigned int attrcount = 0;
 	unsigned int i;
 	char *postfix;