Skip to contentSkip to conversation

scsi: smartpqi: Overwriting previous value

PATCH New Sebin Sebastian 1 participant 1 message Aug 1, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: smartpqi: Overwriting previous value

Fixes coverity warning 'Unused value'. Assigning value 256 in shost->max_lun but that stored value is overwritten before it can be used.

Fixes 904f2bfda65e0 (Add driver support for multi-LUN devices)
---
 drivers/scsi/smartpqi/smartpqi_init.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/smartpqi/smartpqi_init.c +0 -1
index 7a8c2c75acba..5a9fd52c6e7c 100644
@@ -7405,7 +7405,6 @@ static int pqi_register_scsi(struct pqi_ctrl_info *ctrl_info)
 	shost->max_channel = PQI_MAX_BUS;
 	shost->max_cmd_len = MAX_COMMAND_SIZE;
 	shost->max_lun = PQI_MAX_LUNS_PER_DEVICE;
-	shost->max_lun = ~0;
 	shost->max_id = ~0;
 	shost->max_sectors = ctrl_info->max_sectors;
 	shost->can_queue = ctrl_info->scsi_ml_can_queue;
Signature · 1 line
2.34.1