Skip to contentSkip to conversation

wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

PATCH In review Kalle Valo 2 participants 3 messages Aug 1, 2022 – Aug 8, 2022 Microchip WILC1000 wifi driver

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH 1/1 wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

Sparse warns:

drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition

Remove the inline, it's not needed.

---
 drivers/net/wireless/microchip/wilc1000/hif.c | 2 +-
 drivers/net/wireless/microchip/wilc1000/hif.h | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/microchip/wilc1000/hif.c +1 -1
index b89519ab9205..eb1d1ba3a443 100644
@@ -635,7 +635,7 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
 	conn_info->req_ies_len = 0;
 }
 
-inline void wilc_handle_disconnect(struct wilc_vif *vif)
+void wilc_handle_disconnect(struct wilc_vif *vif)
 {
 	struct host_if_drv *hif_drv = vif->hif_drv;
 
drivers/net/wireless/microchip/wilc1000/hif.h +2 -1
index 69ba1d469e9f..baa2881f4465 100644
@@ -215,5 +215,6 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
 void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
 				struct cfg80211_crypto_settings *crypto);
 int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index);
-inline void wilc_handle_disconnect(struct wilc_vif *vif);
+void wilc_handle_disconnect(struct wilc_vif *vif);
+
 #endif

base-commit: 63757225a93353bc2ce4499af5501eabdbbf23f9

Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Kalle Valo

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Sparse warns:

drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition

Remove the inline, it's not needed.

Quoted 37 lines
---
  drivers/net/wireless/microchip/wilc1000/hif.c | 2 +-
  drivers/net/wireless/microchip/wilc1000/hif.h | 3 ++-
  2 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/microchip/wilc1000/hif.c +1 -1
index b89519ab9205..eb1d1ba3a443 100644
@@ -635,7 +635,7 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
         conn_info->req_ies_len = 0;
  }
 
-inline void wilc_handle_disconnect(struct wilc_vif *vif)
+void wilc_handle_disconnect(struct wilc_vif *vif)
  {
         struct host_if_drv *hif_drv = vif->hif_drv;
 
drivers/net/wireless/microchip/wilc1000/hif.h +2 -1
index 69ba1d469e9f..baa2881f4465 100644
@@ -215,5 +215,6 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
  void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
                                 struct cfg80211_crypto_settings *crypto);
  int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index);
-inline void wilc_handle_disconnect(struct wilc_vif *vif);
+void wilc_handle_disconnect(struct wilc_vif *vif);
+
  #endif

base-commit: 63757225a93353bc2ce4499af5501eabdbbf23f9 --
2.30.2

author
#2 lore raw
In reply to Kalle Valo
Quoted 9 lines · Kalle Valo

Sparse warns:

drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition

Remove the inline, it's not needed.

Patch applied to wireless.git, thanks.

f01272ee3856 wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches