Skip to contentSkip to conversation

disable DCO if no --dev was specified

PATCH In review Antonio Quartulli 2 participants 2 messages Aug 1, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 disable DCO if no --dev was specified

The DCO logic is uanble to proceed without --dev argument, therefore just disable DCO if no --dev was specified by the user.

Right now, calling openvpn with DCO enabled (default) and no --dev specified leads to a crash, because --dev is assumed to always be there.

---
 src/openvpn/dco.c | 5 +++++
 1 file changed, 5 insertions(+)
src/openvpn/dco.c +5 -0
index b3fd135f..a3a081b2 100644
@@ -109,6 +109,11 @@ dco_check_option_conflict(int msglevel, const struct options *o)
         return false;
     }
 
+    if (!o->dev)
+    {
+        return false;
+    }
+
     if (!dco_check_option_conflict_platform(msglevel, o))
     {
         return false;
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw

The broken bit was added quite a few patches ago, but wasn't caught by my testing, because it needed --enable-dco *and* DCO-in-kernel - otherwise, the DCO paths would disable themselves, and not crash :-)

Tested on ubuntu 20 with DCO kernel support - without this,

  $ openvpn --test-crypto

segfaults - with the patch, it complains :-)

Your patch has been applied to the master branch.

commit b8b0a95efff0184cebacc43a6e751fa8f9092cd8

Author: Antonio Quartulli
Date:   Mon Aug 1 17:08:12 2022 +0200
     disable DCO if no --dev was specified

     Signed-off-by: Antonio Quartulli <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg24772.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering