Skip to contentSkip to conversation

Rust Oe-Selftest implementation

PATCH Superseded [email protected] 2 participants 5 messages Aug 2, 2022

v6 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 Rust Oe-Selftest implementation

From: pgowda <[email protected]>

The patch implements Rust testing framework similar to other selftest, specifically the gcc selftest in OE. It uses the client and server based method to test the binaries for cross-target on the image. The test framework is a wrapper around the Rust build system as ./x.py test.
It tests many functionalities of Rust distribution like tools, documentation, libraries, packages, tools, Cargo, Crater etc. Please refer the following link for detailed description of Rust testing:-
https://rustc-dev-guide.rust-lang.org/tests/intro.html#tool-tests

To support the rust tests in oe-core, the following functions were added:-
setup_cargo_environment(): Build bootstrap and some early stage tools. do_rust_setup_snapshot(): Install the snapshot version of rust binaries. do_configure(): To generate config.toml
do_compile(): To build "remote-test-server" for qemu target image.

Approximate Number of Tests Run in the Rust Testsuite :- 18000 Approximate Number of Tests that FAIL in bitbake environment :- 100-150 Normally majority of the testcases are present in major folder "test/" It contributes to more than 80% of the testcases present in Rust test framework. These tests pass as expected on any Rust versions without much fuss. The tests that fail are of less important and contribute to less than 2% of the total testcases. These minor tests are observed to work on some versions and fail on others. They have to be added, ignored or excluded for different versions as per the behavior. These tests have been ignored or excluded in the Rust selftest environment to generate success of completing the testsuite.

These tests work in parallel mode even in the skipped test mode as expected. Although the patch to disable tests is large, it is very simple in that it only disables tests. When updating to a newer version of Rust, the patch can usually be ported in a day.

---
 meta/classes/rust-target-config.bbclass       |   2 +-
 meta/lib/oeqa/selftest/cases/rust.py          |  57 +++
 meta/recipes-devtools/rust/rust-testsuite.inc | 164 ++++++
 .../rust-testsuite/rust-oe-selftest.patch     | 477 ++++++++++++++++++
 .../rust/rust-testsuite_1.62.0.bb             |   3 +
 5 files changed, 702 insertions(+), 1 deletion(-)
 create mode 100644 meta/lib/oeqa/selftest/cases/rust.py
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite.inc
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite_1.62.0.bb
meta/classes/rust-target-config.bbclass +1 -1
index 87b7dee3ed..26dc931971 100644
@@ -344,7 +344,7 @@ def rust_gen_target(d, thing, wd, arch):
     tspec['linker-is-gnu'] = True
     tspec['linker-flavor'] = "gcc"
     tspec['has-rpath'] = True
-    tspec['has-elf-tls'] = True
+#    tspec['has-elf-tls'] = True
     tspec['position-independent-executables'] = True
     tspec['panic-strategy'] = d.getVar("RUST_PANIC_STRATEGY")
 
meta/lib/oeqa/selftest/cases/rust.py new file +57 -0

57 lines not on this page · raw message

meta/recipes-devtools/rust/rust-testsuite.inc new file +164 -0

164 lines not on this page · raw message

meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch new file +477 -0

477 lines not on this page · raw message

meta/recipes-devtools/rust/rust-testsuite_1.62.0.bb new file +3 -0
new file mode 100644
index 0000000000..d334231c8f
@@ -0,0 +1,3 @@
+require rust-testsuite.inc
+require rust-source.inc
+require rust-snapshot.inc
Signature · 1 line
2.25.1
#1 lore raw
Quoted 56 lines · On Tue, 2 Aug 2022 09:23:52 +0530 "Pgowda" <[email protected]> wrote:

From: pgowda <[email protected]>

The patch implements Rust testing framework similar to other selftest, specifically the gcc selftest in OE. It uses the client and server based method to test the binaries for cross-target on the image. The test framework is a wrapper around the Rust build system as ./x.py test.
It tests many functionalities of Rust distribution like tools, documentation, libraries, packages, tools, Cargo, Crater etc. Please refer the following link for detailed description of Rust testing:-
https://rustc-dev-guide.rust-lang.org/tests/intro.html#tool-tests

To support the rust tests in oe-core, the following functions were added:-
setup_cargo_environment(): Build bootstrap and some early stage tools. do_rust_setup_snapshot(): Install the snapshot version of rust binaries. do_configure(): To generate config.toml
do_compile(): To build "remote-test-server" for qemu target image.

Approximate Number of Tests Run in the Rust Testsuite :- 18000 Approximate Number of Tests that FAIL in bitbake environment :- 100-150 Normally majority of the testcases are present in major folder "test/" It contributes to more than 80% of the testcases present in Rust test framework. These tests pass as expected on any Rust versions without much fuss. The tests that fail are of less important and contribute to less than 2% of the total testcases. These minor tests are observed to work on some versions and fail on others. They have to be added, ignored or excluded for different versions as per the behavior. These tests have been ignored or excluded in the Rust selftest environment to generate success of completing the testsuite.

These tests work in parallel mode even in the skipped test mode as expected. Although the patch to disable tests is large, it is very simple in that it only disables tests. When updating to a newer version of Rust, the patch can usually be ported in a day.

---
 meta/classes/rust-target-config.bbclass       |   2 +-
 meta/lib/oeqa/selftest/cases/rust.py          |  57 +++
 meta/recipes-devtools/rust/rust-testsuite.inc | 164 ++++++
 .../rust-testsuite/rust-oe-selftest.patch     | 477 ++++++++++++++++++
 .../rust/rust-testsuite_1.62.0.bb             |   3 +
 5 files changed, 702 insertions(+), 1 deletion(-)
 create mode 100644 meta/lib/oeqa/selftest/cases/rust.py
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite.inc
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite_1.62.0.bb
meta/classes/rust-target-config.bbclass +0 -0
index 87b7dee3ed..26dc931971 100644

meta/classes/rust-target-config.bbclass def rust_gen_target(d, thing, wd, arch): · line 347

Quoted 5 lines
meta/classes/rust-target-config.bbclass +1 -1
@@ -344,7 +344,7 @@ def rust_gen_target(d, thing, wd, arch):
     tspec['linker-is-gnu'] = True
     tspec['linker-flavor'] = "gcc"
     tspec['has-rpath'] = True
-    tspec['has-elf-tls'] = True
+#    tspec['has-elf-tls'] = True

I'm not sure of the meaning of the above change, can you clarify that?

Thanks.

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

Hi Luca,

There were around 270 testcase failing when "has-elf-tls" has been enabled while building llvm.
Hence, we had to remove the option to enable the proper working of these tests. The patch has been tested on Ubuntu and also fedora (using docker image).

Thanks,
Pgowda

Quoted 73 lines · Luca Ceresoli
Quoted 56 lines · On Tue, 2 Aug 2022 09:23:52 +0530 "Pgowda" <[email protected]> wrote:

From: pgowda <[email protected]>

The patch implements Rust testing framework similar to other selftest, specifically the gcc selftest in OE. It uses the client and server based method to test the binaries for cross-target on the image. The test framework is a wrapper around the Rust build system as ./x.py test.
It tests many functionalities of Rust distribution like tools, documentation, libraries, packages, tools, Cargo, Crater etc. Please refer the following link for detailed description of Rust testing:-
https://rustc-dev-guide.rust-lang.org/tests/intro.html#tool-tests

To support the rust tests in oe-core, the following functions were added:-
setup_cargo_environment(): Build bootstrap and some early stage tools. do_rust_setup_snapshot(): Install the snapshot version of rust binaries. do_configure(): To generate config.toml
do_compile(): To build "remote-test-server" for qemu target image.

Approximate Number of Tests Run in the Rust Testsuite :- 18000 Approximate Number of Tests that FAIL in bitbake environment :- 100-150 Normally majority of the testcases are present in major folder "test/" It contributes to more than 80% of the testcases present in Rust test framework. These tests pass as expected on any Rust versions without much fuss. The tests that fail are of less important and contribute to less than 2% of the total testcases. These minor tests are observed to work on some versions and fail on others. They have to be added, ignored or excluded for different versions as per the behavior. These tests have been ignored or excluded in the Rust selftest environment to generate success of completing the testsuite.

These tests work in parallel mode even in the skipped test mode as expected. Although the patch to disable tests is large, it is very simple in that it only disables tests. When updating to a newer version of Rust, the patch can usually be ported in a day.

---
 meta/classes/rust-target-config.bbclass       |   2 +-
 meta/lib/oeqa/selftest/cases/rust.py          |  57 +++
 meta/recipes-devtools/rust/rust-testsuite.inc | 164 ++++++
 .../rust-testsuite/rust-oe-selftest.patch     | 477 ++++++++++++++++++
 .../rust/rust-testsuite_1.62.0.bb             |   3 +
 5 files changed, 702 insertions(+), 1 deletion(-)
 create mode 100644 meta/lib/oeqa/selftest/cases/rust.py
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite.inc
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite/rust-oe-selftest.patch
 create mode 100644 meta/recipes-devtools/rust/rust-testsuite_1.62.0.bb
meta/classes/rust-target-config.bbclass +0 -0
index 87b7dee3ed..26dc931971 100644

meta/classes/rust-target-config.bbclass def rust_gen_target(d, thing, wd, arch): · line 347

Quoted 5 lines
meta/classes/rust-target-config.bbclass +1 -1
@@ -344,7 +344,7 @@ def rust_gen_target(d, thing, wd, arch):
     tspec['linker-is-gnu'] = True
     tspec['linker-flavor'] = "gcc"
     tspec['has-rpath'] = True
-    tspec['has-elf-tls'] = True
+#    tspec['has-elf-tls'] = True

I'm not sure of the meaning of the above change, can you clarify that?

Thanks.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

Hi Pgowda,

Quoted 6 lines · On Tue, 2 Aug 2022 14:37:54 +0530 "Pgowda" <[email protected]> wrote:

Hi Luca,

There were around 270 testcase failing when "has-elf-tls" has been enabled while building llvm.
Hence, we had to remove the option to enable the proper working of these tests. The patch has been tested on Ubuntu and also fedora (using docker image).

Thanks for the explanation. Then why not adding an explanatory comment, as below?

# Disabled because.....
# tspec['has-elf-tls'] = True

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

Hi Luca,

Thanks very much for checking the patch and comment about the elf-tls.

An explanatory comment has been added as per your suggestion and patch posted as:-
https://lists.openembedded.org/g/openembedded-core/message/168778

Thanks,
Pgowda

Quoted 23 lines · Luca Ceresoli

Hi Pgowda,

Quoted 6 lines · On Tue, 2 Aug 2022 14:37:54 +0530 "Pgowda" <[email protected]> wrote:

Hi Luca,

There were around 270 testcase failing when "has-elf-tls" has been enabled while building llvm.
Hence, we had to remove the option to enable the proper working of these tests. The patch has been tested on Ubuntu and also fedora (using docker image).

Thanks for the explanation. Then why not adding an explanatory comment, as below?

# Disabled because.....
# tspec['has-elf-tls'] = True

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com