Skip to contentSkip to conversation

edid-decode: downgrade missing display product name to warning

PATCH Superseded Simon Ser 2 participants 2 messages Aug 2, 2022 Media (V4L/DVB)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Simon Ser

author
#0 lore raw

PATCH 1/1 edid-decode: downgrade missing display product name to warning

The spec says:

Quoted 3 lines

The model name of the display product may be listed (optional but recommended) in the Display Product Name (ASCII) String Descriptor (tag #FCh).

So a missing Display Product Name descriptor shouldn't fail conformance.

---
 parse-base-block.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
parse-base-block.cpp +1 -1
index 9644577bab70..525cd4c02257 100644
@@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x)
 	do_checksum("", x, EDID_PAGE_SIZE);
 	if (base.edid_minor >= 3) {
 		if (!base.has_name_descriptor)
-			fail("Missing Display Product Name.\n");
+			warn("Missing Display Product Name.\n");
 		if ((base.edid_minor == 3 || base.supports_continuous_freq) &&
 		    !base.has_display_range_descriptor)
 			fail("Missing Display Range Limits Descriptor.\n");

base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac

Signature · 1 line
2.37.1
#1 lore raw
Quoted 8 lines · Simon Ser

The spec says:

Quoted 3 lines

The model name of the display product may be listed (optional but recommended) in the Display Product Name (ASCII) String Descriptor (tag #FCh).

So a missing Display Product Name descriptor shouldn't fail conformance.

Actually it is mandatory in EDID v1.3, but optional for EDID v1.4.

So this should be a fail if edid_minor == 3, and a warn otherwise.

Can you post a v2 of this patch? You can use the msg() function directly instead of fail/warn.

Regards,

Hans

Quoted 21 lines
---
 parse-base-block.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
parse-base-block.cpp +1 -1
index 9644577bab70..525cd4c02257 100644
@@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x)
 	do_checksum("", x, EDID_PAGE_SIZE);
 	if (base.edid_minor >= 3) {
 		if (!base.has_name_descriptor)
-			fail("Missing Display Product Name.\n");
+			warn("Missing Display Product Name.\n");
 		if ((base.edid_minor == 3 || base.supports_continuous_freq) &&
 		    !base.has_display_range_descriptor)
 			fail("Missing Display Range Limits Descriptor.\n");

base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac